On Tue, Jun 17, 2008 at 04:52:25PM -0700, Trent Piepho wrote:
> Why is FS_ENET_HAS_SCC a bool, and not tristate?
That was an oversight on my part -- they should be tristate.
-Scott
___
Linuxppc-dev mailing list
Linuxppc-dev@ozlabs.org
https://ozlabs.org
> >
> >I'm not sure I understand what you're looking for, but I don't see
> >anything wrong with something like this (apart from missing help text):
> >
> >config FS_ENET
> > bool
> > select MII
> > select PHYLIB
> >
> >config FS_ENET_HAS_SCC
> > bool "Freescale CPM SCC Etherne
On Tue, 17 Jun 2008, Scott Wood wrote:
Sam Ravnborg wrote:
In general when you select a symbol that has dependencies you are almost
always on the wrong track.
more specific options should make sure that they never select it when the
dependencies aren't met.
Sure, in theory that would work
Sam Ravnborg wrote:
But I was misguided by:
+config FS_ENET_MPC5121_FEC
+ select FS_ENET
This is not good.
Why not, if we get rid of the prompt on FS_ENET?
In general when you select a symbol that has dependencies you are almost
always on the wrong track.
The dependencies on FS_ENET coul
On Tue, Jun 17, 2008 at 03:03:54PM -0500, Scott Wood wrote:
> Sam Ravnborg wrote:
> >On Tue, Jun 17, 2008 at 02:33:28PM -0500, Scott Wood wrote:
> >>John Rigby wrote:
> >>>config FS_ENET
> >>> tristate "Freescale Ethernet Driver"
> >>>- depends on CPM1 || CPM2
> >>>+ depends on CP
Sam Ravnborg wrote:
On Tue, Jun 17, 2008 at 02:33:28PM -0500, Scott Wood wrote:
John Rigby wrote:
config FS_ENET
tristate "Freescale Ethernet Driver"
- depends on CPM1 || CPM2
+ depends on CPM1 || CPM2 || FS_ENET_MPC5121_FEC
select MII
select PHYLIB
+config FS_
On Tue, Jun 17, 2008 at 01:43:40PM -0600, John Rigby wrote:
> Thanks Sam, Scott already addressed most of your issues. The
> background that you are likely missing and I will add to the patch
> header is that the 5121 has an FEC core with all the same registers as
> 8xx except the order of the
On Tue, Jun 17, 2008 at 02:33:28PM -0500, Scott Wood wrote:
> John Rigby wrote:
> > config FS_ENET
> >tristate "Freescale Ethernet Driver"
> >- depends on CPM1 || CPM2
> >+ depends on CPM1 || CPM2 || FS_ENET_MPC5121_FEC
> >select MII
> >select PHYLIB
> >
> >+con
On Tue, Jun 17, 2008 at 02:31:31PM -0500, Scott Wood wrote:
> Sam Ravnborg wrote:
> >>+ data = of_get_property(ofdev->node, "fsl,align-tx-packets", &len);
> >>+ if (data && len == 4)
> >>+ fpi->align_tx_packets = *data;
> >>+
> >Where did "4" come from. USe a define with a desriptive
Thanks Sam, Scott already addressed most of your issues. The
background that you are likely missing and I will add to the patch
header is that the 5121 has an FEC core with all the same registers as
8xx except the order of the registers is scrambled. Fortunately the old
FEC only exists on CP
John Rigby wrote:
config FS_ENET
tristate "Freescale Ethernet Driver"
- depends on CPM1 || CPM2
+ depends on CPM1 || CPM2 || FS_ENET_MPC5121_FEC
select MII
select PHYLIB
+config FS_ENET_MPC5121_FEC
+ bool "Freescale MPC512x FEC driver"
+ depends
Sam Ravnborg wrote:
+ data = of_get_property(ofdev->node, "fsl,align-tx-packets", &len);
+ if (data && len == 4)
+ fpi->align_tx_packets = *data;
+
Where did "4" come from. USe a define with a desriptive name.
It's sizeof(u32), i.e. one device tree cell. This is fair
Hi John - a few nitpicks.
>
> +config FS_ENET_MPC5121_FEC
> + bool "Freescale MPC512x FEC driver"
> + depends on PPC_MPC512x
> + select FS_ENET
> + select PPC_CPM_NEW_BINDING
> + default y
help is missing. I assume you can help the casual reader a bit by being
a bit more ver
Add support for MPC512x to fs_enet driver
NOTE: This patch is not perfect, there are still some CONFIG_CPM1
ifdefs. But in reality this is not a problem since CPM2 and FEC
are mutually exclusive. This patch does not break MULTIPLATFORM
kernels.
arch/powerpc/boot/dts/mpc5121ads.dts
Fix a t
14 matches
Mail list logo
