Re: [PATCH] [PATCH] powerpc/sstep: Check ISA 3.0 instruction validity before emulation

2021-01-20 Thread Ananth N Mavinakayanahalli
On 1/20/21 3:44 PM, Naveen N. Rao wrote: On 2021/01/20 03:16PM, Ananth N Mavinakayanahalli wrote: ... diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index bf7a7d62ae8b..ed119858e5e9 100644 --- a/arch/powerpc/lib/sstep.c +++ b/arch/powerpc/lib/sstep.c @@ -1528,6 +1528,8 @@ int

Re: [PATCH] [PATCH] powerpc/sstep: Check ISA 3.0 instruction validity before emulation

2021-01-20 Thread Naveen N. Rao
On 2021/01/20 03:16PM, Ananth N Mavinakayanahalli wrote: > We currently unconditionally try to newer emulate instructions on older ^ never? Or: "emulate newer"? > Power versions that could cause issues. Gate it. > > S

[PATCH] [PATCH] powerpc/sstep: Check ISA 3.0 instruction validity before emulation

2021-01-20 Thread Ananth N Mavinakayanahalli
We currently unconditionally try to newer emulate instructions on older Power versions that could cause issues. Gate it. Signed-off-by: Ananth N Mavinakayanahalli --- arch/powerpc/lib/sstep.c | 40 1 file changed, 40 insertions(+) diff --git a/arch/pow