RE: [PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-08 Thread David Laight
> Case when ffs return will never arise.This scenario is > already been discussed > on linuxppc-dev@lists.ozlabs.org. Please see below explanation: > sata_fsl_error_intr() is called during device error.The > mentioned scenario > will never comes. It can be observed via code:- > if (

[PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-07 Thread Prabhakar Kushwaha
When a single device error is detected, the device under the error is indicated by the error bit set in the DER. There is a one to one mapping between register bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP device 0 and bit 1 represents PMP device 1 etc. Current implementation t

RE: [PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-01 Thread Kushwaha Prabhakar-B32579
PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register > usage > > On Mon, 2011-02-21 at 15:27 +0530, Prabhakar Kushwaha wrote: > > When a single device error is detected, the device under the error is > > indicated by the error bit set in the DER. There is a one to one > >

Re: [PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-03-01 Thread Benjamin Herrenschmidt
On Mon, 2011-02-21 at 15:27 +0530, Prabhakar Kushwaha wrote: > When a single device error is detected, the device under the error is > indicated > by the error bit set in the DER. There is a one to one mapping between > register > bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP

[PATCH][v2] driver/FSL SATA:Fix wrong Device Error Register usage

2011-02-21 Thread Prabhakar Kushwaha
When a single device error is detected, the device under the error is indicated by the error bit set in the DER. There is a one to one mapping between register bit and devices on Port multiplier(PMP) i.e. bit 0 represents PMP device 0 and bit 1 represents PMP device 1 etc. Current implementation t