Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-09-08 Thread Jeff Garzik
On 07/29/2009 12:03 PM, ashish kalra wrote: From: Ashish Kalra Date: Wed, 29 Jul 2009 21:15:49 +0530 Fix for non-ncq & ncq commands causing timeouts when both are issued simultaneously to the same device. Signed-off-by: Ashish Kalra --- drivers/ata/sata_fsl.c | 1 + 1 files changed, 1 insertio

Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-30 Thread Kumar Gala
On Jul 30, 2009, at 8:58 AM, Kalra Ashish-B00888 wrote: Hello Kumar, >> > This doesn't look like it should change anything. sata_fsl_ops >> inherits >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which >> already >> > sets qc_defer to ata_std_qc_defer. >> Oh, yes. Actually thi

RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-30 Thread Kalra Ashish-B00888
Hello Kumar, >> > This doesn't look like it should change anything. sata_fsl_ops >> inherits >> > from sata_pmp_port_ops, which inherits from sata_port_ops, which >> already >> > sets qc_defer to ata_std_qc_defer. >> Oh, yes. Actually this patch was for older kernels where there >> inheritence

Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-30 Thread Kumar Gala
On Jul 30, 2009, at 8:23 AM, Kalra Ashish-B00888 wrote: Hello, >> Signed-off-by: Ashish Kalra >> --- >> drivers/ata/sata_fsl.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c >> index 5a88b44..a33f130 100644 >> --- a

RE: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-30 Thread Kalra Ashish-B00888
Hello, >> Signed-off-by: Ashish Kalra >> --- >> drivers/ata/sata_fsl.c | 1 + >> 1 files changed, 1 insertions(+), 0 deletions(-) >> >> diff --git a/drivers/ata/sata_fsl.c b/drivers/ata/sata_fsl.c >> index 5a88b44..a33f130 100644 >> --- a/drivers/ata/sata_fsl.c >> +++ b/drivers/ata/sata_fsl.c >>

Re: [PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-29 Thread Robert Hancock
On 07/29/2009 10:03 AM, ashish kalra wrote: From: Ashish Kalra Date: Wed, 29 Jul 2009 21:15:49 +0530 Fix for non-ncq & ncq commands causing timeouts when both are issued simultaneously to the same device. Signed-off-by: Ashish Kalra --- drivers/ata/sata_fsl.c | 1 + 1 files changed, 1 insertio

[PATCH][sata_fsl] Defer non-ncq commands when ncq commands active

2009-07-29 Thread ashish kalra
From: Ashish Kalra Date: Wed, 29 Jul 2009 21:15:49 +0530 Fix for non-ncq & ncq commands causing timeouts when both are issued simultaneously to the same device. Signed-off-by: Ashish Kalra --- drivers/ata/sata_fsl.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/dr