Re: [PATCH][POWERPC] Workaround for iommu page alignment (#2)

2008-01-07 Thread Benjamin Herrenschmidt
> And sloppy of me to not catch it. Anyway: > > Acked-by: Olof Johansson <[EMAIL PROTECTED]> > > I wonder how long until there's a device that has some other < PAGE_SIZE > alignment bug^Wrequirement that we'll need to meet too. :( Yeah, it's a worry... Ben. ___

Re: [PATCH][POWERPC] Workaround for iommu page alignment (#2)

2008-01-07 Thread Olof Johansson
On Tue, Jan 08, 2008 at 10:34:22AM +1100, Benjamin Herrenschmidt wrote: > powerpc: Workaround for iommu page alignment > > Our iommu page size is currently always 4K. That means with our current > code, drivers may do a dma_map_sg() of a 64K page and obtain a dma_addr_t > that is only 4K aligned.

[PATCH][POWERPC] Workaround for iommu page alignment (#2)

2008-01-07 Thread Benjamin Herrenschmidt
powerpc: Workaround for iommu page alignment Our iommu page size is currently always 4K. That means with our current code, drivers may do a dma_map_sg() of a 64K page and obtain a dma_addr_t that is only 4K aligned. This works fine in most cases except some infiniband HW it seems, where they tell

Re: [PATCH][POWERPC] Workaround for iommu page alignment

2008-01-07 Thread Benjamin Herrenschmidt
> I don't see in the code where you implement the "size > PAGE_SIZE" > condition. But I only just got back from holidays .. :) Indeed ... a "quilt ref" was missing :-( New patch coming ... Ben. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org h

Re: [PATCH][POWERPC] Workaround for iommu page alignment

2008-01-07 Thread Michael Ellerman
On Tue, 2008-01-08 at 08:45 +1100, Benjamin Herrenschmidt wrote: > Our iommu page size is currently always 4K. That means with our current > code, drivers may do a dma_map_sg() of a 64K page and obtain a dma_addr_t > that is only 4K aligned. > > This works fine in most cases except some infiniband

Re: [PATCH][POWERPC] Workaround for iommu page alignment

2008-01-07 Thread Olof Johansson
On Tue, Jan 08, 2008 at 08:45:59AM +1100, Benjamin Herrenschmidt wrote: > Our iommu page size is currently always 4K. That means with our current > code, drivers may do a dma_map_sg() of a 64K page and obtain a dma_addr_t > that is only 4K aligned. > > This works fine in most cases except some inf

[PATCH][POWERPC] Workaround for iommu page alignment

2008-01-07 Thread Benjamin Herrenschmidt
Our iommu page size is currently always 4K. That means with our current code, drivers may do a dma_map_sg() of a 64K page and obtain a dma_addr_t that is only 4K aligned. This works fine in most cases except some infiniband HW it seems, where they tell the HW about the page size and it ignores the