Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Benjamin Herrenschmidt
On Wed, 2013-08-14 at 14:21 +0100, Sudeep KarkadaNagesha wrote: > IMO moving of handling ibm,ppc-interrupt-server#s to generic code > under > #ifdef CONFIG_PPC seems to be cleaner approach than weak definitation. > > As per my understanding each thread is a different logical cpu. > Each logical cp

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Sudeep KarkadaNagesha
On 14/08/13 13:53, Rob Herring wrote: > On 08/14/2013 05:01 AM, Sudeep KarkadaNagesha wrote: >> On 13/08/13 22:07, Benjamin Herrenschmidt wrote: >>> On Tue, 2013-08-13 at 19:29 +0100, Sudeep KarkadaNagesha wrote: I don't understand completely the use of ibm,ppc-interrupt-server#s and its

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Sudeep KarkadaNagesha
On 14/08/13 12:37, Benjamin Herrenschmidt wrote: > On Wed, 2013-08-14 at 11:01 +0100, Sudeep KarkadaNagesha wrote: >> Yes this doesn't cover the historical "ibm,ppc-interrupt-server#s", >> for >> which we can have PPC specific wrapper above the generic one i.e. get >> the cpu node and then parse fo

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Rob Herring
On 08/14/2013 05:01 AM, Sudeep KarkadaNagesha wrote: > On 13/08/13 22:07, Benjamin Herrenschmidt wrote: >> On Tue, 2013-08-13 at 19:29 +0100, Sudeep KarkadaNagesha wrote: >>> I don't understand completely the use of ibm,ppc-interrupt-server#s and >>> its implications on generic of_get_cpu_node impl

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Benjamin Herrenschmidt
On Wed, 2013-08-14 at 11:01 +0100, Sudeep KarkadaNagesha wrote: > Yes this doesn't cover the historical "ibm,ppc-interrupt-server#s", > for > which we can have PPC specific wrapper above the generic one i.e. get > the cpu node and then parse for thread id under custom property. A wrapper is wrong.

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Sudeep KarkadaNagesha
On 13/08/13 22:07, Benjamin Herrenschmidt wrote: > On Tue, 2013-08-13 at 19:29 +0100, Sudeep KarkadaNagesha wrote: >> I don't understand completely the use of ibm,ppc-interrupt-server#s and >> its implications on generic of_get_cpu_node implementation. >> I see the PPC specific definition of of_get

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Sudeep KarkadaNagesha
On 13/08/13 20:45, Rafael J. Wysocki wrote: > On Tuesday, August 13, 2013 01:44:23 PM Rob Herring wrote: >> On Tue, Aug 13, 2013 at 10:40 AM, Sudeep KarkadaNagesha >> wrote: >>> Adding PowerPC list >>> >>> On 13/08/13 14:00, Rafael J. Wysocki wrote: On Monday, August 12, 2013 02:27:47 PM Sude

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-14 Thread Sudeep KarkadaNagesha
On 13/08/13 19:37, Michal Simek wrote: > On 08/13/2013 05:40 PM, Sudeep KarkadaNagesha wrote: >> Adding PowerPC list >> >> On 13/08/13 14:00, Rafael J. Wysocki wrote: >>> On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: The following changes since commit d4e4ab86bcba5a7

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Benjamin Herrenschmidt
On Tue, 2013-08-13 at 21:45 +0200, Rafael J. Wysocki wrote: > > I'd go for 1 above personally. Yuck no. Two functions with roughly the same name and the same purpose differing only by an underscore just because one can't take 5mn to reconcile the new one with the old one ? No way. Ben. ___

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Benjamin Herrenschmidt
On Tue, 2013-08-13 at 13:44 -0500, Rob Herring wrote: > It is up to Rafael if he is willing/able to rebase his tree, but I > would drop this series until this is sorted out. I think the new > common function should be and can be generalized to work for powerpc. > It would need to make reg property

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Benjamin Herrenschmidt
On Tue, 2013-08-13 at 19:29 +0100, Sudeep KarkadaNagesha wrote: > I don't understand completely the use of ibm,ppc-interrupt-server#s and > its implications on generic of_get_cpu_node implementation. > I see the PPC specific definition of of_get_cpu_node uses thread id only > in 2 instances. Based

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Benjamin Herrenschmidt
On Tue, 2013-08-13 at 16:40 +0100, Sudeep KarkadaNagesha wrote: > There seems to be conflict in the new function "of_get_cpu_node" added. > PowerPC also defines the same function name. Further microblaze and > openrisc declares it(can be removed) but doesn't define it. > To fix this: > 1. I can ren

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Rafael J. Wysocki
On Tuesday, August 13, 2013 01:44:23 PM Rob Herring wrote: > On Tue, Aug 13, 2013 at 10:40 AM, Sudeep KarkadaNagesha > wrote: > > Adding PowerPC list > > > > On 13/08/13 14:00, Rafael J. Wysocki wrote: > >> On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: > >>> The following cha

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Rob Herring
On Tue, Aug 13, 2013 at 10:40 AM, Sudeep KarkadaNagesha wrote: > Adding PowerPC list > > On 13/08/13 14:00, Rafael J. Wysocki wrote: >> On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: >>> The following changes since commit >>> d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: >>> >>> L

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Michal Simek
On 08/13/2013 05:40 PM, Sudeep KarkadaNagesha wrote: > Adding PowerPC list > > On 13/08/13 14:00, Rafael J. Wysocki wrote: >> On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: >>> The following changes since commit >>> d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: >>> >>> Linux 3.11-

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Sudeep KarkadaNagesha
On 13/08/13 16:40, Sudeep KarkadaNagesha wrote: > Adding PowerPC list > > On 13/08/13 14:00, Rafael J. Wysocki wrote: >> On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: >>> The following changes since commit >>> d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: >>> >>> Linux 3.11-rc5 (

Re: [GIT PULL] DT/core: cpu_ofnode updates for v3.12

2013-08-13 Thread Sudeep KarkadaNagesha
Adding PowerPC list On 13/08/13 14:00, Rafael J. Wysocki wrote: > On Monday, August 12, 2013 02:27:47 PM Sudeep KarkadaNagesha wrote: >> The following changes since commit >> d4e4ab86bcba5a72779c43dc1459f71fea3d89c8: >> >> Linux 3.11-rc5 (2013-08-11 18:04:20 -0700) >> >> are available in the git