RE: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break

2019-04-09 Thread S.j. Wang
Hi > > Hi Gustavo, > > On Mon, Apr 08, 2019 at 10:20:25PM -0500, Gustavo A. R. Silva wrote: > > >>> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c > > >>> index > > >>> c7410bbfd2af..bad0dfed6b68 100644 > > >>> --- a/sound/soc/fsl/fsl_esai.c > > >>> +++ b/sound/soc/fsl/fsl_esai

Re: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break

2019-04-08 Thread Nicolin Chen
Hi Gustavo, On Mon, Apr 08, 2019 at 10:20:25PM -0500, Gustavo A. R. Silva wrote: > >>> diff --git a/sound/soc/fsl/fsl_esai.c b/sound/soc/fsl/fsl_esai.c index > >>> c7410bbfd2af..bad0dfed6b68 100644 > >>> --- a/sound/soc/fsl/fsl_esai.c > >>> +++ b/sound/soc/fsl/fsl_esai.c > >>> @@ -251,7 +251,7 @@

Re: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break

2019-04-08 Thread Gustavo A. R. Silva
Hi Shengjiu, On 4/8/19 9:54 PM, S.j. Wang wrote: > Hi Gustavo > >> >> >> On 4/8/19 4:28 AM, S.j. Wang wrote: >>> case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be >> independent of >>> each other, so replace fall-through with break. >>> >> If this is correct, then you should use the followi

RE: [EXT] Re: [PATCH V1] ASoC: fsl_esai: replace fall-through with break

2019-04-08 Thread S.j. Wang
Hi Gustavo > > > On 4/8/19 4:28 AM, S.j. Wang wrote: > > case ESAI_HCKT_EXTAL and case ESAI_HCKR_EXTAL should be > independent of > > each other, so replace fall-through with break. > > > If this is correct, then you should use the following "Fixes" tag instead, > which is the one that introduce