Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 21:23:26 +1100, Benjamin Herrenschmidt wrote: > > On Fri, 2011-03-25 at 11:12 +0100, Takashi Iwai wrote: > > At Fri, 25 Mar 2011 20:15:33 +1100, > > Benjamin Herrenschmidt wrote: > > > > > > > > We > > > > > must also make sure we don't go down that path for vmalloc memory > >

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Benjamin Herrenschmidt
On Fri, 2011-03-25 at 11:12 +0100, Takashi Iwai wrote: > At Fri, 25 Mar 2011 20:15:33 +1100, > Benjamin Herrenschmidt wrote: > > > > > > We > > > > must also make sure we don't go down that path for vmalloc memory > > > > though. > > > > > > Yes. > > > > I haven't actually checked, but I assume t

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 20:15:33 +1100, Benjamin Herrenschmidt wrote: > > > > We > > > must also make sure we don't go down that path for vmalloc memory > > > though. > > > > Yes. > > I haven't actually checked, but I assume that the test > > substream->dma_buffer.dev.type == SNDRV_DMA_TYPE_DEV > >

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Benjamin Herrenschmidt
On Fri, 2011-03-25 at 09:01 +0100, Takashi Iwai wrote: > > In fact, cache coherent architectures often don't support mapping memory > > uncached -at-all- so something like snd_pcm_lib_mmap_noncached() > > shouldn't exist, or at least be under arch control. There's no case > > where it's "always saf

Re: [BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-25 Thread Takashi Iwai
At Fri, 25 Mar 2011 09:16:48 +1100, Benjamin Herrenschmidt wrote: > > Hi Takashi ! > > While working on endian-fixing xHCI with Matt (CC), we discovered the > source of our problems with usb-audio on a board we were working on. > > c32d977b8157bf67cdf47729ce7dd054a26eb534 > "ALSA: pcm - Call pgp

[BUG] pgprot_noncached() is -NOT- safe for mapping vmalloc buffers into userspace

2011-03-24 Thread Benjamin Herrenschmidt
Hi Takashi ! While working on endian-fixing xHCI with Matt (CC), we discovered the source of our problems with usb-audio on a board we were working on. c32d977b8157bf67cdf47729ce7dd054a26eb534 "ALSA: pcm - Call pgprot_noncached() for vmalloc'ed buffers" I'm afraid that this is totally bogus :-)