Re: [2/2] powerpc: Align hot loops of some string functions

2016-06-15 Thread Michael Ellerman
On Wed, 2016-25-05 at 22:39:55 UTC, Unknown sender due to SPF wrote: > Align the hot loops in our assembly implementation of strncpy(), > strncmp() and memchr(). > > Signed-off-by: Anton Blanchard Applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/87a156fb18fe15d012c3db506b chee

Re: [PATCH 2/2] powerpc: Align hot loops of some string functions

2016-05-26 Thread Segher Boessenkool
On Fri, May 27, 2016 at 07:45:18AM +0200, Christophe Leroy wrote: > >>Wouldn't it be better to add nops before the function entry in order to > >>get the hot loop aligned, instead of adding nops in the middle of the > >>function ? > >Why would that be better? The nops are executed once per functio

Re: [PATCH 2/2] powerpc: Align hot loops of some string functions

2016-05-26 Thread Christophe Leroy
Le 26/05/2016 à 21:37, Segher Boessenkool a écrit : On Thu, May 26, 2016 at 09:24:51AM +0200, Christophe Leroy wrote: Wouldn't it be better to add nops before the function entry in order to get the hot loop aligned, instead of adding nops in the middle of the function ? Why would that be bett

Re: [PATCH 2/2] powerpc: Align hot loops of some string functions

2016-05-26 Thread Segher Boessenkool
On Thu, May 26, 2016 at 09:24:51AM +0200, Christophe Leroy wrote: > Wouldn't it be better to add nops before the function entry in order to > get the hot loop aligned, instead of adding nops in the middle of the > function ? Why would that be better? The nops are executed once per function call

Re: [PATCH 2/2] powerpc: Align hot loops of some string functions

2016-05-26 Thread Christophe Leroy
Le 26/05/2016 à 00:39, Anton Blanchard via Linuxppc-dev a écrit : Align the hot loops in our assembly implementation of strncpy(), strncmp() and memchr(). Wouldn't it be better to add nops before the function entry in order to get the hot loop aligned, instead of adding nops in the middle of t

[PATCH 2/2] powerpc: Align hot loops of some string functions

2016-05-25 Thread Anton Blanchard via Linuxppc-dev
Align the hot loops in our assembly implementation of strncpy(), strncmp() and memchr(). Signed-off-by: Anton Blanchard --- Index: linux.junk/arch/powerpc/lib/string.S === --- linux.junk.orig/arch/powerpc/lib/string.S +++ linux.junk