Re: [-next] powerpc/eeh: Fix debugfs_simple_attr.cocci warnings

2018-12-22 Thread Michael Ellerman
On Thu, 2018-12-20 at 02:42:51 UTC, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEB

Re: [PATCH -next] powerpc/eeh: Fix debugfs_simple_attr.cocci warnings

2018-12-19 Thread Russell Currey
On Thu, 2018-12-20 at 02:42 +, YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBU

[PATCH -next] powerpc/eeh: Fix debugfs_simple_attr.cocci warnings

2018-12-19 Thread YueHaibing
Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE for debugfs files. Semantic patch information: Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() imposes some significant overhead as compared to DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). Generated by: script