>>> Hello Wen,
>>>
>>> Thanks for your patch!
>>>
>>> Did you test your patch with a P.A. Semi board?
>>>
>> Hello Christian, thank you.
>> We don't have a P.A. Semi board yet, so we didn't test it.
>> If you have such a board, could you please kindly help to test it?
>>
>> --
>> Thanks and regards
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f6 ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang
> > Cc: "Rafael J. Wysocki"
> > Cc: Viresh Ku
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f6 ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang
> > Cc: "Rafael J. Wysocki"
> > Cc: Viresh Ku
> > we developed a coccinelle script to detect such problems.
>
> Would you find the implementation of the function “dt_init_idle_driver”
> suspicious according to discussed source code search patterns?
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/cpuidle/dt_id
> > The immr_node variable is still being used after the of_node_put() call,
> > which may result in use-after-free.
>
> Was any known source code analysis tool involved to point such
> a questionable implementation detail out for further software
> development considerations?
Hi Markus,
we deve
> > The np variable is still being used after the of_node_put() call,
>
> > which may result in use-after-free.
>
> > We fix this issue by calling of_node_put() after the last usage.
>
>
> I imagine that this commit description can be improved a bit more
> (by mentioning the influence of “immr_
> Hello Wen,
>
> Thanks for your patch!
>
> Did you test your patch with a P.A. Semi board?
>
Hello Christian, thank you.
We don't have a P.A. Semi board yet, so we didn't test it.
If you have such a board, could you please kindly help to test it?
--
Thanks and regards,
Wen
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang
> > Cc: "Rafael J. Wysocki"
> > Cc: Viresh Kum
> > The cpu variable is still being used in the of_get_property() call
> > after the of_node_put() call, which may result in use-after-free.
> >
> > Fixes: a9acc26b75f ("cpufreq/pasemi: fix possible object reference leak")
> > Signed-off-by: Wen Yang
> > Cc: "Rafael J. Wysocki"
> > Cc: Viresh Kum
>> The call to of_find_compatible_node returns a node pointer with refcount
>> incremented thus it must be explicitly decremented after the last
>> usage.
>> irq_domain_add_linear also calls of_node_get to increase refcount,
>> so irq_domain will not be affected when it is released.
>>
>> Detected
Hi, Christophe,
>> The call to of_find_compatible_node returns a node pointer with refcount
>> incremented thus it must be explicitly decremented after the last
>> usage.
>> irq_domain_add_linear also calls of_node_get to increase refcount,
>> so irq_domain will not be affected when it is released
Hi David，
Thank you, we'll fix it soon.
Best wishes,
Wen
--Original Mail--
Sender: DavidMiller
To: peng hao10096742;
CC: qiang.z...@nxp.com leoyang...@nxp.com
linux-ker...@vger.kernel.org
wen yang10156314;julia.law...@lip6.fr
net...@vger.kernel.org
linuxppc-d
Hi Qiang,
Thank you, we'll send a new version to fix this.
Best regards,
Wen
--Original Mail--
Sender: QiangZhao
To: wang yi10129963;
CC: zhong weidong10001088;lkml
julia.law...@lip6.fr
linuxppc-dev wen
yang10156314;moderatedlist:ARM/FREESCALE IMX / MXC ARM
Hi Christophe, thank you for your review.
There are two problems in the ucc_of_parse_tdm function.
1, NULL pointer reference
2, pdev gets modified, iomap was done with a different pdev.
We will submit a patch to repair it later.
Thanks.
132 pdev = of_find_device_by_node(np2);
..
141
14 matches
Mail list logo
