[PATCH v2] mm: z3fold: deprecate CONFIG_Z3FOLD

2024-09-04 Thread Yosry Ahmed
https://lore.kernel.org/lkml/CAJD7tkbnmeVugfunffSovJf9FAgy9rhBVt_tx=nxuvelufq...@mail.gmail.com/ Acked-by: Chris Down Acked-by: Nhat Pham Signed-off-by: Yosry Ahmed --- I think it should actually be fine to remove z3fold without deprecating it first, but I am doing the due diligence. v1:

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-06 Thread Yosry Ahmed
On Thu, Jun 6, 2024 at 10:55 AM Yu Zhao wrote: > > On Thu, Jun 6, 2024 at 11:42 AM Yosry Ahmed wrote: > > > > On Thu, Jun 6, 2024 at 10:14 AM Takero Funaki wrote: > > > > > > 2024年6月6日(木) 8:42 Yosry Ahmed : > > > > > > > I think there a

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-06 Thread Yosry Ahmed
On Thu, Jun 6, 2024 at 10:14 AM Takero Funaki wrote: > > 2024年6月6日(木) 8:42 Yosry Ahmed : > > > I think there are multiple ways to go forward here: > > (a) Make the number of zpools a config option, leave the default as > > 32, but allow special use cases to set

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-06 Thread Yosry Ahmed
On Thu, Jun 6, 2024 at 6:28 AM Erhard Furtner wrote: > > On Wed, 5 Jun 2024 16:58:11 -0700 > Yosry Ahmed wrote: > > > On Wed, Jun 5, 2024 at 4:53 PM Yu Zhao wrote: > > > > > > On Wed, Jun 5, 2024 at 5:42 PM Yosry Ahmed wrote: > > > > >

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-05 Thread Yosry Ahmed
On Wed, Jun 5, 2024 at 4:53 PM Yu Zhao wrote: > > On Wed, Jun 5, 2024 at 5:42 PM Yosry Ahmed wrote: > > > > On Wed, Jun 5, 2024 at 4:04 PM Erhard Furtner wrote: > > > > > > On Tue, 4 Jun 2024 20:03:27 -0700 > > > Yosry Ahmed wrote: > > > &

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-05 Thread Yosry Ahmed
On Wed, Jun 5, 2024 at 4:04 PM Erhard Furtner wrote: > > On Tue, 4 Jun 2024 20:03:27 -0700 > Yosry Ahmed wrote: > > > Could you check if the attached patch helps? It basically changes the > > number of zpools from 32 to min(32, nr_cpus). > > Thanks! The patch does

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Yosry Ahmed
On Tue, Jun 4, 2024 at 2:10 PM Erhard Furtner wrote: > > On Tue, 4 Jun 2024 11:01:39 -0700 > Yosry Ahmed wrote: > > > How many CPUs does this machine have? I am wondering if 32 can be an > > overkill for small machines, perhaps the number of pools should be > &

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Yosry Ahmed
On Tue, Jun 4, 2024 at 1:52 PM Vlastimil Babka (SUSE) wrote: > > On 6/4/24 1:24 AM, Yosry Ahmed wrote: > > On Mon, Jun 3, 2024 at 3:13 PM Erhard Furtner wrote: > >> > >> On Sun, 2 Jun 2024 20:03:32 +0200 > >> Erhard Furtner wrote: > >> > &g

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Yosry Ahmed
On Tue, Jun 4, 2024 at 10:54 AM Yu Zhao wrote: > > On Tue, Jun 4, 2024 at 11:34 AM Yosry Ahmed wrote: > > > > On Tue, Jun 4, 2024 at 10:19 AM Yu Zhao wrote: > > > > > > On Tue, Jun 4, 2024 at 10:12 AM Yosry Ahmed wrote: > > > > >

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Yosry Ahmed
On Tue, Jun 4, 2024 at 10:19 AM Yu Zhao wrote: > > On Tue, Jun 4, 2024 at 10:12 AM Yosry Ahmed wrote: > > > > On Tue, Jun 4, 2024 at 4:45 AM Erhard Furtner wrote: > > > > > > On Mon, 3 Jun 2024 16:24:02 -0700 > > > Yosry Ahmed wrote: > > &

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-04 Thread Yosry Ahmed
On Tue, Jun 4, 2024 at 4:45 AM Erhard Furtner wrote: > > On Mon, 3 Jun 2024 16:24:02 -0700 > Yosry Ahmed wrote: > > > Thanks for bisecting. Taking a look at the thread, it seems like you > > have a very limited area of memory to allocate kernel memory from. One >

Re: kswapd0: page allocation failure: order:0, mode:0x820(GFP_ATOMIC), nodemask=(null),cpuset=/,mems_allowed=0 (Kernel v6.5.9, 32bit ppc)

2024-06-03 Thread Yosry Ahmed
t; > > > > Do you know a kernel version that doesn't have OOM kills while running > > > the same workload? If so, could you send that .config to me? If not, > > > could you try disabling CONFIG_HIGHMEM? (It might not help but I'm out > > > of ideas at the

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-24 Thread Yosry Ahmed
On Mon, Jan 22, 2024 at 12:49 PM Yosry Ahmed wrote: > > On Sun, Jan 21, 2024 at 11:42 PM Christoph Hellwig wrote: > > > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > > Well, better compression ratios for one :) > > > > > > I thi

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-22 Thread Yosry Ahmed
On Sun, Jan 21, 2024 at 11:42 PM Christoph Hellwig wrote: > > On Tue, Jan 16, 2024 at 12:19:39PM -0800, Yosry Ahmed wrote: > > Well, better compression ratios for one :) > > > > I think a long time ago there were complaints that zsmalloc had higher > > latency than

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-16 Thread Yosry Ahmed
On Tue, Jan 16, 2024 at 7:39 AM Christoph Hellwig wrote: > > On Fri, Jan 12, 2024 at 04:38:30PM -0800, Nhat Pham wrote: > > > > > > I thought deprecating z3fold is the low hanging fruit. Then, once we > > > can sort out the MMU dependency in zsmalloc, we can go after zbud as > > > well. > > > > Ma

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-15 Thread Yosry Ahmed
On Mon, Jan 15, 2024 at 4:27 AM Vitaly Wool wrote: > > On Fri, Jan 12, 2024 at 8:31 PM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users use > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > de

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-14 Thread Yosry Ahmed
On Sun, Jan 14, 2024 at 2:42 PM Nhat Pham wrote: > > On Sun, Jan 14, 2024 at 10:49 AM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 4:38 PM Nhat Pham wrote: > > > > > > On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > > > > >

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-14 Thread Yosry Ahmed
On Fri, Jan 12, 2024 at 4:38 PM Nhat Pham wrote: > > On Fri, Jan 12, 2024 at 3:37 PM Yosry Ahmed wrote: > > > > On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > > > > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed > > > wrote: > > >

Re: [RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Yosry Ahmed
On Fri, Jan 12, 2024 at 11:42 AM Nhat Pham wrote: > > On Fri, Jan 12, 2024 at 11:31 AM Yosry Ahmed wrote: > > > > The z3fold compressed pages allocator is not widely used, most users use > > zsmalloc. The only disadvantage of zsmalloc in comparison is the > > de

[RFC PATCH] mm: z3fold: rename CONFIG_Z3FOLD to CONFIG_Z3FOLD_DEPRECATED

2024-01-12 Thread Yosry Ahmed
objections. Otherwise, we can remove z3fold in a few releases. Signed-off-by: Yosry Ahmed --- I have limited understanding of Kconfigs. I modelled this after commit eb07c4f39c3e ("mm/slab: rename CONFIG_SLAB to CONFIG_SLAB_DEPRECATED"), but one difference is that CONFIG_Z3FOLD is a trista