[PATCH RESEND] tty: hvc_console: Remove the repeated words 'no' and 'from'

2021-05-20 Thread Xiaofei Tan
Remove the repeated words 'no' and 'from', reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index cdc

Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments

2021-05-20 Thread Xiaofei Tan
Hi Johan, On 2021/5/20 21:52, Johan Hovold wrote: On Thu, May 20, 2021 at 09:21:25PM +0800, Xiaofei Tan wrote: Checkpatch already has too many checks IMO and I'm a bit surprised that it doesn't check this already. Perhaps it's because you used the -f to run checkpatch on

Re: [PATCH 0/9] tty: hvc_console: Fix some coding style issues

2021-05-20 Thread Xiaofei Tan
Hi Greg, On 2021/5/20 23:11, Greg KH wrote: On Mon, May 17, 2021 at 02:37:04PM +0800, Xiaofei Tan wrote: Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Xiaofei Tan (9): tty: hvc_console: Fix spaces required around that '=&#

Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments

2021-05-20 Thread Xiaofei Tan
Hi Johan, On 2021/5/20 16:21, Johan Hovold wrote: On Tue, May 18, 2021 at 12:01:22PM +0800, Xiaofei Tan wrote: Hi Johan, Thanks for reviewing this patch. On 2021/5/17 22:15, Johan Hovold wrote: On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote: Fix coding style issues of block

Re: [PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments

2021-05-17 Thread Xiaofei Tan
Hi Johan, Thanks for reviewing this patch. On 2021/5/17 22:15, Johan Hovold wrote: On Mon, May 17, 2021 at 02:37:10PM +0800, Xiaofei Tan wrote: Fix coding style issues of block comments, reported by checkpatch.pl. Besides, add a period at the end of the sentenses. Signed-off-by: Xiaofei Tan

[PATCH 0/9] tty: hvc_console: Fix some coding style issues

2021-05-17 Thread Xiaofei Tan
Fix some issues reported by checkpatch.pl. All of them are coding style issues, no function changes. Xiaofei Tan (9): tty: hvc_console: Fix spaces required around that '=' tty: hvc_console: Fix "foo * bar" should be "foo *bar" tty: hvc_console: Remove trailing

[PATCH 5/9] tty: hvc_console: Delete spaces prohibited around open parenthesis '(' and ')'

2021-05-17 Thread Xiaofei Tan
Delete spaces prohibited after that open parenthesis '(' and before that close parenthesis ')', reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_con

[PATCH 7/9] tty: hvc_console: Add a blank line after declarations

2021-05-17 Thread Xiaofei Tan
Add a blank line after declarations, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index a61cdf0..f31efeb 100644 --- a/drivers/tty/hvc

[PATCH 2/9] tty: hvc_console: Fix "foo * bar" should be "foo *bar"

2021-05-17 Thread Xiaofei Tan
Fix "foo * bar" should be "foo *bar", reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index a1eca9d..

[PATCH 8/9] tty: hvc_console: Remove the repeated words 'no' and 'from'

2021-05-17 Thread Xiaofei Tan
Remove the repeated words 'no' and 'from', reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index f31

[PATCH 3/9] tty: hvc_console: Remove trailing whitespace

2021-05-17 Thread Xiaofei Tan
Remove trailing whitespace, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index ddf07ff..13f63d5 100644 --- a/drivers/tty

[PATCH 6/9] tty: hvc_console: Fix coding style issues of block comments

2021-05-17 Thread Xiaofei Tan
Fix coding style issues of block comments, reported by checkpatch.pl. Besides, add a period at the end of the sentenses. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/tty/hvc

[PATCH 1/9] tty: hvc_console: Fix spaces required around that '='

2021-05-17 Thread Xiaofei Tan
Fix spaces required around that '=', reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index d0f0253..a1eca9d 10

[PATCH 4/9] tty: hvc_console: Fix issues of code indent should use tabs

2021-05-17 Thread Xiaofei Tan
Fix issues of code indent should use tabs, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 13f63d5..2e5c133 100644

[PATCH 9/9] tty: hvc_console: Move open brace { on the previous line

2021-05-17 Thread Xiaofei Tan
Fix issues that open brace { should be on the previous line, reported by checkpatch.pl. Signed-off-by: Xiaofei Tan --- drivers/tty/hvc/hvc_console.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index