Re: rcutorture's init segfaults in ppc64le VM

2022-02-07 Thread Willy Tarreau
32 detached > > Huh. In PowerPC, is there some difference between system calls > executed in initrd and those same system calls executed in userspace? I've faced some issues in the past with certain syscalls not working exactly the sa

Re: powerpc: build failures in Linus' tree

2020-08-03 Thread Willy Tarreau
On Mon, Aug 03, 2020 at 09:18:00PM +1000, Michael Ellerman wrote: > If we just move the include of asm/paca.h below asm-generic/percpu.h > then it avoids the bad circular dependency and we still have paca.h > included from percpu.h as before. > > eg: > > diff --git a/arch/powerpc/include/asm/perc

Re: powerpc: build failures in Linus' tree

2020-08-02 Thread Willy Tarreau
On Mon, Aug 03, 2020 at 02:10:17PM +1000, Stephen Rothwell wrote: > Our mails have crossed. Ah indeed :-) > I just sent a more comprehensive patch. I > think your patch would require a lot of build testing and even then may > fail for some CONFIG combination that we didn't test or added in the >

Re: powerpc: build failures in Linus' tree

2020-08-02 Thread Willy Tarreau
Hi again Stephen, On Sun, Aug 02, 2020 at 07:20:19PM +0200, Willy Tarreau wrote: > On Sun, Aug 02, 2020 at 08:48:42PM +1000, Stephen Rothwell wrote: > > Hi all, > > > > We are getting build failures in some PowerPC configs for Linus' tree. > > See e.g. htt

Re: powerpc: build failures in Linus' tree

2020-08-02 Thread Willy Tarreau
On Sun, Aug 02, 2020 at 08:48:42PM +1000, Stephen Rothwell wrote: > Hi all, > > We are getting build failures in some PowerPC configs for Linus' tree. > See e.g. http://kisskb.ellerman.id.au/kisskb/buildresult/14306515/ > > In file included from /kisskb/src/arch/powerpc/include/asm/paca.h:18, >

[PATCH 3.10 078/250] powerpc: Fix build warning on 32-bit PPC

2017-06-07 Thread Willy Tarreau
ggesting this solution. Fixes: 9994a33865f4 ("powerpc: Introduce entry_{32,64}.S, misc_{32,64}.S, systbl.S") Signed-off-by: Larry Finger Cc: Nicholas Piggin Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Linu

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
On Thu, Apr 03, 2014 at 06:15:25PM +0800, zhuyj wrote: > Hi, Willy > > I made a new patch. In long commit message, I inserted the equivalent > mainline commit > about this feature. Maybe it is better. Now this patch is in the > attachment. Please check > and merge it into kernel 2.6.32.62. Sure

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
Hi Zhu, On Thu, Apr 03, 2014 at 05:57:53PM +0800, zhuyj wrote: > I reference the following 2 mainline commits. These 2 commits are based > on the current kernel 3.x and ethtool. > If we only backport these 2 commits on kernel 2.6.x, this problem will > not be fixed yet. OK fine, I just wanted t

Re: on kernel 2.6.34.15, vlan and raw packets can not be received with gfar-enet nic

2014-04-03 Thread Willy Tarreau
Hi Zhu, On Thu, Apr 03, 2014 at 05:11:48PM +0800, zhuyj wrote: > Hi, Claudiu > > Please help to review this patch. This patch is for kernel 2.6.x. Thanks > a lot. > > Hi, Willy > > Please help to merge this patch to longterm: 2.6.32.61 since this > problem also occurs on this kernel. Thanks a

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
On Thu, Apr 11, 2013 at 10:59:15AM -0700, Eric Dumazet wrote: > On Thu, 2013-04-11 at 19:51 +0200, Willy Tarreau wrote: > > > Eric provided me with one such experimental patch in the past for this > > driver. It worked for me but we never tried to clean it up to propose &g

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
On Thu, Apr 11, 2013 at 01:31:19PM -0400, David Miller wrote: > From: Sebastian Hesselbarth > Date: Thu, 11 Apr 2013 17:27:03 +0200 > > > On Thu, Apr 11, 2013 at 5:03 PM, Willy Tarreau wrote: > >> On Thu, Apr 11, 2013 at 04:47:49PM +0200, Sebastian Hesselbarth wrote:

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
On Thu, Apr 11, 2013 at 06:59:11PM +0200, Sebastian Hesselbarth wrote: > On Thu, Apr 11, 2013 at 5:32 PM, Willy Tarreau wrote: > > On Thu, Apr 11, 2013 at 05:27:03PM +0200, Sebastian Hesselbarth wrote: > >> I don't have a strong opinion on whether Soeren's or

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
On Thu, Apr 11, 2013 at 08:54:35AM -0700, Eric Dumazet wrote: > On Thu, 2013-04-11 at 17:32 +0200, Willy Tarreau wrote: > > On Thu, Apr 11, 2013 at 05:27:03PM +0200, Sebastian Hesselbarth wrote: > > > I don't have a strong opinion on whether Soeren's or your proposal sh

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
On Thu, Apr 11, 2013 at 05:27:03PM +0200, Sebastian Hesselbarth wrote: > I don't have a strong opinion on whether Soeren's or your proposal should > be submitted. But I insist on having one of them in, as GRO significantly > improves the common use case, is enabled by default, and not as > constrai

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
Hi Sebastian, On Thu, Apr 11, 2013 at 04:47:49PM +0200, Sebastian Hesselbarth wrote: > I did some simple tests on Dove/Cubox with 'netperf -cCD' and > gso/gro/lro options on > mv643xx_eth. The tests may not be sufficient, as I am not that into > net performance testing. In fact the difference onl

Re: [PATCH] net: mv643xx_eth: Add GRO support

2013-04-11 Thread Willy Tarreau
Hi, On Thu, Apr 11, 2013 at 02:40:23PM +0200, Sebastian Hesselbarth wrote: > This patch adds GRO support to mv643xx_eth by making it invoke > napi_gro_receive instead of netif_receive_skb. > > Signed-off-by: Soeren Moch > Signed-off-by: Sebastian Hesselbarth > --- > Cc: "David S. Miller" > Cc:

Re: [PATCH 00/14] Backport 8xx TLB to 2.4

2012-04-09 Thread Willy Tarreau
Hi Joakim, On Wed, Feb 08, 2012 at 12:39:50PM +0100, Joakim Tjernlund wrote: > I figure, after 2.4.37.12, a public git tree on kernel org which still > receives fixes would be enough. FYI, I've merged your patches and pushed them along with a few pending other ones here : http://git.kernel.or

Re: [PATCH stable-2.6.27] powerpc: Add more Power7 specific definitions

2012-02-13 Thread Willy Tarreau
Hi Tony, On Tue, Feb 14, 2012 at 09:44:19AM +1100, Tony Breeds wrote: > On Mon, Feb 13, 2012 at 07:35:28AM +0100, Willy Tarreau wrote: > > On Mon, Feb 13, 2012 at 11:52:02AM +1100, Michael Neuling wrote: > > > stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it&#

Re: [PATCH stable-2.6.27] powerpc: Add more Power7 specific definitions

2012-02-12 Thread Willy Tarreau
On Mon, Feb 13, 2012 at 11:52:02AM +1100, Michael Neuling wrote: > stable-2.6.27.60 added c24cb8e5 which uses PV_POWER7 but it's not > defined. Following patch adds these definitions. Thank you for the report Michael, I have no PPC toolchain so I have not tested this one. Added now. Just one que

Re: [PATCH 00/14] Backport 8xx TLB to 2.4

2012-02-08 Thread Willy Tarreau
On Wed, Feb 08, 2012 at 12:39:50PM +0100, Joakim Tjernlund wrote: > > BTW, since you're asking, you seem to still be using 2.4. Do you think it's > > worth pursuing maintenance over 2.4.37.12 and if so for how long ? I'm > > asking > > because until the break-in, I felt like almost nobody was usin

Re: [PATCH 00/14] Backport 8xx TLB to 2.4

2012-02-08 Thread Willy Tarreau
Hi Joakim, On Wed, Feb 08, 2012 at 09:44:18AM +0100, Joakim Tjernlund wrote: > Willy Tarreau wrote on 2011/12/11 18:33:46: > > > > Hi Joakim, > > > > On Sun, Dec 11, 2011 at 06:19:54PM +0100, Joakim Tjernlund wrote: > > > > To: Joakim Tjernlund > >

[PATCH 24/91] seqlock: Dont smp_rmb in seqlock reader spin loop

2012-02-05 Thread Willy Tarreau
2.6.27-longterm review patch. If anyone has any objections, please let us know. -- commit 5db1256a5131d3b133946fa02ac9770a784e6eb2 upstream. Move the smp_rmb after cpu_relax loop in read_seqlock and add ACCESS_ONCE to make sure the test and return are consistent. A multi-thread

Re: [PATCH 00/14] Backport 8xx TLB to 2.4

2011-12-11 Thread Willy Tarreau
Hi Joakim, On Sun, Dec 11, 2011 at 06:19:54PM +0100, Joakim Tjernlund wrote: > > To: Joakim Tjernlund > > From: Willy Tarreau > > > > Hi Joakim, On Mon, Oct 10, 2011 at 01:30:06PM +0200, Joakim Tjernlund > > wrote: > This is a > > backport from 2.6 whic

Re: [PATCH 0/3] 8xx: Large page(8MB) support for 2.4

2011-10-10 Thread Willy Tarreau
Hi an, On Mon, Oct 10, 2011 at 09:22:09AM -0700, Dan Malek wrote: > > Hi Joakim. > > On Oct 10, 2011, at 4:38 AM, Joakim Tjernlund wrote: > > >This adds Large page support for 8xx and uses it > >for all kernel RAM > > >- Dan, what do you think :) > > Since you asked, yes it looks great :-

Re: [PATCH 00/14] Backport 8xx TLB to 2.4

2011-10-10 Thread Willy Tarreau
Hi Joakim, On Mon, Oct 10, 2011 at 01:30:06PM +0200, Joakim Tjernlund wrote: > This is a backport from 2.6 which I did to overcome 8xx CPU > bugs. 8xx does not update the DAR register when taking a TLB > error caused by dcbX and icbi insns which makes it very > tricky to use these insns. Also the

Re: [PATCH 00/15] Backport 8xx TLB to 2.4

2011-06-14 Thread Willy Tarreau
Hi Joakim, On Tue, Jun 14, 2011 at 03:54:45PM +0200, Joakim Tjernlund wrote: > This is a backport from 2.6 which I did to overcome 8xx CPU > bugs. 8xx does not update the DAR register when taking a TLB > error caused by dcbX and icbi insns which makes it very > tricky to use these insns. Also the

Re: [PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove

2011-02-07 Thread Willy Tarreau
Hi Anton, On Tue, Feb 08, 2011 at 08:16:00AM +1100, Anton Blanchard wrote: > > Hi, > > > From: Amit Shah > > > > commit e74d098c66543d0731de62eb747ccd5b636a6f4c upstream. > > > > Alan pointed out a race in the code where hvc_remove is invoked. The > > recent virtio_console work is the first u

[PATCH 21/23] hvc_console: Fix race between hvc_close and hvc_remove

2011-02-06 Thread Willy Tarreau
using tty_vhangup(). Reported-by: Alan Cox Signed-off-by: Amit Shah CC: Alan Cox CC: linuxppc-...@ozlabs.org CC: Rusty Russell Signed-off-by: Greg Kroah-Hartman Signed-off-by: Willy Tarreau --- drivers/char/hvc_console.c | 31 +-- 1 file changed, 21 insertions

Re: [PATCH 00/13] powerpc: Backport 8xx TLB to 2.4

2011-01-11 Thread Willy Tarreau
On Tue, Jan 11, 2011 at 09:12:44AM +0100, Joakim Tjernlund wrote: > Willy Tarreau wrote on 2011/01/11 07:09:26: > > > > Hi Joakim, > > > > On Mon, Jan 10, 2011 at 10:37:46PM +0100, Joakim Tjernlund wrote: > > > This is a backport from 2.6 which I did to overc

Re: [PATCH 00/13] powerpc: Backport 8xx TLB to 2.4

2011-01-10 Thread Willy Tarreau
Hi Joakim, On Mon, Jan 10, 2011 at 10:37:46PM +0100, Joakim Tjernlund wrote: > This is a backport from 2.6 which I did to overcome 8xx CPU > bugs. 8xx does not update the DAR register when taking a TLB > error caused by dcbX and icbi insns which makes it very > tricky to use these insns. Also the

Re: [Patch] fix lcd panel driver build failure

2009-02-03 Thread Willy Tarreau
Thanks Sachin ! Greg, could you please merge this one into your staging tree ? Thanks, Willy On Tue, Feb 03, 2009 at 09:10:58PM +0530, Sachin P. Sant wrote: > * Fix build break for lcd panel driver. > > Signed-off-by : Sachin Sant Signed-off-by: Willy Tarreau > --- > &g

Re: 2.6.29-rc3-git5 build failure : drivers/staging/panel

2009-02-03 Thread Willy Tarreau
Hi, On Tue, Feb 03, 2009 at 08:45:38PM +0530, Sachin P. Sant wrote: > 2.6.29-rc3-git5 randconfig build on powerpc fails with following error > > CALLarch/powerpc/kernel/systbl_chk.sh > CALLarch/powerpc/kernel/prom_init_check.sh > CC [M] drivers/staging/panel/panel.o > drivers/staging/pan

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-19 Thread Willy Tarreau
On Tue, Feb 19, 2008 at 10:28:46AM +0100, Andi Kleen wrote: > > Sometimes, for performance critical paths, I would like gcc to be dumb and > > follow *my* code and not its hard-coded probabilities. > > If you really want that, simple: just disable optimization @) already tried. It fixed some dif

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-18 Thread Willy Tarreau
On Tue, Feb 19, 2008 at 01:33:53PM +1100, Nick Piggin wrote: > > Note in particular the last predictors; assuming branch ending > > with goto, including call, causing early function return or > > returning negative constant are not taken. Just these alone > > are likely 95+% of the unlikelies in th

Re: [Cbe-oss-dev] [PATCH 1/3] Fix Unlikely(x) == y

2008-02-17 Thread Willy Tarreau
On Sun, Feb 17, 2008 at 01:45:23AM -0800, Andrew Pinski wrote: > On Feb 16, 2008 9:58 AM, Willy Tarreau <[EMAIL PROTECTED]> wrote: > > Last but not least, gcc 4 tends to emit stupid checks, to the point that I > > have replaced unlikely(x) with (x) in my code when gcc >=

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-16 Thread Willy Tarreau
On Sat, Feb 16, 2008 at 09:42:26AM -0800, Arjan van de Ven wrote: > On Sat, 16 Feb 2008 18:33:16 +0100 > Willy Tarreau <[EMAIL PROTECTED]> wrote: > > > On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > > > On Sat, 16 Feb 2008 17:08:01 +0100 >

Re: [PATCH 1/3] Fix Unlikely(x) == y

2008-02-16 Thread Willy Tarreau
On Sat, Feb 16, 2008 at 09:25:52AM -0800, Arjan van de Ven wrote: > On Sat, 16 Feb 2008 17:08:01 +0100 > Roel Kluin <[EMAIL PROTECTED]> wrote: > > > The patch below was not yet tested. If it's correct as it is, please > > comment. --- > > Fix Unlikely(x) == y > > > > you found a great set of bug