回复: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent

2022-06-14 Thread Wenhu Wang
>发件人: Michael Ellerman >发送时间: 2022年6月14日 18:45 >收件人: Wang Wenhu ; gre...@linuxfoundation.org >; christophe.le...@csgroup.eu > >抄送: linuxppc-dev@lists.ozlabs.org ; >linux-ker...@vger.kernel.org ; Wang Wenhu > >主题: Re: [PATCH 1/2] powerpc:mm: export symbol ioremap_coherent >  >Wang Wenhu write

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Wenhu Wang
>>> >>> I looked at that patch. >>> >>> I don't think you can just drop the #ifdef in function >>> __access_remote_vm() in mm/memory.c >>> >>> You have to replace it with something like: >>> >>>  if (!IS_ENABLED(CONFIG_HAVE_IOREMAP_PROT)) >>>  break; >>> >> >> >>Another thing in that pa

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Wenhu Wang
>On Tue, Jun 14, 2022 at 07:53:46AM +0000, Wenhu Wang wrote: >> >> >> + >> >> >> +struct mpc85xx_l2ctlr { >> >> >> + u32 ctl;/* 0x000 - L2 control */ >> >> > >> >> >What is the endian of th

Re: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-14 Thread Wenhu Wang
>> >> + >> >> +struct mpc85xx_l2ctlr { >> >> + u32 ctl;/* 0x000 - L2 control */ >> > >> >What is the endian of these u32 values? You map them directly to >> >memory, so they must be specified some way, right? Please make it >> >obvious what they are. >> > >> >> Surely, the val

回复: [PATCH 2/2] uio:powerpc:mpc85xx: l2-cache-sram uio driver implementation

2022-06-13 Thread Wenhu Wang
Hi Greg, thanks for the comments. The questions are replied specifically below. I have figured out and tested the patch v2, which is to be posted later. >发件人: Greg KH >发送时间: 2022年6月9日 21:17 >收件人: Wang Wenhu >抄送: christophe.le...@csgroup.eu ; >m...@ellerman.id.au ; linuxppc-dev@lists.ozlabs.org

Re: [PATCH v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr

2022-06-08 Thread wenhu wang
-邮件原件- 发件人: Christophe Leroy 发送时间: 2022年5月28日 15:03 收件人: 王文虎 ; ker...@vivo.com 抄送: Greg Kroah-Hartman ; Arnd Bergmann ; Scott Wood ; Michael Ellerman ; Randy Dunlap ; linuxppc-dev@lists.ozlabs.org 主题: Re: [PATCH v4,1/5] powerpc: sysdev: fix compile error for fsl_85xx_l2ctlr Le 15/0