[PATCH] fadump: allow duplicate assignment to /sys/kernel/fadump_registered when it's assigned the desired value already

2013-04-09 Thread Wang Sheng-Hui
sys/kernel/fadump_enabled if 1 is already set and we have added more logic check in the user space script. I think we can enable the duplicate assignment to ease the user space tools, as long as the value is the right 1 or 0. Signed-off-by: Wang Sheng-Hui --- arch/powerpc/kernel/fadump.c |8 ++

Re: [PATCH] powerpc/irq: Fix another case of lazy IRQ state getting out of sync

2012-05-13 Thread Wang Sheng-Hui
On 2012年05月11日 10:12, Benjamin Herrenschmidt wrote: > So we have another case of paca->irq_happened getting out of > sync with the HW irq state. This can happen when a perfmon > interrupt occurs while soft disabled, as it will return to a > soft disabled but hard enabled context while leaving a sta

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-09 Thread Wang Sheng-Hui
On 2012年05月08日 11:46, Benjamin Herrenschmidt wrote: > Hi Wang ! > > Does this patch fixes it for you ? > Sorry, this patch doesn't work. And my system crashed again with the patch. == # kernel BUG at /usr/src/kernels/linux/arch/powerpc/kernel/i

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-03 Thread Wang Sheng-Hui
On 2012年05月03日 16:09, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 14:59 +0800, Wang Sheng-Hui wrote: >> On 2012年05月03日 14:33, Wang Sheng-Hui wrote: >>> if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) >>>>__hard_irq_disable(); >> >>

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 14:33, Wang Sheng-Hui wrote: > if (unlikely(irq_happened != PACA_IRQ_HARD_DIS)) >> __hard_irq_disable(); I have commented out the 2 lines. FYI. thanks, ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
up with that bit in irq_happened set and interrupts hard > enabled. > > Something like may_hard_irq_enable() shouldn't cause it since it should > only be called while hard disabled but adding a check in there might be > worth it (something like WARN_ON(mfmsr() & MSR_EE)). > > Che

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
t; Something like may_hard_irq_enable() shouldn't cause it since it should > only be called while hard disabled but adding a check in there might be > worth it (something like WARN_ON(mfmsr() & MSR_EE)). > > Cheers, > Be

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 10:15, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 09:53 +0800, Wang Sheng-Hui wrote: >> local_paca->irq_happened may be changed asychronously. >> >> In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped >> oprofile. T

Re: [PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
On 2012年05月03日 10:15, Benjamin Herrenschmidt wrote: > On Thu, 2012-05-03 at 09:53 +0800, Wang Sheng-Hui wrote: >> local_paca->irq_happened may be changed asychronously. >> >> In my test env (IBM Power 9117-MMA), I installed the RHEL6.2 with the shipped >> oprofile. T

[PATCH] powerpc: use local var instead of local_paca->irq_happened directly in __check_irq_replay

2012-05-02 Thread Wang Sheng-Hui
002694fbf90] .start_secondary_prolog at c000936c Use local var instead of local_paca->irq_happened directly in this function here. Please check this patch. Any comments are welcome. Signed-off-by: Wang Sheng-Hui --- arch/powerpc/kernel/irq.c | 46 ++