Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-13 Thread Wang Jian
Tejun Heo wrote: Hello, Wang Jian wrote: +static void pata_platform_postreset(struct ata_link *link, unsigned int *classes) +{ + struct ata_port *ap = link->ap; + struct ata_device *dev; + u8 select = ATA_DEVICE_OBS; + + /* Call default callback fi

Re: [PATCH RFC] pata_platform: add 8 bit data io support

2008-10-11 Thread Wang Jian
Benjamin Herrenschmidt 写道: > On Sun, 2008-10-12 at 02:00 +0800, Wang Jian wrote: >> To avoid adding another rare used ata_port member, new bit is added to >> ata_port->flags. >> >> Originally, I hacked pata_platform to make it 8bit only to support 8bit >> da

[PATCH RFC] pata_platform: add 8 bit data io support

2008-10-11 Thread Wang Jian
is broken, so a small patch is needed. Signed-off-by: Wang Jian <[EMAIL PROTECTED]> --- drivers/ata/pata_platform.c | 63 -- include/linux/ata.h |8 + include/linux/ata_platform.h |4 ++ include/linux/libata.h |1 +

Re: Compact Flash on 8349mITX

2008-10-10 Thread Wang Jian
Jeff Borlin wrote: Anton Vorontsov-2 wrote: This happens just before the PATA information is printed. I'm not libata expert; and from the brief look I don't see where libata clears any pending "unexpected" irqs. Just a guesswork, could you try this patch? This patch did not appear to change an

Re: Compact Flash on 8349mITX

2008-10-09 Thread Wang Jian
How 8349mITX's compact flash is wired? If it is wired using 8 bit data bus line, without another patch, data transfer can't be done. Looking at logs Sam Sparks provided (without irq): ata1.00: failed to IDENTIFY (I/O error, err_mask=0x4) it seems data transfer failed. I have a 8 bit data trans

Re: [PATCH] pata_of_platform: fix no irq handling

2008-10-07 Thread Wang Jian
Tejun Heo wrote: Anton Vorontsov wrote: On Mon, Oct 06, 2008 at 03:41:19PM -0500, Matt Sealey wrote: There is a simple problem with the patch which is that an "IRQ 0" can and does actually exist on a bunch of platforms, at least to the best of my knowledge. Checking for -1 (which means for def

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
Li Yang wrote: On Thu, Sep 25, 2008 at 4:54 PM, Wang Jian <[EMAIL PROTECTED]> wrote: The alternative fix can be. This one is better as 0 is defined as 'invalid irq' for all architectures. Added linux-ide and Anton to cc. However, this is not very true. Just git grep &quo

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
ov <[EMAIL PROTECTED]> but last time I cc: him I got bounced. Leo Li wrote: On Thu, Sep 25, 2008 at 4:36 PM, Wang Jian <[EMAIL PROTECTED]> wrote: Hi, This patch is to pata_platform.c but at this time, it's powerpc specific because it can only be triggerred using openfirmware, so

Re: [PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
, ret = of_irq_to_resource(dn, 0, &irq_res); if (ret == NO_IRQ) - irq_res.start = irq_res.end = -1; + irq_res.start = irq_res.end = 0; else irq_res.flags = 0; I just didn't spend much time to see which is better. Wang J

[PATCH] pata_platform struct resource signness fix

2008-09-25 Thread Wang Jian
even when it is (-1). When the device has no irq, irq_res->start is assigned (-1). Signed-off-by: Wang Jian <[EMAIL PROTECTED]> --- drivers/ata/pata_platform.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/ata/pata_platform.c b/drivers/ata/pata_platform

Re: mpc8541 pci1 ioport allocation address space problem

2008-09-23 Thread Wang Jian
Confirmed. I had this patch and 2 fixes on dts applied simultaneously, and the board works. I thought this patch was necessary. I reverted this patch and tried again, the board still works. Thanks for your insight. Anyway, the io port read from /proc/ioports is misleading, so I wish it can be c

Re: mpc8541 pci1 ioport allocation address space problem

2008-09-20 Thread Wang Jian
ci_addr -- On Sat, Sep 20, 2008 at 07:16:25PM +0800, Wang Jian wrote: > Hi, > > Here I have a 8541 dev board, with 2 e1000 attached to pci0 and a > homebrewed addon board inserted into pci1. I am trying to make it work > under 2.6.26-rc8 (2.6.26 broken so I am working at rc8).

mpc8541 pci1 ioport allocation address space problem

2008-09-20 Thread Wang Jian
Hi, Here I have a 8541 dev board, with 2 e1000 attached to pci0 and a homebrewed addon board inserted into pci1. I am trying to make it work under 2.6.26-rc8 (2.6.26 broken so I am working at rc8). The ioports allocation reads $ cat /proc/ioports -000f : /[EMAIL PROTECTED] 1000

Re: DTS configuration of external interrupts on 8347

2008-07-25 Thread Wang Jian
Richard Whitlock wrote: Sean MacLennan wrote: On Wed, 23 Jul 2008 15:58:38 +0100 "Richard Whitlock" <[EMAIL PROTECTED]> wrote: I have a small problem with a port of linux 2.6.26 to a custom board. Our board is almost identical to the Analogue & Micro asp 8347 board, so I'm using Kumar Gala's

Re: [PATCH 0/2] Fix register misuse in drivers/net/phy/marvel.c

2008-07-10 Thread Wang Jian
Welch, Martyn (GE EntSol, Intelligent Platforms) 写道: Wang Jian wrote: It may not be appropriate to post here instead of netdev, but I am using powerpc dev board and I think there will be someone here who has board to test. Wang Jian 写道: These 2 patches fixed misuse of register for 88e

Re: [PATCH 0/2] Fix register misuse in drivers/net/phy/marvel.c

2008-07-09 Thread Wang Jian
It may not be appropriate to post here instead of netdev, but I am using powerpc dev board and I think there will be someone here who has board to test. Wang Jian 写道: These 2 patches fixed misuse of register for 88e. Notice: These two patches didn't fix some auto selection problem y

[PATCH 2/2] Fix 88e1111 copper/fiber selection in RGMII mode

2008-07-09 Thread Wang Jian
MII_M_HWCFG_FIBER_COPPER_RES is a bit of MII_M_PHY_EXT_SR, not MII_M_PHY_EXT_CR. Signed-off-by: Wang Jian <[EMAIL PROTECTED]> --- drivers/net/phy/marvell.c |5 + 1 files changed, 1 insertions(+), 4 deletions(-) diff --git a/drivers/net/phy/marvell.c b/drivers/n

[PATCH 0/2] Fix register misuse in drivers/net/phy/marvel.c

2008-07-09 Thread Wang Jian
These 2 patches fixed misuse of register for 88e. Notice: These two patches didn't fix some auto selection problem yet. I will discuss the problem in seperate email. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/l

[PATCH 1/2] Fix copper/fiber auto-selection for 88e1111

2008-07-09 Thread Wang Jian
The 27.15 bit (MII_M_HWCFG_FIBER_COPPER_AUTO) is disable bit. When set to 1, copper/fiber auto selection is disabled. The current code to enable but actually disable auto selection. Signed-off-by: Wang Jian <[EMAIL PROTECTED]> --- drivers/net/phy/marvell.c |2 +- 1 files chan