Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-15 Thread Vishal Chourasia
On Mon, Oct 14, 2024 at 05:54:44PM +0530, Ritesh Harjani wrote: > Vishal Chourasia writes: > > > On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: > >> > >> I don't see why of_reconfig_notifier_unregister() needs to be called > >>

[v2 PATCH 1/2] crypto/nx: Rename devdata_mutex to devdata_spinlock

2024-10-15 Thread Vishal Chourasia
Rename devdata_mutex to devdata_spinlock to accurately reflect its implementation as a spinlock. [1] v1 https://lore.kernel.org/all/zwyqd-w5hehrn...@linux.ibm.com Signed-off-by: Vishal Chourasia --- drivers/crypto/nx/nx-common-pseries.c | 34 +-- 1 file changed, 17

[v2 PATCH 2/2] crypto/nx: Fix invalid wait context during kexec reboot

2024-10-15 Thread Vishal Chourasia
nterrupt: 3000 Suggested-by: Michael Ellerman Signed-off-by: Vishal Chourasia --- drivers/crypto/nx/nx-common-pseries.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/crypto/nx/nx-common-pseries.c b/drivers/crypto/nx/nx-common-pseries.c index a0eb900383af7..1660c5

[PATCH] crypto/nx: Rename devdata_mutex to devdata_spinlock

2024-10-13 Thread Vishal Chourasia
Rename devdata_mutex to devdata_spinlock to accurately reflect its implementation as a spinlock. Signed-off-by: Vishal Chourasia --- drivers/crypto/nx/nx-common-pseries.c | 34 +-- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/drivers/crypto/nx/nx

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Vishal Chourasia
On Fri, Oct 11, 2024 at 05:13:11PM +0530, Vishal Chourasia wrote: > On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: > > Vishal Chourasia writes: > > > Hi, > > > I am getting Invalid wait context warning printed when rebooting lpar > > > &g

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Vishal Chourasia
On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: > Vishal Chourasia writes: > > Hi, > > I am getting Invalid wait context warning printed when rebooting lpar > > > > kexec/61926 is trying to acquire `of_reconfig_chain.rwsem` while holding > > spin

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Vishal Chourasia
On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: > Vishal Chourasia writes: > > Hi, > > I am getting Invalid wait context warning printed when rebooting lpar > > > > kexec/61926 is trying to acquire `of_reconfig_chain.rwsem` while holding > > spin

Re: drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Vishal Chourasia
On Fri, Oct 11, 2024 at 09:37:27PM +1100, Michael Ellerman wrote: > Vishal Chourasia writes: > > Hi, > > I am getting Invalid wait context warning printed when rebooting lpar > > > > kexec/61926 is trying to acquire `of_reconfig_chain.rwsem` while holding > > spin

Re: [RFC] powerpc/kvm: Fix spinlock member access for PREEMPT_RT

2024-10-11 Thread Vishal Chourasia
On Thu, Oct 10, 2024 at 11:23:55PM +0200, Paolo Bonzini wrote: > On 10/10/24 20:09, Vishal Chourasia wrote: > > Hi, > > > > While building the kernel with CONFIG_PREEMPT_RT, I encountered several > > compilation errors in the PowerPC KVM code. The issues appear in >

drivers/nx: Invalid wait context issue when rebooting

2024-10-11 Thread Vishal Chourasia
Hi, I am getting Invalid wait context warning printed when rebooting lpar kexec/61926 is trying to acquire `of_reconfig_chain.rwsem` while holding spinlock `devdata_mutex` Note: Name of the spinlock is misleading. In my case, I compiled a new vmlinux file and loaded it into the running kernel us

[RFC] powerpc/kvm: Fix spinlock member access for PREEMPT_RT

2024-10-10 Thread Vishal Chourasia
s/Makefile.build:478: arch/powerpc] Error 2 make[2]: *** Waiting for unfinished jobs Replace arch_spin_lock/unlock on kvm->mmu_lock.rlock.raw_lock with simple spin_lock/unlock on kvm->mmu_lock to fix build errors with CONFIG_PREEMPT_RT. The RT configuration changes the spinlock structure,

Re: [RFC PATCH v3 00/11] powerpc: Add support for ftrace direct and BPF trampolines

2024-07-03 Thread Vishal Chourasia
On Fri, Jun 21, 2024 at 12:24:03AM +0530, Naveen N Rao wrote: > This is v3 of the patches posted here: > http://lkml.kernel.org/r/cover.1718008093.git.nav...@kernel.org > > Since v2, I have addressed review comments from Steven and Masahiro > along with a few fixes. Patches 7-11 are new in this s

Re: [RFC PATCH v3 00/11] powerpc: Add support for ftrace direct and BPF trampolines

2024-06-24 Thread Vishal Chourasia
On Fri, Jun 21, 2024 at 12:24:03AM +0530, Naveen N Rao wrote: > This is v3 of the patches posted here: > http://lkml.kernel.org/r/cover.1718008093.git.nav...@kernel.org > > Since v2, I have addressed review comments from Steven and Masahiro > along with a few fixes. Patches 7-11 are new in this s

Re: [PATCH v3] powerpc: Adjust config HOTPLUG_CPU dependency

2023-11-24 Thread Vishal Chourasia
On 24/11/23 8:09 am, Michael Ellerman wrote: > Hi Vishal, > > I think our wires got crossed here somewhere :) > > Vishal Chourasia writes: >> Changed HOTPLUG_CPU dependency to SMP and either ARCH_HIBERNATION_POSSIBLE or >> ARCH_SUSPEND_POSSIBLE, aligning with s

[PATCH v3] powerpc: Adjust config HOTPLUG_CPU dependency

2023-11-22 Thread Vishal Chourasia
D_POSSIBLE are now selected only if required platform dependencies are met. Reported-by: Srikar Dronamraju Suggested-by: Aneesh Kumar K V Suggested-by: Michael Ellerman Signed-off-by: Vishal Chourasia v2: https://lore.kernel.org/all/20231122092303.223719-1-vish...@linux.ibm.com v1: https://lore.

Re: [PATCH] powerpc: Adjust config HOTPLUG_CPU dependency

2023-11-22 Thread Vishal Chourasia
On 22/11/23 3:03 pm, Aneesh Kumar K V wrote: > On 11/22/23 2:53 PM, Vishal Chourasia wrote: >> Changed HOTPLUG_CPU dependency to SMP and either ARCH_HIBERNATION_POSSIBLE or >> ARCH_SUSPEND_POSSIBLE, aligning with systems' suspend/hibernation >> capabilities. >> T

[PATCH] powerpc: Adjust config HOTPLUG_CPU dependency

2023-11-22 Thread Vishal Chourasia
ael Ellerman Signed-off-by: Vishal Chourasia v1: https://lore.kernel.org/all/20231114082046.6018-1-vish...@linux.ibm.com --- During the configuration process with 'make randconfig' followed by 'make olddefconfig', we observed a warning indicating an unmet direct dependency for t

Re: [PATCH] powerpc: Restrict ARCH_HIBERNATION_POSSIBLE to supported configurations

2023-11-17 Thread Vishal Chourasia
On 17/11/23 4:52 am, Michael Ellerman wrote: > Vishal Chourasia writes: >> On 15/11/23 5:46 pm, Aneesh Kumar K V wrote: >>> On 11/15/23 5:23 PM, Vishal Chourasia wrote: >>>> On 15/11/23 1:39 pm, Aneesh Kumar K.V wrote: >>>>> Vishal Chourasia

Re: [PATCH] powerpc: Restrict ARCH_HIBERNATION_POSSIBLE to supported configurations

2023-11-17 Thread Vishal Chourasia
On 17/11/23 4:52 am, Michael Ellerman wrote: > Vishal Chourasia writes: >> On 15/11/23 5:46 pm, Aneesh Kumar K V wrote: >>> On 11/15/23 5:23 PM, Vishal Chourasia wrote: >>>> On 15/11/23 1:39 pm, Aneesh Kumar K.V wrote: >>>>> Vishal Chourasia

Re: [PATCH] powerpc: Restrict ARCH_HIBERNATION_POSSIBLE to supported configurations

2023-11-16 Thread Vishal Chourasia
On 15/11/23 5:46 pm, Aneesh Kumar K V wrote: > On 11/15/23 5:23 PM, Vishal Chourasia wrote: >> On 15/11/23 1:39 pm, Aneesh Kumar K.V wrote: >>> Vishal Chourasia writes: >>> >>>> This patch modifies the ARCH_HIBERNATION_POSSIBLE option to ensure that it

Re: [PATCH] powerpc: Restrict ARCH_HIBERNATION_POSSIBLE to supported configurations

2023-11-15 Thread Vishal Chourasia
On 15/11/23 1:39 pm, Aneesh Kumar K.V wrote: > Vishal Chourasia writes: > >> This patch modifies the ARCH_HIBERNATION_POSSIBLE option to ensure that it >> correctly depends on these PowerPC configurations being enabled. As a result, >> it prevents the HOTPLUG_CPU from

[PATCH] powerpc: Restrict ARCH_HIBERNATION_POSSIBLE to supported configurations

2023-11-14 Thread Vishal Chourasia
the expected hardware support for CPU hot-plugging under PowerPC architectures, ensuring that the kernel configuration steps do not lead to inconsistent states. Signed-off-by: Vishal Chourasia --- During the configuration process with 'make randconfig' followed by 'make olddefconfig&

Re: [PATCH] powerpc/crypto: Fix aes-gcm-p10 link errors

2023-05-29 Thread Vishal Chourasia
finitions of certain functions appears to be resolved. λ grep -i CRYPTO_AES_GCM_P10 .config CONFIG_CRYPTO_AES_GCM_P10=y λ grep -i CRYPTO_DEV_VMX_ENCRYPT .config CONFIG_CRYPTO_DEV_VMX_ENCRYPT=y  + make O=${BUILD_DIR} CC=clang ARCH=powerpc CROSS_COMPILE=powerpc64le-linux-gnu- -j16 -s vmlinux mo

Re: [PATCH] powerpc/crypto: Fix aes-gcm-p10 link errors

2023-05-29 Thread Vishal Chourasia
After applying the patch, I was able to successfully build the Linux kernel v6.4-rc4. I encountered no errors during the build process. The issue pertaining to multiple definitions of certain functions appears to be resolved. λ grep -i CRYPTO_AES_GCM_P10 .config CONFIG_CRYPTO_AES_GCM_P10=y λ g

Re: [PATCH v2] powerpc/cpuidle: Set CPUIDLE_FLAG_POLLING for snooze state

2022-11-19 Thread Vishal Chourasia
files changed, 10 insertions(+), 3 deletions(-) Thanks for the patch. Tested it on top of v6.0-rc4 Against workload: https://github.com/gautshen/misc/tree/master/cpuidle-smt-performance Reviewed-by: Vishal Chourasia Tested-by: Vishal Chourasia mailto:vish...@linux

Re: sched/debug: CPU hotplug operation suffers in a large cpu systems

2022-11-08 Thread Vishal Chourasia
From f66f66ee05a9f719b58822d13e501d65391dd9d3 Mon Sep 17 00:00:00 2001 From: Vishal Chourasia Date: Tue, 8 Nov 2022 14:21:15 +0530 Subject: [PATCH] Add kernel parameter to disable creation of sched_domain files For large systems, creation of sched_domain debug files takes unusually long time. In which case, sched_sd_exp

Re: sched/debug: CPU hotplug operation suffers in a large cpu systems

2022-10-26 Thread Vishal Chourasia
On Tue, Oct 18, 2022 at 01:04:40PM +0200, Greg Kroah-Hartman wrote: > Why do you need to? What tools require these debugfs files to be > present? We are not entirely sure what applications (if any) might be using this interface. > And if you only have 7-8 files per CPU, that does not seem like