Hi,
Any progress/update with this patch ?
Please do let know, if something more is needed here.
Regards,
Vipin
On Wednesday 14 March 2018 01:22 PM, Vipin K Parashar wrote:
printk() in unmap_cpu_from_node() uses KERN_ERR message severity,
for a WARNING message. Change it to pr_warn
On Tuesday 13 March 2018 03:58 PM, Christophe LEROY wrote:
Le 13/03/2018 à 11:11, Vipin K Parashar a écrit :
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/mm
printk() in unmap_cpu_from_node() uses KERN_ERR message severity,
for a WARNING message. Change it to pr_warn().
Signed-off-by: Vipin K Parashar
---
arch/powerpc/mm/numa.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm/numa.c
index
printk in unmap_cpu_from_node() uses KERN_ERR message severity
for a WARNING message. Correct message severity to KERN_WARNING.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/mm/numa.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/powerpc/mm/numa.c b/arch/powerpc/mm
Hi Michael,
Any feedback/outlook with this patch ?
Regards,
Vipin
On Friday 10 March 2017 05:27 PM, Vipin K Parashar wrote:
OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
in opal_get_sensor_data() for sensor read failure with
OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
in opal_get_sensor_data() for sensor read failure with
OPAL_WRONG_STATE return code and returned -EIO.
Signed-off-by: Vipin K Parashar
---
Changes in v4:
- Removed sleeping core log
On Monday 06 March 2017 03:03 PM, Michael Ellerman wrote:
Vipin K Parashar writes:
OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
for OPAL_WRONG_STATE rerurn code with sensor read failure.
Also added a log message indicating
OPAL returns OPAL_WRONG_STATE upon failing to provide
sensor data due to core sleeping/offline. Added check
for OPAL_WRONG_STATE rerurn code with sensor read failure.
Also added a log message indicating sensor data being
queried for sleeping/offline core.
Signed-off-by: Vipin K Parashar
On Thursday 02 March 2017 06:00 PM, Vipin K Parashar wrote:
Hi Stewart/Michael,
Thanks!! for review.
Responses as below:
On Wednesday 01 March 2017 02:38 AM, Stewart Smith wrote:
Vipin K Parashar writes:
Added check for OPAL_WRONG_STATE error code returned from OPAL.
Currently Linux
Hi Stewart/Michael,
Thanks!! for review.
Responses as below:
On Wednesday 01 March 2017 02:38 AM, Stewart Smith wrote:
Vipin K Parashar writes:
Added check for OPAL_WRONG_STATE error code returned from OPAL.
Currently Linux flashes "unexpected error" over console for this
error.
Added check for OPAL_WRONG_STATE error code returned from OPAL.
Currently Linux flashes "unexpected error" over console for this
error. This will avoid throwing such message and return I/O error
for such OPAL failures.
Signed-off-by: Vipin K Parashar
---
Changes in v2:
- Added l
Thanks!! for review.
Sending out v2 with suggested changes.
On Thursday 23 February 2017 09:22 AM, Stewart Smith wrote:
Michael Ellerman writes:
Stewart Smith writes:
Vipin K Parashar writes:
On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote:
Vipin K Parashar writes
This patch uses "printk_ratelimited" in place of
"printk_ratelimit" used in v1
On Thursday 16 February 2017 10:40 PM, Vipin K Parashar wrote:
kvm_ppc_mmu_book3s_32/64 xlat() logs "KVM can't copy data" error
upon failing to copy user data to kernel space. Thi
v2 for this patch with 'printk_ratelimit' replaced with
'printk_ratelimited' is available at mailing list.
https://patchwork.ozlabs.org/patch/728831/
On Tuesday 14 February 2017 11:50 AM, Vipin K Parashar wrote:
Forwarded same patch to k...@vger.kernel.org
and kvm-...
kvm_ppc_mmu_book3s_32/64 xlat() logs "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log once such fails occur in short time period. Ratelimit this
error to avoid flooding kernel logs upon copy data failures.
Signed-off-by: V
Hi Michael,
Thanks!! for review.
Answers to your questions as below:
On Monday 13 February 2017 06:13 AM, Michael Ellerman wrote:
Vipin K Parashar writes:
OPAL returns OPAL_WRONG_STATE for XSCOM operations
done to read any core FIR which is sleeping, offline.
OK.
Do we know why Linux
Forwarded same patch to k...@vger.kernel.org
and kvm-...@vger.kernel.org too.
On Tuesday 14 February 2017 12:26 AM, Vipin K Parashar wrote:
kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log
kvm_ppc_mmu_book3s_32/64 xlat() log "KVM can't copy data" error
upon failing to copy user data to kernel space. This floods kernel
log once such fails occur in short time period. Ratelimit this
error to avoid flooding kernel logs upon copy data failures.
Signed-off-by: Vipin K Para
OPAL returns OPAL_WRONG_STATE for XSCOM operations
done to read any core FIR which is sleeping, offline.
On Friday 27 January 2017 05:47 AM, Michael Ellerman wrote:
Vipin K Parashar writes:
Added check for OPAL_WRONG_STATE error code returned from OPAL.
Currently Linux flashes "unexp
Added check for OPAL_WRONG_STATE error code returned from OPAL.
Currently Linux flashes "unexpected error" over console for this
error. This will avoid throwing such message and return I/O error
for such OPAL failures.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/platforms/powe
On Saturday 21 May 2016 05:34 PM, Andrea Gelmini wrote:
Signed-off-by: Andrea Gelmini
Reviewed-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc
. Merged adjacent log messages into single one to reduce number of
lines printed per event.
Signed-off-by: Kamalesh Babulal
Signed-off-by: Vipin K Parashar
---
v6 changes:
- Added single increment for epow events counter variable outside
epow events switch-case scenario.
- Corrected
On Tuesday 01 December 2015 09:16 AM, Michael Ellerman wrote:
On Mon, 2015-11-30 at 17:31 +0530, Vipin K Parashar wrote:
On Thursday 26 November 2015 02:50 PM, Vasant Hegde wrote:
On 11/18/2015 02:12 PM, Vipin K Parashar wrote:
Kernel prints respective warnings about various EPOW events for
On Thursday 26 November 2015 02:50 PM, Vasant Hegde wrote:
On 11/18/2015 02:12 PM, Vipin K Parashar wrote:
Kernel prints respective warnings about various EPOW events for
user information/action after parsing EPOW interrupts. At times
below EPOW reset event warning is seen to be flooding
. Merged adjacent log messages into single one to reduce number of
lines printed per event.
Signed-off-by: Kamalesh Babulal
Signed-off-by: Vipin K Parashar
---
v5 changes:
- Used num_epow_events counter variable to count number of epow_events
- Improved log messages to better describe epow event
Cc: Anton Blanchard
Cc: Vipin K Parashar
Signed-off-by: Kamalesh Babulal
---
V4: Changes:
- Changed the approach to depth counter to match the EPOW events and
EPOW reset.
- Converted pr_err() ot pr_info() for non-critical errors.
- Merged adjacent warnings into single line acros
lines printed per warning across the file and converted
non-critical errors to pr_info from pr_error, including grammar
correction in the warnings printed.
Suggested-by: Michael Ellerman
Cc: Anshuman Khandual
Cc: Anton Blanchard
Cc: Vipin K Parashar
Signed-off-by: Kamalesh Babulal
---
V4: Chan
sages defined, avoiding unnecessary bugs due to enum values
order mismatch.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/arch/powerpc/include/asm/opal-api.h
b/arch/powerpc/include/asm/opal-
warning.
Suggested-by: Vipin K Parashar
[Vipin: edited the changelog]
Cc: Anshuman Khandual
Cc: Anton Blanchard
Cc: Michael Ellerman
Signed-off-by: Kamalesh Babulal
---
v3 Changes:
- Limit warning printed by EPOW RESET event, by guarding it with bool flag.
Instead of rate limiting
inted per warning.
Suggested-by: Vipin K Parashar
[Vipin: edited the changelog]
This probably should go to change summary below.
Cc: Anshuman Khandual
Cc: Anton Blanchard
Cc: Michael Ellerman
Signed-off-by: Kamalesh Babulal
---
v3 Changes:
- Limit warning printed by EPOW RESET even
critical power or cooling issue cleared
May 25 04:22:26 alp kernel: Non critical power or cooling issue cleared
May 25 04:22:36 alp kernel: Non critical power or cooling issue cleared
Suggested-by: Vipin K Parashar
Cc: Anshuman Khandual
Cc: Anton Blanchard
Cc: Michael Ellerman
Signed-off-by
Patch looks good to me. A small nit pick below.
On 07/14/2015 01:21 PM, Kamalesh Babulal wrote:
* Vipin K Parashar [2015-06-25 00:48:20]:
On 06/02/2015 10:48 AM, Kamalesh Babulal wrote:
We print the respective warning after parsing EPOW interrupts,
prompting user to take action depending
performing graceful system shutdown.
Signed-off-by: Vipin K Parashar
Acked-by: Vaibhav Jain
---
arch/powerpc/include/asm/opal-api.h| 40 +++
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/opal-power.c| 147 ++---
arch
OPAL device-tree.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/po
On 06/11/2015 05:13 PM, Vipin K Parashar wrote:
This patch adds support for OPAL EPOW (Early Power Off Warning) and
Hi Micheal,
Please use below expansion for EPOW acronym in commit log
once u add this patch.
EPOW = Environmental and Power Warnings
It matches with PAPR expansion for
On 06/02/2015 10:48 AM, Kamalesh Babulal wrote:
We print the respective warning after parsing EPOW interrupts,
prompting user to take action depending upon the severity of the
event.
Some times same EPOW event warning, such as below could flood kernel
log, over a period of time. So Limit the wa
On 06/11/2015 04:25 AM, Stewart Smith wrote:
Vipin K Parashar writes:
This patch adds support for FSP (Flexible Service Processor)
EPOW (Early Power Off Warning) and DPO (Delayed Power Off) events for
Not restricted to FSP systems, it's a generic OPAL API that any platform
could impl
graceful system shutdown.
Reviewed-by: Joel Stanley
Reviewed-by: Vaibhav Jain
Reviewed-by: Michael Ellerman
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 40 +++
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/opal
evice-tree.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/powerpc/includ
On 06/11/2015 04:25 AM, Stewart Smith wrote:
Vipin K Parashar writes:
This patch adds support for FSP (Flexible Service Processor)
EPOW (Early Power Off Warning) and DPO (Delayed Power Off) events for
Not restricted to FSP systems, it's a generic OPAL API that any platform
could impl
Stanley
Reviewed-by: Vaibhav Jain
Reviewed-by: Michael Ellerman
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 40 +++
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/opal-power.c| 147
vious review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/powerpc/include/asm/opal-api.h| 40 +++
arch/powerpc/include/asm/o
Stanley
Reviewed-by: Vaibhav Jain
Reviewed-by: Michael Ellerman
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 40
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/opal-power.c| 126
changes to use existing OPAL EPOW API.
- Removed patch to extract EPOW event timeout from OPAL device-tree.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1
On 06/05/2015 03:31 AM, Michael Ellerman wrote:
On Thu, 2015-04-06 at 12:03:17 UTC, Vipin K Parashar wrote:
This patch adds support for FSP (Flexible Service Processor)
EPOW (Early Power Off Warning) and DPO (Delayed Power Off) events for
the PowerNV platform. EPOW events are generated by FSP
Stanley
Reviewed-by: Vaibhav Jain
Reviewed-by: Michael Ellerman
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 40
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/opal-power.c| 125
OPAL device-tree.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/powerpc
Hi Michael,
Thanks for review. Responses below
On 06/03/2015 10:43 AM, Michael Ellerman wrote:
On Mon, 2015-18-05 at 15:18:04 UTC, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
Please spell out the acronyms the first time you use them
Hi Michael,
Please add below minor additions in commit log once u
accept this patch. Thanks for your help with this. Let me know,
if anything else is needed from me on this.
Regards,
Vipin
On 05/18/2015 08:48 PM, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early
perform any specific
actions like graceful guest shutdown upon system poweroff. libvirt-guests
is systemd service available on recent distros for management of guests
at system start/shutdown time.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 44
.
- Removed patch to extract EPOW event timeout from OPAL device-tree.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events
Thanks for review.
Made changes as suggested.
On 05/14/2015 08:51 PM, trigg wrote:
On 14-May-2015, at 16:16, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
DPO (Delayed Power Off) events support for PowerNV platform. EPOW events
are generated by
scripts to perform any specific actions like graceful guest
shutdown upon system poweroff. libvirt-guests is systemd service available on
recent distros for management of guests at system start/shutdown time.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 44
code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/powerpc/include/asm/opal-api.h| 44 +++
arch/powerpc
shutdown scripts to perform any specific actions like graceful guest
shutdown upon system poweroff. libvirt-guests is systemd service available on
recent distros for management of guests at system start/shutdown time.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h
event timeout values from OPAL device-tree.
Vipin K Parashar (1):
powerpc/powernv: Add poweroff (EPOW, DPO) events support for PowerNV
platform
arch/powerpc/include/asm/opal-api.h| 44 +++
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv
On 05/11/2015 12:19 PM, Michael Ellerman wrote:
On Thu, 2015-05-07 at 15:00 +0530, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
DPO (Delayed Power Off) events support for PowerNV platform. EPOW events
are generated by SPCN/FSP due to various
On 05/11/2015 02:31 PM, Vipin K Parashar wrote:
On 05/11/2015 12:19 PM, Michael Ellerman wrote:
On Thu, 2015-05-07 at 15:00 +0530, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
DPO (Delayed Power Off) events support for PowerNV platform. EPOW
On 05/11/2015 12:19 PM, Michael Ellerman wrote:
On Thu, 2015-05-07 at 15:00 +0530, Vipin K Parashar wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
DPO (Delayed Power Off) events support for PowerNV platform. EPOW events
are generated by SPCN/FSP due to various
Hi Joel,
Thanks for review. My comments below.
On 05/08/2015 06:56 AM, Joel Stanley wrote:
Hello Vipin,
On Thu, May 7, 2015 at 7:00 PM, Vipin K Parashar
wrote:
This patch adds support for FSP EPOW (Early Power Off Warning) and
DPO (Delayed Power Off) events support for PowerNV
crit-ambient-temp-timeout
high-internal-temp-timeout
crit-internal-temp-timeout
Signed-off-by: Vipin K Parashar
---
arch/powerpc/platforms/powernv/opal-power.c | 79 +
1 file changed, 70 insertions(+), 9 deletions(-)
diff --git a/arch/powerpc/platforms/powernv/opal
n can also add systemd service shutdown scripts to
perform any specific actions like graceful guest shutdown upon system
poweroff. libvirt-guests is systemd service available on recent distros
for management of guests at system stat/shutdown time.
Signed-off-by: Vipin K Parashar
---
arch/po
s
for management of guests at system stat/shutdown time.
Changes in v2:
- Made code changes to improve code as per previous review comments.
- Added patch to obtain EPOW event timeout values from OPAL device-tree.
Vipin K Parashar (2):
powerpc/powernv: Add poweroff (EPOW, DPO) events suppor
rform any specific actions like graceful guest
shutdown upon system poweroff.
Signed-off-by: Vipin K Parashar
---
arch/powerpc/include/asm/opal-api.h| 30 ++
arch/powerpc/include/asm/opal.h| 3 +-
arch/powerpc/platforms/powernv/Makefile
Hi Stewart,
Tried to fake ACPI via acpi_bus_generate_netlink_event
and found that
it needs other files which arch specific and use x86 assembly.
Regards,
Vipin
On 02/24/2015 03:14 PM, Vipin K Parashar wrote:
Hi Stewart,
I looked into ACPI and found details about it
off overhead of convincing distros for adding
something extra.
This was my findings and opinions on alternatives. Apologies for a
little lengthy text :-)
Let me know if i missed out anything and any suggestions that you would
have.
Regards,
Vipin
On 02/11/2015 10:32 AM, Stewart Smith wrote:
V
On 02/11/2015 10:32 AM, Stewart Smith wrote:
Vipin K Parashar writes:
(1) Environmental and Power Warning (EPOW)
(2) Delayed Power Off (DPO)
The user interface for this driver is /dev/opal_event character
device file where the user space clients can poll and read for
new opal
the
system explicitly.
Signed-off-by: Vipin K Parashar
Signed-off-by: Anshuman Khandual
---
Changes in V4:
- Used miscdev in place of chardev
- Used module_platform_driver macro for registering platform driver
- Added endianness conversions before and after making OPAL calls
- Changed events data
68 matches
Mail list logo
