[PATCH] ASoC: fsl_xcvr: fix potential resource leak

2020-11-24 Thread Viorel Suman (OSS)
From: Viorel Suman "fw" variable must be relased before return. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_xcvr.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/fsl_xcvr.c b/sound/soc/fsl/fsl_xcvr.c index 2a28810d0e29..3d58c88ea603 100644 --- a/sou

[PATCH] ASoC: fsl_xcvr: fix break condition

2020-11-02 Thread Viorel Suman (OSS)
From: Viorel Suman The break condition copied by mistake as same as loop condition in the previous version, but must be the opposite. So fix it. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_xcvr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl

[PATCH v4 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-10-13 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a new IP module found on i.MX8MP. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,xcvr.yaml | 104 ++ 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,xcvr.yaml

[PATCH v4 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-10-13 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a on-chip functional module found on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig| 10 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_xcvr.c | 1359

RE: [PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-10-13 Thread Viorel Suman (OSS)
Hi Rob, Thank you for review, fixed in V4. /Viorel > -Original Message- > From: Rob Herring [mailto:r...@kernel.org] > Sent: Tuesday, October 6, 2020 9:35 PM > To: Viorel Suman (OSS) > Cc: Liam Girdwood ; Mark Brown > ; Jaroslav Kysela ; Takashi Iwai > ; Timu

RE: [PATCH v2 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-29 Thread Viorel Suman (OSS)
Hi Philipp, Thank you for your review, please check my comments inline. /Viorel > -Original Message- > From: Philipp Zabel [mailto:p...@pengutronix.de] > Sent: Tuesday, September 22, 2020 3:09 PM > To: Viorel Suman (OSS) > Cc: Liam Girdwood ; Mark Brown > ; Rob

[PATCH v3 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-09-29 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a new IP module found on i.MX8MP. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,xcvr.yaml| 103 + 1 file changed, 103 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl

[PATCH v3 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-29 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a on-chip functional module found on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig| 10 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_xcvr.c | 1356

[PATCH v3 0/2] DAI driver for new XCVR IP

2020-09-29 Thread Viorel Suman (OSS)
From: Viorel Suman DAI driver for new XCVR IP found in i.MX8MP. Viorel Suman (2): ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver ASoC: dt-bindings: fsl_xcvr: Add document for XCVR Changes since v1: - improved 6- and 12-ch layout comment - used regmap polling function, improved clocks

[PATCH v2 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-09-21 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a new IP module found on i.MX8MP. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,xcvr.yaml| 103 + 1 file changed, 103 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl

[PATCH v2 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-21 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a on-chip functional module found on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig| 10 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_xcvr.c | 1343

[PATCH v2 0/2] DAI driver for new XCVR IP

2020-09-21 Thread Viorel Suman (OSS)
From: Viorel Suman DAI driver for new XCVR IP found in i.MX8MP. Viorel Suman (2): ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver ASoC: dt-bindings: fsl_xcvr: Add document for XCVR Changes since v1: - improved 6- and 12-ch layout comment - used regmap polling function, improved clocks

RE: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-18 Thread Viorel Suman (OSS)
> On Fri, Sep 18, 2020 at 03:02:39PM +0000, Viorel Suman (OSS) wrote: > > Please fix your mail client to word wrap within paragraphs at something > substantially less than 80 columns. Doing this makes your messages much > easier > to read and reply to. &

RE: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-18 Thread Viorel Suman (OSS)
Hi Mark, Thank you for your review. > On Wed, Sep 16, 2020 at 12:17:55PM +0300, Viorel Suman (OSS) wrote: > > +static int fsl_xcvr_load_firmware(struct fsl_xcvr *xcvr) { > > + struct device *dev = &xcvr->pdev->dev; > > + const struct firmware *fw; > >

RE: [PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-18 Thread Viorel Suman (OSS)
Hi Nicolin, Thank you for your review. > > +static const u32 fsl_xcvr_earc_channels[] = { 1, 2, 8, 16, 32, }; /* > > +one bit 6, 12 ? */ > > What's the meaning of the comments? Just a thought noted as comment. HDMI2.1 spec defines 6- and 12-channels layout when one bit audio stream is transmit

[PATCH 2/2] ASoC: dt-bindings: fsl_xcvr: Add document for XCVR

2020-09-16 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a new IP module found on i.MX8MP. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,xcvr.yaml| 104 + 1 file changed, 104 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl

[PATCH 1/2] ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver

2020-09-16 Thread Viorel Suman (OSS)
From: Viorel Suman XCVR (Audio Transceiver) is a on-chip functional module found on i.MX8MP. It support HDMI2.1 eARC, HDMI1.4 ARC and SPDIF. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig| 10 + sound/soc/fsl/Makefile |2 + sound/soc/fsl/fsl_xcvr.c | 1352

[PATCH 0/2] DAI driver for new XCVR IP

2020-09-16 Thread Viorel Suman (OSS)
From: Viorel Suman DAI driver for new XCVR IP found in i.MX8MP. Viorel Suman (2): ASoC: fsl_xcvr: Add XCVR ASoC CPU DAI driver ASoC: dt-bindings: fsl_xcvr: Add document for XCVR .../devicetree/bindings/sound/fsl,xcvr.yaml| 104 ++ sound/soc/fsl/Kconfig

[PATCH] ASoC: fsl_audmix: make clock and output src write only

2020-09-14 Thread Viorel Suman (OSS)
From: Viorel Suman "alsactl -f state.conf store/restore" sequence fails because setting "mixing clock source" and "output source" requires active TDM clock being started for configuration propagation. Make these two controls write only so that their values ar

Re: [PATCH v3 0/3] Add runtime PM for SAI digital audio interface

2019-04-23 Thread Viorel Suman
For this series: Reviewed-by: Viorel Suman On Lu, 2019-04-22 at 19:02 +, Daniel Baluta wrote: > First patch fixes a bug by correctly setting is_slave_mode, then > second patch adds support for runtime PM and finally 3rd patch moves > clock handling from startup/shtudown function t

Re: [PATCH 3/3 v3] ASoC: fsl_sai: Move clock operation to PM runtime

2019-04-22 Thread Viorel Suman
Hi Daniel, On Du, 2019-04-21 at 19:39 +, Daniel Baluta wrote: > From: Shengjiu Wang > > Turn off/on clocks when device enters suspend/resume. This > can help saving power. > > As a further optimization, we turn off/on mclk only when SAI > is in master mode because otherwise mclk is external

Re: [PATCH 2/2] ASoC: fsl: Move clock operation to PM runtime

2019-04-22 Thread Viorel Suman
Hi Nicolin, On Sb, 2019-04-20 at 22:54 -0700, Nicolin Chen wrote: > On Sat, Apr 20, 2019 at 03:59:05PM +, Daniel Baluta wrote: > > > > Turn off/on clocks when device enters suspend/resume. This > > helps saving power. > > > > @@ -934,6 +933,25 @@ static int fsl_sai_runtime_suspend(struct dev

[PATCH v4 4/4] ASoC: fsl_audmix: cache pdev->dev pointer

2019-04-10 Thread Viorel Suman
There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Viorel Suman Suggested-by: Nicolin Chen --- sound/soc/fsl/fsl_audmix.c | 27 +-- 1 file changed, 13 insertions(+),

[PATCH v4 3/4] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-10 Thread Viorel Suman
Release the reference to the underlying device taken by of_find_device_by_node() call. Signed-off-by: Viorel Suman Reported-by: Julia Lawall Acked-by: Nicolin Chen --- sound/soc/fsl/imx-audmix.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl

[PATCH v4 2/4] ASoC: fsl_audmix: remove "model" attribute from DT document

2019-04-10 Thread Viorel Suman
Remove "model" attribute from fsl_audmix DT document. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen --- Documentation/devicetree/bindings/sound/fsl,audmix.txt | 4 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,audmix.txt b/Doc

[PATCH v4 1/4] ASoC: fsl_audmix: remove "model" attribute

2019-04-10 Thread Viorel Suman
Use "of_device_id.data" to specify the machine driver instead of "model" DTS attribute. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_audmix.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) di

[PATCH v4 0/4] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks

2019-04-10 Thread Viorel Suman
probe reported by Julia Lawall. Viorel Suman (4): ASoC: fsl_audmix: remove "model" attribute ASoC: fsl_audmix: remove "model" attribute from DT document ASoC: imx-audmix: fix object reference leaks in probe ASoC: fsl_audmix: cache pdev->dev pointer Changes since V1: a) Rem

Re: [EXT] Re: [PATCH v3 2/4] dt-bindings: fsl, audmix: remove "model" attribute

2019-04-10 Thread Viorel Suman
Hi Mark, On Mi, 2019-04-10 at 11:39 +0100, Mark Brown wrote: > On Wed, Apr 10, 2019 at 10:37:30AM +0000, Viorel Suman wrote: > > > > Remove "model" attribute. > > > > Signed-off-by: Viorel Suman > > Acked-by: Nicolin Chen > Please use subject lin

[PATCH v3 4/4] ASoC: fsl_audmix: cache pdev->dev pointer

2019-04-10 Thread Viorel Suman
There should be no trouble to understand dev = pdev->dev. This can save some space to have more print info or save some wrapped lines. Signed-off-by: Viorel Suman Suggested-by: Nicolin Chen --- sound/soc/fsl/fsl_audmix.c | 26 +- 1 file changed, 13 insertions(+),

[PATCH v3 3/4] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-10 Thread Viorel Suman
Release the reference to the underlying device taken by of_find_device_by_node() call. Signed-off-by: Viorel Suman Reported-by: Julia Lawall Acked-by: Nicolin Chen --- sound/soc/fsl/imx-audmix.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl

[PATCH v3 2/4] dt-bindings: fsl,audmix: remove "model" attribute

2019-04-10 Thread Viorel Suman
Remove "model" attribute. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen --- Documentation/devicetree/bindings/sound/fsl,audmix.txt | 4 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,audmix.txt b/Documentation/devicetree/bindings

[PATCH v3 1/4] ASoC: fsl_audmix: remove "model" attribute

2019-04-10 Thread Viorel Suman
Use "of_device_id.data" to specify the machine driver instead of "model" DTS attribute. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen --- sound/soc/fsl/fsl_audmix.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) di

[PATCH v3 0/4] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks

2019-04-10 Thread Viorel Suman
probe reported by Julia Lawall. Viorel Suman (4): ASoC: fsl_audmix: remove "model" attribute dt-bindings: fsl,audmix: remove "model" attribute ASoC: imx-audmix: fix object reference leaks in probe ASoC: fsl_audmix: cache pdev->dev pointer Changes since V1: a) Removed

Re: [EXT] Re: [PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute

2019-04-10 Thread Viorel Suman
Hi Nicolin, On Ma, 2019-04-09 at 21:29 -0700, Nicolin Chen wrote: > WARNING: This email was created outside of NXP. DO NOT CLICK links or > attachments unless you recognize the sender and know the content is > safe. > > > > On Tue, Apr 09, 2019 at 11:27:39AM +000

[PATCH v2 2/3] dt-bindings: fsl,audmix: remove "model" attribute

2019-04-09 Thread Viorel Suman
Remove "model" attribute. Signed-off-by: Viorel Suman --- Documentation/devicetree/bindings/sound/fsl,audmix.txt | 4 1 file changed, 4 deletions(-) diff --git a/Documentation/devicetree/bindings/sound/fsl,audmix.txt b/Documentation/devicetree/bindings/sound/fsl,audmix.txt ind

[PATCH v2 1/3] ASoC: fsl_audmix: remove "model" attribute

2019-04-09 Thread Viorel Suman
Use "of_device_id.data" to specify the machine driver instead of "model" DTS attribute. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_audmix.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) diff --git a/sound/soc/fsl/

[PATCH v2 0/3] ASoC: fsl: audmix: remove "model" attribute and fix ref leaks

2019-04-09 Thread Viorel Suman
probe reported by Julia Lawall. Viorel Suman (3): ASoC: fsl_audmix: remove "model" attribute dt-bindings: fsl,audmix: remove "model" attribute ASoC: imx-audmix: fix object reference leaks in probe Changes since V1: a) Removed "model" attribute from dt-bindings do

[PATCH v2 3/3] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-09 Thread Viorel Suman
Release the reference to the underlying device taken by of_find_device_by_node() call. Signed-off-by: Viorel Suman Reported-by: Julia Lawall --- sound/soc/fsl/imx-audmix.c | 4 1 file changed, 4 insertions(+) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx-audmix.c index

Re: [PATCH 0/2] ASoC: fsl: audmix: fix two issues

2019-04-09 Thread Viorel Suman
Please ignore this series, the device bindings documentation, [1], still contains "model" attribute. Will send V2. [1] Documentation/devicetree/bindings/sound/fsl,audmix.txt Regards, Viorel On Ma, 2019-04-09 at 08:35 +0000, Viorel Suman wrote: > The latest audmix patch-set (v5) h

[PATCH 1/2] ASoC: fsl_audmix: remove "model" attribute

2019-04-09 Thread Viorel Suman
Use "of_device_id.data" to specify the machine driver, instead of "model" DTS attribute. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_audmix.c | 61 -- 1 file changed, 32 insertions(+), 29 deletions(-) diff --git a/sound/so

[PATCH 0/2] ASoC: fsl: audmix: fix two issues

2019-04-09 Thread Viorel Suman
The latest audmix patch-set (v5) had the "model" attribute removed as requested by Nicolin Chen, but looks like (v4) version of DAI driver reached "for-next" branch - fix this. Asside of this fix object reference leaks in machine probe reported by Julia Lawall. Vior

[PATCH 2/2] ASoC: imx-audmix: fix object reference leaks in probe

2019-04-09 Thread Viorel Suman
Release the reference to the underlying device taken by of_find_device_by_node() call. Signed-off-by: Viorel Suman --- sound/soc/fsl/imx-audmix.c | 31 +++ 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/sound/soc/fsl/imx-audmix.c b/sound/soc/fsl/imx

Re: [PATCH][next] ASoC: fsl: fix spelling mistake: "missign" -> "missing"

2019-03-29 Thread Viorel Suman
On Jo, 2019-03-28 at 15:48 +0530, Mukesh Ojha wrote: > On 3/28/2019 2:58 PM, Colin King wrote: > > > > From: Colin Ian King > > > > There is a spelling mistake in a dev_err message. Fix this. > > > > Signed-off-by: Colin Ian King > > Revi

[PATCH] ASoC: fsl_audmix: Fix kbuild failure

2019-03-27 Thread Viorel Suman
The format in dev_dbg function must be a constant. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_audmix.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_audmix.c b/sound/soc/fsl/fsl_audmix.c index 3356cb6..dabde03 100644 --- a/sound/soc/fsl

[PATCH RESEND v5 3/3] ASoC: fsl: Add Audio Mixer machine driver

2019-03-04 Thread Viorel Suman
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen --- sound/soc/fsl/Kconfig | 9 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/imx-audmix.c | 327

[PATCH RESEND v5 2/3] ASoC: add fsl_audmix DT binding documentation

2019-03-04 Thread Viorel Suman
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by: Viorel Suman Acked-by: Nicolin Chen Acked-by: Rob Herring --- .../devicetree/bindings/sound/fsl,audmix.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 Documentation

[PATCH RESEND v5 1/3] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-03-04 Thread Viorel Suman
-by: Viorel Suman Acked-by: Nicolin Chen --- sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_audmix.c | 578 + sound/soc/fsl/fsl_audmix.h | 102 4 files changed, 690 insertions(+) create mode 100644

[PATCH RESEND v5 0/3] Add NXP AUDMIX device and machine drivers

2019-03-04 Thread Viorel Suman
vice driver and DT binding documentation. 2. Replaced AMIX with AUDMIX in both code and file names as it looks more RM-compliant. 3. Removed polarity control from CPU DAI driver as suggested by Nicolin. 4. Added machine driver and related DT binding documentation. Viorel Suman (3): ASoC: fsl: Add

[PATCH] ASoC: fsl_spdif: fix sysclk_df type

2019-02-18 Thread Viorel Suman
According to RM SPDIF STC SYSCLK_DF field is 9-bit wide, values being in 0..511 range. Use a proper type to handle sysclk_df. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_spdif.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/sound/soc/fsl/fsl_spdif.c b

[PATCH] ASoC: fsl_spdif: fix TXCLK_DF mask

2019-02-18 Thread Viorel Suman
According to RM SPDIF TXCLK_DF mask is 7-bit wide. Signed-off-by: Viorel Suman --- sound/soc/fsl/fsl_spdif.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/soc/fsl/fsl_spdif.h b/sound/soc/fsl/fsl_spdif.h index 7666dab..e6c61e0 100644 --- a/sound/soc/fsl/fsl_spdif.h

[PATCH v5 3/3] ASoC: fsl: Add Audio Mixer machine driver

2019-02-15 Thread Viorel Suman
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig | 9 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/imx-audmix.c | 327

[PATCH v5 2/3] ASoC: add fsl_audmix DT binding documentation

2019-02-15 Thread Viorel Suman
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,audmix.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt diff

[PATCH v5 1/3] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-02-15 Thread Viorel Suman
-by: Viorel Suman --- sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_audmix.c | 578 + sound/soc/fsl/fsl_audmix.h | 102 4 files changed, 690 insertions(+) create mode 100644 sound/soc/fsl/fsl_audmix.c

[PATCH v5 0/3] Add NXP AUDMIX device and machine drivers

2019-02-15 Thread Viorel Suman
vice driver and DT binding documentation. 2. Replaced AMIX with AUDMIX in both code and file names as it looks more RM-compliant. 3. Removed polarity control from CPU DAI driver as suggested by Nicolin. 4. Added machine driver and related DT binding documentation. Viorel Suman (3): ASoC: fsl: Add

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-22 Thread Viorel Suman
Hi Rob, On Lu, 2019-01-21 at 09:23 -0600, Rob Herring wrote: > On Fri, Jan 18, 2019 at 11:46:42AM -0800, Nicolin Chen wrote: > > > > On Fri, Jan 18, 2019 at 01:16:24PM +0000, Viorel Suman wrote: > > > > > > > > > > > > > > > >

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-22 Thread Viorel Suman
Hi Nicolin, On Vi, 2019-01-18 at 11:46 -0800, Nicolin Chen wrote: > On Fri, Jan 18, 2019 at 01:16:24PM +0000, Viorel Suman wrote: > > > > > > > > > > > > > 1. Moved "dais" node from machine driver DTS node to device > > > > drive

[PATCH v4 3/3] ASoC: fsl: Add Audio Mixer machine driver

2019-01-22 Thread Viorel Suman
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig | 9 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/imx-audmix.c | 327

[PATCH v4 0/3] Add NXP AUDMIX device and machine drivers

2019-01-22 Thread Viorel Suman
3. Removed polarity control from CPU DAI driver as suggested by Nicolin. 4. Added machine driver and related DT binding documentation. Viorel Suman (3): ASoC: fsl: Add Audio Mixer CPU DAI driver ASoC: add fsl_audmix DT binding documentation ASoC: fsl: Add Audio Mixer machine driver .../

[PATCH v4 2/3] ASoC: add fsl_audmix DT binding documentation

2019-01-22 Thread Viorel Suman
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,audmix.txt | 54 ++ 1 file changed, 54 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt diff

[PATCH v4 1/3] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-22 Thread Viorel Suman
-by: Viorel Suman --- sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_audmix.c | 576 + sound/soc/fsl/fsl_audmix.h | 102 4 files changed, 688 insertions(+) create mode 100644 sound/soc/fsl/fsl_audmix.c

Re: [PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-18 Thread Viorel Suman
Hi Rob, Nicolin, All, On Jo, 2019-01-17 at 10:18 -0600, Rob Herring wrote: > On Thu, Jan 17, 2019 at 12:46:25PM +0000, Viorel Suman wrote: > > > > The patchset adds NXP Audio Mixer (AUDMIX) device and machine > > drivers and related DT bindings documentation. > >

[PATCH v3 4/4] ASoC: add imx-audmix DT binding documentation

2019-01-17 Thread Viorel Suman
Add the DT binding documentation for Audio Mixer machine driver. Signed-off-by: Viorel Suman --- Documentation/devicetree/bindings/sound/imx-audmix.txt | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt diff

[PATCH v3 0/4] Add NXP AUDMIX device and machine drivers

2019-01-17 Thread Viorel Suman
atches for the device driver and DT binding documentation. 2. Replaced AMIX with AUDMIX in both code and file names as it looks more RM-compliant. 3. Removed polarity control from CPU DAI driver as suggested by Nicolin. 4. Added machine driver and related DT binding documentation. Viorel Suman (

[PATCH v3 3/4] ASoC: fsl: Add Audio Mixer machine driver

2019-01-17 Thread Viorel Suman
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig | 9 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/imx-audmix.c | 334

[PATCH v3 2/4] ASoC: add fsl_audmix DT binding documentation

2019-01-17 Thread Viorel Suman
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,audmix.txt | 50 ++ 1 file changed, 50 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt diff

[PATCH v3 1/4] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-17 Thread Viorel Suman
-by: Viorel Suman --- sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_audmix.c | 551 + sound/soc/fsl/fsl_audmix.h | 102 + 4 files changed, 663 insertions(+) create mode 100644 sound/soc/fsl/fsl_audmix.c

[PATCH v2 4/4] ASoC: add imx-audmix DT binding documentation

2019-01-08 Thread Viorel Suman
Add the DT binding documentation for Audio Mixer machine driver. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/imx-audmix.txt | 24 ++ 1 file changed, 24 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/imx-audmix.txt diff

[PATCH v2 3/4] ASoC: fsl: Add Audio Mixer machine driver

2019-01-08 Thread Viorel Suman
This patch implements Audio Mixer machine driver for NXP iMX8 SOCs. It connects together Audio Mixer and related SAI instances. Signed-off-by: Viorel Suman --- sound/soc/fsl/Kconfig | 9 ++ sound/soc/fsl/Makefile | 2 + sound/soc/fsl/imx-audmix.c | 333

[PATCH v2 2/4] ASoC: add fsl_audmix DT binding documentation

2019-01-08 Thread Viorel Suman
Add the DT binding documentation for NXP Audio Mixer CPU DAI driver. Signed-off-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,audmix.txt | 44 ++ 1 file changed, 44 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/fsl,audmix.txt diff

[PATCH v2 1/4] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-08 Thread Viorel Suman
-by: Viorel Suman --- sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_audmix.c | 551 + sound/soc/fsl/fsl_audmix.h | 102 + 4 files changed, 663 insertions(+) create mode 100644 sound/soc/fsl/fsl_audmix.c

[PATCH v2 0/4] Add NXP AUDMIX device and machine drivers

2019-01-08 Thread Viorel Suman
more RM-compliant. 3. Removed polarity control from CPU DAI driver as suggested by Nicolin. 4. Added machine driver and related DT binding documentation. Viorel Suman (4): ASoC: fsl: Add Audio Mixer CPU DAI driver ASoC: add fsl_audmix DT binding documentation ASoC: fsl: Add Audio Mixer

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-04 Thread Viorel Suman
Hi Nicolin, On Jo, 2019-01-03 at 12:03 -0800, Nicolin Chen wrote: > Hi, > > On Thu, Jan 03, 2019 at 03:56:46PM +0000, Viorel Suman wrote: > > > > > > > > > > > > >  sound/soc/fsl/fsl_amix.c   | 554 > > >

RE: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
> -Original Message- > From: Rob Herring [mailto:robh...@kernel.org] > Sent: Thursday, January 3, 2019 8:26 PM > To: Viorel Suman > Cc: nicoleots...@gmail.com; dl-linux-imx ; linux- > ker...@vger.kernel.org; linuxppc-dev@lists.ozlabs.org; ti...@kernel.org; > devic

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
gt; below. > > On Wed, Dec 19, 2018 at 12:30 AM Viorel Suman > wrote: > > > > > > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs. > > The Audio Mixer is a on-chip functional module that allows mixing > > of > > two audio stream

Re: [RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2019-01-03 Thread Viorel Suman
Hi Rob, On Vi, 2018-12-28 at 17:32 -0600, Rob Herring wrote: > On Tue, Dec 18, 2018 at 04:30:01PM +0000, Viorel Suman wrote: > > > > This patch implements Audio Mixer CPU DAI driver for NXP iMX8 SOCs. > > The Audio Mixer is a on-chip functional module that allows mixing

[RFC PATCH] ASoC: fsl: Add Audio Mixer CPU DAI driver

2018-12-18 Thread Viorel Suman
-by: Viorel Suman --- .../devicetree/bindings/sound/fsl,amix.txt | 45 ++ sound/soc/fsl/Kconfig | 7 + sound/soc/fsl/Makefile | 3 + sound/soc/fsl/fsl_amix.c | 554 + sound/soc/fsl