Re: [PATCH 13/26] block: move cache control settings out of queue->flags

2024-06-12 Thread Ulf Hansson
red in dm for targets that map to underlying devices. > > Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson # For MMC FYI, for now I don't expect any other patches in my mmc tree to clash with this for v6.11, assuming that is the target. Kind regards Uffe > --- > .

Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

2024-04-02 Thread Ulf Hansson
On Thu, 28 Mar 2024 at 17:21, Tejun Heo wrote: > > Hello, > > On Thu, Mar 28, 2024 at 01:53:25PM +0100, Ulf Hansson wrote: > > At this point we have suggested to drivers to switch to use threaded > > irq handlers (and regular work queues if needed too). That said, > &g

Re: [PATCH 9/9] mmc: Convert from tasklet to BH workqueue

2024-03-28 Thread Ulf Hansson
On Wed, 27 Mar 2024 at 17:03, Allen Pais wrote: > > The only generic interface to execute asynchronously in the BH context is > tasklet; however, it's marked deprecated and has some design flaws. To > replace tasklets, BH workqueue support was recently added. A BH workqueue > behaves similarly to

Re: [PATCH v3 07/13] tty: Convert ->dtr_rts() to take bool argument

2023-01-13 Thread Ulf Hansson
e u8 in their control messages. > > In moxa_tiocmget(), dtr variable was reused for line status which > requires int so use a separate variable for status. > > Reviewed-by: Jiri Slaby > Signed-off-by: Ilpo Järvinen Acked-by: Ulf Hansson # For MMC Kind regards Uffe > --- &g

Re: [PATCH v3 11/13] tty/serial: Call ->dtr_rts() parameter active consistently

2023-01-13 Thread Ulf Hansson
On Wed, 11 Jan 2023 at 15:24, Ilpo Järvinen wrote: > > Convert various parameter names for ->dtr_rts() and related functions > from onoff, on, and raise to active. > > Reviewed-by: Jiri Slaby > Signed-off-by: Ilpo Järvinen Acked-by: Ulf Hansson # For MMC Kind regards U

Re: [PATCH v2 12/44] cpuidle,dt: Push RCU-idle into driver

2022-11-22 Thread Ulf Hansson
On Wed, 16 Nov 2022 at 16:29, Peter Zijlstra wrote: > > > Sorry; things keep getting in the way of finishing this :/ > > As such, I need a bit of time to get on-track again.. > > On Tue, Oct 04, 2022 at 01:03:57PM +0200, Ulf Hansson wrote: > > > > --- a/drivers/

Re: [PATCH v3 0/5] treewide cleanup of random integer usage

2022-10-07 Thread Ulf Hansson
t; Cc: Heiko Carstens > Cc: Helge Deller > Cc: Herbert Xu > Cc: Huacai Chen > Cc: Hugh Dickins > Cc: Jakub Kicinski > Cc: James E.J. Bottomley > Cc: Jan Kara > Cc: Jason Gunthorpe > Cc: Jens Axboe > Cc: Johannes Berg > Cc: Jonathan Corbet > Cc: Jozsef K

Re: [PATCH v2 00/44] cpuidle,rcu: Clean up the mess

2022-10-04 Thread Ulf Hansson
- > kernel/trace/trace.c | 3 ++ > lib/ubsan.c | 5 ++- > mm/kasan/kasan.h | 4 ++ > mm/kasan/shadow.c | 38 ++ > tools/objtool/check.c | 17 > 121 files changed, 511 insertions(+), 420 deletions(-) Thanks for cleaning up the situation! I have applied this on a plain v6.0 (only one patch had a minor conflict) and tested this on an ARM64 Dragonboard 410c, which uses cpuidle-psci and the cpuidle-psci-domain. I didn't observe any problems, so feel free to add: Tested-by: Ulf Hansson Kind regards Uffe

Re: [PATCH v2 12/44] cpuidle,dt: Push RCU-idle into driver

2022-10-04 Thread Ulf Hansson
On Tue, 4 Oct 2022 at 13:03, Ulf Hansson wrote: > > On Mon, 19 Sept 2022 at 12:18, Peter Zijlstra wrote: > > > > Doing RCU-idle outside the driver, only to then temporarily enable it > > again before going idle is daft. > > > > Notably: this co

Re: [PATCH v2 38/44] cpuidle,powerdomain: Remove trace_.*_rcuidle()

2022-10-04 Thread Ulf Hansson
s good to me. Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/arm/mach-omap2/powerdomain.c | 10 +- > drivers/base/power/runtime.c | 24 > 2 files changed, 17 insertions(+), 17 deletions(-) > > --- a/arch/arm/mach-omap2/powerdomain

Re: [PATCH v2 39/44] cpuidle,clk: Remove trace_.*_rcuidle()

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > OMAP was the one and only user. OMAP? :-) > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ulf Hansson Kind regards Uffe > --- > drivers/clk/clk.c |8 > 1 file changed, 4 insertions(+), 4 d

Re: [PATCH v2 23/44] arm,smp: Remove trace_.*_rcuidle() usage

2022-10-04 Thread Ulf Hansson
e > deeper into the idle path"). > > Signed-off-by: Peter Zijlstra (Intel) FWIW: Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/arm/kernel/smp.c |6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > --- a/arch/arm/kernel/smp.c > +++

Re: [PATCH v2 14/44] cpuidle,cpu_pm: Remove RCU fiddling from cpu_pm_{enter,exit}()

2022-10-04 Thread Ulf Hansson
On Mon, 19 Sept 2022 at 12:17, Peter Zijlstra wrote: > > All callers should still have RCU enabled. > > Signed-off-by: Peter Zijlstra (Intel) > Acked-by: Mark Rutland Reviewed-by: Ulf Hansson Kind regards Uffe > --- > kernel/cpu_pm.c |9 - > 1 f

Re: [PATCH v2 12/44] cpuidle,dt: Push RCU-idle into driver

2022-10-04 Thread Ulf Hansson
trably intertwined. > > Signed-off-by: Peter Zijlstra (Intel) Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/arm/mach-omap2/cpuidle34xx.c|4 ++-- > drivers/acpi/processor_idle.c|2 ++ > drivers/cpuidle/cpuidle-arm.c|1 + > driv

Re: [PATCH v2 4/4] bus: Make remove callback return void

2021-07-08 Thread Ulf Hansson
álvez (For ipack) > Reviewed-by: Tom Rix (For fpga) > Acked-by: Geoff Levand (For ps3) > Signed-off-by: Uwe Kleine-König Acked-by: Ulf Hansson # For MMC [...] Kind regards Uffe

Re: [PATCH 08/30] mspro: use blk_mq_alloc_disk

2021-06-03 Thread Ulf Hansson
On Wed, 2 Jun 2021 at 08:54, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue > allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/memstick/co

Re: [PATCH 07/30] ms_block: use blk_mq_alloc_disk

2021-06-03 Thread Ulf Hansson
On Wed, 2 Jun 2021 at 08:54, Christoph Hellwig wrote: > > Use the blk_mq_alloc_disk API to simplify the gendisk and request_queue > allocation. > > Signed-off-by: Christoph Hellwig Acked-by: Ulf Hansson Kind regards Uffe > --- > drivers/memstick

Re: simplify gendisk and request_queue allocation for bio based drivers

2021-05-26 Thread Ulf Hansson
On Wed, 26 May 2021 at 06:49, Christoph Hellwig wrote: > > On Wed, May 26, 2021 at 12:41:37AM +0200, Ulf Hansson wrote: > > On Fri, 21 May 2021 at 07:51, Christoph Hellwig wrote: > > > > > > Hi all, > > > > > > this series is the first part of c

Re: simplify gendisk and request_queue allocation for bio based drivers

2021-05-25 Thread Ulf Hansson
| 23 + > 30 files changed, 297 insertions(+), 466 deletions(-) This looks like a nice cleanup to me. Feel free to add, for the series: Reviewed-by: Ulf Hansson Kind regards Uffe

Re: [PATCH] of: Add OF_DMA_DEFAULT_COHERENT & select it on powerpc

2020-01-26 Thread Ulf Hansson
> Tested-by: Christian Zigotzky > Signed-off-by: Michael Ellerman Thanks Michael for helping out fixing and this! The patch looks good to me. Reviewed-by: Ulf Hansson Kind regards Uffe > --- > arch/powerpc/Kconfig | 1 + > drivers/of/Kconfig | 4 > drivers/of/ad

Re: [FSL P5020 P5040 PPC] Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates

2020-01-20 Thread Ulf Hansson
On Mon, 20 Jan 2020 at 10:17, Christian Zigotzky wrote: > > Am 16.01.20 um 16:46 schrieb Ulf Hansson: > > On Thu, 16 Jan 2020 at 12:18, Christian Zigotzky > > wrote: > >> Hi All, > >> > >> We still need the attached patch for our onboard SD card in

Re: [FSL P5020 P5040 PPC] Onboard SD card doesn't work anymore after the 'mmc-v5.4-2' updates

2020-01-16 Thread Ulf Hansson
On Thu, 16 Jan 2020 at 12:18, Christian Zigotzky wrote: > > Hi All, > > We still need the attached patch for our onboard SD card interface > [1,2]. Could you please add this patch to the tree? No, because according to previous discussion that isn't the correct solution and more importantly it wil

Re: [PATCH v1 4/4] mmc: sdhci-of-esdhc: add erratum A011334 support in ls1028a 1.0 SoC

2019-08-22 Thread Ulf Hansson
On Wed, 14 Aug 2019 at 09:24, Yinbo Zhu wrote: > > This patch is to add erratum A011334 support in ls1028a 1.0 SoC > > Signed-off-by: Yinbo Zhu Applied for next, thanks! Kind regards Uffe > --- > drivers/mmc/host/sdhci-of-esdhc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drive

Re: [PATCH v1 1/2] mmc/host: add FSP2(ppc476fpe) into depends for sdhci-st

2017-07-11 Thread Ulf Hansson
On 30 June 2017 at 13:53, Ivan Mikhaylov wrote: > shdci-st driver can be used for ppc476 fsp2 soc. > > Signed-off-by: Ivan Mikhaylov Thanks, applied for next! Kind regards Uffe > --- > drivers/mmc/host/Kconfig |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/driv

Re: [PATCH v2 0/7] soc: renesas: Identify SoC and register with the SoC bus

2016-11-10 Thread Ulf Hansson
On 10 November 2016 at 10:22, Geert Uytterhoeven wrote: > Hi Ulf, > > On Wed, Nov 9, 2016 at 10:12 PM, Arnd Bergmann wrote: >> On Wednesday, November 9, 2016 6:19:06 PM CET Geert Uytterhoeven wrote: >>> On Wed, Nov 9, 2016 at 5:56 PM, Arnd Bergmann wrote: >>> > On Wednesday, November 9, 2016 2:3

Re: [v16, 0/7] Fix eSDHC host version register bug

2016-11-09 Thread Ulf Hansson
me Documentation/devicetree/bindings/{powerpc => soc}/fsl/guts.txt (91%) > create mode 100644 drivers/soc/fsl/Kconfig > create mode 100644 drivers/soc/fsl/guts.c > > -- > 2.1.0.27.g96db324 > Thanks, applied on my mmc tree for next! I noticed that some DT compatibles weren't documented, according to checkpatch. Please fix that asap! Kind regards Ulf Hansson

Re: [v12, 0/8] Fix eSDHC host version register bug

2016-10-18 Thread Ulf Hansson
On 21 September 2016 at 08:57, Yangbo Lu wrote: > This patchset is used to fix a host version register bug in the > T4240-R1.0-R2.0 > eSDHC controller. To match the SoC version and revision, 10 previous version > patchsets had tried many methods but all of them were rejected by reviewers. > Such

Re: [v11, 7/8] base: soc: introduce soc_device_match() interface

2016-09-06 Thread Ulf Hansson
On 6 September 2016 at 10:28, Yangbo Lu wrote: > We keep running into cases where device drivers want to know the exact > version of the a SoC they are currently running on. In the past, this has > usually been done through a vendor specific API that can be called by a > driver, or by directly acc

Re: [v10, 7/7] mmc: sdhci-of-esdhc: fix host version for T4240-R1.0-R2.0

2016-05-26 Thread Ulf Hansson
On 26 May 2016 at 06:05, Yangbo Lu wrote: > Hi Uffe, > > Could we merge this patchset? ... > It has been a long time to wait for Arnd's response... > > Thanks a lot. > > As we are still in the merge window I won't queue anything but fixes. Let's give Arnd another week or so to respond. Kind rega

Re: [v9, 6/7] MAINTAINERS: add entry for Freescale SoC driver

2016-05-04 Thread Ulf Hansson
On 4 May 2016 at 05:24, Yangbo Lu wrote: > Add maintainer entry for Freescale SoC driver including > the QE library and the GUTS driver now. Also add maintainer > for QE library. > > Signed-off-by: Yangbo Lu So I need an ack from Scott and Qiang for this one, then I intend to queue up the series

Re: [v7, 0/5] Fix eSDHC host version register bug

2016-04-06 Thread Ulf Hansson
>> >> I was about to queue this for next, when I noticed that checkpatch is >> complaining/warning lots about these patches. Can you please a round of >> checkpatch and fix what makes sense. >> >> Kind regards >> Uffe > > [Lu Yangbo-B47093] Sorry about this, Uffe... No worries! > Should I ignore

Re: [v7, 0/5] Fix eSDHC host version register bug

2016-04-05 Thread Ulf Hansson
On 1 April 2016 at 05:07, Yangbo Lu wrote: > This patchset is used to fix a host version register bug in the > T4240-R1.0-R2.0 > eSDHC controller. To get the SoC version and revision, it's needed to add the > GUTS driver to access the global utilities registers. > > So, the first three patches ar

Re: [v7, 4/5] powerpc/fsl: move mpc85xx.h to include/linux/fsl

2016-04-05 Thread Ulf Hansson
- decreasing the cc list significantly On 1 April 2016 at 05:07, Yangbo Lu wrote: > Move mpc85xx.h to include/linux/fsl and rename it to svr.h as > a common header file. It has been used for mpc85xx and it will > be used for ARM-based SoC as well. > > Signed-off-by: Yangbo Lu > Acked-by: Wolfram

Re: [PATCH 3/3] mmc: sdhci-of-esdhc: add workaround for T4240 incorrect HOSTVER value

2015-08-25 Thread Ulf Hansson
On 27 July 2015 at 17:57, Scott Wood wrote: > On Mon, 2015-07-27 at 09:58 +0200, Ulf Hansson wrote: >> On 25 July 2015 at 04:27, Scott Wood wrote: >> > On Tue, 2015-07-21 at 15:02 +0200, Ulf Hansson wrote: >> > > On 21 July 2015 at 11:45, Yangbo Lu wrote: >

Re: [PATCH 3/3] mmc: sdhci-of-esdhc: add workaround for T4240 incorrect HOSTVER value

2015-07-27 Thread Ulf Hansson
On 25 July 2015 at 04:27, Scott Wood wrote: > On Tue, 2015-07-21 at 15:02 +0200, Ulf Hansson wrote: >> On 21 July 2015 at 11:45, Yangbo Lu wrote: >> > For T4240-R1.0-R2.0, the HOSTVER register has incorrcet vender >> > version value and sdhc spec version value. This wi

Re: [PATCH v8 2/2] mmc: host: sdhci: Disable 1.8V signaling for arasan 4.9a version of SDHCI controller.

2015-07-21 Thread Ulf Hansson
On 19 June 2015 at 14:28, Suman Tripathi wrote: > Hi , > > On Fri, Jun 19, 2015 at 5:30 PM, Suman Tripathi wrote: >> This patch disables the 1.8V signaling for arasan 4.9a version >> of SDHCI controller with the help SDHCI_QUIRK2_NO_1_8_V quirk. >> >> Signed-off-by: Suman Tripathi >> --- >> ---

Re: [PATCH 3/3] mmc: sdhci-of-esdhc: add workaround for T4240 incorrect HOSTVER value

2015-07-21 Thread Ulf Hansson
On 21 July 2015 at 11:45, Yangbo Lu wrote: > For T4240-R1.0-R2.0, the HOSTVER register has incorrcet vender > version value and sdhc spec version value. This will break down > the ADMA data transfer. So add workaround to get right value > VVN=0x13, SVN = 0x1. So T4240-R1.0-R2.0 is the version of

Re: [PATCH RESEND v7 2/2] mmc: host: sdhci: Add support to disable SDR104/SDR50/DDR50 based on capability register 0.

2015-06-08 Thread Ulf Hansson
On 8 June 2015 at 10:37, Ulf Hansson wrote: > [...] > >>> > >>> >Can you test this patch on imx SoC ? >>> > >>> >>> (Your email have some format issue.) >> >> Yeah missed to sent in plain text mode. >> >>

Re: [PATCH RESEND v7 2/2] mmc: host: sdhci: Add support to disable SDR104/SDR50/DDR50 based on capability register 0.

2015-06-08 Thread Ulf Hansson
[...] >> > >> >Can you test this patch on imx SoC ? >> > >> >> (Your email have some format issue.) > > Yeah missed to sent in plain text mode. > >> >> I have tested this patch and it does not break imx SoC. >> You can add my tag. >> Tested-by: Dong Aisheng > > Thanks Dong !! > >> >> However

Re: [PATCH RESEND v7 2/2] mmc: host: sdhci: Add support to disable SDR104/SDR50/DDR50 based on capability register 0.

2015-05-26 Thread Ulf Hansson
On 21 May 2015 at 10:43, Suman Tripathi wrote: > The sdhci framework disables SDR104/SDR50/DDR50 based on only quirk. > This patch adds the support to disable SDR104/SDR50/DDR50 based on > reading the capability register 0. > > Signed-off-by: Suman Tripathi > --- > --- > drivers/mmc/host/sdhci.c

Re: [PATCH RESEND v6 1/2] arm64: dts: Add the arasan sdhci nodes in apm-storm.dtsi

2015-05-12 Thread Ulf Hansson
On 12 May 2015 at 09:28, Arnd Bergmann wrote: > On Tuesday 12 May 2015 11:03:46 Suman Tripathi wrote: >> > @@ -533,6 +567,15 @@ >> > interrupts = <0x0 0x4f 0x4>; >> > }; >> > >> > + sdhci0: sdhci@1c00 { >> > + compatib

Re: [PATCH v5 1/1] arm64: dts: Add the arasan sdhc nodes in apm-storm.dtsi.

2015-05-06 Thread Ulf Hansson
On 5 May 2015 at 12:34, Ulf Hansson wrote: > On 5 May 2015 at 11:17, Suman Tripathi wrote: >> This patch adds the arasan sdhc nodes to reuse the of-arasan >> driver for APM X-Gene SoC. >> >> Signed-off-by: Suman Tripathi > > I consider this one acked by Arnd,

Re: [PATCH v4 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller.

2015-05-05 Thread Ulf Hansson
On 5 May 2015 at 10:42, Suman Tripathi wrote: > On Tue, May 5, 2015 at 2:06 PM, Ulf Hansson wrote: >> On 4 May 2015 at 15:39, Suman Tripathi wrote: >>> This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI >>> controller. >&g

Re: [PATCH v4 0/3] Add SDHCI support for APM X-Gene SoC using ARASAN SDHCI controller.

2015-05-05 Thread Ulf Hansson
On 4 May 2015 at 15:39, Suman Tripathi wrote: > This patch adds the SDHCI support for APM X-Gene SoC using ARASAN SDHCI > controller. > > v1 change: > * Use the CONFIG_ARM64_DMA_HAS_IOMMU for dma-mapping. > > v2 change: > * Drop the IOMMU support and switching to PIO mode for arasan. >contr

Re: [PATCH v2 2/2] mmc: host: Add some quirks to be read from fdt in sdhci-pltm.c

2015-04-08 Thread Ulf Hansson
On 30 March 2015 at 16:46, Suman Tripathi wrote: > This patch adds some quirks support to be read from fdt. > > Signed-off-by: Suman Tripathi > --- > drivers/mmc/host/sdhci-pltfm.c | 15 +++ > 1 file changed, 15 insertions(+) > > diff --git a/drivers/mmc/host/sdhci-pltfm.c b/drivers/

Re: [PATCH] mmc: sdhci-pltfm: remove the unneeded check of disabled device

2015-03-05 Thread Ulf Hansson
On 4 February 2015 at 07:33, Kevin Hao wrote: > Since commit cd1e65044d44 ("of/device: Don't register disabled > devices"), the disabled device will not be registered at all. So > we don't need to do the check again in the platform device driver. > > And the check in the current code is useless ev

Re: [PATCH v2 09/11] mmc: kconfig: replace PPC_OF with PPC

2015-03-05 Thread Ulf Hansson
On 26 February 2015 at 13:08, Kevin Hao wrote: > The PPC_OF is a ppc specific option which is used to mean that the > firmware device tree access functions are available. Since all the > ppc platforms have a device tree, it is aways set to 'y' for ppc. > So it makes no sense to keep a such option

Re: [PATCH] mmc: sdhci: Apply FSL ESDHC reset handling quirk to OF

2015-01-29 Thread Ulf Hansson
On 28 January 2015 at 20:52, Martin Hicks wrote: > > The reset code was pushed into the esdhc-imx driver, but missed being > pushed into the FSL OF driver at the same time. The commit that broke > the OF ESDHC driver was 0718e59ae259f7c48155b4e852d8b0632d59028e > > Signed-off-by: Martin Hicks M

Re: [PATCH v8 3/7] clk: Move all drivers to use internal API

2014-09-02 Thread Ulf Hansson
On 1 September 2014 17:32, Tomeu Vizoso wrote: > In preparation to change the public API to return a per-user clk structure, > remove any usage of this public API from the clock implementations. > > The reason for having this in a separate commit from the one that introduces > the implementation o

Re: [PATCH 3/5 v2] mmc: sdhci-pltfm: Do not use parent as the host's device

2014-08-12 Thread Ulf Hansson
On 12 August 2014 12:37, Pawel Moll wrote: > The code selecting a device for the sdhci host has been > continuously tweaked (4b711cb13843f5082e82970dd1e8031383134a65 > "mmc: sdhci-pltfm: Add structure for host-specific data" and > a4d2177f00a5252d825236c5124bc1e9918bdb41 "mmc: sdhci-pltfm: dt > de

Re: [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device

2014-08-12 Thread Ulf Hansson
On 11 August 2014 11:32, Ulf Hansson wrote: > On 11 August 2014 11:15, Pawel Moll wrote: >> On Mon, 2014-08-11 at 10:07 +0100, Ulf Hansson wrote: >>> On 8 August 2014 18:36, Pawel Moll wrote: >>> > On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote: >>>

Re: [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device

2014-08-11 Thread Ulf Hansson
On 11 August 2014 11:15, Pawel Moll wrote: > On Mon, 2014-08-11 at 10:07 +0100, Ulf Hansson wrote: >> On 8 August 2014 18:36, Pawel Moll wrote: >> > On Fri, 2014-07-25 at 15:23 +0100, Pawel Moll wrote: >> >> The code selecting a device for the sdhci host has b

Re: [PATCH 3/5] mmc: sdhci-pltfm: Do not use parent as the host's device

2014-08-11 Thread Ulf Hansson
; The comment saying "Some PCI-based MFD need the parent here" >> seem to refer to Timberdale FPGA driver (the only MFD driver >> registering SDHCI cell, drivers/mfd/timberdale.c) but again, >> the only situation when parent device matter is runtime PM, >> whi

Re: [RFC PATCH v2 6/6] mmc: core: add manual resume capability

2014-06-27 Thread Ulf Hansson
On 27 juni 2014 04:23:42 CEST, Vincent Yang wrote: >2014-06-26 17:42 GMT+08:00 Ulf Hansson : >> >> >> On 26 juni 2014 08:23:32 CEST, Vincent Yang > wrote: >>>This patch adds manual resume for some embedded platforms with rootfs &g

Re: [RFC PATCH v2 6/6] mmc: core: add manual resume capability

2014-06-26 Thread Ulf Hansson
On 26 juni 2014 08:23:32 CEST, Vincent Yang wrote: >This patch adds manual resume for some embedded platforms with rootfs >stored in SD card. It references CONFIG_MMC_BLOCK_DEFERRED_RESUME in >kernel 3.10. It lets host controller driver to manually handle resume >by itself. > >[symptom] >This i

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Ulf Hansson
On 16 June 2014 14:17, Ulf Hansson wrote: > On 16 June 2014 12:46, Russell King - ARM Linux > wrote: >> On Wed, Apr 23, 2014 at 08:08:07PM +0100, Russell King wrote: >>> @@ -1507,25 +1529,7 @@ static void sdhci_do_set_ios(struct sdhci_host >>&

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-16 Thread Ulf Hansson
a || d < c)) || z == f) > > With the former "style", I normally end up having to pull the file into > the editor, and rewrite the damned statement to work out what the > grouping is, because the excessive use of parenthesis is detrimental to > readability. Don't do it. Learn the C precedence rules and keep code > readable. Sure, we will adopt. Please, feel free to send a patch to fixup my misstake. I will happily apply it. Kind regards Ulf Hansson ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-25 Thread Ulf Hansson
On 25 April 2014 13:20, Russell King - ARM Linux wrote: > On Fri, Apr 25, 2014 at 01:18:28PM +0200, Ulf Hansson wrote: >> On 25 April 2014 11:03, Russell King - ARM Linux >> wrote: >> > On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote: >> >> On 24

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-25 Thread Ulf Hansson
On 25 April 2014 11:03, Russell King - ARM Linux wrote: > On Thu, Apr 24, 2014 at 01:13:05PM +0200, Ulf Hansson wrote: >> On 24 April 2014 12:57, Russell King - ARM Linux >> wrote: >> > This is nothing new or unexpected - it was last posted back in February, >> >

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-24 Thread Ulf Hansson
On 24 April 2014 12:57, Russell King - ARM Linux wrote: > On Thu, Apr 24, 2014 at 12:52:11PM +0200, Ulf Hansson wrote: >> On 24 April 2014 12:17, Russell King - ARM Linux >> wrote: >> > On Thu, Apr 24, 2014 at 10:25:42AM +0200, Ulf Hansson wrote: >> >> I hav

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-24 Thread Ulf Hansson
On 24 April 2014 12:17, Russell King - ARM Linux wrote: > On Thu, Apr 24, 2014 at 10:25:42AM +0200, Ulf Hansson wrote: >> I have looked though the patches up until patch 33 and this is clearly >> a nice piece of clean-up /fixes work for sdhci. Besides my minor >> comments pe

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-24 Thread Ulf Hansson
d them on Chris' mmc-next branch, unfortunate it fails at patch 23, so it would be nice to get a re-based patchset for the mmc-next branch. Kind regards Ulf Hansson > Documentation/devicetree/bindings/mmc/mmc.txt | 11 + > arch/arm/boot/dts/imx6qdl-cubox-i.dtsi| 34 +- &g