Re: [PATCH v12 07/15] media: v4l2: Add audio capture and output support

2024-02-20 Thread Tomasz Figa
/media/v4l2-ioctl.h| 34 + > include/uapi/linux/videodev2.h| 17 + > 13 files changed, 222 insertions(+) > create mode 100644 > Documentation/userspace-api/media/v4l/dev-audio-mem2mem.rst For drivers/media/common/videobuf2: Acked-by: Tomasz Figa Best regards, Tomasz

Re: [PATCH v12 07/15] media: v4l2: Add audio capture and output support

2024-02-20 Thread Tomasz Figa
On Sat, Feb 17, 2024 at 6:42 PM Mauro Carvalho Chehab wrote: > > Em Thu, 18 Jan 2024 20:32:00 +0800 > Shengjiu Wang escreveu: > > > Audio signal processing has the requirement for memory to > > memory similar as Video. > > > > This patch is to add this support in v4l2 framework, defined > > new b

Re: [PATCH v9 10/15] media: uapi: Add V4L2_CTRL_TYPE_FIXED_POINT

2023-11-15 Thread Tomasz Figa
On Wed, Nov 15, 2023 at 8:49 PM Laurent Pinchart wrote: > > Hi Hans, > > On Wed, Nov 15, 2023 at 12:19:31PM +0100, Hans Verkuil wrote: > > On 11/15/23 11:55, Laurent Pinchart wrote: > > > On Wed, Nov 15, 2023 at 09:09:42AM +0100, Hans Verkuil wrote: > > >> On 13/11/2023 13:44, Laurent Pinchart wro

Re: [PATCH v9 10/15] media: uapi: Add V4L2_CTRL_TYPE_FIXED_POINT

2023-11-15 Thread Tomasz Figa
On Wed, Nov 15, 2023 at 5:09 PM Hans Verkuil wrote: > > Hi Laurent, > > On 13/11/2023 13:44, Laurent Pinchart wrote: > > Hi Hans, > > > > On Mon, Nov 13, 2023 at 01:05:12PM +0100, Hans Verkuil wrote: > >> On 13/11/2023 12:43, Laurent Pinchart wrote: > >>> On Mon, Nov 13, 2023 at 11:28:51AM +,

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-08-02 Thread Tomasz Figa
On Tue, Aug 1, 2023 at 6:47 PM Shengjiu Wang wrote: > > On Fri, Jul 28, 2023 at 3:59 PM Tomasz Figa wrote: > > > > Hi Shengjiu, > > > > On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > > > Audio signal processing has the requirement for

Re: [RFC PATCH v2 4/7] media: v4l2: Add audio capture and output support

2023-07-28 Thread Tomasz Figa
Hi Shengjiu, On Tue, Jul 25, 2023 at 02:12:17PM +0800, Shengjiu Wang wrote: > Audio signal processing has the requirement for memory to > memory similar as Video. > > This patch is to add this support in v4l2 framework, defined > new buffer type V4L2_BUF_TYPE_AUDIO_CAPTURE and > V4L2_BUF_TYPE_AUD

Re: [PATCH mm-unstable v1 16/20] mm/frame-vector: remove FOLL_FORCE usage

2022-11-28 Thread Tomasz Figa
e read-only buffer issue has been resolved, FOLL_WRITE could > >>> again be set depending on the DMA direction. > >>> > >>> Cc: Hans Verkuil > >>> Cc: Marek Szyprowski > >>> Cc: Tomasz Figa > >>> Cc: Marek Szyprowski >

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Tomasz Figa
On Wed, Jan 13, 2021 at 12:56 PM Florian Fainelli wrote: > > > > On 1/12/2021 6:29 PM, Tomasz Figa wrote: > > Hi Florian, > > > > On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli > > wrote: > >> > >> On 1/11/21 11:48 PM, Claire Chang wrote:

Re: [RFC PATCH v3 0/6] Restricted DMA

2021-01-12 Thread Tomasz Figa
Hi Florian, On Wed, Jan 13, 2021 at 3:01 AM Florian Fainelli wrote: > > On 1/11/21 11:48 PM, Claire Chang wrote: > > On Fri, Jan 8, 2021 at 1:59 AM Florian Fainelli > > wrote: > >> > >> On 1/7/21 9:42 AM, Claire Chang wrote: > >> > Can you explain how ATF gets involved and to what extent i

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-22 Thread Tomasz Figa
On Thursday 22 of August 2013 15:43:31 Mike Turquette wrote: > Quoting Sascha Hauer (2013-08-22 14:00:35) > > > On Thu, Aug 22, 2013 at 01:09:31PM +0100, Mark Rutland wrote: > > > On Thu, Aug 22, 2013 at 08:19:10AM +0100, Mike Turquette wrote: > > > > Quoting

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-21 Thread Tomasz Figa
On Wednesday 21 of August 2013 09:50:15 Mark Rutland wrote: > On Tue, Aug 20, 2013 at 01:06:25AM +0100, Mike Turquette wrote: > > Quoting Mark Rutland (2013-08-19 02:35:43) > > > > > On Sat, Aug 17, 2013 at 04:17:18PM +0100, Tomasz Figa wrote: > > > > On Saturd

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-21 Thread Tomasz Figa
On Wednesday 21 of August 2013 12:30:59 Stephen Warren wrote: > On 08/20/2013 09:13 PM, Nicolin Chen wrote: > > This patch implements a device-tree-only machine driver for Freescale > > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > > fsl_spdif.c drivers. > > > > diff --git

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Tomasz Figa
On Sunday 18 of August 2013 08:09:36 Benjamin Herrenschmidt wrote: > On Sat, 2013-08-17 at 12:50 +0200, Tomasz Figa wrote: > > I wonder how would this handle uniprocessor ARM (pre-v7) cores, for > > which > > the updated bindings[1] define #address-cells = <0>

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 17:14:09 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:56:11PM +0200, Tomasz Figa wrote: > > Hi Nicolin, > > > > > First, you are right that all the properties you just commented are > > > software configurations. And I g

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 16:53:16 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:28:04PM +0200, Tomasz Figa wrote: > > > > > Also I would make this option required. Use a dummy clock for > > > > > mux > > > > > inputs that are grounded for

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Saturday 17 of August 2013 17:00:02 Sascha Hauer wrote: > On Sat, Aug 17, 2013 at 02:26:40PM +0200, Tomasz Figa wrote: > > > You mean tx<0-7>. > > > > > > Also I would make this option required. Use a dummy clock for mux > > > inputs that are gro

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
Hi Nicolin, On Friday 16 of August 2013 12:43:31 Nicolin Chen wrote: > Hi Tomasz, > >Thank you for the comments. You're welcome. >I'll revise them in v6. >And below is my reply for you comments. Thanks for your reply. > On Thu, Aug 15, 2013 at 02:18:2

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Friday 16 of August 2013 12:11:51 Sascha Hauer wrote: > On Fri, Aug 16, 2013 at 05:53:58PM +0800, Nicolin Chen wrote: > > On Fri, Aug 16, 2013 at 10:56:32AM +0200, Sascha Hauer wrote: > > > > "tx<0-8>" OptionalTx clock source for spdif playback. > > > > > > > >

Re: [PATCH v5 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-17 Thread Tomasz Figa
On Friday 16 of August 2013 10:56:32 Sascha Hauer wrote: > On Fri, Aug 16, 2013 at 04:01:25PM +0800, Nicolin Chen wrote: > > Hi Sascha, > > > >Thank you for the detailed comments. > > > > On Fri, Aug 16, 2013 at 09:08:18AM +0200, Sascha Hauer wrote: > > > Which of them the driver should use i

Re: [RFC PATCH v2 3/4] powerpc: refactor of_get_cpu_node to support other architectures

2013-08-17 Thread Tomasz Figa
Hi Sudeep, This looks good to me overall, but I have one more question inline. On Friday 16 of August 2013 18:39:50 Sudeep KarkadaNagesha wrote: > From: Sudeep KarkadaNagesha > > Currently different drivers requiring to access cpu device node are > parsing the device tree themselves. Since the

Re: [RFC/PATCH 24/32] usb: gadget: s3c-hsotg: let udc-core manage gadget->dev

2013-01-24 Thread Tomasz Figa
s3c_hsotg_remove(struct > platform_device *pdev) } > > s3c_hsotg_phy_disable(hsotg); > - > clk_disable_unprepare(hsotg->clk); > > - device_unregister(&hsotg->gadget.dev); > return 0; > } Looks good. Reviewed-by: Tomasz Figa Best regards, Tomasz Figa ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [RFC/PATCH 01/32] usb: gadget: udc-core: allow udc class register gadget device

2013-01-24 Thread Tomasz Figa
t;, kobject_name(&parent->kobj)); > if (ret) > - goto err2; > + goto err3; Just a nitpick: If you are at changing labels of error path, wouldn't it be better to give them some meaningful names? Like err_del_unlock, err_put_udc, err_put_gadget, er

Re: [RFC/PATCH 32/32] usb: gadget: drop now unnecessary flag

2013-01-24 Thread Tomasz Figa
ct_uevent(&udc->dev.kobj, KOBJ_REMOVE); > device_unregister(&udc->dev); > > - if (gadget->register_my_device) > device_unregister(&gadget->dev); Correct me if I am wrong, but doesn't this patch leave us with incorrect indentation? Otherwise looks good. Best regards, Tomasz Figa ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev