Re: [PATCH v4 6/6] clk: Add floor and ceiling constraints to clock rates

2014-07-31 Thread Stephen Warren
On 07/31/2014 05:47 AM, Tomeu Vizoso wrote: On 07/22/2014 07:50 PM, Stephen Warren wrote: On 07/17/2014 08:13 AM, Tomeu Vizoso wrote: Adds a way for clock consumers to set maximum and minimum rates. This can be used for thermal drivers to set ceiling rates, or by misc. drivers to set floor

Re: [PATCH v4 6/6] clk: Add floor and ceiling constraints to clock rates

2014-07-22 Thread Stephen Warren
On 07/17/2014 08:13 AM, Tomeu Vizoso wrote: > Adds a way for clock consumers to set maximum and minimum rates. This can be > used for thermal drivers to set ceiling rates, or by misc. drivers to set > floor rates to assure a minimum performance level. > diff --git a/drivers/clk/clk.c b/drivers/clk

Re: [PATCH 23/38] mmc: sdhci: convert sdhci_set_uhs_signaling() into a library function

2014-06-19 Thread Stephen Warren
On 06/19/2014 06:28 AM, Russell King - ARM Linux wrote: > On Mon, Jun 16, 2014 at 02:17:30PM +0200, Ulf Hansson wrote: >> Anyway, we did get some folks to test the patches and was thus fairly >> confident that we could merge them. Chris asked me to try to collect >> them in a PR for him, so I did.

Re: [PATCH 00/38] MMC updates, plus CuBox-i WiFi support

2014-04-28 Thread Stephen Warren
and BT support for CuBox. > > The questions over how to handle these devices were never properly settled, > so I recommend against merging patch 34 onwards. As for the rest, I'm not > planning on any further work, so it may be a good idea for people to > consider testing them wi

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-24 Thread Stephen Warren
On 09/24/2013 04:30 AM, Hongbo Zhang wrote: > On 09/24/2013 01:04 AM, Stephen Warren wrote: >> On 09/18/2013 04:15 AM, hongbo.zh...@freescale.com wrote: >>> From: Hongbo Zhang >>> >>> Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this >>

Re: [PATCH v10 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-09-23 Thread Stephen Warren
On 09/18/2013 04:15 AM, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds > the device tree nodes for them. > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > b/Documentation/devicetree/b

Re: [PATCH v12] ASoC: fsl: Add S/PDIF machine driver

2013-08-29 Thread Stephen Warren
On 08/27/2013 10:04 PM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. Sorry for the slow response. For the record, the binding, Acked-by: Steph

Re: [alsa-devel] [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-23 Thread Stephen Warren
On 08/23/2013 01:13 PM, Mark Brown wrote: > On Fri, Aug 23, 2013 at 01:08:28PM -0600, Stephen Warren wrote: >> On 08/23/2013 02:04 AM, Nicolin Chen wrote: >>> This patch implements a device-tree-only machine driver for >>> Freescale i.MX series Soc. It works

Re: [PATCH v11] ASoC: fsl: Add S/PDIF machine driver

2013-08-23 Thread Stephen Warren
On 08/23/2013 02:04 AM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. The binding looks reasonable to me now. Thanks. > diff --git a/sound/soc/fsl/imx-spdif.c

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-22 Thread Stephen Warren
On 08/22/2013 05:40 AM, Nicolin Chen wrote: > Hi Stephen, > > On Wed, Aug 21, 2013 at 12:30:59PM -0600, Stephen Warren wrote: >> I still don't think those two properties are correct. >> >> Exactly what node will those phandles point at? >> >> Ther

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-21 Thread Stephen Warren
On 08/21/2013 04:57 PM, Scott Wood wrote: > On Wed, 2013-08-21 at 16:40 -0600, Stephen Warren wrote: >> On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: >>> +- ranges: describes the mapping between the address space of >>> the >>> +

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-21 Thread Stephen Warren
On 08/21/2013 05:00 PM, Scott Wood wrote: > On Wed, 2013-08-21 at 16:40 -0600, Stephen Warren wrote: >> On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: >>> +- reg : >>> +- interrupts: >> >> s/interrupts/

Re: [PATCH v7 1/3] DMA: Freescale: revise device tree binding document

2013-08-21 Thread Stephen Warren
On 08/21/2013 04:45 PM, Scott Wood wrote: > On Wed, 2013-08-21 at 16:33 -0600, Stephen Warren wrote: >> On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: >>> From: Hongbo Zhang >>> >>> This patch updates the discription of each type of DMA co

Re: [PATCH v7 1/3] DMA: Freescale: revise device tree binding document

2013-08-21 Thread Stephen Warren
On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: > From: Hongbo Zhang > > This patch updates the discription of each type of DMA controller and its > channels, it is preparation for adding another new DMA controller binding, it > also fixes some defects of indent for text alignment at th

Re: [PATCH v7 2/3] DMA: Freescale: Add new 8-channel DMA engine device tree nodes

2013-08-21 Thread Stephen Warren
On 07/29/2013 04:49 AM, hongbo.zh...@freescale.com wrote: > Freescale QorIQ T4 and B4 introduce new 8-channel DMA engines, this patch adds > the device tree nodes for them. > diff --git a/Documentation/devicetree/bindings/powerpc/fsl/dma.txt > b/Documentation/devicetree/bindings/powerpc/fsl/dma.t

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-21 Thread Stephen Warren
On 08/21/2013 12:54 PM, Tomasz Figa wrote: > On Wednesday 21 of August 2013 12:30:59 Stephen Warren wrote: >> On 08/20/2013 09:13 PM, Nicolin Chen wrote: >>> This patch implements a device-tree-only machine driver for Freescale >>> i.MX series Soc. It works with spdif

Re: [PATCH v10 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-21 Thread Stephen Warren
On 08/20/2013 09:13 PM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt > b/Documenta

Re: [PATCH v10 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-21 Thread Stephen Warren
On 08/20/2013 09:13 PM, Nicolin Chen wrote: > This patch implements a device-tree-only CPU DAI driver for Freescale > S/PDIF controller that supports stereo playback and record feature. The DT bindings part of this patch, Acked-by: Stephen

Re: [alsa-devel] [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-21 Thread Stephen Warren
On 08/20/2013 08:18 PM, Nicolin Chen wrote: > On Tue, Aug 20, 2013 at 11:28:10PM +0100, Mark Brown wrote: >> On Tue, Aug 20, 2013 at 01:53:49PM -0600, Stephen Warren wrote: >>> On 08/20/2013 01:07 PM, Mark Brown wrote: >> >>>> The point is that it mi

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Stephen Warren
On 08/20/2013 01:07 PM, Mark Brown wrote: > On Tue, Aug 20, 2013 at 09:48:46AM -0600, Stephen Warren wrote: >> On 08/19/2013 06:18 PM, Mark Brown wrote: > >>> S/PDIF is also sometimes used as an interconnect between >>> devices - some CODECs have S/PDIF I/O (more no

Re: [alsa-devel] [PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Stephen Warren
On 08/20/2013 10:54 AM, Nicole Otsuka wrote: > Hi Stephen, > > I have a whole changelist in the cover letter (PATCH 0/2). Please take a > look at it. > > And about the codec dummy things.. I do that only because the codec > driver's doc say so. The DT binding document is not meant to be influenc

Re: [PATCH v7 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-20 Thread Stephen Warren
On 08/19/2013 11:19 PM, Shawn Guo wrote: > On Mon, Aug 19, 2013 at 10:54:33AM +0100, Mark Rutland wrote: >>> I guess it's better to drop the 'imx6q-spdif' here? >> >> That depends: >> >> * If the two IP blocks are identical, only the "imx35-spdif" name is >> necessary, and we can forget about "fs

Re: [PATCH v9 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Stephen Warren
On 08/19/2013 10:32 PM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. > > Signed-off-by: Nicolin Chen > --- > .../devicetree/bindings/sound/imx-audio-spdif.t

Re: [PATCH v9 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-20 Thread Stephen Warren
On 08/19/2013 10:32 PM, Nicolin Chen wrote: > This patch implements a device-tree-only CPU DAI driver for Freescale > S/PDIF controller that supports stereo playback and record feature. > > Signed-off-by: Nicolin Chen > --- > .../devicetree/bindings/sound/fsl,spdif.txt| 54 + What chan

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-20 Thread Stephen Warren
On 08/19/2013 06:18 PM, Mark Brown wrote: > On Mon, Aug 19, 2013 at 03:39:26PM -0600, Stephen Warren wrote: >> On 08/19/2013 06:08 AM, Nicolin Chen wrote: >>> This patch implements a device-tree-only machine driver for >>> Freescale i.MX series Soc. It works

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-20 Thread Stephen Warren
On 08/19/2013 08:28 PM, Nicolin Chen wrote: > On Mon, Aug 19, 2013 at 03:35:58PM -0600, Stephen Warren wrote: >>> + "core" The core clock of spdif controller >>> + "rxtx<0-7>" Clock source list for tx and rx clock. >>> +

Re: [PATCH] i2c: move of helpers into the core

2013-08-19 Thread Stephen Warren
On 08/19/2013 05:04 PM, Rafael J. Wysocki wrote: > On Monday, August 19, 2013 03:19:18 PM Wolfram Sang wrote: >> I2C of helpers used to live in of_i2c.c but experience (from SPI) shows >> that it is much cleaner to have this in the core. This also removes a >> circular dependency between the helper

Re: [PATCH v8 2/2] ASoC: fsl: Add S/PDIF machine driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 06:08 AM, Nicolin Chen wrote: > This patch implements a device-tree-only machine driver for Freescale > i.MX series Soc. It works with spdif_transmitter/spdif_receiver and > fsl_spdif.c drivers. > diff --git a/Documentation/devicetree/bindings/sound/imx-audio-spdif.txt > b/Documenta

Re: [PATCH v8 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-19 Thread Stephen Warren
On 08/19/2013 06:08 AM, Nicolin Chen wrote: > This patch implements a device-tree-only CPU DAI driver for Freescale > S/PDIF controller that supports stereo playback and record feature. > diff --git a/Documentation/devicetree/bindings/sound/fsl,spdif.txt > b/Documentation/devicetree/bindings/soun

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-16 Thread Stephen Warren
On 08/15/2013 03:24 AM, Shawn Guo wrote: > On Thu, Aug 15, 2013 at 10:18:23AM +0800, Nicolin Chen wrote: >> Hi Stephen, >> >> On Wed, Aug 14, 2013 at 09:47:19AM -0600, Stephen Warren wrote: >>> If the clock source name list is different, then it needs a different >

Re: [alsa-devel] [PATCH v4 1/2] ASoC: fsl: Add S/PDIF CPU DAI driver

2013-08-14 Thread Stephen Warren
On 08/14/2013 02:14 AM, Shawn Guo wrote: > On Wed, Aug 14, 2013 at 02:34:45PM +0800, Nicolin Chen wrote: >> On Wed, Aug 14, 2013 at 02:39:33PM +0800, Shawn Guo wrote: >>> We only need to maintain those versions that require different >>> programming model in the list. For example, if S/PDIF on Vyb

[PATCH REPOST] dtc: ensure #line directives don't consume data from the next line

2013-06-12 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line

Re: [PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-05 Thread Stephen Warren
On 06/03/2013 09:36 AM, Stephen Warren wrote: > From: Stephen Warren > > Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} > could match line-break characters. If the #line directive did not contain > the optional flags field at the end, this could cause any

[PATCH] dtc: ensure #line directives don't consume data from the next line

2013-06-03 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line

[PATCH V2] dtc: ensure #line directives don't consume data from the next line

2013-05-31 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line

Re: [PATCH] dtc: Ensure #line directives don't consume data from the next line

2013-05-31 Thread Stephen Warren
On 05/31/2013 11:38 AM, Andreas Schwab wrote: > Stephen Warren writes: > >> Fix this by replacing {WS} with [ \t] so that it can't match line-breaks. > > I think the other uses of {WS} shouldn't span lines either. That is true, but only the optional occurrence /sh

[PATCH] dtc: Ensure #line directives don't consume data from the next line

2013-05-31 Thread Stephen Warren
From: Stephen Warren Previously, the #line parsing regex ended with ({WS}+[0-9]+)?. The {WS} could match line-break characters. If the #line directive did not contain the optional flags field at the end, this could cause any integer data on the next line to be consumed as part of the #line

Re: DTB build failure due to preproccessing

2013-05-31 Thread Stephen Warren
On 05/31/2013 04:29 AM, Ian Campbell wrote: > This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is > actually a more general issue: > > $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb > CC scripts/mod/devicetable-offsets.s >

Re: DTB build failure due to preproccessing

2013-05-31 Thread Stephen Warren
On 05/31/2013 05:48 AM, Grant Likely wrote: > On Fri, 31 May 2013 11:29:30 +0100, Ian Campbell > wrote: >> This affects arch/powerpc/boot/dts/virtex440-ml510.dts but I think it is >> actually a more general issue: >> >> $ make ARCH=powerpc CROSS_COMPILE=powerpc-linux- virtex440-ml510.dtb

Re: [PATCH 1/2] cpufreq: Notify all policy->cpus in cpufreq_notify_transition()

2013-03-25 Thread Stephen Warren
other fixup for tegra: This series including this patch (although I had a devil of a time applying this fixup since all the TABs got converted to spaces when it was pasted into email) Acked-by: Stephen Warren Tested-by: Stephen Warren ___ Linuxp

Re: [PATCH] of: Fix export of of_find_matching_node_and_match()

2012-12-19 Thread Stephen Warren
e. However, the change neglected to change the EXPORT_SYMBOL() > reference causing build errors for modules. > > This patch fixes the EXPORT_SYMBOL() statement. Discovered on a PowerPC > Efika build with the mpc52xx_uart driver being built as a module. Oops. The patch is obviously correc

Re: [PATCH V7 1/7] kbuild: centralize .dts->.dtb rule

2012-11-28 Thread Stephen Warren
On 11/27/2012 04:29 PM, Stephen Warren wrote: > All architectures that use cmd_dtc do so in almost the same way. Create > a central build rule to avoid duplication. The one difference is that > most current uses of dtc build $(obj)/%.dtb from $(src)/dts/%.dts rather > than building the

Re: [alsa-devel] [PATCH 4/5] arch/powerpc/boot/dts pcm030 add mpc5200-soc-audio node

2012-09-11 Thread Stephen Warren
On 09/11/2012 08:14 PM, Eric Millbrandt wrote: > Describe the audio codec on the pcm030 baseboard. > +++ b/arch/powerpc/boot/dts/pcm030.dts > + sound { > + compatible = "fsl,mpc5200b-soc-audio","fsl,mpc5200-soc-audio"; > + card-name = "pcm030"; > + audio-pl

Re: [alsa-devel] [PATCH 3/5] ASoC: fsl: mpc5200-soc-audio driver

2012-09-11 Thread Stephen Warren
On 09/11/2012 08:14 PM, Eric Millbrandt wrote: > Add a generic mpc5200 driver that allows asoc cards to be defined in the > device tree. > +++ b/Documentation/devicetree/bindings/powerpc/fsl/mpc5200.txt > +A sound node is defined for each asoc platform. A sound node must > +have at least one chi

Re: [PATCH] clk: Make the generic clock API available by default

2012-08-30 Thread Stephen Warren
On 08/30/12 10:19, Mark Brown wrote: On Wed, Aug 29, 2012 at 02:49:34PM -0700, Stephen Warren wrote: On 08/28/12 13:35, Mark Brown wrote: @@ -674,6 +676,7 @@ config ARCH_TEGRA select GENERIC_CLOCKEVENTS select GENERIC_GPIO select HAVE_CLK + select

Re: [PATCH] clk: Make the generic clock API available by default

2012-08-29 Thread Stephen Warren
On 08/28/12 13:35, Mark Brown wrote: Rather than requiring platforms to select the generic clock API to make it available make the API available as a user selectable option unless the user either selects HAVE_CUSTOM_CLK (if they have their own implementation) or selects COMMON_CLK (if they depend

Re: [PATCH] i2c: let the core register devices from devicetree

2012-06-13 Thread Stephen Warren
On 06/13/2012 03:12 PM, Wolfram Sang wrote: > Currently, every driver has to do it on its own, but it should be done > in the core, like we already do with board_info structs. At least on Tegra this works fine, Tested-by: Stephen Warren ___ Li

RE: [PATCH 2/2] Kbuild: Use dtc's -d (dependency) option

2012-01-17 Thread Stephen Warren
Michal Marek wrote at Saturday, January 14, 2012 3:51 PM: > On 11.1.2012 20:36, Mark Salter wrote: > > On Mon, 2012-01-09 at 11:38 -0700, Stephen Warren wrote: > >> This hooks dtc into Kbuild's dependency system. > >> > >> Thus, for example, "mak

[PATCH 2/2] Kbuild: Use dtc's -d (dependency) option

2012-01-09 Thread Stephen Warren
s. For ARM, it's obvious what to add to $(targets). I'm not familiar enough with other architectures to know what to add there. Powerpc appears to already add various .dtb files into $(targets), but the other archs may need something added to $(targets) to work. Signed-off-by: Stephen

[PATCH 1/2] dtc: Implement -d option to write out a dependency file

2012-01-09 Thread Stephen Warren
This will allow callers to rebuild .dtb files when any of the /include/d .dtsi files are modified, not just the top-level .dts file. Signed-off-by: Stephen Warren --- This patch is against the Linux kernel's copy of dtc, but it applies to upstream dtc with a couple of trivial conflicts.