Re: [PATCH 12/15] auxdisplay: ht16k33: Introduce backlight_get_brightness()

2023-03-19 Thread Stephen Kitt
Hi, On Mon, 09 Jan 2023 11:12:02 +0100, Robin van der Gracht wrote: > On 2023-01-08 10:29, Sam Ravnborg wrote: > > On Sat, Jan 07, 2023 at 10:02:38PM +0100, Miguel Ojeda wrote: > >> On Sat, Jan 7, 2023 at 7:26 PM Sam Ravnborg via B4 Submission Endpoint > >> wrote: > >> > > >> > Introduce bac

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
Hi Sam, On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote: > > Here are my pending patches from last June on lore: > > > > All patches are handled I think except this: > > * https://lore.kernel.org/lkml/20220608205623.2106113-1-st...@sk2.org/ > > Can I ask you to drop the assignment th

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
On Sun, 8 Jan 2023 18:26:12 +0100, Helge Deller wrote: > On 1/7/23 21:53, Sam Ravnborg wrote: > > Hi Stephen. > > > > On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: > >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-09 Thread Stephen Kitt
On Mon, 9 Jan 2023 20:53:44 +0100, Stephen Kitt wrote: > On Sun, 8 Jan 2023 21:24:20 +0100, Sam Ravnborg wrote: > > > Here are my pending patches from last June on lore: > > > > > > > All patches are handled I think except this: > > > * https://l

Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-08 Thread Stephen Kitt
Hi Sam, On Sun, 8 Jan 2023 21:29:43 +0100, Sam Ravnborg wrote: > On Sun, Jan 08, 2023 at 08:28:17PM +0100, Stephen Kitt wrote: > > On Sat, 07 Jan 2023 19:26:23 +0100, Sam Ravnborg via B4 Submission > > Endpoint wrote: > > > > > From: Sam Ravnborg > >

Re: [PATCH 15/15] backlight: backlight: Drop the deprecated fb_blank property

2023-01-08 Thread Stephen Kitt
props.state |= BL_CORE_FBBLANK; > > return backlight_update_status(bd); > @@ -403,7 +382,6 @@ static inline int backlight_disable(struct > backlight_device *bd) static inline bool backlight_is_blank(const struct > backlight_device *bd) { > return bd->props.power != FB_BLANK_UNBLANK || > -bd->props.fb_blank != FB_BLANK_UNBLANK || > bd->props.state & (BL_CORE_SUSPENDED | BL_CORE_FBBLANK); > } > > > -- > 2.34.1 Reviewed-by: Stephen Kitt pgpbyBq2TjOWa.pgp Description: OpenPGP digital signature

Re: [PATCH 09/15] staging: fbtft: fb_ssd1351.c: Introduce backlight_is_blank()

2023-01-08 Thread Stephen Kitt
- it was only used for debug. > > Signed-off-by: Sam Ravnborg > Cc: Stephen Kitt > Cc: Greg Kroah-Hartman > Cc: Daniel Thompson > Cc: Andy Shevchenko > Cc: linux-fb...@vger.kernel.org > --- > drivers/staging/fbtft/fb_ssd1351.c | 9 +++-- > 1 file changed, 3

Re: [PATCH 13/15] backlight: omap1: Use backlight helpers

2023-01-08 Thread Stephen Kitt
atic int omapbl_probe(struct platform_device *pdev) > if (IS_ERR(dev)) > return PTR_ERR(dev); > > - bl->powermode = FB_BLANK_POWERDOWN; > - bl->current_intensity = 0; > - > bl->pdata = pdata; > bl->dev = &pdev->dev; > > @@ -149,7 +101,6 @@ static int omapbl_probe(struct platform_device *pdev) > > omap_cfg_reg(PWL); /* Conflicts with UART3 */ > > - dev->props.fb_blank = FB_BLANK_UNBLANK; > dev->props.brightness = pdata->default_intensity; > omapbl_update_status(dev); > > > -- > 2.34.1 Wow that gets rid of a lot of unnecessary code! Reviewed-by: Stephen Kitt pgp3J4GC4VScW.pgp Description: OpenPGP digital signature

Re: [PATCH 11/15] powerpc: via-pmu-backlight: Introduce backlight_get_brightness()

2023-01-08 Thread Stephen Kitt
On Sat, 07 Jan 2023 19:26:25 +0100, Sam Ravnborg via B4 Submission Endpoint wrote: > From: Sam Ravnborg > > Introduce backlight_get_brightness() to simplify logic > and avoid direct access to backlight properties. > > Signed-off-by: Sam Ravnborg > Cc: Benjamin Herrenschmidt > Cc: Sam Ravnbor

Re: [PATCH 10/15] staging: fbtft: core: Introduce backlight_is_blank()

2023-01-08 Thread Stephen Kitt
- it was only used for debug. > > Signed-off-by: Sam Ravnborg > Cc: Thomas Zimmermann > Cc: Andy Shevchenko > Cc: Javier Martinez Canillas > Cc: Greg Kroah-Hartman > Cc: Sam Ravnborg > Cc: Stephen Kitt > Cc: Peter Suti > Cc: linux-fb...@vger.kernel.org

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-08 Thread Stephen Kitt
On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >Hi Stephen. > >On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint >> wrote: >> >From: Sam Ravnborg >> > >> &g

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 8 January 2023 08:45:46 CET, Stephen Kitt wrote: >On 7 January 2023 21:53:46 CET, Sam Ravnborg wrote: >>Hi Stephen. >> >>On Sat, Jan 07, 2023 at 09:36:47PM +0100, Stephen Kitt wrote: >>> On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoi

Re: [PATCH 01/15] video: fbdev: atmel_lcdfb: Rework backlight handling

2023-01-07 Thread Stephen Kitt
On 7 January 2023 19:26:15 CET, Sam Ravnborg via B4 Submission Endpoint wrote: >From: Sam Ravnborg > >The atmel_lcdfb had code to save/restore power state. >This is not needed so drop it. > >Introduce backlight_is_brightness() to make logic simpler. > >Signed-off-by: Sam Ravnborg >Cc: Nicolas F

[PATCH v2] macintosh: via-pmu-backlight: Use backlight helper

2022-06-16 Thread Stephen Kitt
, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org

[PATCH] backlight: Use backlight helper

2022-06-07 Thread Stephen Kitt
, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt Cc: Benjamin Herrenschmidt Cc: Michael Ellerman Cc: Christophe Leroy Cc: linuxppc-dev@lists.ozlabs.org

[PATCH] mm: Remove HARDENED_USERCOPY_FALLBACK

2021-09-21 Thread Stephen Kitt
s"); since usercopy_fallback is effectively 0, the fallback handling is removed too. This also removes the usercopy_fallback module parameter on slab_common. Link: https://github.com/KSPP/linux/issues/153 Signed-off-by: Stephen Kitt Suggested-by: Kees Cook --- arch/powerpc/configs/skiroot

[PATCH] arch/powerpc: use simple i2c probe function

2020-08-07 Thread Stephen Kitt
The i2c probe functions here don't use the id information provided in their second argument, so the single-parameter i2c probe function ("probe_new") can be used instead. This avoids scanning the identifier tables during probes. Signed-off-by: Stephen Kitt --- arch/powerpc/platf