Re: [PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

2022-06-18 Thread Souptick Joarder
On Sun, Jun 19, 2022 at 11:13 AM Randy Dunlap wrote: > > > > On 6/18/22 20:11, Souptick Joarder wrote: > > From: "Souptick Joarder (HPE)" > > > > Kernel test robot throws warning -> > > > > arch/powerpc/kernel/interrupt.c: > > In fun

[PATCH] powerpc/interrupt: Put braces around empty body in an 'if' statement

2022-06-18 Thread Souptick Joarder
From: "Souptick Joarder (HPE)" Kernel test robot throws warning -> arch/powerpc/kernel/interrupt.c: In function 'interrupt_exit_kernel_prepare': >> arch/powerpc/kernel/interrupt.c:542:55: warning: suggest braces around empty body in an 'if&

Re: [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper

2021-06-08 Thread Souptick Joarder
On Tue, Jun 8, 2021 at 8:27 PM Christophe Leroy wrote: > > > > Le 08/06/2021 à 16:53, Souptick Joarder a écrit : > > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang > > wrote: > >> > >> Add setup_initial_init_mm() helper to setup kernel text, &

Re: [PATCH v3 resend 11/15] powerpc: convert to setup_initial_init_mm()

2021-06-08 Thread Souptick Joarder
On Tue, Jun 8, 2021 at 8:24 PM Christophe Leroy wrote: > > > > Le 08/06/2021 à 16:36, Souptick Joarder a écrit : > > On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang > > wrote: > >> > >> Use setup_initial_init_mm() helper to simplify code. > >>

Re: [PATCH v3 resend 01/15] mm: add setup_initial_init_mm() helper

2021-06-08 Thread Souptick Joarder
On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang wrote: > > Add setup_initial_init_mm() helper to setup kernel text, > data and brk. > > Cc: linux-snps-...@lists.infradead.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-c...@vger.kernel.org > Cc: uclinux-h8-de...@lists.sourceforge.jp > Cc: li

Re: [PATCH v3 resend 11/15] powerpc: convert to setup_initial_init_mm()

2021-06-08 Thread Souptick Joarder
On Tue, Jun 8, 2021 at 1:56 PM Kefeng Wang wrote: > > Use setup_initial_init_mm() helper to simplify code. > > Note klimit is (unsigned long) _end, with new helper, > will use _end directly. With this change klimit left with no user in this file and can be moved to some appropriate header. But in

Re: [linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()

2020-05-26 Thread Souptick Joarder
On Tue, May 26, 2020 at 1:29 PM Paul Mackerras wrote: > > On Mon, May 25, 2020 at 02:23:32PM +0530, Souptick Joarder wrote: > > API __get_user_pages_fast() renamed to get_user_pages_fast_only() > > to align with pin_user_pages_fast_only(). > > > > As part of

[linux-next PATCH] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()

2020-05-25 Thread Souptick Joarder
callers are changed to pass FOLL_WRITE. Also introduce get_user_page_fast_only(), and use it in a few places that hard-code nr_pages to 1. Updated the documentation of the API. Signed-off-by: Souptick Joarder Reviewed-by: John Hubbard Cc: Matthew Wilcox Cc: John Hubbard --- arch/powerpc/kvm

Re: [linux-next RFC v2] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()

2020-05-24 Thread Souptick Joarder
On Mon, May 25, 2020 at 6:36 AM John Hubbard wrote: > > On 2020-05-23 21:27, Souptick Joarder wrote: > > API __get_user_pages_fast() renamed to get_user_pages_fast_only() > > to align with pin_user_pages_fast_only(). > > > > As part of this we will get rid of w

[linux-next RFC v2] mm/gup.c: Convert to use get_user_{page|pages}_fast_only()

2020-05-23 Thread Souptick Joarder
the documentation of the API. Signed-off-by: Souptick Joarder Cc: John Hubbard Cc: Matthew Wilcox --- v2: Updated the subject line and change log. Address Matthew's comment to fix a bug and added new inline get_user_page_fast_only(). arch/powerpc/kvm/book3s_64_mmu_hv.

Re: [linux-next RFC] mm/gup.c: Convert to use get_user_pages_fast_only()

2020-05-23 Thread Souptick Joarder
On Sat, May 23, 2020 at 10:55 PM Matthew Wilcox wrote: > > On Sat, May 23, 2020 at 10:11:12PM +0530, Souptick Joarder wrote: > > Renaming the API __get_user_pages_fast() to get_user_pages_ > > fast_only() to align with pin_user_pages_fast_only(). > > Please don't

[linux-next RFC] mm/gup.c: Convert to use get_user_pages_fast_only()

2020-05-23 Thread Souptick Joarder
the callers are changed to pass FOLL_WRITE. Updated the documentation of the API. Signed-off-by: Souptick Joarder Cc: John Hubbard Cc: Matthew Wilcox --- arch/powerpc/kvm/book3s_64_mmu_hv.c| 2 +- arch/powerpc/kvm/book3s_64_mmu_radix.c | 2 +- arch/powerpc/perf/callchain_64.c | 2

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-03-06 Thread Souptick Joarder
On Mon, Mar 4, 2019 at 4:19 PM Souptick Joarder wrote: > > On Tue, Feb 26, 2019 at 10:59 AM Souptick Joarder > wrote: > > > > On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman > > wrote: > > > > > > Souptick Joarder writes: > > &g

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-03-04 Thread Souptick Joarder
On Tue, Feb 26, 2019 at 10:59 AM Souptick Joarder wrote: > > On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman wrote: > > > > Souptick Joarder writes: > > > Remove duplicate headers which are included twice. > > > > > > Signed-off-by: Sabyasachi

Re: [PATCH] tools: testing: selftests: Remove duplicate headers

2019-02-25 Thread Souptick Joarder
On Tue, Feb 26, 2019 at 7:18 AM Michael Ellerman wrote: > > Souptick Joarder writes: > > Remove duplicate headers which are included twice. > > > > Signed-off-by: Sabyasachi Gupta > > Signed-off-by: Souptick Joarder > > --- > ... > > tools/testing/

[PATCH] tools: testing: selftests: Remove duplicate headers

2019-02-22 Thread Souptick Joarder
Remove duplicate headers which are included twice. Signed-off-by: Sabyasachi Gupta Signed-off-by: Souptick Joarder --- tools/testing/selftests/gpio/gpio-mockup-chardev.c | 1 - tools/testing/selftests/net/udpgso.c| 1 - tools/testing/selftests/powerpc/pmu/ebb

Re: [RESEND PATCH 3/7] mm/gup: Change GUP fast to use flags rather than a write 'bool'

2019-02-20 Thread Souptick Joarder
Hi Ira, On Wed, Feb 20, 2019 at 11:01 AM wrote: > > From: Ira Weiny > > To facilitate additional options to get_user_pages_fast() change the > singular write parameter to be gup_flags. > > This patch does not change any functionality. New functionality will > follow in subsequent patches. > > S

Re: [PATCH] powerpc/kernel/time: Remove duplicate header

2019-01-28 Thread Souptick Joarder
On Mon, Jan 28, 2019 at 9:41 PM Brajeswar Ghosh wrote: > > Remove linux/rtc.h which is included more than once > > Signed-off-by: Brajeswar Ghosh Acked-by: Souptick Joarder > --- > arch/powerpc/kernel/time.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/a

Re: [PATCH] powerpc/powernv: Remove duplicate header

2019-01-18 Thread Souptick Joarder
On Thu, Jan 17, 2019 at 9:40 PM Sabyasachi Gupta wrote: > > Remove linux/printk.h which is included more than once. > > Signed-off-by: Sabyasachi Gupta Acked-by: Souptick Joarder > --- > arch/powerpc/platforms/powernv/opal.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH] powerpc/cell: Remove duplicate header

2019-01-17 Thread Souptick Joarder
On Thu, Jan 17, 2019 at 9:49 PM Sabyasachi Gupta wrote: > > Remove linux/syscalls.h which is included more than once > > Signed-off-by: Sabyasachi Gupta Acked-by: Souptick Joarder > --- > arch/powerpc/platforms/cell/spu_syscalls.c | 1 - > 1 file changed, 1 deletion(-)

Re: [PATCH] arch/powerpc: Use dma_zalloc_coherent

2018-11-16 Thread Souptick Joarder
Hi Joe, On Fri, Nov 16, 2018 at 12:55 AM Joe Perches wrote: > > On Thu, 2018-11-15 at 23:29 +0530, Sabyasachi Gupta wrote: > > On Mon, Nov 5, 2018 at 8:58 AM Sabyasachi Gupta > > wrote: > > > Replaced dma_alloc_coherent + memset with dma_zalloc_coherent > > > > > > Signed-off-by: Sabyasachi Gupt

Re: misc: ocxl: Change return type for fault handler

2018-07-13 Thread Souptick Joarder
On Wed, Jul 11, 2018 at 6:54 PM, Michael Ellerman wrote: > On Mon, 2018-06-11 at 20:29:04 UTC, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than an errn

Re: [PATCH] misc: ocxl: Change return type for fault handler

2018-06-18 Thread Souptick Joarder
On Thu, Jun 14, 2018 at 9:36 PM, Frederic Barrat wrote: > > > Le 11/06/2018 à 22:29, Souptick Joarder a écrit : >> >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather

[PATCH v2] mm: convert return type of handle_mm_fault() caller to vm_fault_t

2018-06-17 Thread Souptick Joarder
_t") In this patch all the caller of handle_mm_fault() are changed to return vm_fault_t type. Signed-off-by: Souptick Joarder --- v2: Fixed kbuild error arch/alpha/mm/fault.c | 3 ++- arch/arc/mm/fault.c | 4 +++- arch/arm/mm/fault.c

[PATCH] mm: convert return type of handle_mm_fault() caller to vm_fault_t

2018-06-14 Thread Souptick Joarder
_t") In this patch all the caller of handle_mm_fault() are changed to return vm_fault_t type. Signed-off-by: Souptick Joarder --- arch/alpha/mm/fault.c | 3 ++- arch/arc/mm/fault.c | 4 +++- arch/arm/mm/fault.c | 7 --- arch/arm64/mm/fault.c | 6

[PATCH] misc: ocxl: Change return type for fault handler

2018-06-11 Thread Souptick Joarder
quot;) There is an existing bug when vm_insert_pfn() can return ENOMEM which was ignored and VM_FAULT_NOPAGE returned as default. The new inline vmf_insert_pfn() has removed this inefficiency by returning correct vm_fault_ type. Signed-off-by: Souptick Joarder --- drivers/misc/ocxl/c

Re: [PATCH v2] powerpc: kvm: Change return type to vm_fault_t

2018-05-16 Thread Souptick Joarder
On Wed, May 16, 2018 at 12:38 PM, Paul Mackerras wrote: > On Wed, May 16, 2018 at 10:11:11AM +0530, Souptick Joarder wrote: >> On Thu, May 10, 2018 at 11:57 PM, Souptick Joarder >> wrote: >> > Use new return type vm_fault_t for fault handler >> > in struct vm_op

Re: [PATCH v2] powerpc: kvm: Change return type to vm_fault_t

2018-05-15 Thread Souptick Joarder
On Thu, May 10, 2018 at 11:57 PM, Souptick Joarder wrote: > Use new return type vm_fault_t for fault handler > in struct vm_operations_struct. For now, this is > just documenting that the function returns a > VM_FAULT value rather than an errno. Once all > instances are conver

Re: [PATCH v2] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-05-15 Thread Souptick Joarder
On Thu, May 10, 2018 at 8:35 PM, Souptick Joarder wrote: > On Sat, Apr 21, 2018 at 3:04 AM, Matthew Wilcox wrote: >> On Fri, Apr 20, 2018 at 11:02:39PM +0530, Souptick Joarder wrote: >>> Use new return type vm_fault_t for fault handler. For >>> now, this is just do

[PATCH v2] powerpc: kvm: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
eturn type to vm_fault_t") Signed-off-by: Souptick Joarder --- v2: Updated the change log arch/powerpc/kvm/book3s_64_vio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/kvm/book3s_64_vio.c b/arch/powerpc/kvm/book3s_64_vio.c index 4dffa61..346ac0d 100644

Re: [PATCH] kvm: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
On Thu, Apr 19, 2018 at 7:26 PM, Cornelia Huck wrote: > On Thu, 19 Apr 2018 00:49:58 +0530 > Souptick Joarder wrote: > >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather than a

Re: [PATCH v2] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-05-10 Thread Souptick Joarder
On Sat, Apr 21, 2018 at 3:04 AM, Matthew Wilcox wrote: > On Fri, Apr 20, 2018 at 11:02:39PM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather th

[PATCH v2] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-04-20 Thread Souptick Joarder
_t") We are fixing a minor bug, that the error from vm_insert_ pfn() was being ignored and the effect of this is likely to be only felt in OOM situations. Signed-off-by: Souptick Joarder --- arch/powerpc/platforms/cell/spufs/file.c | 33 +--- 1 file changed,

Re: [PATCH] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
On Thu, Apr 19, 2018 at 12:57 AM, Matthew Wilcox wrote: > On Thu, Apr 19, 2018 at 12:34:15AM +0530, Souptick Joarder wrote: >> > Re-reading spufs_ps_fault(), I wouldn't change anything inside it. Just >> > change its return type to vm_fault_t and call it done. >>

[PATCH] kvm: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- arch/mips/kvm/mips.c | 2 +- arch/powerpc/kvm/powerpc.c | 2 +- arch/s390/kvm/kvm-s390.c | 2 +- arch/x86/kvm/x86.c | 2 +- include/linux/kvm_host.h | 2 +- virt/kvm/arm/arm.c | 2 +- virt/kvm/kvm_main.c

Re: [PATCH] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-04-18 Thread Souptick Joarder
On Wed, Apr 18, 2018 at 2:17 AM, Matthew Wilcox wrote: > On Wed, Apr 18, 2018 at 12:50:38AM +0530, Souptick Joarder wrote: >> Use new return type vm_fault_t for fault handler. For >> now, this is just documenting that the function returns >> a VM_FAULT value rather th

[PATCH] powerpc: platform: cell: spufs: Change return type to vm_fault_t

2018-04-17 Thread Souptick Joarder
err. Signed-off-by: Souptick Joarder Reviewed-by: Matthew Wilcox --- arch/powerpc/platforms/cell/spufs/file.c | 37 1 file changed, 23 insertions(+), 14 deletions(-) diff --git a/arch/powerpc/platforms/cell/spufs/file.c b/arch/powerpc/platforms/cell/spufs/file.c

[PATCH] misc: cxl: Change return type to vm_fault_t

2018-04-17 Thread Souptick Joarder
_fault_t") previously cxl_mmap_fault returns VM_FAULT_NOPAGE as default value irrespective of vm_insert_pfn() return value. This bug is fixed with new vmf_insert_pfn() which will return VM_FAULT_ type based on err. Signed-off-by: Souptick Joarder --- drivers/misc/cxl/context.c | 7 --- 1 fi