Re: [PATCH net-next v3 3/3] net: ibmveth: added KUnit tests for some buffer pool functions

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:51PM -0500, Dave Marquardt wrote: > Added KUnit tests for ibmveth_remove_buffer_from_pool and > ibmveth_rxq_get_buffer under new IBMVETH_KUNIT_TEST config option. > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

Re: [PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:50PM -0500, Dave Marquardt wrote: > Reset the adapter through new function ibmveth_reset, called in > WARN_ON situations. Removed conflicting and unneeded forward > declaration. > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

Re: [PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

2025-04-22 Thread Simon Horman
On Wed, Apr 16, 2025 at 03:57:49PM -0500, Dave Marquardt wrote: > Made struct ibmveth_adapter follow indentation rules > > Signed-off-by: Dave Marquardt Reviewed-by: Simon Horman

Re: [PATCH net-next v2 1/2] net: ibmveth: make ibmveth use WARN_ON instead of BUG_ON

2025-04-16 Thread Simon Horman
On Mon, Apr 14, 2025 at 02:40:15PM -0500, Dave Marquardt wrote: > Replaced BUG_ON calls with WARN_ON calls with error handling, with > calls to a new ibmveth_reset routine, which resets the device. Removed > conflicting and unneeded forward declaration. To me the most important change here is addi

Re: [PATCH net] net: ibmveth: make veth_pool_store stop hanging

2025-04-01 Thread Simon Horman
ve Marquardt > Fixes: 860f242eb534 ("[PATCH] ibmveth change buffer pools dynamically") > Reviewed-by: Nick Child Reviewed-by: Simon Horman

Re: [PATCH] net: remove sb1000 cable modem driver

2025-03-17 Thread Simon Horman
been broken for 25 years, and > the driver has only ever seen mechanical updates. > > Link: > http://web.archive.org/web/2611165545/http://home.adelphia.net:80/~siglercm/sb1000.html > Signed-off-by: Arnd Bergmann Reviewed-by: Simon Horman

Re: [PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Simon Horman
On Fri, Jan 10, 2025 at 12:07:25PM +0100, Christophe Leroy wrote: > > > Le 10/01/2025 à 11:18, Simon Horman a écrit : > > Remove set but unused variables. These seem to provide no value. > > So in the spirit of less being more, remove them. > > Would be good to id

[PATCH net-next] freescale: ucc_geth: Remove set but unused variables

2025-01-10 Thread Simon Horman
ariable] 3046 | struct ucc_geth_info *ug_info; | ^~~ Compile tested only. No runtime effect intended. Signed-off-by: Simon Horman --- drivers/net/ethernet/freescale/ucc_geth.c | 39 +++ 1 file changed, 8 insertions(+),

Re: [PATCH net-next v2 01/10] net: freescale: ucc_geth: Drop support for the "interface" DT property

2024-11-15 Thread Simon Horman
On Thu, Nov 14, 2024 at 04:35:52PM +0100, Maxime Chevallier wrote: > In april 2007, ucc_geth was converted to phylib with : > > commit 728de4c927a3 ("ucc_geth: migrate ucc_geth to phylib"). > > In that commit, the device-tree property "interface", that could be used to > retrieve the PHY interfac

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-26 Thread Simon Horman
On Fri, Oct 25, 2024 at 12:32:27PM -0700, Rosen Penev wrote: > On Fri, Oct 25, 2024 at 5:57 AM Simon Horman wrote: > > > > On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > > > The latter is the preferred way to copy ethtool strings. > > > >

Re: [PATCH net-next] net: freescale: use ethtool string helpers

2024-10-25 Thread Simon Horman
On Thu, Oct 24, 2024 at 01:52:57PM -0700, Rosen Penev wrote: > The latter is the preferred way to copy ethtool strings. > > Avoids manually incrementing the pointer. Cleans up the code quite well. > > Signed-off-by: Rosen Penev ... > diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_ethtoo

Re: [PATCH net-next] ibmvnic: use ethtool string helpers

2024-10-24 Thread Simon Horman
On Tue, Oct 22, 2024 at 01:32:40PM -0700, Rosen Penev wrote: > They are the prefered way to copy ethtool strings. > > Avoids manually incrementing the data pointer. > > Signed-off-by: Rosen Penev Reviewed-by: Simon Horman

Re: [PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size_t

2024-10-15 Thread Simon Horman
mii_bus id field to a string") > > > > Reported-by: Geert Uytterhoeven > > Closes: > > https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cc...@linux-m68k.org/ > > > > --- > > Simon Horman (2): > > net: fec_mpc52xx_phy: Use %p

[PATCH] powerpc/ep8248e: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
nel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cc...@linux-m68k.org/ Signed-off-by: Simon Horman --- arch/powerpc/platforms/82xx/ep8248e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/82xx/ep8248e.c b/arch/powerpc/platforms/82xx/ep8248e.c index 3dc6

[PATCH 1/2] net: fec_mpc52xx_phy: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
erhoeven Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cc...@linux-m68k.org/ Signed-off-by: Simon Horman --- drivers/net/ethernet/freescale/fec_mpc52xx_phy.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fec_mpc52xx_phy

[PATCH 2/2] net: ethernet: fs_enet: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
erhoeven Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cc...@linux-m68k.org/ Signed-off-by: Simon Horman --- drivers/net/ethernet/freescale/fs_enet/mii-bitbang.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/freescale/fs_enet/mi

[PATCH 0/2] net: ethernet: freescale: Use %pa to format resource_size_t

2024-10-14 Thread Simon Horman
-api/printk-formats.rst#L229 These problems were introduced by commit 9d9326d3bc0e ("phy: Change mii_bus id field to a string") Reported-by: Geert Uytterhoeven Closes: https://lore.kernel.org/netdev/711d7f6d-b785-7560-f4dc-c6aad2cc...@linux-m68k.org/ --- Simon Horman (2):

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Simon Horman
On Mon, Oct 14, 2024 at 11:18:14AM +0200, Geert Uytterhoeven wrote: > Hi Simon, > > On Mon, Oct 14, 2024 at 10:58 AM Simon Horman wrote: > > On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote: > > > + /kisskb/src/drivers/net/ethernet/freesca

Re: Build regressions/improvements in v6.12-rc3

2024-10-14 Thread Simon Horman
On Mon, Oct 14, 2024 at 10:38:20AM +0200, Geert Uytterhoeven wrote: > On Mon, 14 Oct 2024, Geert Uytterhoeven wrote: > > JFYI, when comparing v6.12-rc3[1] to v6.12-rc2[3], the summaries are: > > - build errors: +3/-1 > > + /kisskb/src/crypto/async_tx/async_tx.c: error: no previous prototype for

Re: [PATCH net-next] eth: remove the DLink/Sundance (ST201) driver

2024-10-09 Thread Simon Horman
tely, we can revert it back in > if someone complains. > > Link: https://lore.kernel.org/20240925-bizarre-earwig-from-pluto-1484aa@lemu/ > Signed-off-by: Jakub Kicinski Reviewed-by: Simon Horman

Re: [PATCH net-next 6/6] net: ethernet: fs_enet: phylink conversion

2024-08-28 Thread Simon Horman
On Wed, Aug 28, 2024 at 11:51:02AM +0200, Maxime Chevallier wrote: > fs_enet is a quite old but still used Ethernet driver found on some NXP > devices. It has support for 10/100 Mbps ethernet, with half and full > duplex. Some variants of it can use RMII, while other integrations are > MII-only. >

Re: [PATCH net v1] net: wan: fsl_qmc_hdlc: Convert carrier_lock spinlock to a mutex

2024-07-31 Thread Simon Horman
amer support") > Cc: sta...@vger.kernel.org > Signed-off-by: Herve Codina Reviewed-by: Simon Horman

Re: [PATCH net v1] net: wan: fsl_qmc_hdlc: Discard received CRC

2024-07-31 Thread Simon Horman
+++-- > 1 file changed, 18 insertions(+), 6 deletions(-) The above notwithstanding, this looks good to me. Reviewed-by: Simon Horman

Re: [PATCH 3/4] crypto: caam: Unembed net_dev structure from qi

2024-06-28 Thread Simon Horman
On Mon, Jun 24, 2024 at 09:21:21AM -0700, Breno Leitao wrote: > Embedding net_device into structures prohibits the usage of flexible > arrays in the net_device structure. For more details, see the discussion > at [1]. > > Un-embed the net_devices from struct caam_qi_pcpu_priv by converting them >

Re: [PATCH 1/1] [RFC] ethernet: Convert from tasklet to BH workqueue

2024-05-08 Thread Simon Horman
On Tue, May 07, 2024 at 12:27:10PM -0700, Allen wrote: > On Tue, May 7, 2024 at 12:23 PM Russell King (Oracle) > wrote: > > > > On Tue, May 07, 2024 at 07:01:11PM +, Allen Pais wrote: > > > The only generic interface to execute asynchronously in the BH context is > > > tasklet; however, it's m

Re: [PATCH v3 13/15] sh: Move defines needed for suppressing warning backtraces

2024-04-05 Thread Simon Horman
; Prototype was for HAVE_BUG_FUNCTION() instead > > Move the defines above the kerneldoc entry for _EMIT_BUG_ENTRY > to make kerneldoc happy. > > Reported-by: Simon Horman > Cc: Simon Horman > Cc: Yoshinori Sato > Cc: Rich Felker > Cc: John Paul Adrian Glaubitz >

Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces

2024-03-27 Thread Simon Horman
On Wed, Mar 27, 2024 at 08:10:51AM -0700, Guenter Roeck wrote: > On 3/27/24 07:44, Simon Horman wrote: > > On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote: > > > Add name of functions triggering warning backtraces to the __bug_table > > > object se

Re: [PATCH v2 12/14] sh: Add support for suppressing warning backtraces

2024-03-27 Thread Simon Horman
On Mon, Mar 25, 2024 at 10:52:46AM -0700, Guenter Roeck wrote: > Add name of functions triggering warning backtraces to the __bug_table > object section to enable support for suppressing WARNING backtraces. > > To limit image size impact, the pointer to the function name is only added > to the __b

[PATCH net-next] ps3/gelic: minor Kernel Doc corrections

2024-02-21 Thread Simon Horman
stead .../ps3_gelic_net.c:1531: warning: Function parameter or struct member 'netdev' not described in 'gelic_alloc_card_net' Signed-off-by: Simon Horman --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --g

[PATCH RFC net] ps3/gelic: Fix possible NULL pointer dereference

2024-02-21 Thread Simon Horman
the case where tx_chain->tail->skb may be NULL. Flagged by Smatch. Compile tested only. Fixes: 589866f9f1cb ("PS3: gelic: Add support for dual network interface") Signed-off-by: Simon Horman --- drivers/net/ethernet/toshiba/ps3_gelic_net.c | 8 +--- 1 file changed, 5 inse

Re: [PATCH v4 21/28] net: wan: Add framer framework support

2023-08-20 Thread Simon Horman
On Fri, Aug 18, 2023 at 06:39:15PM +0200, Christophe Leroy wrote: > From: Herve Codina > > A framer is a component in charge of an E1/T1 line interface. > Connected usually to a TDM bus, it converts TDM frames to/from E1/T1 > frames. It also provides information related to the E1/T1 line. > > Th

Re: [PATCH -next] net/ps3_gelic_net: Use ether_addr_to_u64() to convert ethernet address

2023-08-09 Thread Simon Horman
On Tue, Aug 08, 2023 at 07:40:50PM +0800, Li Zetao wrote: > Use ether_addr_to_u64() to convert an Ethernet address into a u64 value, > instead of directly calculating, as this is exactly what > this function does. > > Signed-off-by: Li Zetao > --- > drivers/net/ethernet/toshiba/ps3_gelic_net.c |

Re: [PATCH net-next v2 00/10] net: fs_enet: Driver cleanup

2023-08-06 Thread Simon Horman
For the series, Reviewed-by: Simon Horman

Re: [PATCH net-next v2 10/10] net: fs_enet: Use cpm_muram_xxx() functions instead of cpm_dpxxx() macros

2023-08-06 Thread Simon Horman
On Fri, Aug 04, 2023 at 03:30:20PM +0200, Christophe Leroy wrote: > cpm_dpxxx() macros are now always referring to cpm_muram_xxx() fonctions nit: fonctions -> functions Thanks Christophe, This minor nit notwithstanding, this series looks good to me. I'll send a reviewed-by tag for the whole seri

Re: [PATCH net-next v3] net: Explicitly include correct DT includes

2023-07-27 Thread Simon Horman
to > explicitly include the correct includes. > > Acked-by: Alex Elder > Reviewed-by: Bhupesh Sharma > Reviewed-by: Wei Fang > Signed-off-by: Rob Herring Reviewed-by: Simon Horman

Re: [PATCH v2] net: Explicitly include correct DT includes

2023-07-25 Thread Simon Horman
On Mon, Jul 24, 2023 at 03:22:16PM -0600, Rob Herring wrote: ... > 90 files changed, 88 insertions(+), 92 deletions(-) Hi Rob, I suppose that it's reasonable to take this patch through netdev. But it does have a pretty wide surface, and netdev moves a lot. As it stands the patch doesn't apply

Re: [RFC PATCH 20/21] crypto: deflate - implement acomp API directly

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:46PM +0200, Ard Biesheuvel wrote: ... > -static int deflate_comp_init(struct deflate_ctx *ctx) > +static int deflate_process(struct acomp_req *req, struct z_stream_s *stream, > +int (*process)(struct z_stream_s *, int)) > { > - int ret =

Re: [RFC PATCH 19/21] crypto: remove obsolete 'comp' compression API

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:45PM +0200, Ard Biesheuvel wrote: ... > diff --git a/crypto/crypto_user_stat.c b/crypto/crypto_user_stat.c > index d4f3d39b51376973..d3133eda2f528d17 100644 > --- a/crypto/crypto_user_stat.c > +++ b/crypto/crypto_user_stat.c > @@ -86,10 +86,6 @@ static int crypto_rep

Re: [RFC PATCH 08/21] zram: Migrate to acomp compression API

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:34PM +0200, Ard Biesheuvel wrote: ... > @@ -1618,9 +1614,7 @@ static int zram_recompress(struct zram *zram, u32 > index, struct page *page, > > num_recomps++; > zstrm = zcomp_stream_get(zram->comps[prio]); > - src = kmap_ato

Re: [RFC PATCH 07/21] ubifs: Migrate to acomp compression API

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:33PM +0200, Ard Biesheuvel wrote: > UBIFS is one of the remaining users of the obsolete 'comp' compression > API exposed by the crypto subsystem. Given that it operates strictly on > contiguous buffers that are either entirely in lowmem or covered by a > single page, t

Re: [RFC PATCH 04/21] net: ipcomp: Migrate to acomp API from deprecated comp API

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:30PM +0200, Ard Biesheuvel wrote: > Migrate the IPcomp network compression code to the acomp API, in order > to drop the dependency on the obsolete 'comp' API which is going away. > > For the time being, this is a rather mechanical conversion replacing > each comp TFM

Re: [RFC PATCH 01/21] crypto: scomp - Revert "add support for deflate rfc1950 (zlib)"

2023-07-21 Thread Simon Horman
On Tue, Jul 18, 2023 at 02:58:27PM +0200, Ard Biesheuvel wrote: > This reverts commit a368f43d6e3a001e684e9191a27df384fbff12f5. > > "zlib-deflate" was introduced 6 years ago, but it does not have any > users. So let's remove the generic implementation and the test vectors, > but retain the "zlib-d

Re: [PATCH net] ibmvnic: Do not reset dql stats on NON_FATAL err

2023-06-23 Thread Simon Horman
On Fri, Jun 23, 2023 at 09:52:26AM +0200, Simon Horman wrote: > + maintainers and blamed authors A second time, because something went wrong with the first attempt. > On Thu, Jun 22, 2023 at 02:03:32PM -0500, Nick Child wrote: > > All ibmvnic resets, make a call to netdev_tx_reset_

Re: [PATCH net-next v2 5/8] net: fs_enet: Convert to platform remove callback returning void

2023-06-07 Thread Simon Horman
ays returning zero in the remove > callback to the void returning variant. > > Reviewed-by: Michal Kubiak > Signed-off-by: Uwe Kleine-König Reviewed-by: Simon Horman

Re: [PATCH net-next v2 8/8] net: ucc_geth: Convert to platform remove callback returning void

2023-06-07 Thread Simon Horman
ays returning zero in the remove > callback to the void returning variant. > > Reviewed-by: Michal Kubiak > Signed-off-by: Uwe Kleine-König Reviewed-by: Simon Horman

Re: [PATCH v9 4/4] tpm/kexec: Duplicate TPM measurement log in of-tree for kexec

2023-04-19 Thread Simon Horman
On Tue, Apr 18, 2023 at 09:44:09AM -0400, Stefan Berger wrote: > The memory area of the TPM measurement log is currently not properly > duplicated for carrying it across kexec when an Open Firmware > Devicetree is used. Therefore, the contents of the log get corrupted. > Fix this for the kexec_file

Re: [PATCH] net: Use of_property_read_bool() for boolean properties

2023-03-15 Thread Simon Horman
On Tue, Mar 14, 2023 at 02:14:37PM -0500, Rob Herring wrote: > On Sat, Mar 11, 2023 at 5:50 AM Simon Horman > wrote: > > > > On Fri, Mar 10, 2023 at 08:47:16AM -0600, Rob Herring wrote: > > > It is preferred to use typed property access functions (i.e. > > >

Re: [PATCH] net: Use of_property_read_bool() for boolean properties

2023-03-11 Thread Simon Horman
erties to to of_property_read_bool(). > > Signed-off-by: Rob Herring Reviewed-by: Simon Horman ... > diff --git a/drivers/net/ethernet/via/via-velocity.c > b/drivers/net/ethernet/via/via-velocity.c > index a502812ac418..86f7843b4591 100644 > --- a/drivers/net/ethernet/via/via-

Re: [PATCH v5 07/11] PCI: Replace pci_dev::driver usage that gets the driver name

2021-09-29 Thread Simon Horman
drivers/net/ethernet/marvell/prestera/prestera_pci.c | 2 +- > drivers/net/ethernet/mellanox/mlxsw/pci.c| 2 +- > drivers/net/ethernet/netronome/nfp/nfp_net_ethtool.c | 3 ++- > 5 files changed, 6 insertions(+), 5 deletions(-) Thanks Uwe. For NFP: Acked-by: Simon Horman

Re: [PATCH v4 4/8] PCI: replace pci_dev::driver usage that gets the driver name

2021-09-29 Thread Simon Horman
On Tue, Sep 28, 2021 at 12:31:29PM +0200, Uwe Kleine-König wrote: > On Tue, Sep 28, 2021 at 12:01:28PM +0200, Simon Horman wrote: > > On Mon, Sep 27, 2021 at 10:43:22PM +0200, Uwe Kleine-König wrote: > > > From: Uwe Kleine-König > > > > > > struct pci_dev:

Re: [PATCH v4 4/8] PCI: replace pci_dev::driver usage that gets the driver name

2021-09-28 Thread Simon Horman
columns wide. But not nearly strongly enough to engage in a long debate about it. In any case, for the NFP portion of this patch. Acked-by: Simon Horman > nfp_net_get_nspinfo(app, nsp_version); > snprintf(drvinfo->fw_version, sizeof(drvinfo->fw_version), >"%s %s %s %s", vnic_version, nsp_version, ...

Re: [oss-drivers] [trivial PATCH] treewide: Convert switch/case fallthrough; to break;

2020-09-17 Thread Simon Horman
On Wed, Sep 09, 2020 at 01:06:39PM -0700, Joe Perches wrote: > fallthrough to a separate case/default label break; isn't very readable. > > Convert pseudo-keyword fallthrough; statements to a simple break; when > the next label is case or default and the only statement in the next > label block is

Re: [oss-drivers] [PATCH 16/20] ethernet: netronome: convert tasklets to use new tasklet_setup() API

2020-08-17 Thread Simon Horman
ned-off-by: Romain Perier > Signed-off-by: Allen Pais Reviewed-by: Simon Horman But: This series should be targeted at net-next, and thus have net-next in its subject [PATCH net-next x/y] ... And it should be posted when net-next is open: it is currently closed. http://v

Re: [PATCH v2 26/34] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-12-10 Thread Simon Horman
On Thu, Dec 06, 2018 at 01:38:42PM -0600, Rob Herring wrote: > On Wed, Dec 5, 2018 at 1:44 PM Simon Horman wrote: > > > > On Tue, Dec 04, 2018 at 09:08:57AM -0600, Rob Herring wrote: > > > On Tue, Dec 4, 2018 at 8:57 AM Geert Uytterhoeven > > >

Re: [PATCH v2 26/34] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-12-05 Thread Simon Horman
On Tue, Dec 04, 2018 at 09:08:57AM -0600, Rob Herring wrote: > On Tue, Dec 4, 2018 at 8:57 AM Geert Uytterhoeven > wrote: > > > > Hi Simon, > > > > On Tue, Dec 4, 2018 at 3:48 PM Simon Horman wrote: > > > On Mon, Dec 03, 2018 at 03:32:15PM -0600, Rob Her

Re: [PATCH v2 26/34] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-12-04 Thread Simon Horman
On Mon, Dec 03, 2018 at 03:32:15PM -0600, Rob Herring wrote: > Convert Renesas SoC bindings to DT schema format using json-schema. > > Cc: Simon Horman > Cc: Magnus Damm > Cc: Mark Rutland > Cc: linux-renesas-...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Si

Re: [PATCH v2 25/34] dt-bindings: arm: renesas: Move 'renesas,prr' binding to its own doc

2018-12-04 Thread Simon Horman
On Mon, Dec 03, 2018 at 03:32:14PM -0600, Rob Herring wrote: > In preparation to convert board-level bindings to json-schema, move > various misc SoC bindings out to their own file. > > Cc: Mark Rutland > Cc: Simon Horman > Cc: Magnus Damm > Cc: devicet...@vger.kernel.or

Re: [PATCH 05/36] dt-bindings: arm: renesas: Move 'renesas,prr' binding to its own doc

2018-10-18 Thread Simon Horman
son-schema, move > > > various misc SoC bindings out to their own file. > > > > > > Cc: Mark Rutland > > > Cc: Simon Horman > > > Cc: Magnus Damm > > > Cc: devicet...@vger.kernel.org > > > Cc: linux-renesas-...@vger.kernel.org >

Re: [PATCH 29/36] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-10-18 Thread Simon Horman
On Mon, Oct 08, 2018 at 09:05:58AM -0500, Rob Herring wrote: > On Mon, Oct 8, 2018 at 3:02 AM Simon Horman wrote: > > > > On Fri, Oct 05, 2018 at 11:58:41AM -0500, Rob Herring wrote: > > > Convert Renesas SoC bindings to DT schema format using json-schema. > > >

Re: [PATCH 29/36] dt-bindings: arm: Convert Renesas board/soc bindings to json-schema

2018-10-08 Thread Simon Horman
On Fri, Oct 05, 2018 at 11:58:41AM -0500, Rob Herring wrote: > Convert Renesas SoC bindings to DT schema format using json-schema. > > Cc: Simon Horman > Cc: Magnus Damm > Cc: Mark Rutland > Cc: linux-renesas-...@vger.kernel.org > Cc: devicet...@vger.kernel.org > Si

Re: [PATCH 1/4] treewide: convert ISO_8859-1 text comments to utf-8

2018-07-24 Thread Simon Horman
| 8 +- > net/netfilter/ipvs/ip_vs_mh.c | 4 +- IPVS portion: Acked-by: Simon Horman > tools/power/cpupower/po/de.po | 44 +++ > tools/power/cpupower/po/fr.po | 120 +- > 12 files changed, 103 insertions(

Re: [PATCH] powerpc: kexec_file: Fix error code when trying to load kdump kernel

2018-03-30 Thread Simon Horman
d failed: Unknown error 524 > > After the patch: > > # ~bauermann/src/kexec-tools/build/sbin/kexec -s -p /boot/vmlinuz > kexec_file_load failed: Operation not supported > > Fixes: a0458284f062 ("powerpc: Add support code for kexec_file_load()") > Reported-by: Dave Young > Signed-off-by: Thiago Jung Bauermann Reviewed-by: Simon Horman

Re: [PATCH] soc: Convert to using %pOF instead of full_name

2017-07-27 Thread Simon Horman
: Scott Wood > Cc: Qiang Zhao > Cc: Matthias Brugger > Cc: Simon Horman > Cc: Magnus Damm > Cc: Kukjin Kim > Cc: Krzysztof Kozlowski > Cc: Javier Martinez Canillas > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-

Re: [PATCH 1 4/4] PCI: rcar: Use of_device_get_match_data() to simplify probe

2017-02-02 Thread Simon Horman
_fn pointer. No > functional change intended. > > Suggested-by: Geert Uytterhoeven > Signed-off-by: Bjorn Helgaas Acked-by: Simon Horman > --- > drivers/pci/host/pcie-rcar.c |7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/

Re: [PATCH v2 3/3] ppc64: Add a flag to tell the kernel it's booting from kexec

2015-12-07 Thread Simon Horman
On Tue, Dec 08, 2015 at 02:46:17PM +1100, Michael Ellerman wrote: > On Mon, 2015-12-07 at 14:42 -0600, Scott Wood wrote: > > On Tue, 2015-10-06 at 17:55 -0500, Scott Wood wrote: > > > It needs to know this because the SMP release mechanism for Freescale > > > book3e is different from when booting w

Re: [PATCH v2 2/3] ppc64: Avoid rfid if no need to clear MSR_LE

2015-11-01 Thread Simon Horman
On Mon, Nov 02, 2015 at 11:21:43AM +1100, Sam Mendoza-Jonas wrote: > On Mon, Nov 02, 2015 at 09:55:53AM +1100, Sam Mendoza-Jonas wrote: > > On Tue, Oct 06, 2015 at 05:55:49PM -0500, Scott Wood wrote: > > > Commit a304e2d82a8c3 ("ppc64: purgatory: Reset primary cpu endian to > > > big-endian) change

Re: [ANNOUNCE] kexec-tools 2.0.11-rc1

2015-10-30 Thread Simon Horman
On Thu, Oct 29, 2015 at 07:23:24PM -0500, Scott Wood wrote: > On Fri, 2015-10-30 at 08:48 +0900, Simon Horman wrote: > > Hi all, > > > > I am happy to announce the release of kexec-tools 2.0.11-rc1. > > > > This is an incremental feature pre-release. > > &

Re: [PATCH v2 1/3] ppc64: Fix warnings

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:48PM -0500, Scott Wood wrote: > Produce a warning-free build on ppc64 (at least, when built as 64-bit > userspace -- if a 64-bit binary for ppc64 is a requirement, why is -m64 > set only on purgatory?). Mostly unused (or write-only) variable > warnings, but also one n

Re: [PATCH v2 2/3] ppc64: Avoid rfid if no need to clear MSR_LE

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:49PM -0500, Scott Wood wrote: > Commit a304e2d82a8c3 ("ppc64: purgatory: Reset primary cpu endian to > big-endian) changed bctr to rfid. rfid is book3s-only and will cause a > fatal exception on book3e. > > Purgatory is an isolated environment which makes importing i

Re: [PATCH v2 3/3] ppc64: Add a flag to tell the kernel it's booting from kexec

2015-10-15 Thread Simon Horman
On Tue, Oct 06, 2015 at 05:55:50PM -0500, Scott Wood wrote: > It needs to know this because the SMP release mechanism for Freescale > book3e is different from when booting with normal hardware. In theory > we could simulate the normal spin table mechanism, but not (easily) at > the addresses U-Boo

Re: [PATCH] purgatory/arch/ppc64: Reset primary cpu endian to big-endian

2015-09-04 Thread Simon Horman
On Thu, Sep 03, 2015 at 03:18:02PM +1000, Michael Ellerman wrote: > On Wed, 2015-09-02 at 10:02 +0900, Simon Horman wrote: > > [CC linuxppc-dev] > > > > On Fri, Aug 21, 2015 at 12:51:16PM +1000, Samuel Mendoza-Jonas wrote: > > > Older big-endian ppc64 kernels don&#x

Re: [PATCH] purgatory/arch/ppc64: Reset primary cpu endian to big-endian

2015-09-01 Thread Simon Horman
[CC linuxppc-dev] On Fri, Aug 21, 2015 at 12:51:16PM +1000, Samuel Mendoza-Jonas wrote: > Older big-endian ppc64 kernels don't include the FIXUP_ENDIAN check, > meaning if we kexec from a little-endian kernel the target kernel will > fail to boot. > Returning to big-endian before we enter the targ

Re: [PATCH 5/7] PCI: Remove unnecessary #includes of

2015-06-04 Thread Simon Horman
|1 - > arch/sh/drivers/pci/pci-sh5.c |1 - > arch/x86/kernel/x86_init.c|1 - > 11 files changed, 11 deletions(-) arch/sh/drivers portion: Acked-by: Simon Horman ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH 0/4] defconfigs: cleanup obsolete MTD configs

2015-01-26 Thread Simon Horman
On Sat, Jan 24, 2015 at 06:33:29PM +0200, Semen Protsenko wrote: > This patch series removes next obsolete MTD configs from all defconfig files: > - CONFIG_MTD_CHAR > - CONFIG_MTD_CONCAT > - CONFIG_MTD_DEBUG > - CONFIG_MTD_DEBUG_VERBOSE > - CONFIG_MTD_PARTITIONS > > All those configs wer

Re: [PATCH v2] kexec/ppc64 fix device tree endianess issues for memory attributes

2014-01-30 Thread Simon Horman
On Thu, Jan 30, 2014 at 04:06:22PM +0100, Laurent Dufour wrote: > All the attributes exposed in the device tree are in Big Endian format. > > This patch add the byte swap operation for some entries which were not yet > processed, including those fixed by the following kernel's patch : > > https:/

Re: [PATCH 0/4] Minor fixes and improvements for kexec

2013-12-11 Thread Simon Horman
On Thu, Dec 12, 2013 at 12:18:56AM +, Geoff Levand wrote: > Hi Eric, > > Here are a few minor fixes and improvements for kexec. Please consider. FWIW, Reviewed-by: Simon Horman > > -Geoff > > The following changes since commit 374b105797c3d4f29c685f3be535c35f5689b3

Re: Preliminary kexec support for Linux/m68k

2013-09-19 Thread Simon Horman
On Thu, Sep 19, 2013 at 11:20:22AM +0200, Geert Uytterhoeven wrote: > On Tue, Sep 17, 2013 at 12:01 PM, Geert Uytterhoeven > wrote: > > This is a preliminary set of patches to add kexec support for m68k. > > > - [PATCH 1/3] m68k: Add preliminary kexec support > > - [PATCH 2/3] m68k: Add suppo

Re: [PATCH] kexec/ppc: Fix kernel program entry point while changing the load addr

2013-03-04 Thread Simon Horman
On Mon, Mar 04, 2013 at 11:26:24AM +0530, Suzuki K. Poulose wrote: > On 03/04/2013 07:11 AM, Simon Horman wrote: > >[ Cc: linuxppc-dev@lists.ozlabs.org ] > > > >On Sun, Mar 03, 2013 at 01:06:00PM +0530, Suzuki K. Poulose wrote: > >>From: Suzuki K. Poulose > &g

Re: [PATCH] kexec/ppc: Fix kernel program entry point while changing the load addr

2013-03-03 Thread Simon Horman
[ Cc: linuxppc-dev@lists.ozlabs.org ] On Sun, Mar 03, 2013 at 01:06:00PM +0530, Suzuki K. Poulose wrote: > From: Suzuki K. Poulose > > uImage probe fills the entry point (ep) based on the load_addr > from the uImage headers. If we change the load_addr, we should > accordingly update the entry po

Re: [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type

2013-01-16 Thread Simon Horman
jay Abraham I > --- > arch/arm/mach-shmobile/board-marzen.c |2 +- Modification to the above file: Acked-by: Simon Horman ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH] [ppc] Do not reserve cpu spin-table for crash kernel

2012-07-12 Thread Simon Horman
On Thu, May 24, 2012 at 11:39:45AM +0530, Suzuki K. Poulose wrote: > As of now, the kexec reserves the spin-table for all the CPUs > on an SMP machine. The spin-table is pointed to by the > cpu-release-addr property in the device-tree. Reserving the > spin-table in the crash kernel will cause a BU

Re: [PATCH 2/5] ppc: move DEBUG code to --debug

2012-03-15 Thread Simon Horman
[CC linuxppc-...@ozlabs.org] On Thu, Mar 08, 2012 at 02:39:39PM +0800, Cong Wang wrote: > Like patch 1/5, this one moves code under #if DEBUG to --debug > on ppc arch. > > Signed-off-by: Cong Wang > --- > kexec/arch/ppc/crashdump-powerpc.c | 18 -- > kexec/arch/ppc/fixup_dtb.c

Re: [PATCH] [v3] kexec-tools: ppc32: Fixup ThreadPointer for purgatory code

2011-07-12 Thread Simon Horman
On Tue, Jul 12, 2011 at 03:20:40PM +0530, Suzuki K. Poulose wrote: > PPC32 ELF ABI expects r2 to be loaded with Thread Pointer, which is 0x7000 > bytes past the end of TCB. Though the purgatory is single threaded, it uses > TCB scratch space in vsnprintf(). This patch allocates a 1024byte TCB > and

Re: [PATCH v2] kexec-tools: powerpc: Use the #address-cells information to parsememory/reg

2011-06-16 Thread Simon Horman
On Thu, Jun 16, 2011 at 04:15:13PM +0530, Suzuki K. Poulose wrote: > The format of memory/reg is based on the #address-cells,#size-cells. > Currently, > the kexec-tools doesn't use the above values in parsing the memory/reg values. > Hence the kexec cannot handle cases where #address-cells, #size-

Re: [RFC][PATCH] kexec-tools: powerpc: Use the #address-cells information to parsememory/reg - V2

2011-06-15 Thread Simon Horman
On Wed, Jun 08, 2011 at 12:08:55PM +0530, Suzuki Poulose wrote: > Hi, > > This is version 2 of the patch > > Changes from Version 1 : > : Changed the interface for read_memory_region_limits to use 'int fd' > instead of FILE*. > : Use sizeof(variable) for read(, instead of sizeof(type). >

Re: [PATCH] ppc64: increase TREEWORDS value in ppc64

2010-09-09 Thread Simon Horman
[ Repost with correct kexec ML address ] [ CCed linuxppc-dev ] On Thu, Sep 09, 2010 at 04:27:11PM -0400, Neil Horman wrote: > hey- > Got a segfault recently on ppc64 kexec with a system with 256Gb of ram. > Tracked it back to running over the end of the device tree buffer that we have > alloc

Re: [PATCH] ppc64: increase TREEWORDS value in ppc64

2010-09-09 Thread Simon Horman
[ CCed linuxppc-dev ] On Thu, Sep 09, 2010 at 04:27:11PM -0400, Neil Horman wrote: > hey- > Got a segfault recently on ppc64 kexec with a system with 256Gb of ram. > Tracked it back to running over the end of the device tree buffer that we have > allocated. I can't find any docs on how big t

Re: [PATCH v2 0/3] Misc. bug fixes for ppc32

2010-08-20 Thread Simon Horman
On Wed, Aug 18, 2010 at 11:56:48PM -0500, Matthew McClintock wrote: > This patch series fixes a few issues I have discovered with my previous > patch series. Nothing new has been added. Thanks, all applied. ___ Linuxppc-dev mailing list Linuxppc-dev@lis

Re: [PATCH v2] powerpc/kexec: Fix orphaned offline CPUs across kexec

2010-07-29 Thread Simon Horman
On Fri, Jul 30, 2010 at 01:15:14PM +1000, Michael Neuling wrote: > (adding kexec list to CC) > > In message <4c521fd2.4050...@ozlabs.org> you wrote: > > Michael Neuling wrote: > > > In message <4c511216.30...@ozlabs.org> you wrote: > > >> When CPU hotplug is used, some CPUs may be offline at the t

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

2010-07-29 Thread Simon Horman
On Mon, Jul 26, 2010 at 11:22:58PM -0500, Matthew McClintock wrote: > > On Jul 26, 2010, at 9:55 PM, Simon Horman wrote: > > > [Cced linuxppc-dev] > > > > On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote: > >> This patch series adds full su

Re: [PATCH v2 5/7] Add support for ramdisk on ppc32 for uImage-ppc and Elf-ppc

2010-07-29 Thread Simon Horman
On Tue, Jul 20, 2010 at 03:14:58PM -0500, Matthew McClintock wrote: > This fixes --reuseinitrd and --ramdisk option for ppc32 on > uImage-ppc and Elf. It works for normal kexec as well as for > kdump. > > When using --reuseinitrd you need to specifify retain_initrd > on the command line. Also, if

Re: [PATCH v3 0/7] Fixup booting with device trees and uImage/elf on ppc32

2010-07-26 Thread Simon Horman
[Cced linuxppc-dev] On Tue, Jul 20, 2010 at 11:42:57PM -0500, Matthew McClintock wrote: > This patch series adds full support for booting with a flat device tree > with either uImage or elf file formats. Kexec and Kdump should work, and > you should also be able to use ramdisks or reuse your curre

Re: [PATCH] Restore kexec uImage-ppc to working state

2010-06-15 Thread Simon Horman
CCed linuxppc-dev to fish for an ack. On Mon, Jun 14, 2010 at 02:38:42PM -0500, Matthew McClintock wrote: > Booting with uImage-ppc was broken by previous work, this > patch should restore it to working order > > Signed-off-by: Matthew McClintock > --- > kexec/arch/ppc/kexec-ppc.c | 6

Re: [patch] ppc: Fix gamecube build

2010-05-18 Thread Simon Horman
On Fri, May 14, 2010 at 12:25:19AM +0900, Simon Horman wrote: > This fixes the kexec-build on ppc32 when > the --game-cube option is supplied to ./configure. > It seems to have bit-rotted a little. > > Cc: Sebastian Andrzej Siewior > Cc: Maxim Uvarov > Signed-off-by: Simon

Re: [PATCH v2] kexec-tools, ppc64: Fix segfault parsing DR memory property

2010-05-18 Thread Simon Horman
On Tue, May 18, 2010 at 09:30:32AM +1000, Michael Neuling wrote: > > > In message <4becbe89.3020...@ozlabs.org> you wrote: > > add_dyn_reconf_usable_mem_property() iterates over memory spans > > in /ibm,dynamic-reconfiguration-memory/ibm,dynamic-memory and intersects > > these with usablemem_rgns

[patch] ppc: Fix gamecube build

2010-05-13 Thread Simon Horman
This fixes the kexec-build on ppc32 when the --game-cube option is supplied to ./configure. It seems to have bit-rotted a little. Cc: Sebastian Andrzej Siewior Cc: Maxim Uvarov Signed-off-by: Simon Horman Index: kexec-tools/kexec/arch/ppc/kexec-elf-ppc.c

Re: [PATCH v2 2/2] powerpc new toolchains fix (crt.S)

2010-05-13 Thread Simon Horman
On Wed, May 12, 2010 at 11:08:49AM +0400, Maxim Uvarov wrote: > > Hello everybody, > > Changes from previous version: > - removed bogus hyphen from the patch; > - move ifdefs to crt.S instead of Makefile > > > Please find here patch for user land kexec-tools application.

Re: [PATCH 1/2] Fix kexec on powerpc32

2010-05-12 Thread Simon Horman
On Wed, May 12, 2010 at 10:31:26AM +0400, Maxim Uvarov wrote: > 2010/5/12 Christian Kujau > > > Maxim Uvarov wrote on 2010-05-11 10:47 : > > > This patch is required in case if you are using new toolchains. > > > > I'm on Debian/stable (binutils 2.18, gcc 4.3.2), so I applied your patches > > to

Re: [PATCH] kexec-tools, ppc64: Fix segfault on parsing of large device trees.

2010-05-10 Thread Simon Horman
On Mon, May 10, 2010 at 02:55:03PM +1000, Michael Neuling wrote: > > > In message <4be78e06.6080...@ozlabs.org> you wrote: > > > > ppc64's fs2dt used to use a fixed-size array into which the device tree > > was parsed. There was no bounds checking, so with a large device tree other > > heap dat

Re: [PATCH] kexec-tools, ppc64: fix build error on ppc64

2010-05-05 Thread Simon Horman
On Wed, May 05, 2010 at 11:46:25AM +0400, Maxim Uvarov wrote: > 2010/5/5 Simon Horman > > > On Wed, May 05, 2010 at 01:35:21PM +1000, Michael Neuling wrote: > > > > > > > > > In message <20100505023316.gf13...@verge.net.au> you wrote: > > &g

  1   2   >