Re: [kvm-unit-tests PATCH v3 16/16] scripts: Enable kvmtool

2025-05-20 Thread Shaoqin Huang
ff-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- README.md| 18 +- arm/efi/run | 5 + configure| 1 - scripts/vmm.bash | 2 +- 4 files changed, 23 insertions(+), 3 deletions(-) diff --git a/README.md b/README.md index be07dc28a094..723ce04cd978

Re: [kvm-unit-tests PATCH v3 14/16] scripts/mkstandalone: Export $TARGET

2025-05-20 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: $TARGET is needed for the test runner to decide if it should use qemu or kvmtool, so export it. Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- scripts/mkstandalone.sh | 1 + 1 file changed, 1

Re: [kvm-unit-tests PATCH v3 13/16] scripts: Do not probe for maximum number of VCPUs when using kvmtool

2025-05-20 Thread Shaoqin Huang
automatically limit the number of VCPUs to the what KVM supports, which is exactly what --probe-maxsmp wants to achieve. When doing --probe-maxsmp with kvmtool, print a message explaining why it's redundant and don't do anything else. Signed-off-by: Alexandru Elisei Reviewed-by: Sha

Re: [kvm-unit-tests PATCH v3 12/16] scripts: Detect kvmtool failure in premature_failure()

2025-05-20 Thread Shaoqin Huang
() about the kvmtool's error message when it fails to load the dummy kernel. Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- scripts/runtime.bash | 8 +++- scripts/vmm.bash | 23 +++ 2 files changed, 26 insertions(+), 5 deletions(-) diff --

Re: [kvm-unit-tests PATCH v3 10/16] scripts: Add default arguments for kvmtool

2025-05-20 Thread Shaoqin Huang
ut the 'Otherwise' to the next paragraph) # --nodefaults: suppress VM configuration that cannot be disabled # (like modifying the supplied kernel command line). # Otherwise tests that use the command line will fail # without this parameter.

Re: [kvm-unit-tests PATCH v3 00/16] arm/arm64: Add kvmtool to the runner script

2025-05-19 Thread Shaoqin Huang
Hi Alexandru, For this series, I've tested it, everything works good. On 5/7/25 11:12 PM, Alexandru Elisei wrote: v2 can be found here [1]. To goal is to allow the user to do: $ ./configure --target=kvmtool $ make clean && make $ ./run_tests.sh to run all the tests automatically with kvmtool

Re: [kvm-unit-tests PATCH v3 09/16] scripts: Add support for kvmtool

2025-05-19 Thread Shaoqin Huang
return the test exit code, so kvm-unit-tests must always parse the "EXIT: STATUS" line for the exit code. Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- arm/run | 161 ++ powerpc/run | 4 +-

Re: [kvm-unit-tests PATCH v3 11/16] scripts: Add KVMTOOL environment variable for kvmtool binary path

2025-05-19 Thread Shaoqin Huang
-by: Shaoqin Huang --- run_tests.sh | 1 + scripts/arch-run.bash | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/run_tests.sh b/run_tests.sh index dd9d27377905..150a06a91064 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -36,6 +36,7 @@ The following environment

Re: [kvm-unit-tests PATCH v3 07/16] scripts: Use an associative array for qemu argument names

2025-05-14 Thread Shaoqin Huang
-by: Andrew Jones Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- scripts/common.bash | 10 +++--- scripts/runtime.bash | 7 +-- scripts/vmm.bash | 7 +++ 3 files changed, 15 insertions(+), 9 deletions(-) diff --git a/scripts/common.bash b/scripts

Re: [kvm-unit-tests PATCH v3 06/16] scripts: Refuse to run the tests if not configured for qemu

2025-05-14 Thread Shaoqin Huang
chine. This two step process can be time consuming, so save the user time (and frustration!) and add a check directly to mkstandalone.sh. Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- arm/efi/run | 3 +++ arm/run | 4 scripts/mkstandalo

Re: [kvm-unit-tests PATCH v3 04/16] run_tests.sh: Document --probe-maxsmp argument

2025-05-13 Thread Shaoqin Huang
Reviewed-by: Shaoqin Huang --- run_tests.sh | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/run_tests.sh b/run_tests.sh index 152323ffc8a2..f30b6dbd131c 100755 --- a/run_tests.sh +++ b/run_tests.sh @@ -17,14 +17,15 @@ cat < Usage: $0 [-h] [-v] [-a]

Re: [kvm-unit-tests PATCH v3 05/16] scripts: Document environment variables

2025-05-13 Thread Shaoqin Huang
On 5/7/25 11:12 PM, Alexandru Elisei wrote: Document the environment variables that influence how a test is executed by the run_tests.sh test runner. Suggested-by: Andrew Jones Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- docs

Re: [kvm-unit-tests PATCH v3 02/16] scripts: Add 'test_args' test definition parameter

2025-05-13 Thread Shaoqin Huang
by: Andrew Jones Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- arm/unittests.cfg | 94 ++- docs/unittests.txt| 17 ++-- powerpc/unittests.cfg | 19 + riscv/unittests.cfg | 2 +- s390x/unittests.

Re: [kvm-unit-tests PATCH v3 01/16] scripts: unittests.cfg: Rename 'extra_params' to 'qemu_params'

2025-05-13 Thread Shaoqin Huang
going forward new tests will use 'qemu_params'. Signed-off-by: Alexandru Elisei Reviewed-by: Shaoqin Huang --- arm/unittests.cfg | 76 +++ docs/unittests.txt| 15 +++-- powerpc/unittests.cfg | 18 +++--- riscv/unittests.cfg | 2 +- s390x/unit

Re: [kvm-unit-tests PATCH v1 00/18] arm/arm64: Rework cache maintenance at boot

2023-12-01 Thread Shaoqin Huang
don't believe I won't be able to do that for at least 2 weeks. Thanks, Alex On Thu, Nov 30, 2023 at 04:07:02AM -0500, Shaoqin Huang wrote: Hi, I'm posting Alexandru's patch set[1] rebased on the latest branch with the conflicts being resolved. No big changes compare to it

[kvm-unit-tests PATCH v1 02/18] powerpc: Replace the physical allocator with the page allocator

2023-11-30 Thread Shaoqin Huang
From: Alexandru Elisei The spapr_hcall test makes two page sized allocations using the physical allocator. Replace the physical allocator with the page allocator, which has has more features (like support for freeing allocations), and would allow for further simplification of the physical allocat

[kvm-unit-tests PATCH v1 01/18] Makefile: Define __ASSEMBLY__ for assembly files

2023-11-30 Thread Shaoqin Huang
is Reviewed-by: Andrew Jones Signed-off-by: Alexandru Elisei Signed-off-by: Shaoqin Huang --- Makefile | 5 - arm/cstart.S | 1 - arm/cstart64.S | 1 - powerpc/cstart64.S | 1 - 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Makefile b/Makefile index 602

[kvm-unit-tests PATCH v1 00/18] arm/arm64: Rework cache maintenance at boot

2023-11-30 Thread Shaoqin Huang
Hi, I'm posting Alexandru's patch set[1] rebased on the latest branch with the conflicts being resolved. No big changes compare to its original code. As this version 1 of this series was posted one years ago, I would first let you recall it, what's the intention of this series and what this serie