Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-17 Thread Seth Jennings
>> On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: >>> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: >>> > Check old_devdata->dev in nx-842 driver before accessing it, as >>> > on systems without any nx-842 hardware, the ->dev will never be >>> > set. Currently, the module wil

Re: [PATCH] drivers/crypto/nx: prevent oops on module exit

2014-10-17 Thread Seth Jennings
> On Fri, 2014-10-17 at 09:43 +1100, Michael Ellerman wrote: >> On Thu, 2014-10-16 at 15:30 -0400, Dan Streetman wrote: >> > Check old_devdata->dev in nx-842 driver before accessing it, as >> > on systems without any nx-842 hardware, the ->dev will never be >> > set. Currently, the module will cau

Re: [PATCH] Do not update sysfs cpu registration from invalid context

2013-06-24 Thread Seth Jennings
On Mon, Jun 24, 2013 at 12:18:04PM -0500, Seth Jennings wrote: > On Mon, Jun 24, 2013 at 09:14:23AM -0500, Nathan Fontenot wrote: > > The topology update code that updates the cpu node registration in sysfs > > should not be called while in stop_machine(). The register/unregister &

Re: [PATCH] Do not update sysfs cpu registration from invalid context

2013-06-24 Thread Seth Jennings
outside of the call to stop_machine(). > > Signed-off-by:Nathan Fontenot Reviewed-by: Seth Jennings > --- > arch/powerpc/mm/numa.c |5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > I

Re: [PATCH] powerpc/crypto: Remove virt_to_abs() usage in nx-842.c

2012-08-03 Thread Seth Jennings
lude that directly. > > Having done all that, clean up the ordering of the includes. > > Signed-off-by: Michael Ellerman > --- > drivers/crypto/nx/nx-842.c | 34 ++ > 1 file changed, 18 insertions(+), 16 deletions(-) Looks good here. Thanks f

Re: [PATCH 3/4] powerpc/crypto: add 842 hardware compression driver

2012-07-20 Thread Seth Jennings
On 07/20/2012 12:33 AM, Michael Ellerman wrote: > On Thu, 2012-07-19 at 09:42 -0500, Seth Jennings wrote: >> This patch adds the driver for interacting with the 842 >> compression accelerator on IBM Power7+ systems. > > ... > >> +struct nx842_slentry { >>

[PATCH 2/4] powerpc/crypto: add compression support to arch vec

2012-07-19 Thread Seth Jennings
This patch enables compression engine support in the architecture vector. This causes the Power hypervisor to allow access to the nx comrpession accelerator. Signed-off-by: Seth Jennings --- arch/powerpc/kernel/prom_init.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff

[PATCH 1/4] powerpc/crypto: rework Kconfig

2012-07-19 Thread Seth Jennings
/Makefile|Kconfig. Signed-off-by: Seth Jennings --- drivers/crypto/Kconfig | 20 +++- drivers/crypto/nx/Kconfig | 17 + drivers/crypto/nx/Makefile |2 +- 3 files changed, 25 insertions(+), 14 deletions(-) create mode 100644 drivers/crypto/nx/Kconfig diff

[PATCH 0/4] powerpc/crypto: IBM Power7+ in-Nest compression support

2012-07-19 Thread Seth Jennings
has limits on generic compression and is geared toward compressing units that are of PAGE_SIZE for in-kernel memory compression. Based on linux-next (20120717) Seth Jennings (4): powerpc: nx: rework Kconfig powerpc: nx: add compression support to arch vec powerpc: nx: add 842 hardware

[PATCH 4/4] powerpc/crypto: add 842 crypto driver

2012-07-19 Thread Seth Jennings
future compression requests. For decompression requests, the 842 hardware driver contains a software implementation of the 842 decompressor to support the decompression of data that was compressed before the accelerator went offline. Signed-off-by: Robert Jennings Signed-off-by: Seth Jennings

CPU-local TLB flushing

2012-06-18 Thread Seth Jennings
This is a continuation of a thread a few months ago: https://lists.ozlabs.org/pipermail/linuxppc-dev/2012-February/095775.html zsmalloc is now in the staging tree and there are patches on lkml to convert the x86 only tlb flushing code to arch independent code. https://lkml.org/lkml/2012/5/14/55

[PATCH 2/2] drivers: crypto: fix typo in nx driver config option

2012-06-13 Thread Seth Jennings
Cc: Kent Yoder Signed-off-by: Seth Jennings --- drivers/crypto/Kconfig |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/Kconfig b/drivers/crypto/Kconfig index 1092a77..b9b11a6 100644 --- a/drivers/crypto/Kconfig +++ b/drivers/crypto/Kconfig @@ -298,7 +298,7

[PATCH 1/2] drivers: crypto: move nx build to driver/crypto Makefile

2012-06-13 Thread Seth Jennings
When the nx driver was pulled, the Makefile that actually builds it is arch/powerpc/Makefile. This is unnatural. This patch moves the line that builds the nx driver from arch/powerpc/Makefile to drivers/crypto/Makefile where it belongs. Cc: Kent Yoder Signed-off-by: Seth Jennings --- arch

Re: tlb flushing on Power

2012-03-07 Thread Seth Jennings
On 03/06/2012 11:28 PM, Michael Neuling wrote: > Seth, > >> Thanks for the help! I was wondering if you could take a look at something >> for me. >> >> I've been working on this staging driver (zsmalloc memory allocator) >> that does virtual mapping of two pages. >> >> I have a github repo with t

Re: tlb flushing on Power

2012-03-05 Thread Seth Jennings
thing is stable. Any feedback you (or others) can provide would be appreciated! Thanks, Seth On 02/16/2012 02:31 PM, Benjamin Herrenschmidt wrote: > On Thu, 2012-02-16 at 11:11 -0600, Seth Jennings wrote: > >> Just wanted to bump you again about this. You mentioned that if I want

Re: tlb flushing on Power

2012-02-16 Thread Seth Jennings
On 02/10/2012 01:14 PM, Seth Jennings wrote: > On 02/08/2012 03:04 PM, Benjamin Herrenschmidt wrote: >> >>> You can look at https://lkml.org/lkml/2012/1/9/389 in zsmalloc-main.c, >>> zs_[un]map_object() functions for the currently uses of set_pte() and >>> __fl

Re: tlb flushing on Power

2012-02-10 Thread Seth Jennings
On 02/08/2012 03:04 PM, Benjamin Herrenschmidt wrote: > >> You can look at https://lkml.org/lkml/2012/1/9/389 in zsmalloc-main.c, >> zs_[un]map_object() functions for the currently uses of set_pte() and >> __flush_tlb_one(). >> >>> set_pte() is long gone on all archs really (or if it's still there

Re: tlb flushing on Power

2012-02-08 Thread Seth Jennings
Hey Ben, Thanks for responding. On 01/26/2012 03:39 PM, Benjamin Herrenschmidt wrote: > On Thu, 2012-01-26 at 08:41 -0600, Brian King wrote: >> CC'ing linuxppc-dev... >> >> >> On 01/26/2012 08:18 AM, Seth Jennings wrote: >>> Hey Dave, >>> >