Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 19:54:56 [+0530], Shrikanth Hegde wrote: > > > But looking at the semantics of usage of xfer_to_guest_mode_work > > > I think using schedule is probably right over here. > > > Correct me if i got it all wrong. > > > > No, if you do xfer_to_guest_mode_work() then it will invoke schedu

Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work

2025-04-25 Thread Sebastian Andrzej Siewior
On 2025-04-25 16:49:19 [+0530], Shrikanth Hegde wrote: > On 4/25/25 00:08, Sebastian Andrzej Siewior wrote: > > On 2025-04-24 21:27:59 [+0530], Shrikanth Hegde wrote: > > > > > diff --git a/arch/powerpc/kvm/book3s_hv.c > > > > > b/arch/powerpc/kvm/book3s_hv

Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work

2025-04-24 Thread Sebastian Andrzej Siewior
On 2025-04-24 21:27:59 [+0530], Shrikanth Hegde wrote: > > > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > > > index 19f4d298d..123539642 100644 > > > --- a/arch/powerpc/kvm/book3s_hv.c > > > +++ b/arch/powerpc/kvm/book3s_hv.c > > > @@ -4901,7 +4901,7 @@ int kvmhv_run_s

Re: [PATCH 1/2] powerpc: kvm: use generic transfer to guest mode work

2025-04-24 Thread Sebastian Andrzej Siewior
On 2025-04-21 15:58:36 [+0530], Shrikanth Hegde wrote: > diff --git a/arch/powerpc/kvm/book3s_hv.c b/arch/powerpc/kvm/book3s_hv.c > index 19f4d298d..123539642 100644 > --- a/arch/powerpc/kvm/book3s_hv.c > +++ b/arch/powerpc/kvm/book3s_hv.c > @@ -80,8 +80,8 @@ > #include > #include > #include

[PATCH v4 5/9] powerpc: Rely on generic printing of preemption model.

2025-03-14 Thread Sebastian Andrzej Siewior
dev@lists.ozlabs.org Reviewed-by: Christophe Leroy Reviewed-by: Shrikanth Hegde Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/traps.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index edf5cabe5d

[PATCH v3 5/9] powerpc: Rely on generic printing of preemption model.

2025-02-12 Thread Sebastian Andrzej Siewior
dev@lists.ozlabs.org Reviewed-by: Christophe Leroy Reviewed-by: Shrikanth Hegde Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/traps.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index edf5cabe5d

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-10 Thread Sebastian Andrzej Siewior
an Srinivasan Cc: Michael Ellerman Cc: Nicholas Piggin Cc: Christophe Leroy Cc: Naveen N Rao Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Christophe Leroy Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/traps.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --g

Re: [PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-10 Thread Sebastian Andrzej Siewior
On 2025-02-08 13:05:57 [+0530], Shrikanth Hegde wrote: > > > On 2/4/25 13:52, Sebastian Andrzej Siewior wrote: > > Use preempt_model_str() instead of manually conducting the preemption > > model. Use pr_emerg() instead of printk() to pass a loglevel. > > even on p

[PATCH v3 5/9] powerpc: Use preempt_model_str().

2025-02-04 Thread Sebastian Andrzej Siewior
: Sebastian Andrzej Siewior --- v2…v3: - Use printk() instead of pr_emerg() to remain consistent with the other invocations in terms of printing context. arch/powerpc/kernel/traps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc

Re: [PATCH v2 5/9] powerpc: Use preempt_model_str().

2025-02-03 Thread Sebastian Andrzej Siewior
On 2025-02-03 16:19:06 [+0100], Christophe Leroy wrote: > > > Le 03/02/2025 à 15:16, Sebastian Andrzej Siewior a écrit : > > Use preempt_model_str() instead of manually conducting the preemption > > model. Use pr_emerg() instead of printk() to pass a loglevel. > >

[PATCH v2 5/9] powerpc: Use preempt_model_str().

2025-02-03 Thread Sebastian Andrzej Siewior
: Sebastian Andrzej Siewior --- arch/powerpc/kernel/traps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/traps.c b/arch/powerpc/kernel/traps.c index edf5cabe5dfdb..9eb383189cfb2 100644 --- a/arch/powerpc/kernel/traps.c +++ b/arch/powerpc/kernel/traps.c

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-30 22:27:07 [+0530], Shrikanth Hegde wrote: > > | #DEFINE need_irq_preemption() \ > > | (static_branch_unlikely(&sk_dynamic_irqentry_exit_cond_resched)) > > | > > | if (need_irq_preemption()) { > > > > be a bit smaller/ quicker? This could be a fast path ;) > > I am okay wit

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-30 16:03:09 [+0100], Christophe Leroy wrote: > Le 30/01/2025 à 15:54, Sebastian Andrzej Siewior a écrit : > > On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: > > > --- a/arch/powerpc/kernel/interrupt.c > > > +++ b/arch/powerpc/kernel/interr

Re: [PATCH v3 1/1] powerpc: Enable dynamic preemption

2025-01-30 Thread Sebastian Andrzej Siewior
On 2025-01-06 10:49:19 [+0530], Shrikanth Hegde wrote: > --- a/arch/powerpc/kernel/interrupt.c > +++ b/arch/powerpc/kernel/interrupt.c > @@ -25,6 +25,10 @@ > unsigned long global_dbcr0[NR_CPUS]; > #endif > > +#if defined(CONFIG_PREEMPT_DYNAMIC) && > defined(CONFIG_HAVE_PREEMPT_DYNAMIC_KEY) > +

Re: [PATCH v3 01/28] module: Extend the preempt disabled section in dereference_symbol_descriptor().

2025-01-08 Thread Sebastian Andrzej Siewior
On 2025-01-08 10:55:04 [+0100], Helge Deller wrote: > Nice catch. > > Acked-by: Helge Deller > > This patch really should be backported. > Can you add a Cc: stable tag? It should be picked due to the fixes tag. I add it if I am going to repost it. > Helge Sebastian

[PATCH v3 01/28] module: Extend the preempt disabled section in dereference_symbol_descriptor().

2025-01-08 Thread Sebastian Andrzej Siewior
lerman Cc: Naveen N Rao Cc: Nicholas Piggin Cc: Sergey Senozhatsky Cc: linux-par...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Reviewed-by: Sergey Senozhatsky Acked-by: Peter Zijlstra (Intel) Signed-off-by: Sebastian Andrzej Siewior --- include/linux/kallsyms.h | 2 +- 1 file

[PATCH v3 20/28] powerpc/ftrace: Use RCU in all users of __module_text_address().

2025-01-08 Thread Sebastian Andrzej Siewior
Ellerman Cc: Naveen N Rao Cc: Nicholas Piggin Cc: Steven Rostedt Cc: linux-trace-ker...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Acked-by: Peter Zijlstra (Intel) Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/trace/ftrace.c | 6 ++ arch/powerpc/kernel/trace

[PATCH v2 20/28] powerpc/ftrace: Use RCU in all users of __module_text_address().

2024-12-20 Thread Sebastian Andrzej Siewior
Ellerman Cc: Naveen N Rao Cc: Nicholas Piggin Cc: Steven Rostedt Cc: linux-trace-ker...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/trace/ftrace.c | 6 ++ arch/powerpc/kernel/trace/ftrace_64_pg.c | 6 ++ 2 files

[PATCH v2 01/28] module: Extend the preempt disabled section in dereference_symbol_descriptor().

2024-12-20 Thread Sebastian Andrzej Siewior
Cc: Michael Ellerman Cc: Naveen N Rao Cc: Nicholas Piggin Cc: Sergey Senozhatsky Cc: linux-par...@vger.kernel.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- include/linux/kallsyms.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/includ

Re: [PATCH v2 2/2] powerpc: Large user copy aware of full:rt:lazy preemption

2024-11-20 Thread Sebastian Andrzej Siewior
On 2024-11-19 13:08:31 [-0800], Ankur Arora wrote: > > Shrikanth Hegde writes: > > > Large user copy_to/from (more than 16 bytes) uses vmx instructions to > > speed things up. Once the copy is done, it makes sense to try schedule > > as soon as possible for preemptible kernels. So do this for >

Re: [PATCH v2 2/2] powerpc: Large user copy aware of full:rt:lazy preemption

2024-11-20 Thread Sebastian Andrzej Siewior
nd rt kernel. > > Not checking for lazy bit here, since it could lead to unnecessary > context switches. > > Suggested-by: Sebastian Andrzej Siewior > Signed-off-by: Shrikanth Hegde > --- > arch/powerpc/lib/vmx-helper.c | 2 +- > 1 file changed, 1 insertion(+

Re: [PATCH] powerpc: Add preempt lazy support

2024-11-08 Thread Sebastian Andrzej Siewior
dda-c79e-4d95-935b-e4b93eb07...@linux.ibm.com/ The lazy bits are only in tip. Reviewed-by: Sebastian Andrzej Siewior > Signed-off-by: Shrikanth Hegde > --- > diff --git a/arch/powerpc/kernel/interrupt.c b/arch/powerpc/kernel/interrupt.c > index af62ec974b97..8f4acc55407b 100644

[PATCH] powerpc/imc-pmu: Use the correct spinlock initializer.

2023-03-09 Thread Sebastian Andrzej Siewior
abled section") Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/perf/imc-pmu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/perf/imc-pmu.c b/arch/powerpc/perf/imc-pmu.c index 9d229ef7f86ef..ada817c49b722 100644 --- a/arch/powerpc/perf/imc-pmu.c

[PATCH] powerpc/pseries: Select the generic memory allocator.

2023-03-09 Thread Sebastian Andrzej Siewior
The RTAS work area allocator is using the generic memory allocator and as such it must select it. Select the generic memory allocator on pseries. Fixes: 43033bc62d349 ("powerpc/pseries: add RTAS work area allocator") Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/platfor

Re: [RFC PATCH RESEND 04/28] mm: move mmap_lock assert function definitions

2022-09-01 Thread Sebastian Andrzej Siewior
On 2022-09-01 16:24:09 [-0400], Kent Overstreet wrote: > > --- a/include/linux/mmap_lock.h > > +++ b/include/linux/mmap_lock.h > > @@ -60,6 +60,18 @@ static inline void __mmap_lock_trace_released(struct > > mm_struct *mm, bool write) > > > > #endif /* CONFIG_TRACING */ > > > > +static inline

Re: [PATCH] arch/*: Disable softirq stacks on PREEMPT_RT.

2022-06-17 Thread Sebastian Andrzej Siewior
On 2022-06-15 17:41:45 [+0200], Arnd Bergmann wrote: > Applied to the asm-generic tree with the above fixup, thanks! Thank you Arnd. > Arnd Sebastian

[PATCH] arch/*: Disable softirq stacks on PREEMPT_RT.

2022-06-14 Thread Sebastian Andrzej Siewior
Andrzej Siewior --- Initially I aimed only for the asm-generic bits and arm since I have most bits of the port ready. Arnd then suggested to do all arches at once and here it is. I tried to keep it minimal in sense that I didn't remove the dedicated softirq-stacks on parisc or powerpc for ins

Re: [PATCH 09/10] scsi/ibmvscsi: Replace srp tasklet with work

2022-06-14 Thread 'Sebastian Andrzej Siewior'
On 2022-06-09 15:46:04 [+], David Laight wrote: > From: Sebastian Andrzej Siewior > > Sent: 09 June 2022 16:03 > > > > On 2022-05-30 16:15:11 [-0700], Davidlohr Bueso wrote: > > > Tasklets have long been deprecated as being too heavy on the system > > >

Re: [PATCH 09/10] scsi/ibmvscsi: Replace srp tasklet with work

2022-06-09 Thread Sebastian Andrzej Siewior
On 2022-05-30 16:15:11 [-0700], Davidlohr Bueso wrote: > Tasklets have long been deprecated as being too heavy on the system > by running in irq context - and this is not a performance critical > path. If a higher priority process wants to run, it must wait for > the tasklet to finish before doing

Re: [PATCH 08/10] scsi/ibmvfc: Replace tasklet with work

2022-06-09 Thread Sebastian Andrzej Siewior
On 2022-05-30 16:15:10 [-0700], Davidlohr Bueso wrote: > diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c > index d0eab5700dc5..31b1900489e7 100644 > --- a/drivers/scsi/ibmvscsi/ibmvfc.c > +++ b/drivers/scsi/ibmvscsi/ibmvfc.c > @@ -891,7 +891,7 @@ static void ibmvfc_rele

Re: [PATCH 06/10] scsi/ibmvscsi_tgt: Replace work tasklet with threaded irq

2022-06-03 Thread Sebastian Andrzej Siewior
On 2022-05-30 16:15:08 [-0700], Davidlohr Bueso wrote: > diff --git a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > index eee1a24f7e15..fafadb7158a3 100644 > --- a/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c > +++ b/drivers/scsi/ibmvscsi_tgt/ibmvscsi_tgt.c >

[PATCH 11/11] locking: Allow to include asm/spinlock_types.h from linux/spinlock_types_raw.h

2021-11-29 Thread Sebastian Andrzej Siewior
ernel.org Cc: linux...@vger.kernel.org Cc: linux-xte...@linux-xtensa.org Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- arch/alpha/include/asm/spinlock_types.h | 2 +- arch/arm/include/asm/spinlock_types.h| 2 +- arch/arm64/include/asm/spinlock_t

Re: [PATCH 00/38] Replace deprecated CPU-hotplug

2021-08-03 Thread Sebastian Andrzej Siewior
On 2021-08-03 17:30:40 [+0200], Hans de Goede wrote: > Hi Sebastien, Hi Hans, > On 8/3/21 4:15 PM, Sebastian Andrzej Siewior wrote: > > This is a tree wide replacement of the deprecated CPU hotplug functions > > which are only wrappers around the actual functions. >

[PATCH 00/38] Replace deprecated CPU-hotplug

2021-08-03 Thread Sebastian Andrzej Siewior
This is a tree wide replacement of the deprecated CPU hotplug functions which are only wrappers around the actual functions. Each patch is independent and can be picked up by the relevant maintainer. Cc: Alexander Shishkin Cc: Amit Kucheria Cc: Andrew Morton Cc: Andy Lutomirski Cc: Arnaldo Ca

[PATCH 03/38] powerpc: Replace deprecated CPU-hotplug functions.

2021-08-03 Thread Sebastian Andrzej Siewior
: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: linuxppc-dev@lists.ozlabs.org Cc: kvm-...@vger.kernel.org Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/rtasd.c | 4 ++-- arch/powerpc/kvm/book3s_hv_builtin.c | 10 +- arch/powerpc/platforms/powernv/idle.c

[PATCH] powerpc/mm: Move the linear_mapping_mutex to the ifdef where it is used

2021-02-19 Thread Sebastian Andrzej Siewior
linear_mapping_mutex to ifdef block where it is used. Fixes: 1f73ad3e8d755 ("powerpc/mm: print warning in arch_remove_linear_mapping()") Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/mm/mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/

Re: [patch V3 13/37] mips/mm/highmem: Switch to generic kmap atomic

2021-01-11 Thread Sebastian Andrzej Siewior
On 2021-01-09 01:33:52 [+0100], Thomas Bogendoerfer wrote: > On Sat, Jan 09, 2021 at 12:58:05AM +0100, Thomas Bogendoerfer wrote: > > On Fri, Jan 08, 2021 at 08:20:43PM +, Paul Cercueil wrote: > > > Hi Thomas, > > > > > > 5.11 does not boot anymore on Ingenic SoCs, I bisected it to this commit

Re: [patch V3 10/37] ARM: highmem: Switch to generic kmap atomic

2020-11-12 Thread Sebastian Andrzej Siewior
On 2020-11-12 09:10:34 [+0100], Marek Szyprowski wrote: > I can do more tests to help fixing this issue. Just let me know what to do. -> https://lkml.kernel.org/r/87y2j6n8mj@nanos.tec.linutronix.de Sebastian

[PATCH v2 net-next 3/3] crypto: caam: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `sched_napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Ay

[PATCH v2 net-next 2/3] net: dpaa: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `sched_napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Ay

[PATCH v2 net-next 1/3] soc/fsl/qbman: Add an argument to signal if NAPI processing is required.

2020-11-01 Thread Sebastian Andrzej Siewior
he value to the caller including `qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert XS Cc: "David S. Miller" Cc: Madalin Bucur Cc: Jakub Kicins

Re: [PATCH net-next 14/15] net: dpaa: Replace in_irq() usage.

2020-11-01 Thread Sebastian Andrzej Siewior
On 2020-10-31 10:12:15 [-0700], Jakub Kicinski wrote: > Nit: some networking drivers have a bool napi which means "are we > running in napi context", the semantics here feel a little backwards, > at least to me. But if I'm the only one thinking this, so be it. I renamed it to `sched_napi'. Sebast

[PATCH net-next 13/15] soc/fsl/qbman: Add an argument to signal if NAPI processing is required.

2020-10-27 Thread Sebastian Andrzej Siewior
he value to the caller including `qman_cb_dqrr' typedef which is used by the dpaa and the crypto driver. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier Cc: Herbert Xu Cc: "David S. Miller" Cc: Madalin Bucur Cc: Jakub Kicins

[PATCH net-next 14/15] net: dpaa: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier

[PATCH net-next 12/15] net: rtlwifi: Remove in_interrupt() usage in halbtc_send_bt_mp_operation()

2020-10-27 Thread Sebastian Andrzej Siewior
t_coex_supported_feature() None of these have a caller. Welcome to the wonderful world of HALs and onion layers. Remove in_interrupt() check. Signed-off-by: Sebastian Andrzej Siewior Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.ker

[PATCH net-next 15/15] crypto: caam: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
conveyed in an argument passed by the caller, which usually knows the context. Use the `napi' argument passed by the callback. It is set true if called from the interrupt handler and NAPI should be scheduled. Signed-off-by: Sebastian Andrzej Siewior Cc: "Horia Geantă" Cc: Aymen Sghaier

[PATCH net-next 08/15] net: airo: Replace in_atomic() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
x27;s pointless to invoke schedule() if there is no request to reschedule. Pass the may_sleep condition through the various call chains leading to issuecommand(). Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.ker

[PATCH net-next 11/15] net: rtlwifi: Remove in_interrupt() usage in is_any_client_connect_to_ap().

2020-10-27 Thread Sebastian Andrzej Siewior
code further use list_empty() instead of walking the list and counting the entries just to check the count for > 0 at the end. Signed-off-by: Sebastian Andrzej Siewior Cc: Ping-Ke Shih Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kerne

[PATCH net-next 09/15] net: hostap: Remove in_atomic() check.

2020-10-27 Thread Sebastian Andrzej Siewior
Sebastian Andrzej Siewior Cc: Jouni Malinen Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org --- drivers/net/wireless/intersil/hostap/hostap_ioctl.c | 13 + 1 file changed, 1 insertion(+), 12 deletions(-)

[PATCH net-next 10/15] net: zd1211rw: Remove in_atomic() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
Andrzej Siewior Cc: Daniel Drake Cc: Ulrich Kunitz Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org --- drivers/net/wireless/zydas/zd1211rw/zd_usb.c | 15 --- 1 file changed, 15 deletions(-) diff --git

[PATCH net-next 07/15] net: airo: Always use JOB_STATS and JOB_EVENT

2020-10-27 Thread Sebastian Andrzej Siewior
context through a quite large amount of functions. As this is ancient hardware, avoid the churn and enforce the invocation of those functions through the JOB machinery. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: l

[PATCH net-next 04/15] net: mlx5: Replace in_irq() usage.

2020-10-27 Thread Sebastian Andrzej Siewior
Andrzej Siewior Cc: Saeed Mahameed Cc: Leon Romanovsky Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-r...@vger.kernel.org --- drivers/net/ethernet/mellanox/mlx5/core/eq.c | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/drivers/net/ethernet/mel

[PATCH net-next 06/15] net: airo: Invoke airo_read_wireless_stats() directly

2020-10-27 Thread Sebastian Andrzej Siewior
y. Invoke airo_read_wireless_stats() directly from the callback and remove the now unused JOB_WSTATS handling. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicinski Cc: linux-wirel...@vger.kernel.org Cc: net...@vger.kernel.org --- driver

[PATCH net-next 03/15] net: forcedeth: Replace context and lock check with a lockdep_assert()

2020-10-27 Thread Sebastian Andrzej Siewior
replace the warning and the lock assert with lockdep_assert_held(). Signed-off-by: Sebastian Andrzej Siewior Cc: Rain River Cc: Zhu Yanjun Cc: "David S. Miller" Cc: Jakub Kicinski Cc: net...@vger.kernel.org --- drivers/net/ethernet/nvidia/forcedeth.c | 6 +- 1 file changed, 1

[PATCH net-next 05/15] net: tlan: Replace in_irq() usage

2020-10-27 Thread Sebastian Andrzej Siewior
(), tlan_mii_write_reg() and tlan_phy_print() are invoked from interrupt and other contexts. Split out the actual function body into helper variants which are called from interrupt context and make the original functions wrappers which acquire tlan_priv::lock unconditionally. Signed-off-by: Sebastian Andrzej Siewior

[PATCH net-next 02/15] net: neterion: s2io: Replace in_interrupt() for context detection

2020-10-27 Thread Sebastian Andrzej Siewior
et_rx_mode() s2io_set_multicast() s2io_txpic_intr_handle() s2io_link() init_tti() Add a may_sleep argument to wait_for_cmd_complete(), s2io_set_multicast() and init_tti() and hand the context information in from the call sites. Signed-off-by: Sebastian Andrzej Siewior Cc: Jon

[PATCH net-next 01/15] net: orinoco: Remove BUG_ON(in_interrupt/irq())

2020-10-27 Thread Sebastian Andrzej Siewior
n the invoked functions (always enabled or debug option dependent) cover these conditions already, so the BUG_ON()'s do not really provide additional value. Just remove them. Signed-off-by: Sebastian Andrzej Siewior Cc: Kalle Valo Cc: "David S. Miller" Cc: Jakub Kicin

[PATCH net-next 00/15] in_interrupt() cleanup, part 2

2020-10-27 Thread Sebastian Andrzej Siewior
Folks, in the discussion about preempt count consistency across kernel configurations: https://lore.kernel.org/r/20200914204209.256266...@linutronix.de/ Linus clearly requested that code in drivers and libraries which changes behaviour based on execution context should either be split up so th

[PATCH 4/5] ia64: Remove mm.h from asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
Fenghua Yu Cc: linux-i...@vger.kernel.org Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior --- arch/ia64/include/asm/uaccess.h | 1 - arch/ia64/kernel/process.c | 1 + arch/ia64/mm/ioremap.c | 1 + 3 files changed, 2 insertions(+), 1 deletion(-) diff --git a

[PATCH 1/5] nds32: Remove mm.h from asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
eentime Hu Cc: Vincent Chen Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior --- arch/nds32/include/asm/uaccess.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/nds32/include/asm/uaccess.h b/arch/nds32/include/asm/uaccess.h index 8916ad9f9f139..3a9219f53ee0d 10

[PATCH 2/5] csky: Remove mm.h from asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
c: linux-c...@vger.kernel.org Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior --- arch/csky/include/asm/uaccess.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/csky/include/asm/uaccess.h b/arch/csky/include/asm/uaccess.h index eaa1c3403a424..abefa125b93cf 100644 --- a

[PATCH 3/5] hexagon: Remove mm.h from asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
Cc: linux-hexa...@vger.kernel.org Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior --- arch/hexagon/include/asm/uaccess.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/hexagon/include/asm/uaccess.h b/arch/hexagon/include/asm/uaccess.h index 00cb38faad0c4..c10

[PATCH 0/5] Remove mm.h from arch/*/include/asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
The following mini-series removes linux/mm.h from the asm/uaccess.h of the individual architecture. The series has been compile tested with the defconfig and additionally for ia64 with the "special" allmodconfig supplied by the bot. The regular allmod for the architectures does not compile (even wi

[PATCH 5/5] microblaze: Remove mm.h from asm/uaccess.h

2020-03-20 Thread Sebastian Andrzej Siewior
chal Simek Reported-by: kbuild test robot Signed-off-by: Sebastian Andrzej Siewior --- arch/microblaze/include/asm/uaccess.h | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/microblaze/include/asm/uaccess.h b/arch/microblaze/include/asm/uaccess.h index a1f206b90753a..4916d5fbea5e3 100644

Re: [PATCH 19/15] sched/swait: Reword some of the main description

2020-03-20 Thread Sebastian Andrzej Siewior
On 2020-03-20 01:55:27 [-0700], Davidlohr Bueso wrote: > diff --git a/include/linux/swait.h b/include/linux/swait.h > index 73e06e9986d4..6e5b5d0e64fd 100644 > --- a/include/linux/swait.h > +++ b/include/linux/swait.h > @@ -39,7 +26,7 @@ > *sleeper state. > * > * - the !exclusive mode; b

Re: [PATCH 17/15] rcuwait: Inform rcuwait_wake_up() users if a wakeup was attempted

2020-03-20 Thread Sebastian Andrzej Siewior
On 2020-03-20 01:55:25 [-0700], Davidlohr Bueso wrote: > Let the caller know if wake_up_process() was actually called or not; > some users can use this information for ad-hoc. Of course returning > true does not guarantee that wake_up_process() actually woke anything > up. Wouldn't it make sense t

Re: [patch V2 06/15] rcuwait: Add @state argument to rcuwait_wait_event()

2020-03-20 Thread Sebastian Andrzej Siewior
On 2020-03-19 22:36:57 [-0700], Davidlohr Bueso wrote: > On Wed, 18 Mar 2020, Thomas Gleixner wrote: > > Right now I'm not sure what the proper fix should be. I though that v2 has it fixed with the previous commit (acpi: Remove header dependency). The kbot just reported that everything is fine. L

Re: [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait

2020-03-19 Thread Sebastian Andrzej Siewior
On 2020-03-19 03:04:59 [-0700], Christoph Hellwig wrote: > But I wonder how alive the whole PS3 support is to start with.. OtherOS can only be used on "old" PS3 which do not have have their firmware upgraded past version 3.21, released April 1, 2010 [0]. It was not possible to install OtherOS on P

Re: [patch V2 07/15] powerpc/ps3: Convert half completion to rcuwait

2020-03-19 Thread Sebastian Andrzej Siewior
On 2020-03-18 21:43:09 [+0100], Thomas Gleixner wrote: > --- a/arch/powerpc/platforms/ps3/device-init.c > +++ b/arch/powerpc/platforms/ps3/device-init.c > @@ -725,12 +728,12 @@ static int ps3_notification_read_write(s > unsigned long flags; > int res; > > - init_completion(&dev->d

Re: [RFC] per-CPU usage in perf core-book3s

2020-02-05 Thread Sebastian Andrzej Siewior
On 2020-02-05 07:10:59 [+0530], maddy wrote: > Yes, currently we dont have anything that prevents the timer > callback to interrupt pmu::event_init. Nice catch. Thanks for > pointing this out. You are welcome. > Looking at the code, per-cpu variable access are made to > check for constraints and

[RFC] per-CPU usage in perf core-book3s

2020-01-27 Thread Sebastian Andrzej Siewior
I've been looking at usage of per-CPU variable cpu_hw_events in arch/powerpc/perf/core-book3s.c. power_pmu_enable() and power_pmu_disable() (pmu::pmu_enable() and pmu::pmu_disable()) are accessing the variable and the callbacks are invoked always with disabled interrupts. power_pmu_event_init() (

[PATCH] powerpc/85xx: Get twr_p102x to compile again

2019-12-19 Thread Sebastian Andrzej Siewior
With CONFIG_QUICC_ENGINE enabled and CONFIG_UCC_GETH + CONFIG_SERIAL_QE disabled we have an unused variable (np). The code won't compile with -Werror. Move the np variable to the block where it is actually used. Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/platforms

Re: [Qemu-ppc] pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-12-19 Thread Sebastian Andrzej Siewior
On 2019-12-19 11:41:21 [+0100], Jason A. Donenfeld wrote: > Hi folks, Hi, so this should duct tape it: diff --git a/arch/powerpc/kernel/dbell.c b/arch/powerpc/kernel/dbell.c index f17ff1200eaae..ec044bdf362a1 100644 --- a/arch/powerpc/kernel/dbell.c +++ b/arch/powerpc/kernel/dbell.c @@ -60,16 +60

Re: [RFC] Efficiency of the phandle_cache on ppc64/SLOF

2019-12-09 Thread Sebastian Andrzej Siewior
On 2019-12-05 20:01:41 [-0600], Frank Rowand wrote: > Is there a memory usage issue for the systems that led to this thread? No, no memory issue led to this thread. I was just testing my patch and I assumed that I did something wrong in the counting/lock drop/lock acquire/allocate path because the

Re: [RFC] Efficiency of the phandle_cache on ppc64/SLOF

2019-12-05 Thread Sebastian Andrzej Siewior
On 2019-12-03 10:56:35 [-0600], Rob Herring wrote: > > Another possibility would be to make the cache be dependent > > upon not CONFIG_PPC. It might be possible to disable the > > cache with a minimal code change. > > I'd rather not do that. > > And yes, as mentioned earlier I don't like the com

Re: [RFC] Efficiency of the phandle_cache on ppc64/SLOF

2019-12-02 Thread Sebastian Andrzej Siewior
On 2019-11-29 20:14:47 [-0600], Frank Rowand wrote: > The hash used is based on the assumptions you noted, and as stated in the > code, that phandle property values are in a contiguous range of 1..n > (not starting from zero), which is what dtc generates. > > We knew that for systems that do not m

[RFC] Efficiency of the phandle_cache on ppc64/SLOF

2019-11-29 Thread Sebastian Andrzej Siewior
I've been looking at phandle_cache and noticed the following: The raw phandle value as generated by dtc starts at zero and is incremented by one for each phandle entry. The qemu pSeries model is using Slof (which is probably the same thing as used on real hardware) and this looks like a poiner valu

[PATCH 03/34 v3] powerpc: Use CONFIG_PREEMPTION

2019-10-24 Thread Sebastian Andrzej Siewior
Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Thomas Gleixner [bigeasy: +Kconfig] Signed-off-by: Sebastian Andrzej Siewior --- v2…v3: Don't mention die.c changes in the description. v1…v2: Remove the changes to die.c. arch/powerpc/Kconfig | 2 +- arch/po

[PATCH 03/34 v2] powerpc: Use CONFIG_PREEMPTION

2019-10-24 Thread Sebastian Andrzej Siewior
Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Thomas Gleixner [bigeasy: +Kconfig] Signed-off-by: Sebastian Andrzej Siewior --- v1…v2: Remove the changes to die.c arch/powerpc/Kconfig | 2 +- arch/powerpc/kernel/entry_32.S | 4

Re: [PATCH 03/34] powerpc: Use CONFIG_PREEMPTION

2019-10-16 Thread Sebastian Andrzej Siewior
On 2019-10-16 20:33:08 [+1100], Michael Ellerman wrote: > Christophe Leroy writes: > > Le 15/10/2019 à 21:17, Sebastian Andrzej Siewior a écrit : > >> From: Thomas Gleixner > >> > >> CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by CONFIG_PREEMPT_

Re: [PATCH 03/34] powerpc: Use CONFIG_PREEMPTION

2019-10-16 Thread Sebastian Andrzej Siewior
On 2019-10-16 06:57:48 [+0200], Christophe Leroy wrote: > > > Le 15/10/2019 à 21:17, Sebastian Andrzej Siewior a écrit : > > From: Thomas Gleixner > > > > CONFIG_PREEMPTION is selected by CONFIG_PREEMPT and by CONFIG_PREEMPT_RT. > > Both PREEMPT and PREEMPT_

[PATCH 03/34] powerpc: Use CONFIG_PREEMPTION

2019-10-15 Thread Sebastian Andrzej Siewior
Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Thomas Gleixner [bigeasy: +traps.c, Kconfig] Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/Kconfig | 2 +- arch/powerpc/kernel/entry_32.S | 4 ++-- arch/powerpc/kernel

Re: [Qemu-ppc] pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-04-05 Thread Sebastian Andrzej Siewior
On 2019-04-05 02:25:44 [+1000], Nicholas Piggin wrote: > Sebastian, are you able to test if this patch solves your problem? yes, it does. Tested-by: Sebastian Andrzej Siewior > Thanks, > Nick Sebastian

Re: [Qemu-ppc] pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-03-29 Thread Sebastian Andrzej Siewior
On 2019-03-29 16:20:51 [+1100], Suraj Jitindar Singh wrote: > > Yeah the kernel must have used msgsndp which isn't implemented for TCG > yet. We use doorbells in linux but only for threads which are on the > same core. It is msgsndp as per instruction decode. > And when I try to construct a situ

pseries on qemu-system-ppc64le crashes in doorbell_core_ipi()

2019-03-27 Thread Sebastian Andrzej Siewior
With qemu-system-ppc64le -machine pseries -smp 4 I get: |# chrt 1 hackbench |Running in process mode with 10 groups using 40 file descriptors each (== 400 tasks) |Each sender will pass 100 messages of 100 bytes | Oops: Exception in kernel mode, sig: 4 [#1] | LE PAGE_SIZE=64K MMU=Hash PREEMPT SMP

[PATCH 17/22] KVM/PPC/Book3S HV: Convert to hotplug state machine

2016-11-26 Thread Sebastian Andrzej Siewior
org Signed-off-by: Anna-Maria Gleixner Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kvm/book3s_hv.c | 48 ++-- include/linux/cpuhotplug.h | 1 + 2 files changed, 12 insertions(+), 37 deletions(-) diff --git a/arch/powerpc/kvm/book3s_hv.c b/ar

[PATCH 16/20] powerpc/sysfs: Convert to hotplug state machine

2016-11-17 Thread Sebastian Andrzej Siewior
hotplug call symmetric. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/kernel/sysfs.c | 50 + 1 file changed, 10 insertions(+), 40 deletions

[PATCH 16/16] powerpc: mmu nohash: Convert to hotplug state machine

2016-08-18 Thread Sebastian Andrzej Siewior
Install the callbacks via the state machine. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/mm/mmu_context_nohash.c | 54 +++- include/linux

[PATCH 15/16] powerpc: powermac: Convert to hotplug state machine

2016-08-18 Thread Sebastian Andrzej Siewior
online callback twice due to rollback. Cc: Benjamin Herrenschmidt Cc: Paul Mackerras Cc: Michael Ellerman Cc: linuxppc-dev@lists.ozlabs.org Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/platforms/powermac/smp.c | 50 +-- include/linux/cpuhotplug.h

[PATCH v2] powerpc/numa: Convert to hotplug state machine

2016-07-18 Thread Sebastian Andrzej Siewior
Install the callbacks via the state machine and let the core invoke the callbacks on the already online CPUs. v1…v2: manual callback invocation on boot-CPU (cpuhp is not up yet and we need them all before additional CPUs are up). Signed-off-by: Sebastian Andrzej Siewior Cc: Andrew Morton

Re: [patch V2 30/67] powerpc/numa: Convert to hotplug state machine

2016-07-15 Thread Sebastian Andrzej Siewior
* Anton Blanchard | 2016-07-15 10:28:25 [+1000]: >Hi Anna-Maria, Hi Anton, >> >> Install the callbacks via the state machine and let the core invoke >> >> the callbacks on the already online CPUs. >> > >> > This is causing an oops on ppc64le QEMU, looks like a NULL >> > pointer: >> >> Did yo

Re: [PATCH v2] powerpc: mm: fixup preempt undefflow with huge pages

2016-03-30 Thread Sebastian Andrzej Siewior
On 03/30/2016 02:41 AM, Michael Ellerman wrote: > The merge window just closed, I'm still recovering. > > I've got it in my fixes branch locally, I'll probably push that today to > linux-next. Thank you. > > cheers > Sebastian ___ Linuxppc-dev mailin

Re: [PATCH v2] powerpc: mm: fixup preempt undefflow with huge pages

2016-03-29 Thread Sebastian Andrzej Siewior
On 2016-03-10 01:04:24 [+0530], Aneesh Kumar K.V wrote: > Sebastian Andrzej Siewior writes: *ping* http://patchwork.ozlabs.org/patch/593943/ > > [ text/plain ] > > hugepd_free() used __get_cpu_var() once. Nothing ensured that the code > > accessing the variable did not mi

[PATCH v2] powerpc: mm: fixup preempt undefflow with huge pages

2016-03-08 Thread Sebastian Andrzej Siewior
(). So now we have a put_cpu_var() which does a preempt_enable() and nothing that does preempt_disable() so we underflow the preempt counter. Cc: Benjamin Herrenschmidt Cc: Christoph Lameter Cc: Michael Ellerman Cc: Signed-off-by: Sebastian Andrzej Siewior --- v1…v2: - use get_cpu_var() in

Re: [PATCH] powerpc: mm: fixup preempt undefflow with huge pages

2016-03-08 Thread Sebastian Andrzej Siewior
On 03/08/2016 12:41 AM, Benjamin Herrenschmidt wrote: > On Mon, 2016-03-07 at 21:04 +0530, Aneesh Kumar K.V wrote: >> Sebastian Andrzej Siewior writes: >> >> While you are there, can you also fix the wrong indentation on line >> 423 >> ? > > .../... &g

[PATCH] powerpc: mm: fixup preempt undefflow with huge pages

2016-03-07 Thread Sebastian Andrzej Siewior
(). So now we have a put_cpu_var() which does a preempt_enable() and nothing that does preempt_disable() so we underflow the preempt counter. Cc: Benjamin Herrenschmidt Cc: Christoph Lameter Cc: Michael Ellerman Cc: Tiejun Chen Cc: Signed-off-by: Sebastian Andrzej Siewior --- arch/powerpc/

Re: [PATCH v2 2/2] powerpc/kvm: Disable in-kernel MPIC emulation for PREEMPT_RT_FULL

2015-05-14 Thread Sebastian Andrzej Siewior
* Bogdan Purcareata | 2015-04-24 15:53:13 [+]: >While converting the openpic emulation code to use a raw_spinlock_t enables >guests to run on RT, there's still a performance issue. For interrupts sent in >Signed-off-by: Bogdan Purcareata Applied with Scott's Acked-by Sebastian

Re: [PATCH v2 0/2] powerpc/kvm: Enable running guests on RT Linux

2015-05-14 Thread Sebastian Andrzej Siewior
* Bogdan Purcareata | 2015-04-24 15:53:11 [+]: >0001: converts the openpic spinlock to a raw spinlock, in order to circumvent >0002: disables in-kernel MPIC emulation for guest running on RT, in order to Scott, I'm asking here for your explicit Acked-by on those two patches. That you want it

Re: [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux

2015-02-26 Thread Sebastian Andrzej Siewior
On 02/26/2015 02:02 PM, Paolo Bonzini wrote: > > > On 24/02/2015 00:27, Scott Wood wrote: >> This isn't a host PIC driver. It's guest PIC emulation, some of which >> is indeed not suitable for a rawlock (in particular, openpic_update_irq >> which loops on the number of vcpus, with a loop body th

Re: [PATCH 0/2] powerpc/kvm: Enable running guests on RT Linux

2015-02-25 Thread Sebastian Andrzej Siewior
* Scott Wood | 2015-02-23 17:27:31 [-0600]: >This isn't a host PIC driver. It's guest PIC emulation, some of which >is indeed not suitable for a rawlock (in particular, openpic_update_irq >which loops on the number of vcpus, with a loop body that calls >IRQ_check() which loops over all pending IR

  1   2   3   >