On Tue, Mar 29, 2011 at 10:58:54AM +1100, Benjamin Herrenschmidt wrote:
> On Mon, 2011-03-28 at 15:34 -0700, Sarah Sharp wrote:
> >
> > What I'd like to do is take out the read of the status register out of
> > the interrupt handler (which is killing performance), and
ci_handle_event() returns a negative
error status. If the status register shows the host controller has a
critical error, the driver should call usb_hcd_died().
Sarah Sharp
> {
> union xhci_trb *event;
> int update_ptrs = 1;
> @@ -2140,7 +2140,7 @@ static void xhci_handle_
//git.kernel.org/?p=linux/kernel/git/gregkh/usb-2.6.git;a=shortlog;h=refs/heads/usb-linus
Also, I haven't read too far into the patches, but the first patch seems
to have several one or two letter variable names, like "f" and "di".
Can you make those variable names more descripti
WARN_ON &
> message to aid debug if it can be recreated.
Hmm, that's interesting. I haven't seen any null pointer dereferences
during my tests, but perhaps I'm not being ADDH enough about randomly
unplugging devices. :) Let me know if you trigger this again.
Sarah Sharp
>
nce
per URB).
Sarah Sharp
> Signed-off-by: Matt Evans
> ---
> drivers/usb/host/xhci-dbg.c |2 +-
> drivers/usb/host/xhci-hub.c |3 +++
> drivers/usb/host/xhci-ring.c |5 +
> 3 files changed, 9 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host
This patch looks fine, thanks!
Sarah Sharp
On Mon, Mar 28, 2011 at 03:52:57PM +1100, Matt Evans wrote:
> On weakly-ordered systems, the reading of an event's content must occur
> after reading the event's validity.
>
> Signed-off-by: Matt Evans
> ---
> Se
