Re: [PATCH v13 5/5] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2025-01-14 Thread Sami Tolvanen
On Tue, Jan 14, 2025 at 10:22:15AM +0900, Masahiro Yamada wrote: > On Tue, Jan 14, 2025 at 5:04 AM Sami Tolvanen wrote: > > > > Hi Masahiro, > > > > On Fri, Jan 10, 2025 at 6:26 PM Masahiro Yamada > > wrote: > > > > > > On Sat, Jan 4, 2025 at

Re: [PATCH v13 5/5] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2025-01-13 Thread Sami Tolvanen
Hi Masahiro, On Fri, Jan 10, 2025 at 6:26 PM Masahiro Yamada wrote: > > On Sat, Jan 4, 2025 at 2:37 AM Matthew Maurer wrote: > > > > From: Sami Tolvanen > > > > Previously, two things stopped Rust from using MODVERSIONS: > > 1. Rust symbols are occasional

Re: [PATCH v7 0/3] Extended MODVERSIONS Support

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:27AM +, Matthew Maurer wrote: > This patch series is intended for use alongside the Implement DWARF > modversions series [1] to enable RUST and MODVERSIONS at the same > time. > > Elsewhere, we've seen a desire for long symbol name support for LTO > symbol names [

Re: [PATCH v7 3/3] rust: Use gendwarfksyms + extended modversions for CONFIG_MODVERSIONS

2024-10-24 Thread Sami Tolvanen
On Wed, Oct 23, 2024 at 02:31:30AM +, Matthew Maurer wrote: > From: Sami Tolvanen > > Previously, two things stopped Rust from using MODVERSIONS: > 1. Rust symbols are occasionally too long to be represented in the >original versions table > 2. Rust types cannot be prop

Re: [PATCH v7 2/3] modpost: Produce extended MODVERSIONS information

2024-10-24 Thread Sami Tolvanen
gt; Signed-off-by: Matthew Maurer Thanks for fixing this, LGTM. Reviewed-by: Sami Tolvanen Sami

Re: [PATCH v7 1/3] modules: Support extended MODVERSIONS info

2024-10-24 Thread Sami Tolvanen
we reproduce > the munging for the new format. Other architectures do not appear to > have architecture-specific usage of this information. > > Signed-off-by: Matthew Maurer Reviewed-by: Sami Tolvanen Sami

Re: [PATCH v5 14/16] modules: Support extended MODVERSIONS info

2024-09-26 Thread Sami Tolvanen
On Thu, Sep 26, 2024 at 5:22 AM Christophe Leroy wrote: > > > > Le 26/09/2024 à 01:38, Matthew Maurer a écrit : > > Adds a new format for MODVERSIONS which stores each field in a separate > > ELF section. This initially adds support for variable length names, but > > could later be used to add add

Re: [PATCH v4 14/16] modules: Support extended MODVERSIONS info

2024-09-25 Thread Sami Tolvanen
Hi Matt, On Tue, Sep 24, 2024 at 09:19:56PM +, Matthew Maurer wrote: > +static void dedotify_ext_version_names(char *str_seq, unsigned long size) > +{ > + unsigned long out = 0; > + unsigned long in; > + char last = '\0'; > + > + for (in = 0; in < size; in++) { > +

Re: [PATCH v3 14/16] modules: Support extended MODVERSIONS info

2024-08-15 Thread Sami Tolvanen
Hi Matt, On Tue, Aug 6, 2024 at 9:25 PM Matthew Maurer wrote: > [...] > +void modversion_ext_start(const struct load_info *info, > + struct modversion_info_ext *start) > +{ > + unsigned int crc_idx = info->index.vers_ext_crc; > + unsigned int name_idx = info->i