Re: [PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-22 Thread Rickard Strandqvist
2014-12-22 18:36 GMT+01:00 Nathan Whitehorn : > > On 12/22/14 09:26, Geoff Levand wrote: >> >> On Sat, 2014-12-20 at 16:00 +0100, Rickard Strandqvist wrote: >>> >>> Remove the function ps3_repository_write_highmem_info() that

Re: [PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-21 Thread Rickard Strandqvist
ed here: > static struct device_attribute afu_attrs[] = { > __ATTR_RO(mmio_size), > >> This was partially found by using a static code analysis program called >> cppcheck. > > Thanks for letting me know which tool to avoid :-) > > Mikey > >

[PATCH] arch: powerpc: platforms: embedded6xx: mpc7448_hpc2.c: Remove some unused functions

2014-12-20 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: mpc7448_hpc2_halt() mpc7448_hpc2_power_off() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/platforms/embedded6xx/mpc7448_hpc2.c | 11 --- 1 file

[PATCH] misc: cxl: sysfs.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function mmio_size_show() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/misc/cxl/sysfs.c | 11 --- 1 file changed, 11 deletions(-) diff --git a/drivers/misc/cxl

[PATCH] arch: powerpc: platforms: ps3: repository.c: Remove unused function

2014-12-20 Thread Rickard Strandqvist
Remove the function ps3_repository_write_highmem_info() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/platforms/ps3/platform.h |2 -- arch/powerpc/platforms/ps3

Re: [PATCH] arch: powerpc: kernel: signal_32.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Hi Ok, sorry :-( But I really do not. I've hacked together a script that will scan all the code for the function, and test builds with some different config options turned on. Kind regards Rickard Strandqvist 2014-12-07 23:18 GMT+01:00 Richard Weinberger : > Am 07.12.2014 um 23:07

[PATCH] arch: powerpc: kernel: vio.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function cmo_high_show() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/vio.c |5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kernel

[PATCH] arch: powerpc: kvm: book3s_paired_singles.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function inst_set_field() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kvm/book3s_paired_singles.c |8 1 file changed, 8 deletions(-) diff --git a/arch

[PATCH] arch: powerpc: kernel: smp.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function generic_mach_cpu_die() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/include/asm/smp.h |1 - arch/powerpc/kernel/smp.c | 14 -- 2 files

[PATCH] arch: powerpc: kernel: signal_32.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function sys_debug_setcontext() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/signal_32.c | 107 --- 1 file changed, 107

[PATCH] arch: powerpc: kernel: traps.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function vsx_assist_exception() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/traps.c | 15 --- 1 file changed, 15 deletions(-) diff --git a/arch

[PATCH] arch: powerpc: kvm: book3s_pr.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function get_fpr_index() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kvm/book3s_pr.c |5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kvm

[PATCH] arch: powerpc: mm: slice.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function slice_set_psize() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/mm/slice.c | 29 - 1 file changed, 29 deletions(-) diff --git a

[PATCH] arch: powerpc: kernel: sys_ppc32.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function compat_sys_mmap2() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/sys_ppc32.c |8 1 file changed, 8 deletions(-) diff --git a/arch/powerpc

[PATCH] arch: powerpc: kvm: book3s.c: Remove some unused functions

2014-12-07 Thread Rickard Strandqvist
Removes some functions that are not used anywhere: kvmppc_core_load_guest_debugstate() kvmppc_core_load_host_debugstate() This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kvm/book3s.c |8 arch

[PATCH] arch: powerpc: kvm: book3s_32_mmu.c: Remove unused function

2014-12-07 Thread Rickard Strandqvist
Remove the function sr_nx() that is not used anywhere. This was partially found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kvm/book3s_32_mmu.c |5 - 1 file changed, 5 deletions(-) diff --git a/arch/powerpc/kvm

[PATCH] arch: powerpc: sysdev: qe_lib: qe.c: Cleaning up in conjunction with strncpy and strcpy

2014-07-26 Thread Rickard Strandqvist
Replacing strcpy and strncpy with strlcpy to avoid strings that ar to big, or lacks null terminate. Signed-off-by: Rickard Strandqvist --- arch/powerpc/sysdev/qe_lib/qe.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/powerpc/sysdev/qe_lib/qe.c b/arch/powerpc

[PATCH] arch: powerpc: platforms: powermac: bootx_init.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-26 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And removed unnecessary magic numbers. Signed-off-by: Rickard Strandqvist --- arch/powerpc/platforms/powermac/bootx_init.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms

[PATCH] arch: powerpc: kernel: nvram_64.c: Cleaning up missing null-terminate in conjunction with strncpy

2014-07-26 Thread Rickard Strandqvist
Replacing strncpy with strlcpy to avoid strings that lacks null terminate. And removed unnecessary magic numbers. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/nvram_64.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/nvram_64.c b

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

2014-06-14 Thread Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it should be an unsigned int rather than a int. Signed-off-by: Rickard Strandqvist --- arch/powerpc/platforms/cell/cbe_thermal.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/powerpc/platforms/cell

[PATCH] arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong type

2014-06-14 Thread Rickard Strandqvist
This variable is of the wrong type, everywhere it is used it should be an unsigned int rather than a int. This was partly found using a static code analysis program called cppcheck. Rickard Strandqvist (1): arch: powerpc: platforms: cell: cbe_thermal.c: Cleaning up a variable is of the wrong

[PATCH] arch: powerpc: kernel: fadump.c: Cleaning up inconsistent NULL checks

2014-05-22 Thread Rickard Strandqvist
Cleaning up inconsistent NULL checks. There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- arch/powerpc/kernel/fadump.c |8 +--- 1 file changed, 5 insertions

[PATCH] macintosh: windfarm_pm121.c: Fix for possible null pointer dereference

2014-05-17 Thread Rickard Strandqvist
There is otherwise a risk of a possible null pointer dereference. Was largely found by using a static code analysis program called cppcheck. Signed-off-by: Rickard Strandqvist --- drivers/macintosh/windfarm_pm121.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff