Re: [PATCH v3] ALSA: aoa: convert bus code to use dev_groups

2015-06-12 Thread Quentin Lambert
On 12/06/2015 11:59, Andreas Schwab wrote: Quentin Lambert writes: The dev_attrs field of struct bus_type is going away, sue dev_groups instead. s/sue/use/ I meant use do you need to fix something else or should I resend with the typo correction ? Quentin

[PATCH v3] ALSA: aoa: convert bus code to use dev_groups

2015-06-12 Thread Quentin Lambert
The dev_attrs field of struct bus_type is going away, sue dev_groups instead. This converts the soundbus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- Changes since v2: - Revert to the version of the patch where the files

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

2015-06-12 Thread Quentin Lambert
On 11/06/2015 14:25, Takashi Iwai wrote: At Thu, 11 Jun 2015 14:04:45 +0200, Quentin Lambert wrote: On 11/06/2015 12:02, Takashi Iwai wrote: At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This

Re: [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

2015-06-11 Thread Quentin Lambert
On 11/06/2015 13:55, walter harms wrote: Am 11.06.2015 10:03, schrieb Quentin Lambert: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use the correct field. Given that all other usages of the macro define the struct attribute

Re: [alsa-devel] [PATCH v2] ALSA: aoa: convert bus code to use dev_groups

2015-06-11 Thread Quentin Lambert
On 11/06/2015 12:02, Takashi Iwai wrote: At Thu, 11 Jun 2015 10:03:38 +0200, Quentin Lambert wrote: The dev_attrs field of struct bus_type is going away, use dev_groups instead. This converts the soundbus code to use the correct field. Given that all other usages of the macro define the

[PATCH v2] ALSA: aoa: convert bus code to use dev_groups

2015-06-11 Thread Quentin Lambert
into core.c. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- Changes since v1: - Fix the commit message to actually talk about soundbus rather than MDIO - This version attempt to fix a problem resulting from the macro ATTRIBUTE_GROUPS declaring the

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-29 Thread Quentin Lambert
On 28/05/2015 17:01, Takashi Iwai wrote: Also, it'd be better to move ATTRIBUTE_GROUPS(soundbus_dev) into soundbus/sysfs.c, and make it this global instead of soundbus_dev_attrs[]. Ok, I need to find a nice way to do that because ATTRIBUTE_GROUPS declares the structure as static. If it resul

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 16:09, Takashi Iwai wrote: At Thu, 28 May 2015 15:59:50 +0200, Quentin Lambert wrote: On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed

Re: [PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
On 28/05/2015 15:52, Takashi Iwai wrote: At Thu, 28 May 2015 14:48:27 +0200, Quentin Lambert wrote: You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed

[PATCH] ALSA: aoa: convert bus code to use dev_groups

2015-05-28 Thread Quentin Lambert
You should use dev_groups instead of the dev_attrs field of struct bus_type. This converts the MDIO bus code to use the correct field. These modifications were made using Coccinelle. Signed-off-by: Quentin Lambert --- sound/aoa/soundbus/core.c |3 ++- sound/aoa/soundbus/soundbus.h