Re: [PATCH 1/2] powerpc: string: implement optimized memset variants

On 30 March 2017 at 12:46, Naveen N. Rao wrote: > Also, with a simple module to memset64() a 1GB vmalloc'ed buffer, here > are the results: > generic:0.245315533 seconds time elapsed( +- 1.83% ) > optimized: 0.169282701 seconds time elapsed( +- 1.96% ) Wondering wha

[PATCH v3] powerpc: sstep.c: Add modsw, moduw instruction emulation

Add modsw and moduw instruction emulation support to analyse_instr. modsw is an x-form instruction that calculates signed modulo of values stored in registers. moduw is similar to modsw but it works with unsigned values. Signed-off-by: PrasannaKumar Muralidharan Reviewed-by: Naveen N. Rao

Re: [PATCH v2] powerpc: sstep.c: Add modsw, moduw instruction emulation

>> Oh, I see. Should I send the patch again with the above change? If so >> should I mark it v3 or just v2? > > Easier for benh/mpe if you do ;) > Be sure to include my reviewed-by tag in your v3. Sure. I will send v3.

Re: [PATCH v2] powerpc: sstep.c: Add modsw, moduw instruction emulation

Hi Naveen, >> Add modsw and moduw instruction emulation support to analyse_instr. >> modsw is an x-form instruction that calculates signed modulo of values >> stored in registers. moduw is similar to modsw but it works with >> unsigned values. >> >> Changes in v2: >> Don't update CR register as th

[PATCH v2] powerpc: sstep.c: Add modsw, moduw instruction emulation

touch that Arrange extended opcode in numerical order Signed-off-by: PrasannaKumar Muralidharan --- arch/powerpc/lib/sstep.c | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index 9c78a9c..b0acdbc 100644 --- a/arch/powerpc/lib/sstep.c

Re: [PATCH] PPC: sstep.c: Add modsw, moduw instruction emulation

> By the way, I missed mentioning previously: please use 'powerpc: ' > prefix for the subject, rather than PPC. I will change it. Wondering how they are different. >> Add modsw and moduw instruction emulation support to analyse_instr. > > And, it will be better if you can briefly describe what th

Re: [PATCH] PPC: sstep.c: Add modsw, moduw instruction emulation

> I guessed as much, but if you look at the existing function, you'll see > that things have been arranged in numerical order. As such, it's best to > stick to that convention. Makes sense. Will do.

Re: [PATCH] PPC: sstep.c: Add modsw, moduw instruction emulation

Hi Naveen, Thanks for the review. >> --- >> arch/powerpc/lib/sstep.c | 9 + >> 1 file changed, 9 insertions(+) >> >> diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c >> index 9c78a9c..5acef72 100644 >> --- a/arch/powerpc/lib/sstep.c >> +++ b/arch/powerpc/lib/sstep.c >> @@

[PATCH] PPC: sstep.c: Add modsw, moduw instruction emulation

Add modsw and moduw instruction emulation support to analyse_instr. Signed-off-by: PrasannaKumar Muralidharan --- arch/powerpc/lib/sstep.c | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/powerpc/lib/sstep.c b/arch/powerpc/lib/sstep.c index 9c78a9c..5acef72 100644 --- a/arch

[PATCH] hwrng: pasemi-rng - Use linux/io.h instead of asm/io.h

Checkpatch.pl warns about usage of asm/io.h. Use linux/io.h instead. Signed-off-by: PrasannaKumar Muralidharan --- drivers/char/hw_random/pasemi-rng.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/char/hw_random/pasemi-rng.c b/drivers/char/hw_random/pasemi-rng.c

[PATCH v2] hwrng: pasemi_rng.c: Migrate to managed API

suggested by LABBE Corentin. CC: Darren Stevens Suggested-by: LABBE Corentin Signed-off-by: PrasannaKumar Muralidharan --- drivers/char/hw_random/pasemi-rng.c | 37 +++-- 1 file changed, 7 insertions(+), 30 deletions(-) diff --git a/drivers/char/hw_random/pasemi

Re: hwrng: pasemi_rng.c: Migrate to managed API

> I didn't explain well, There is a CFE command 'show devtree' here's the > relevant bits (I Hope) This is much simple than I expected. > [CFE ]CFE> show devtree > [/] > | #interrupt-cells val 0x0002 > | #address-cells val 0x0002 > | #size-cells

Re: hwrng: pasemi_rng.c: Migrate to managed API

Hi Darren, >> I wanted to use devm_ioremap_resource but could not find DT entry >> required for this driver in any of the .dts files. So did not change >> that. I could not find any dts/dtsi for this platform. So I assume >> that the dtb is not present in the kernel, dtb is supplied by the >> boot

Re: [PATCH] hwrng: pasemi_rng.c: Migrate to managed API

> I will propose to use devm_ioremap_resource() instead for removing this > hardcoded 0x100, but i cannot find any user of this driver in any dts. (And > so cannot check that this 0x100 is given in any DT resource node) > > Is this normal ? I wanted to use devm_ioremap_resource but could not fin

[PATCH] hwrng: pasemi_rng.c: Migrate to managed API

Use devm_ioremap and devm_hwrng_register instead of ioremap and hwrng_register. This removes unregistering and error handling code. This patch is not tested with hardware as I don't have access to it. Signed-off-by: PrasannaKumar Muralidharan --- drivers/char/hw_random/pasemi-rng.c