Re: [PATCH] [PATCH] powerpc/vio: use strcpy in modalias_show

2013-10-17 Thread Prarit Bhargava
On 10/17/2013 08:22 AM, David Laight wrote: >> Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of >> strcpy which can result in an overflow of newlines on the buffer. > ... >> --- a/arch/powerpc/kernel/vio.c >> +++ b/arch/powerpc/kernel/vio.c >> @@ -1531,12 +1531,12 @@ static

[PATCH] [PATCH] powerpc/vio: use strcpy in modalias_show

2013-10-17 Thread Prarit Bhargava
Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 used strcat instead of strcpy which can result in an overflow of newlines on the buffer. Signed-off-by: Prarit Bhargava Cc: b...@kernel.crashing.org Cc: b...@decadent.org.uk Cc: sta...@vger.kernel.org --- arch/powerpc/kernel/vio.c |4 ++-- 1

Re: [PATCH] powerpc/vio: Fix modalias_show return values

2013-10-17 Thread Prarit Bhargava
On 10/16/2013 11:53 PM, Ben Hutchings wrote: > Commit e82b89a6f19bae73fb064d1b3dd91fcefbb478f4 introduces a trivial > local denial of service. > >> --- a/arch/powerpc/kernel/vio.c >> +++ b/arch/powerpc/kernel/vio.c >> @@ -1351,11 +1351,15 @@ static ssize_t modalias_show(struct devi >> const

[PATCH] ppc, vio fix modalias_show return values

2013-09-23 Thread Prarit Bhargava
device cat: /sys/devices/vio/4001/modalias: No such device cat: /sys/devices/vio/4002/modalias: No such device cat: /sys/devices/vio/4004/modalias: No such device cat: /sys/devices/vio/modalias: No such device Signed-off-by: Prarit Bhargava Cc: Paul Mackerras Cc: Steve Best --- arch/powerpc/

[PATCH] ppc, vio fix modalias_show return values

2013-09-23 Thread Prarit Bhargava
device cat: /sys/devices/vio/4002/modalias: No such device cat: /sys/devices/vio/4004/modalias: No such device cat: /sys/devices/vio/modalias: No such device Signed-off-by: Prarit Bhargava --- arch/powerpc/kernel/vio.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git

[PATCH]: ppc: notifier_from_errno() cleanup

2011-01-13 Thread Prarit Bhargava
Minor cleanup of notifier_from_errno() in powerpc. notifier_from_errno() now contains the if(ret)/else conditional. There is no need to do it in the powerpc code. Signed-off-by: Prarit Bhargava diff --git a/arch/powerpc/platforms/pseries/cmm.c b/arch/powerpc/platforms/pseries/cmm.c index