Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

2022-06-20 Thread Pierluigi Passaro
> > > > Just for my understanding, are you suggesting to set a device tree > > > > property to force a fixed behavior in the driver ? > > > Yes. > > Why should we use a fixed behavior ? > The things that are fixed by the design should be fixed. > > > The device shares pins between the line inpu

Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

2022-06-20 Thread Pierluigi Passaro
> > Just for my understanding, are you suggesting to set a device tree > > property to force a fixed behavior in the driver ? > Yes. Why should we use a fixed behavior ? > > WM8904 allows using both a DMIC and LINEIN, switching between one or > > the other and this is how we currently use it. >

Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

2022-06-20 Thread Pierluigi Passaro
> > > Via firmware description. > > Can you please provide any reference approach in the kernel code ? > git grep of_ > git grep fwnode_ > and I don't immediately remember what the prefix is for ACPI functions. Just for my understanding, are you suggesting to set a device tree property to forc

Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

2022-06-20 Thread Pierluigi Passaro
> > > > +static const char *cin_text[] = { > > > > + "ADC", "DMIC" > > > > +}; > > > > +static SOC_ENUM_SINGLE_DECL(cin_enum, > > > > + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text); > > > Why would this be runtime selectable?  I'd expect the decision to use > > > an anal

Re: [PATCH 4/4] ASoC: wm8904: add DMIC support

2022-06-20 Thread Pierluigi Passaro
Hi All, > > +static const char *cin_text[] = { > > + "ADC", "DMIC" > > +}; > > + > > +static SOC_ENUM_SINGLE_DECL(cin_enum, > > + WM8904_DIGITAL_MICROPHONE_0, 12, cin_text); > > Why would this be runtime selectable?  I'd expect the decision to use > an analogue or digi

Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

2022-06-20 Thread Pierluigi Passaro
ovide any reference about "convert to DT schema" ? > > > > Signed-off-by: Pierluigi Passaro > > Signed-off-by: Alifer Moraes > > --- > >  .../devicetree/bindings/sound/wm8904.txt  |  53 > >  sound/soc/codecs/wm8904.c 

Re: [PATCH 3/4] ASoC: wm8904: extend device tree support

2022-06-20 Thread Pierluigi Passaro
Hi All, > > +  - num-drc-cfgs: Number of available DRC modes from drc-cfg-regs property > > + > > +  - drc-cfg-regs: Default registers value for R40/41/42/43 (DRC) > > +    The list must be (4 x num-drc-cfgs) entries long. > > +    If absent or incomplete, DRC is disabled. > > What is the purpose