Re: [PATCH v15 06/10] USB/ppc4xx: Add Synopsys DWC OTG HCD queue function

2011-10-20 Thread Philipp Ittershagen
Hello Tirumala, I have some coding style comments below. On Sat, Oct 15, 2011 at 12:09 AM, wrote: > From: Tirumala Marri > > Implements functions to manage Queue Heads and Queue > Transfer Descriptors of DWC USB OTG Controller. > > Signed-off-by: Tirumala R Marri > Signed-off-by: Fushen Che

Re: Loading Linux from already running code..

2011-09-26 Thread Philipp Ittershagen
On Mon, Sep 26, 2011 at 7:26 PM, Carlos Munoz wrote: > You could build a tarball containing the root files system, dtb, Linux, > plus a header indicating where the different pieces need to be loaded. > Then your initial code loads the different parts at the right memory > locations, sets up the Li

Re: Changes to of_device ?

2011-06-17 Thread Philipp Ittershagen
On 06/17/2011 02:57 PM, Philipp Ittershagen wrote: > The struct device_node was moved to struct device in order to make the > CONFIG_OF more generic. See > > commit d706c1b050274b3bf97d7cb0542c0d070c9ccb8b > Author: Grant Likely > Date: Tue Apr 13 16:12:28 2010 -0700 > &

Re: Changes to of_device ?

2011-06-17 Thread Philipp Ittershagen
On 06/17/2011 01:22 PM, Guillaume Dargaud wrote: >> Not answering your primary question here, but in order to print the most >> recent tag (along with a uniqe suffix, see man page) that is reachable >> from your current branch, you can use "git describe". It will print out >> the kernel version on

Re: Changes to of_device ?

2011-06-17 Thread Philipp Ittershagen
On 06/17/2011 11:19 AM, Guillaume Dargaud wrote: > [I'm on the latest Xilinx tree, FWIW, so that's 2.6.25 still ?] Not answering your primary question here, but in order to print the most recent tag (along with a uniqe suffix, see man page) that is reachable from your current branch, you can use "

Re: Early kernel debugging

2011-03-27 Thread Philipp Ittershagen
On 03/25/2011 09:50 AM, Guillaume Dargaud wrote: > Hello all, > what can you do when the kernel you try to run stops before printing anything > on the console ? http://elinux.org/Kernel_Debugging_Tips#Debugging_early_boot_problems Basically it means connecting a debugger to the running kernel (u

Re: [PATCH v3] PPC4xx: Adding PCI(E) MSI support

2010-12-04 Thread Philipp Ittershagen
Hi, a few nitpicks here. I don't have any clue about MSI, but I have seen some code-style related issues. On 12/04/2010 02:33 AM, tma...@apm.com wrote: > +static int ppc4xx_setup_msi_irqs(struct pci_dev *dev, int nvec, int type) > +{ > + int err = 0; > + int int_no = -ENOMEM; > + unsi

Re: Getting the IRQ number (Was: Basic driver devel questions ?)

2010-12-01 Thread Philipp Ittershagen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 12/01/2010 05:35 PM, Guillaume Dargaud wrote: > Now how do I connect the dots between the hardware definitions from the dts > and > my driver ? You can get the interrupt number from the dt by calling irq_of_parse_and_map(). Be sure to pass the no

Re: [PATCH][v1] powerpc/fsl: 85xx: add cache-sram support

2010-10-13 Thread Philipp Ittershagen
Hi Harninder, On Wed, 2010-10-13 at 14:47 +0530, harninder@freescale.com wrote: > +int __init instantiate_cache_sram(struct platform_device *dev, > + struct sram_parameters sram_params) > +{ > + if (cache_sram) { > + dev_err(&dev->dev, "Already initialized cache-sra