Re: [RFC PATCH v11 00/29] KVM: guest_memfd() and per-page attributes

2023-07-26 Thread Nikunj A. Dadhania
On 7/26/2023 7:54 PM, Sean Christopherson wrote: > On Wed, Jul 26, 2023, Nikunj A. Dadhania wrote: >> On 7/24/2023 10:30 PM, Sean Christopherson wrote: >>>> /proc//smaps >>>> 7f528be0-7f5c8be0 rw-p 00:01 26629 >&g

Re: [RFC PATCH v11 00/29] KVM: guest_memfd() and per-page attributes

2023-07-26 Thread Nikunj A. Dadhania
Hi Sean, On 7/24/2023 10:30 PM, Sean Christopherson wrote: > On Mon, Jul 24, 2023, Nikunj A. Dadhania wrote: >> On 7/19/2023 5:14 AM, Sean Christopherson wrote: >>> This is the next iteration of implementing fd-based (instead of vma-based) >>> memory for KVM gu

Re: [RFC PATCH v11 00/29] KVM: guest_memfd() and per-page attributes

2023-07-24 Thread Nikunj A. Dadhania
On 7/19/2023 5:14 AM, Sean Christopherson wrote: > This is the next iteration of implementing fd-based (instead of vma-based) > memory for KVM guests. If you want the full background of why we are doing > this, please go read the v10 cover letter[1]. > > The biggest change from v10 is to implemen

Re: [PATCH 0/2] powerpc/xive: fix CPU hot unplug

2017-10-04 Thread Nikunj A Dadhania
David Gibson writes: > On Tue, Oct 03, 2017 at 08:24:07AM +0200, Cédric Le Goater wrote: >> On 10/03/2017 05:36 AM, David Gibson wrote: >> > On Mon, Oct 02, 2017 at 06:27:20PM +0200, Cédric Le Goater wrote: >> >> On 09/23/2017 10:26 AM, Cédric Le Goater wrote: >> >>> Hi, >> >>> >> >>> Here are a

Re: [PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path

2015-08-11 Thread Nikunj A Dadhania
Hi Michael, Nikunj A Dadhania writes: > In some situations, a NUMA guest that supports > ibm,dynamic-memory-reconfiguration node will end up having flat NUMA > distances between nodes. This is because of two problems in the > current code. > > 1) Different representations of a

Re: [PATCH slof] README: Update with patch submittion note

2015-07-06 Thread Nikunj A Dadhania
Thomas Huth writes: > On Mon, 6 Jul 2015 18:02:00 +1000 > Alexey Kardashevskiy wrote: > >> On 07/06/2015 05:22 PM, Thomas Huth wrote: >> > On Mon, 6 Jul 2015 14:09:10 +1000 >> > Alexey Kardashevskiy wrote: >> > >> >> This adds a maillist and emails to be used when posting a patch for SLOF. > .

Re: [PATCH] Fix function keys sequence on USB

2015-07-06 Thread Nikunj A Dadhania
Dinar valeev writes: > From: Dinar Valeev > > Original issue is home and end keys are not functional in grub2. > Later I've found other inconsistencies in f1-f12 keys. > > "Correct sequence" was crabbed by pressing key on cat running in > xterm. > > Tested with Home, End, F2, Del and F10 keys in

Re: [PATCH] Caps in not always shift

2015-07-05 Thread Nikunj A Dadhania
Dinar valeev writes: > From: Dinar Valeev > > Caps behaves like shift only for latin characters. > In case we're typing - for example with caps enabled, SLOF picks _ char > from shifted table. > > Threat caps as shift only for letters. > > Signed-off-by: Dina

Re: [PATCH slof] README: Update with patch submittion note

2015-07-05 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > This adds a maillist and emails to be used when posting a patch for SLOF. > > Cc: Benjamin Herrenschmidt > Cc: Thomas Huth > Cc: Nikunj A Dadhania > Signed-off-by: Alexey Kardashevskiy > --- > > I was asked to describe somewhere how

Re: [PATCH SLOF v4 1/4] disk-label: simplify gpt-prep-partition? routine

2015-07-04 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 07/02/2015 09:35 PM, Nikunj A Dadhania wrote: >> Signed-off-by: Nikunj A Dadhania >> Reviewed-by: Thomas Huth > > If it does not change SLOF behaviour in any way (and it does not, > right?), It does not. > it would be ni

[PATCH SLOF v4 4/4] disk-label: add support for booting from GPT FAT partition

2015-07-02 Thread Nikunj A Dadhania
in seek-pos updation code * Check for Protective MBR Magic * Check for valid GPT Signature * Boundary check for allocated block size before reading into the buffer Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 108

[PATCH SLOF v4 2/4] introduce 8-byte LE helpers

2015-07-02 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/little-endian.fs | 6 ++ slof/fs/packages/disk-label.fs | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/slof/fs/little-endian.fs b/slof/fs/little-endian.fs index f2e4e8d..6b4779e 100644

[PATCH SLOF v4 0/4] GPT fixes and LVM support with FAT

2015-07-02 Thread Nikunj A Dadhania
tection code * Fixed stack comments * Rename verify-gpt-partition, as it was doing more than that. Added comments. Nikunj A Dadhania (4): disk-label: simplify gpt-prep-partition? routine introduce 8-byte LE helpers disk-label: introduce helper to check fat filesystem disk-label: add support

[PATCH SLOF v4 3/4] disk-label: introduce helper to check fat filesystem

2015-07-02 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index b346774..142e54f 100644 --- a/slof/fs/packages

[PATCH SLOF v4 1/4] disk-label: simplify gpt-prep-partition? routine

2015-07-02 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index fe1c25e..f1f083a

Re: [PATCH SLOF v3 3/5] disk-label: rename confusing "block" word

2015-07-02 Thread Nikunj A Dadhania
Segher Boessenkool writes: > On Thu, Jul 02, 2015 at 11:17:49AM +0530, Nikunj A Dadhania wrote: >> >> "block" word is not a block number, actually its an allocated host >> >> address. Rename it to disk-buf along with a associated >> >> size(dis

Re: [PATCH SLOF v3 3/5] disk-label: rename confusing "block" word

2015-07-01 Thread Nikunj A Dadhania
Hi Segher, Segher Boessenkool writes: > On Tue, Jun 30, 2015 at 04:31:19PM +0530, Nikunj A Dadhania wrote: >> "block" word is not a block number, actually its an allocated host >> address. Rename it to disk-buf along with a associated >> size(disk-buf-size=40

[PATCH RESEND] powerpc/numa: initialize distance lookup table from drconf path

2015-07-01 Thread Nikunj A Dadhania
. Node distance table will not get initialized in certain cases as ibm,dynamic-reconfiguration-memory path does not initialize the lookup table. Call initialize_distance_lookup_table() from drconf path with appropriate associativity list. Reported-by: Bharata B Rao Signed-off-by

Re: [PATCH SLOF v3 5/5] disk-label: add support for booting from GPT FAT partition

2015-06-30 Thread Nikunj A Dadhania
Thomas Huth writes: > Sorry, every time I look at this gpt stuff, my eyes stumble > over something new ... No worries :-) > On Tue, 30 Jun 2015 16:31:21 +0530 > Nikunj A Dadhania wrote: > >> For a GPT+LVM combination disk, older bootloader that does not support >> L

[PATCH SLOF v3 5/5] disk-label: add support for booting from GPT FAT partition

2015-06-30 Thread Nikunj A Dadhania
for Protective MBR Magic * Check for valid GPT Signature * Boundary check for allocated block size before reading into the buffer Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 99 +- 1 file changed, 79 insertions(+), 20 deletions

[PATCH SLOF v3 4/5] disk-label: introduce helper to check fat filesystem

2015-06-30 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index e5a0546..347dc5d 100644 --- a/slof/fs/packages

[PATCH SLOF v3 3/5] disk-label: rename confusing "block" word

2015-06-30 Thread Nikunj A Dadhania
sk-buf and only takes sector number as argument. Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 78 ++ 1 file changed, 41 insertions(+), 37 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/f

[PATCH SLOF v3 2/5] introduce 8-byte LE helpers

2015-06-30 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/little-endian.fs | 6 ++ slof/fs/packages/disk-label.fs | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/slof/fs/little-endian.fs b/slof/fs/little-endian.fs index f2e4e8d..6b4779e 100644

[PATCH SLOF v3 1/5] disk-label: simplify gpt-prep-partition? routine

2015-06-30 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 41 +++-- 1 file changed, 15 insertions(+), 26 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index fe1c25e..f1f083a

[PATCH SLOF v3 0/5] GPT fixes/cleanup and LVM support with FAT

2015-06-30 Thread Nikunj A Dadhania
s * Rename verify-gpt-partition, as it was doing more than that. Added comments. Nikunj A Dadhania (5): disk-label: simplify gpt-prep-partition? routine introduce 8-byte LE helpers disk-label: rename confusing "block" word disk-label: introduce helper to check fat filesystem dis

Re: [PATCH SLOF v2 5/5] disk-label: add support for booting from GPT FAT partition

2015-06-29 Thread Nikunj A Dadhania
Thomas Huth writes: > On Thu, 25 Jun 2015 12:15:29 +0530 > Nikunj A Dadhania wrote: > >> For a GPT+LVM combination disk, older bootloader that does not support >> LVM, cannot load kernel from LVM. >> >> The patch adds support to read from BASIC_DATA UUID parti

Re: [RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-25 Thread Nikunj A Dadhania
Hi Anton/Michael, Nikunj A Dadhania writes: > Hi Anton, > > Anton Blanchard writes: >> Hi Nikunj, >> >>> From: Nikunj A Dadhania >>> >>> powerpc/numa: initialize distance lookup table from drconf path >>> >>> In

[PATCH SLOF v2 5/5] disk-label: add support for booting from GPT FAT partition

2015-06-24 Thread Nikunj A Dadhania
for Protective MBR Magic * Check for valid GPT Signature * Boundary check for allocated block size before reading into the buffer Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 96 +- 1 file changed, 76 insertions(+), 20 deletions

[PATCH SLOF v2 4/5] disk-label: introduce helper to check fat filesystem

2015-06-24 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index 0995808..7ed5526 100644 --- a/slof/fs/packages/disk-label.fs +++ b/slof

[PATCH SLOF v2 3/5] disk-label: rename confusing "block" word

2015-06-24 Thread Nikunj A Dadhania
sk-buf and only takes sector number as argument. Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 78 ++ 1 file changed, 41 insertions(+), 37 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs ind

[PATCH SLOF v2 2/5] introduce 8-byte LE helpers

2015-06-24 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/little-endian.fs | 6 ++ slof/fs/packages/disk-label.fs | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/slof/fs/little-endian.fs b/slof/fs/little-endian.fs index f2e4e8d..6b4779e 100644

[PATCH SLOF v2 0/5] GPT fixes/cleanup and LVM support with FAT

2015-06-24 Thread Nikunj A Dadhania
patch 4: As we need to detect FAT partition, implement a helper that can be used both from GPT code and "fat-bootblock?" patch 5: Implement GPT FAT for LVM suport and make GPT detection code robust Nikunj A Dadhania (5): disk-label: simplify gpt-prep-partitio

[PATCH SLOF v2 1/5] disk-label: simplify gpt-prep-partition? routine

2015-06-24 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania Reviewed-by: Thomas Huth --- slof/fs/packages/disk-label.fs | 42 -- 1 file changed, 16 insertions(+), 26 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index fe1c25e..bb64d57

Re: [PATCH SLOF 5/5] disk-label: make gpt detection code more robust

2015-06-23 Thread Nikunj A Dadhania
Thomas Huth writes: > On Mon, 22 Jun 2015 13:29:47 +0530 > Nikunj A Dadhania wrote: > >> * Check for Protective MBR Magic >> * Check for valid GPT Signature >> * Boundary check for allocated block size before reading into the >> buffer >> >> Sign

Re: [PATCH SLOF 4/5] disk-label: add support for booting from GPT FAT partition

2015-06-23 Thread Nikunj A Dadhania
Thomas Huth writes: > On Mon, 22 Jun 2015 13:29:46 +0530 > Nikunj A Dadhania wrote: > >> For a GPT+LVM combination disk, older bootloader that does not support >> LVM, cannot load kernel from LVM. >> >> The patch add support to read from BASIC_DATA UUID >

Re: [PATCH SLOF 4/5] disk-label: add support for booting from GPT FAT partition

2015-06-23 Thread Nikunj A Dadhania
Segher Boessenkool writes: > On Tue, Jun 23, 2015 at 09:34:44AM +0200, Thomas Huth wrote: >> > +: load-from-gpt-partition ( [ addr ] -- size | TRUE ) >> >> What do you mean with addr in square brackets? Is it optional? > > And "size | TRUE"? The code even returns "false" instead, which > usuall

Re: [RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-23 Thread Nikunj A Dadhania
Hi Anton, Anton Blanchard writes: > Hi Nikunj, > >> From: Nikunj A Dadhania >> >> powerpc/numa: initialize distance lookup table from drconf path >> >> In some situations, a NUMA guest that supports >> ibm,dynamic-memory-reconfiguration node will en

Re: [PATCH SLOF 3/5] disk-label: introduce helper to check fat filesystem

2015-06-22 Thread Nikunj A Dadhania
Hi Segher, Segher Boessenkool writes: > On Mon, Jun 22, 2015 at 01:29:45PM +0530, Nikunj A Dadhania wrote: >> +: has-fat-filesystem ( block -- true | false ) >> + \ block 0 byte 0-2 is a jump instruction in all FAT >> + \ filesystems. > > "block" the

[PATCH SLOF 5/5] disk-label: make gpt detection code more robust

2015-06-22 Thread Nikunj A Dadhania
* Check for Protective MBR Magic * Check for valid GPT Signature * Boundary check for allocated block size before reading into the buffer Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 21 + 1 file changed, 17 insertions(+), 4 deletions(-) diff

[PATCH SLOF 3/5] disk-label: introduce helper to check fat filesystem

2015-06-22 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index 2cf1b85..e317e93 100644 --- a/slof/fs/packages/disk-label.fs +++ b

[PATCH SLOF 0/5] GPT fixes/cleanup and LVM support with FAT

2015-06-22 Thread Nikunj A Dadhania
can be used both from GPT code and "try-dos-files" patch 4: Implement GPT FAT for LVM suport. patch 5: Make GPT detection code robust Nikunj A Dadhania (5): disk-label: simplify gpt-prep-partition? routine introduce 8-byte LE helpers disk-label: introduce helper to

[PATCH SLOF 1/5] disk-label: simplify gpt-prep-partition? routine

2015-06-22 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk-label.fs | 36 +--- 1 file changed, 13 insertions(+), 23 deletions(-) diff --git a/slof/fs/packages/disk-label.fs b/slof/fs/packages/disk-label.fs index fe1c25e..2305eee 100644 --- a/slof/fs/packages/disk

[PATCH SLOF 4/5] disk-label: add support for booting from GPT FAT partition

2015-06-22 Thread Nikunj A Dadhania
For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch add support to read from BASIC_DATA UUID partition. Installer has installed CHRP-BOOT config on a FAT file system. Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk

[PATCH SLOF 2/5] introduce 8-byte LE helpers

2015-06-22 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/little-endian.fs | 6 ++ slof/fs/packages/disk-label.fs | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/slof/fs/little-endian.fs b/slof/fs/little-endian.fs index f2e4e8d..6b4779e 100644 --- a/slof/fs/little-endian.fs

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

2015-06-19 Thread Nikunj A Dadhania
Thomas Huth writes: > On Wed, 17 Jun 2015 17:34:13 +0530 > Nikunj A Dadhania wrote: > >> Nikunj A Dadhania writes: >> >> > Thomas Huth writes: >> >>> +\ Check for GPT MSFT BASIC DATA GUID - vfat based >> >>> +EBD0A0A2 CONSTANT

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

2015-06-17 Thread Nikunj A Dadhania
Thomas Huth writes: > On Thu, 11 Jun 2015 15:48:49 +0530 > Nikunj A Dadhania wrote: > >> + block-size * to seek-pos >> + block gpt>part-entry-size l@-le to gpt-part-size >> + block gpt>num-part-entry l@-le dup 0= IF FALSE EXIT THEN >> +

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

2015-06-17 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Thomas Huth writes: >>> +\ Check for GPT MSFT BASIC DATA GUID - vfat based >>> +EBD0A0A2 CONSTANT GPT-BASIC-DATA-PARTITION-1 >>> +B9E5 CONSTANT GPT-BASIC-DATA-PARTITION-2 >>> +4433 CONSTANT GPT-BASIC-DATA-PAR

Re: [PATCH SLOF] disk-label: add support for booting from GPT FAT partition

2015-06-17 Thread Nikunj A Dadhania
Thomas Huth writes: > On Thu, 11 Jun 2015 15:48:49 +0530 > Nikunj A Dadhania wrote: > >> For a GPT+LVM combination disk, older bootloader that does not support >> LVM, cannot load kernel from LVM. >> >> The patch add support to read from BASIC_DATA UUID >

Re: [RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-15 Thread Nikunj A Dadhania
Nikunj A Dadhania writes: > Reworded commit log: > > From: Nikunj A Dadhania > > powerpc/numa: initialize distance lookup table from drconf path > Ping ? Regards Nikunj ___ Linuxppc-dev mailing list Linuxppc-dev@list

[PATCH SLOF] disk-label: add support for booting from GPT FAT partition

2015-06-11 Thread Nikunj A Dadhania
For a GPT+LVM combination disk, older bootloader that does not support LVM, cannot load kernel from LVM. The patch add support to read from BASIC_DATA UUID partition. Installer has installed CHRP-BOOT config on a FAT file system. Signed-off-by: Nikunj A Dadhania --- slof/fs/packages/disk

Re: [RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-09 Thread Nikunj A Dadhania
Reworded commit log: From: Nikunj A Dadhania powerpc/numa: initialize distance lookup table from drconf path In some situations, a NUMA guest that supports ibm,dynamic-memory-reconfiguration node will end up having flat NUMA distances between nodes. This is because of two problems in the

[RFC PATCH] powerpc/numa: initialize distance lookup table from drconf path

2015-06-09 Thread Nikunj A Dadhania
er to skip the length field before sending the associativity list. Call initialize_distance_lookup_table() from drconf path with appropriate associativity list. Reported-by: Bharata B Rao Signed-off-by: Nikunj A Dadhania --- arch/powerpc/mm/numa.c | 16 +--- 1 file changed, 13

Re: [PATCH] Fix function keys sequence on USB

2015-06-02 Thread Nikunj A Dadhania
Dinar Valeev writes: > On Tue, Jun 2, 2015 at 11:47 AM, Nikunj A Dadhania > wrote: >> Dinar valeev writes: >>> @@ -262,7 +258,7 @@ static void check_key_code(uint8_t *buf) >>> case 0x43: >>>

Re: [PATCH] Fix function keys sequence on USB

2015-06-02 Thread Nikunj A Dadhania
Dinar valeev writes: > From: Dinar Valeev > > Original issue is home and end keys are not functional in grub2. > Later I've found other inconsistencies in f1-f12 keys. > > "Correct sequence" was crabbed by pressing key on cat running in > xterm. > > Tested with Home, End, F2, Del and F10 keys in

Re: [PATCH 3/3] fbuffer: introduce the invert-region-x helper

2015-05-28 Thread Nikunj A Dadhania
nes that Thomas pointed: Reviewed-by: Nikunj A Dadhania > --- > board-js2x/slof/helper.fs |5 + > board-qemu/slof/helper.fs |4 > board-qemu/slof/pci-device_1234_.fs | 10 +- > slof/fs/fbuffer.fs |

Re: [PATCH 2/3] fbuffer: introduce the invert-region helper

2015-05-28 Thread Nikunj A Dadhania
qemu: faster hv-logical-memop based > > With standard graphical settings on board-qemu, we go from 512 hcall > invocations per character down to 16. > > Suggested-by: Thomas Huth > Signed-off-by: Greg Kurz Reviewed-by: Nikunj A Dadhania > --- > board-js2x/slof/helper.fs

Re: [PATCH 1/3] fbuffer: simplify address computations in fb8-toggle-cursor

2015-05-28 Thread Nikunj A Dadhania
address by itself and drop the confusing > "char-width screen-depth * -" address adjustment. Much better :-) Reviewed-by: Nikunj A Dadhania > > Signed-off-by: Greg Kurz > --- > slof/fs/fbuffer.fs |4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [PATCH] fbuffer: improve toggle cursor performance

2015-05-27 Thread Nikunj A Dadhania
Greg Kurz writes: > On Wed, 27 May 2015 10:41:06 +0530 > Nikunj A Dadhania wrote: > >> Greg Kurz writes: >> >> > SLOF currently calls hv-logical-load and hv-logical-store for every pixel >> > when enabling or disabling the cursor. This is suboptimal when

Re: [PATCH] fbuffer: improve toggle cursor performance

2015-05-26 Thread Nikunj A Dadhania
Greg Kurz writes: > SLOF currently calls hv-logical-load and hv-logical-store for every pixel > when enabling or disabling the cursor. This is suboptimal when writing one > char at a time to the console since terminal-write always toggles the cursor. > And this is precisely what grub is doing whe

Re: [PATCH v2 0/4] PCI: Generic fixes and moving enumeration back to QEMU

2015-04-28 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > On 04/27/2015 06:02 PM, Nikunj A Dadhania wrote: >> patch 1: Fixes a bug in pci-to-pci bridge while programming the limit >> registers during probe >> patch 2,3: Support 64-bit address translation and usb devices can have >>

Re: [PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Nikunj A Dadhania
Thomas Huth writes: > On Mon, 27 Apr 2015 13:32:33 +0530 > Nikunj A Dadhania wrote: > >> PCI Enumeration has been part of SLOF. Now with hotplug code addition >> in QEMU, it makes more sense to have this code in one place, >> i.e. QEMU. >> >> Adding ro

[PATCH v2 4/4] pci: Use QEMU created PCI device nodes

2015-04-27 Thread Nikunj A Dadhania
the devices. Signed-off-by: Nikunj A Dadhania --- board-qemu/slof/pci-phb.fs | 44 +++- slof/fs/pci-properties.fs | 6 +- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs index

[PATCH v2 3/4] usb: support 64-bit pci bars

2015-04-27 Thread Nikunj A Dadhania
-by: Nikunj A Dadhania --- slof/fs/devices/pci-class_0c.fs | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/slof/fs/devices/pci-class_0c.fs b/slof/fs/devices/pci-class_0c.fs index 9c47325..39453fb 100644 --- a/slof/fs/devices/pci-class_0c.fs +++ b/slof/fs/devices/pci

[PATCH v2 2/4] pci: Support 64-bit address translation

2015-04-27 Thread Nikunj A Dadhania
Signed-off-by: Nikunj A Dadhania --- slof/fs/translate.fs | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/slof/fs/translate.fs b/slof/fs/translate.fs index e2633e5..9654f24 100644 --- a/slof/fs/translate.fs +++ b/slof/fs/translate.fs @@ -33,11 +33,9 @@ dup l@ FF

[PATCH v2 0/4] PCI: Generic fixes and moving enumeration back to QEMU

2015-04-27 Thread Nikunj A Dadhania
patch 1: Fixes a bug in pci-to-pci bridge while programming the limit registers during probe patch 2,3: Support 64-bit address translation and usb devices can have 64-bit pci memory BARs patch 4: Use QEMU create device tree nodes and program the BARs Nikunj A Dadhania

[PATCH v2 1/4] pci: program correct bridge limit registers during probe

2015-04-27 Thread Nikunj A Dadhania
of the bug 0x got programmed in the memory limit register. All the mmio reads across the pci-to-pci bridge started failing during probe. All pci-bridge-set-[mmio,mem,io]-base sufferred from similar problem. Suggested-by: Thomas Huth Signed-off-by: Nikunj A Dadhania --- slof/fs/pci-scan.fs

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

2015-04-26 Thread Nikunj A Dadhania
Thomas Huth writes: > On Fri, 24 Apr 2015 12:56:57 +0200 > Thomas Huth wrote: > >> On Fri, 24 Apr 2015 09:22:33 +0530 >> Nikunj A Dadhania wrote: >> >> > >> > Hi Thomas, >> > >> > Thomas Huth writes: >> &g

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

2015-04-26 Thread Nikunj A Dadhania
Thomas Huth writes: > On Fri, 24 Apr 2015 12:56:57 +0200 > Thomas Huth wrote: > >> On Fri, 24 Apr 2015 09:22:33 +0530 >> Nikunj A Dadhania wrote: >> >> > >> > Hi Thomas, >> > >> > Thomas Huth writes: >> &g

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

2015-04-26 Thread Nikunj A Dadhania
Thomas Huth writes: > On Fri, 24 Apr 2015 09:22:33 +0530 > Nikunj A Dadhania wrote: > >> >> Hi Thomas, >> >> Thomas Huth writes: >> > Am Wed, 22 Apr 2015 16:27:19 +0530 >> > schrieb Nikunj A Dadhania : >> > >> >> With

Re: [PATCH 2/2] pci: Use Qemu created PCI device nodes

2015-04-26 Thread Nikunj A Dadhania
Hi Thomas, Thomas Huth writes: > Hi Nikunj, > > On Wed, 22 Apr 2015 16:27:20 +0530 > Nikunj A Dadhania wrote: > >> PCI Enumeration has been part of SLOF. Now with hotplug code addition >> in Qemu, it makes more sense to have this code a one place, i.e. Qemu. > &

Re: [PATCH 1/2] pci-phb: check for the 32-bit overflow

2015-04-23 Thread Nikunj A Dadhania
Hi Thomas, Thomas Huth writes: > Am Wed, 22 Apr 2015 16:27:19 +0530 > schrieb Nikunj A Dadhania : > >> With the addition of 64-bit BARS and increase in the mmio address >> space, the code was hitting this limit. The memory of pci devices >> across the bridges were

[PATCH 1/2] pci-phb: check for the 32-bit overflow

2015-04-22 Thread Nikunj A Dadhania
With the addition of 64-bit BARS and increase in the mmio address space, the code was hitting this limit. The memory of pci devices across the bridges were not accessible due to which the drivers failed. Signed-off-by: Nikunj A Dadhania --- board-qemu/slof/pci-phb.fs | 3 ++- 1 file changed, 2

[PATCH 2/2] pci: Use Qemu created PCI device nodes

2015-04-22 Thread Nikunj A Dadhania
devices. Signed-off-by: Nikunj A Dadhania --- board-qemu/slof/pci-phb.fs | 44 +++- slof/fs/pci-properties.fs | 6 +- 2 files changed, 48 insertions(+), 2 deletions(-) diff --git a/board-qemu/slof/pci-phb.fs b/board-qemu/slof/pci-phb.fs index e307d95

Re: [PATCH slof v2] virtio: Fix vring allocation

2015-03-13 Thread Nikunj A Dadhania
size. > At the moment rings are quite small (256) and allocated with > 4096 alignment, this is why we have not been having issues with > this so far. > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Nikunj A Dadhania > --- > Changes: > v2: > * remove magic n

Re: [PATCH slof] virtio: Fix vring allocation

2015-03-13 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > The value returned by virtio_vring_size() is used to allocate memory > for vring. The used descriptor list (array of vring_used_elem) is > counted by the header - vring_used struct - is not. > > This fixes virtio_vring_size() to return the correct size. > At the mom

Re: [PATCH slof] helpers: Fix SLOF_alloc_mem_aligned to meet callers expectation

2015-03-13 Thread Nikunj A Dadhania
[i].desc = > SLOF_alloc_mem_aligned(virtio_vring_size(vq[i].size), 4096); > slof/helpers.c|70| void *SLOF_alloc_mem_aligned(long size, long align) > > Signed-off-by: Alexey Kardashevskiy Reviewed-by: Nikunj A Dadhania > --- > include/helpers.h | 2 +- > slof/helpers.c| 2 +- >

Re: [PATCH SLOF] pci-properties: Remove redundant call to device-type

2015-03-11 Thread Nikunj A Dadhania
Thomas Huth writes: > On Wed, 11 Mar 2015 17:26:32 +1100 > Alexey Kardashevskiy wrote: > >> At the moment SLOF adds a "device_type" property automatically for >> every single PCI device based on its class even if there is no SLOF >> driver for such a device. OF1275 says that "device_type" is for

Re: [PATCH] Add private HCALL to inform updated RTAS base and entry

2014-08-26 Thread Nikunj A Dadhania
exception and hence needs to know the updated RTAS. > > Enhancements to qemu to handle the private HCALL, prepare > error log and invoke machine check notification routine > are in a separate patch. > > Signed-off-by: Nikunj A. Dadhania > Signed-off-by: Aravinda Prasad Than

Re: [PATCH] pci-scan: Fix setting the limit

2014-05-14 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > PCI spec says that lower 20 bits are assumed 0xF. The existing code > seems to get it right in pci-bridge-set-mem-limit. > > However pci-bridge-set-mem-base does not account 0xF and poison > the limit. Since the limit is not stored anywhere in SLOF and only

Re: [PATCH v2] pci: fix interrupt-map for bridges

2013-09-24 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > The previous scheme always put 0 as a parent slot#. However it is > not always the case and QEMU's PCI bridge does not support putting > device at slot#0 as it claims SHPC support for hotplug. > > This modifies the interrups map to let the linux guest resolve XICS >

Re: [PATCH] pci: fix interrupt-map for bridges

2013-09-12 Thread Nikunj A Dadhania
Alexey Kardashevskiy writes: > The previous scheme always put 0 as a parent slot#. However it is > not always the case and QEMU's PCI bridge does not support putting > device at slot#0 as it claims SHPC support for hotplug. > > This modifies the interrups map to let the linux guest resolve XICS >