Re: [PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-23 Thread Nikita Yushchenko
I currently don't have numbers for this patch taken alone. This patch originates from work done some years ago to reduce cost of memory accounting, and x86-only version of this patch was in virtuozzo/openvz kernel since then. Other patches from that work have been upstreamed, but this one was miss

Re: [PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-18 Thread Nikita Yushchenko
This allows archs to optimize it, by freeing multiple tables in a single release_pages() call. This is faster than individual put_page() calls, especially with memcg accounting enabled. Could we quantify "faster"? There's a non-trivial amount of code being added here and it would be nice to bac

Re: [PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-18 Thread Nikita Yushchenko
17.12.2021 21:39, Sam Ravnborg wrote: Hi Nikita, How about adding the following to tlb.h: #ifndef __tlb_remove_tables static void __tlb_remove_tables(...) { } #endif And then the few archs that want to override __tlb_remove_tables needs to do a #define __tlb_remove_tables __tlb_re

Re: [PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-18 Thread Nikita Yushchenko
Oh gawd, that's terrible. Never, ever duplicate code like that. What the patch does is: - formally shift the loop one level down in the call graph, adding instances of __tmp_remove_tables() exactly to locations where instances of __tmp_remove_table() already exist, - on architectures where __tm

[PATCH/RFC] mm: add and use batched version of __tlb_remove_table()

2021-12-17 Thread Nikita Yushchenko
in a single release_pages() call. This is faster than individual put_page() calls, especially with memcg accounting enabled. Signed-off-by: Andrey Ryabinin Signed-off-by: Nikita Yushchenko --- arch/arm/include/asm/tlb.h | 5 arch/arm64/include/asm/tlb.h

powerpc: fsl,pq2-localbus is broken for ages

2015-02-16 Thread Nikita Yushchenko
Hi arch/powerpc/sysdev/fsl_lbc.c driver claims that it is compatible with fsl,pq2-localbus and fsl,pq2pro-localbus arch/powerpc/sysdev/fsl_lbc.c driver requires irq configured in device tree since very old times (commit 3ab8f2a2 from 2.6.37 times) None of in-tree dts files that have either fsl,p

Re: [PATCH] kexec/powerpc: fix exporting memory limit

2014-03-06 Thread Nikita Yushchenko
> On Thu, 2014-03-06 at 18:24 +0400, Nikita Yushchenko wrote: > > When preparing dump-capturing kernel, kexec userspace tool needs to > > know actual amount of memory used by the running kernel. This may > > differ from extire available DRAM for a couple of reasons. To a

[PATCH] kexec/powerpc: fix exporting memory limit

2014-03-06 Thread Nikita Yushchenko
t' to use values from memblock subsystem. These are adjusted at kernel memory management init and thus always contain values that match reality. Signed-off-by: Nikita Yushchenko --- arch/powerpc/kernel/machine_kexec.c |8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/arc

Re: powerpc/hugetlb: BUG: using smp_processor_id() in preemptible

2014-01-17 Thread Nikita Yushchenko
> Could you try this? > > powerpc/hugetlb: replace __get_cpu_var with get_cpu_var > > Replace __get_cpu_var safely with get_cpu_var to avoid > the following call trace: Confirmed, no more acktraces. Nikita ___ Linuxppc-dev mailing list Linuxppc-dev@list

powerpc/hugetlb: BUG: using smp_processor_id() in preemptible

2014-01-17 Thread Nikita Yushchenko
Hi While running LTP hugeltb tests on freescale powerpc board, I'm getting [ 7253.637591] BUG: using smp_processor_id() in preemptible [ ] code: hugemmap01/9048 [ 7253.637601] caller is free_hugepd_range.constprop.25+0x88/0x1a8 [ 7253.637605] CPU: 1 PID: 9048 Comm: hugemmap01 Not

Re: commit e38c0a1f breaks powerpc boards with uli1575 chip

2013-12-18 Thread Nikita Yushchenko
> Reverting would break Tegra PCIe, but you should not have to change the > DT either. So we need a solution. > > Is this something like this sufficient to fix it? > > diff --git a/drivers/of/address.c b/drivers/of/address.c > index 4b9317b..378aebd 100644 > --- a/drivers/of/address.c > +++ b/drive

commit e38c0a1f breaks powerpc boards with uli1575 chip

2013-12-17 Thread Nikita Yushchenko
Hi While trying to make freescale p2020ds and mpc8572ds boards working with mainline kernel, I faced that commit e38c0a1f (Handle #address-cells > 2 specially) breaks things with these boards. Both these boards have uli1575 chip. Corresponding part in device tree is something like