Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-04-04 Thread Nathan Chancellor
On Tue, Mar 18, 2025 at 10:13:35PM +0100, Arnd Bergmann wrote: > Thanks for the report, I missed that the generic ioport_map() function > is missing the PCI_IOBASE macro, we should probably remove that from > the asm-generic/io.h header and require architectures to define it > themselves, since the

Re: [PATCH 5/6] mips: drop GENERIC_IOMAP wrapper

2025-03-18 Thread Nathan Chancellor
Hi Arnd, On Sat, Mar 15, 2025 at 11:59:06AM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > All PIO on MIPS platforms is memory mapped, so there is no benefit in > the lib/iomap.c wrappers that switch between inb/outb and readb/writeb > style accessses. > > In fact, the '#define PIO_RESER

Re: [RFC PATCH] objtool: Skip unannotated intra-function call warning for bl+mflr pattern

2025-02-24 Thread Nathan Chancellor
On Mon, Feb 24, 2025 at 02:19:14PM +0100, Christophe Leroy wrote: > Well, this problem already exists on clang 18 it seems: > > 0004 : >4: 7c 08 02 a6 mflrr0 >8: 94 21 ff e0 stwur1,-32(r1) >c: 93 c1 00 18 stw r30,24(r1) > 10: 90 01 00 24 stw

Re: [PATCH] powerpc/Makefile: Allow overriding CPP

2024-11-07 Thread Nathan Chancellor
Signed-off-by: Michael Ellerman My builds are still green with this change applied. Reviewed-by: Nathan Chancellor Tested-by: Nathan Chancellor > --- > arch/powerpc/Makefile | 7 +++ > arch/powerpc/kernel/vdso/Makefile | 2 +- > 2 files changed, 4 insertions(+),

Re: [PATCH] powerpc/vdso: Drop -mstack-protector-guard flags in 32-bit files with clang

2024-11-06 Thread Nathan Chancellor
Hi Christophe and Segher, On Wed, Nov 06, 2024 at 07:37:52AM -0600, Segher Boessenkool wrote: > On Wed, Nov 06, 2024 at 09:55:58AM +0100, Christophe Leroy wrote: > > Le 30/10/2024 à 19:41, Nathan Chancellor a écrit : > > >Under certain conditions, the 64-bit '-mstack-pro

Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-05 Thread Nathan Chancellor
ed, I think we are all good here. Tested-by: Nathan Chancellor > diff --git a/arch/x86/kernel/alternative.c b/arch/x86/kernel/alternative.c > index 3407efc26528..243843e44e89 100644 > --- a/arch/x86/kernel/alternative.c > +++ b/arch/x86/kernel/alternative.c > @@ -124

Re: [PATCH v7 6/8] x86/module: prepare module loading for ROX allocations of text

2024-11-04 Thread Nathan Chancellor
Hi Mike, On Wed, Oct 23, 2024 at 07:27:09PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > When module text memory will be allocated with ROX permissions, the > memory at the actual address where the module will live will contain > invalid instructions and there will be a wr

[PATCH] powerpc/vdso: Drop -mstack-protector-guard flags in 32-bit files with clang

2024-10-30 Thread Nathan Chancellor
lready handles situations similar to this. Additionally, reformat and align a comment better for the expanding CONFIG_CC_IS_CLANG block. Cc: sta...@vger.kernel.org # v6.1+ Signed-off-by: Nathan Chancellor --- I say "Under certain conditions" because I am not entirely sure what they are. I canno

Re: powerpc: clang-nightly: fatal error: error in backend: Trying to obtain a reserved register "r2".

2024-10-24 Thread Nathan Chancellor
Hi Naresh, On Thu, Oct 24, 2024 at 08:35:11PM +0530, Naresh Kamboju wrote: > The powerpc clang-nightly version 20.0.0 build warnings / errors noticed on > the Today's Linux next-20241024 tag. ... > Build errors: > -- > fatal error: error in backend: Trying to obtain a reserved register "r2

Re: [PATCH v6 6/8] x86/module: prepare module loading for ROX allocations of text

2024-10-21 Thread Nathan Chancellor
Hi Mike, On Wed, Oct 16, 2024 at 03:24:22PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > When module text memory will be allocated with ROX permissions, the > memory at the actual address where the module will live will contain > invalid instructions and there will be a wr

Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text

2024-10-15 Thread Nathan Chancellor
On Fri, Oct 11, 2024 at 03:58:04PM +0300, Mike Rapoport wrote: > I overlooked how cfi_*_callers routines update addr. > This patch should fix it: Thanks, can confirm. My boot is working again and LKDTM's CFI_FORWARD_PROTO test properly fails. > diff --git a/arch/x86/kernel/alternative.c b/arch/x8

Re: [PATCH v5 6/8] x86/module: perpare module loading for ROX allocations of text

2024-10-10 Thread Nathan Chancellor
Hi Mike, On Wed, Oct 09, 2024 at 09:08:14PM +0300, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > When module text memory will be allocated with ROX permissions, the > memory at the actual address where the module will live will contain > invalid instructions and there will be a wr

[PATCH v2 0/2] powerpc: Prepare for clang's per-task stack protector support

2024-10-09 Thread Nathan Chancellor
er selection behavior differs from GCC. - Link to v1: https://lore.kernel.org/r/20241007-powerpc-fix-stackprotector-test-clang-v1-0-08c15b269...@kernel.org --- Nathan Chancellor (2): powerpc: Fix stack protector Kconfig test for clang powerpc: Adjust adding stack protector flags to KBUILD_CLA

[PATCH v2 2/2] powerpc: Adjust adding stack protector flags to KBUILD_CLAGS for clang

2024-10-09 Thread Nathan Chancellor
s the issue and allows clang's implementation to fully work with the kernel. Cc: sta...@vger.kernel.org # 6.1+ Link: https://github.com/llvm/llvm-project/pull/110928 [1] Reviewed-by: Keith Packard Tested-by: Keith Packard Signed-off-by: Nathan Chancellor --- arch/powerpc/Makefile | 13 +

[PATCH v2 1/2] powerpc: Fix stack protector Kconfig test for clang

2024-10-09 Thread Nathan Chancellor
While the 64-bit macro does not strictly need it, add the equivalent 64-bit option for symmetry. Cc: sta...@vger.kernel.org # 6.1+ Link: https://github.com/llvm/llvm-project/pull/110928 [1] Reviewed-by: Keith Packard Tested-by: Keith Packard Signed-off-by: Nathan Chancellor --- arch/powerpc/Kconf

Re: [PATCH 3/3] powerpc: Include -m32 / -m64 for stack protector Kconfig test

2024-10-08 Thread Nathan Chancellor
On Tue, Oct 08, 2024 at 07:14:26AM +0200, Christophe Leroy wrote: > Le 08/10/2024 à 06:22, Nathan Chancellor a écrit : > > Kbuild uses the powerpc64le-linux-gnu target for clang, which causes the > > Kconfig check for 32-bit powerpc stack protector support to fail because > &

Re: [PATCH 2/3] powerpc: Adjust adding stack protector flags to KBUILD_CLAGS for clang

2024-10-08 Thread Nathan Chancellor
Hi Christophe, First of all, thanks a lot for the quick review. On Tue, Oct 08, 2024 at 07:10:36AM +0200, Christophe Leroy wrote: > Le 08/10/2024 à 06:22, Nathan Chancellor a écrit : > > After fixing the HAVE_STACKPROTECTER checks for clang's in-progress > > per-task stack

[PATCH 3/3] powerpc: Include -m32 / -m64 for stack protector Kconfig test

2024-10-07 Thread Nathan Chancellor
orted, in the stack protector support cc-option call to properly switch the target to a 32-bit one, which matches what happens in Kbuild. While the 64-bit macro does not strictly need it, add the equivalent 64-bit option for symmetry. Signed-off-by: Nathan Chancellor --- arch/powerpc/Kconfig | 4

[PATCH 2/3] powerpc: Adjust adding stack protector flags to KBUILD_CLAGS for clang

2024-10-07 Thread Nathan Chancellor
s the issue and allows clang's implementation to fully work with the kernel. Link: https://github.com/llvm/llvm-project/pull/110928 [1] Signed-off-by: Nathan Chancellor --- arch/powerpc/Makefile | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/arch/powerpc/

[PATCH 1/3] powerpc: Fix stack protector Kconfig test for clang

2024-10-07 Thread Nathan Chancellor
ard-offset=0' for testing support, which fixes the issue for clang and does not regress support with GCC. Link: https://github.com/llvm/llvm-project/pull/110928 [1] Signed-off-by: Nathan Chancellor --- arch/powerpc/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH 0/3] powerpc: Prepare for clang's per-task stack protector support

2024-10-07 Thread Nathan Chancellor
I have tested this series in QEMU against LKDTM's REPORT_STACK_CANARY with ppc64le_guest_defconfig and pmac32_defconfig built with a toolchain that contains Keith's in-progress pull request, which should land for LLVM 20: https://github.com/llvm/llvm-project/pull/110928 --- Nathan

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-19 Thread Nathan Chancellor
On Mon, Aug 19, 2024 at 12:29:34PM -0700, Linus Torvalds wrote: > On Mon, 19 Aug 2024 at 11:53, Nathan Chancellor wrote: > > > > > > Modules linked in: > > Pid: 24, comm: mount Not tainted 6.11.0-rc4-next-20240819 > > RIP: 0033:0x68006f6c > > RSP: 000

Re: [PATCH v2 1/4] mm: Add optional close() to struct vm_special_mapping

2024-08-19 Thread Nathan Chancellor
Hi Michael, On Mon, Aug 12, 2024 at 06:26:02PM +1000, Michael Ellerman wrote: > Add an optional close() callback to struct vm_special_mapping. It will > be used, by powerpc at least, to handle unmapping of the VDSO. > > Although support for unmapping the VDSO was initially added > for CRIU[1], it

Re: [PATCH v3 2/3] dma-mapping: replace zone_dma_bits by zone_dma_limit

2024-08-01 Thread Nathan Chancellor
On Thu, Aug 01, 2024 at 03:44:54PM +0200, Christoph Hellwig wrote: > On Wed, Jul 31, 2024 at 06:24:24PM -0700, Nathan Chancellor wrote: > > Unfortunately, I am not sure either... I do not see anything obviously, > > so perhaps it could just be avoided with the __diag()

Re: [PATCH v3 2/3] dma-mapping: replace zone_dma_bits by zone_dma_limit

2024-07-31 Thread Nathan Chancellor
On Tue, Jul 30, 2024 at 05:34:50PM +0200, Christoph Hellwig wrote: > On Mon, Jul 29, 2024 at 07:12:08PM -0700, Nathan Chancellor wrote: > > > | ~~ ^~~~ > > >include/linux/dma-mapping.h:77:40: note

Re: [PATCH v3 2/3] dma-mapping: replace zone_dma_bits by zone_dma_limit

2024-07-29 Thread Nathan Chancellor
On Tue, Jul 30, 2024 at 04:20:51AM +0800, kernel test robot wrote: > Hi Baruch, > > kernel test robot noticed the following build warnings: > > [auto build test WARNING on arm64/for-next/core] > [also build test WARNING on powerpc/next powerpc/fixes s390/features > linus/master v6.11-rc1 next-20

[PATCH] ASoC: fsl: lpc3xxx-i2s: Include bitfield.h for FIELD_PREP

2024-07-01 Thread Nathan Chancellor
Fixes: 0959de657a10 ("ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs") Signed-off-by: Nathan Chancellor --- sound/soc/fsl/lpc3xxx-i2s.h | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/fsl/lpc3xxx-i2s.h b/sound/soc/fsl/lpc3xxx-i2s.h index eec755448478..b6657853017a 1006

[PATCH] ASoC: fsl: lpc3xxx-i2s: Avoid using ret uninitialized in lpc32xx_i2s_probe()

2024-07-01 Thread Nathan Chancellor
he point of this statement, would be to use the '%pe' specifier to symbolically print the error pointer value. Do so, which eliminates the uninitialized use of ret, clearing up the warning. Fixes: 0959de657a10 ("ASoC: fsl: Add i2s and pcm drivers for LPC32xx CPUs") Signed-off-by

Re: [PATCH] powerpc: vdso: fix building with wrong-endian toolchain

2024-06-07 Thread Nathan Chancellor
On Fri, Jun 07, 2024 at 04:11:25PM +0200, Arnd Bergmann wrote: > This patch seems to work as well for me, and is a little > more logical, but it's also more invasive and has a > higher regression risk: Commit feb843a469fb ("kbuild: add $(CLANG_FLAGS) to KBUILD_CPPFLAGS") did something similar for

Re: [PATCH] powerpc: Set _IO_BASE to POISON_POINTER_DELTA not 0 for CONFIG_PCI=n

2024-05-01 Thread Nathan Chancellor
Hi Michael, On Wed, May 01, 2024 at 12:04:40AM +1000, Michael Ellerman wrote: > With -Wextra clang warns about pointer arithmetic using a null pointer. > When building with CONFIG_PCI=n, that triggers a warning in the IO > accessors, eg: > > In file included from linux/arch/powerpc/include/asm/

Re: [RFC PATCH 2/2] objtool/powerpc: Enhance objtool to fixup alternate feature relative addresses

2024-04-22 Thread Nathan Chancellor
Hi Sathvika, On Mon, Apr 22, 2024 at 02:52:06PM +0530, Sathvika Vasireddy wrote: > Implement build-time fixup of alternate feature relative addresses for > the out-of-line (else) patch code. Initial posting to achieve the same > using another tool can be found at [1]. Idea is to implement this usi

[PATCH] powerpc: Fix fatal warnings flag for LLVM's integrated assembler

2024-04-05 Thread Nathan Chancellor
s with both the GNU assembler and LLVM's integrated assembler. Fixes: 608d4a5ca563 ("powerpc: Error on assembly warnings") Signed-off-by: Nathan Chancellor --- arch/powerpc/Kbuild | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/Kbuild b/arch

Re: [PATCH v4 05/13] mm/arch: Provide pud_pfn() fallback

2024-04-02 Thread Nathan Chancellor
Hi Peter (and LoongArch folks), On Wed, Mar 27, 2024 at 11:23:24AM -0400, pet...@redhat.com wrote: > From: Peter Xu > > The comment in the code explains the reasons. We took a different approach > comparing to pmd_pfn() by providing a fallback function. > > Another option is to provide some lo

Re: FAILED: Patch "powerpc: xor_vmx: Add '-mhard-float' to CFLAGS" failed to apply to 5.10-stable tree

2024-03-27 Thread Nathan Chancellor
t > id to . ... > -- original commit in Linus's tree -- > > From 35f20786c481d5ced9283ff42de5c69b65e5ed13 Mon Sep 17 00:00:00 2001 > From: Nathan Chancellor > Date: Sat, 27 Jan 2024 11:07:43 -0700 > Subject: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to

Re: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS

2024-03-06 Thread Nathan Chancellor
On Wed, Mar 06, 2024 at 12:01:42PM +1100, Michael Ellerman wrote: > Nathan Chancellor writes: > > Ping? We have been applying this in our CI since it was sent, it would > > be nice to have this upstream soon so it can start filtering through the > > stable trees. > > S

Re: [PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS

2024-03-05 Thread Nathan Chancellor
Ping? We have been applying this in our CI since it was sent, it would be nice to have this upstream soon so it can start filtering through the stable trees. On Sat, Jan 27, 2024 at 11:07:43AM -0700, Nathan Chancellor wrote: > arch/powerpc/lib/xor_vmx.o is built with '-msoft-float' (

Re: [PATCH linux-next 1/3] x86, crash: don't nest CONFIG_CRASH_DUMP ifdef inside CONFIG_KEXEC_CODE ifdef scope

2024-02-02 Thread Nathan Chancellor
This series resolves the build issues I was seeing. Please feel free to carry Tested-by: Nathan Chancellor # build forward if there are any more revisions without drastic changes. On Mon, Jan 29, 2024 at 09:50:31PM +0800, Baoquan He wrote: > Michael pointed out that the #if

[PATCH] powerpc: xor_vmx: Add '-mhard-float' to CFLAGS

2024-01-27 Thread Nathan Chancellor
hes how other areas of the kernel use '-maltivec', such as AMDGPU. Cc: sta...@vger.kernel.org Closes: https://github.com/ClangBuiltLinux/linux/issues/1986 Link: https://github.com/llvm/llvm-project/commit/4792f912b232141ecba4cbae538873be3c28556c Signed-off-by: Nathan Chancellor --- arch/powerpc/

[PATCH 5.4] powerpc: Use always instead of always-y in for crtsavres.o

2024-01-26 Thread Nathan Chancellor
e aforementioned kbuild commit is not suitable for stable due to its size and number of conflicts, so transform the always-y usage to an equivalent form using always, which resolves the build issues. Fixes: 245da9eebba0 ("powerpc: add crtsavres.o to always-y instead of extra-y") Sig

[PATCH 4.19] powerpc: Use always instead of always-y in for crtsavres.o

2024-01-26 Thread Nathan Chancellor
ting the aforementioned kbuild commit is not suitable for stable due to its size and number of conflicts, so transform the always-y usage to an equivalent form using always, which resolves the build issues. Fixes: b7b85ec5ec15 ("powerpc: add crtsavres.o to always-y instead of extra-y") Sig

Re: [PATCH linux-next v3 00/14] Split crash out from kexec and clean up related config items

2024-01-25 Thread Nathan Chancellor
Hi Baoquan, On Wed, Jan 24, 2024 at 01:12:40PM +0800, Baoquan He wrote: > Motivation: > = > Previously, LKP reported a building error. When investigating, it can't > be resolved reasonablly with the present messy kdump config items. > > https://lore.kernel.org/oe-kbuild-all/202312182

[PATCH 06/11] powerpc: Kconfig: Remove tautology in CONFIG_COMPAT

2024-01-25 Thread Nathan Chancellor
or older LLVM versions. Remove it. Signed-off-by: Nathan Chancellor --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: aneesh.ku...@kernel.org Cc: naveen.n@linux.ibm.com Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/Kconfig | 1 - 1 file changed, 1 deletion(-) diff --git a/arch/powerpc/K

[PATCH 00/11] Bump the minimum supported version of LLVM to 13.0.1

2024-01-25 Thread Nathan Chancellor
kernel.org/20240109-update-llvm-links-v1-0-eb09b59db...@kernel.org/ --- Nathan Chancellor (11): kbuild: Raise the minimum supported version of LLVM to 13.0.1 Makefile: Drop warn-stack-size plugin opt x86: Drop stack-alignment plugin opt ARM: Remove Thumb2 __builtin_thread_pointer

Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-11 Thread Nathan Chancellor
Hi Alexei, On Thu, Jan 11, 2024 at 12:00:50PM -0800, Alexei Starovoitov wrote: > On Thu, Jan 11, 2024 at 11:40 AM Nathan Chancellor wrote: > > > > Hi Yonghong, > > > > On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > > > > &g

Re: [PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-11 Thread Nathan Chancellor
Hi Yonghong, On Wed, Jan 10, 2024 at 08:05:36PM -0800, Yonghong Song wrote: > > On 1/9/24 2:16 PM, Nathan Chancellor wrote: > > reviews.llvm.org was LLVM's Phabricator instances for code review. It > > has been abandoned in favor of GitHub pull requests. While the major

[PATCH 3/3] treewide: Update LLVM Bugzilla links

2024-01-09 Thread Nathan Chancellor
gs.llvm.org/show_bug.cgi?id=" links to the "https://llvm.org/pr" shortlink so that the links show the most up to date information. Each migrated issue links back to the Bugzilla entry, so there should be no loss of fidelity of information here. Signed-off-by: Nathan Chancellor

[PATCH 1/3] selftests/bpf: Update LLVM Phabricator links

2024-01-09 Thread Nathan Chancellor
ation. Additionally, fix a typo in the xdpwall.c print ("LLMV" -> "LLVM") while in the area. Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 Signed-off-by: Nathan Chancellor --- Cc: a...@kernel.org Cc: dan...@iogearbox.net Cc: and...@kernel.

[PATCH 2/3] arch and include: Update LLVM Phabricator links

2024-01-09 Thread Nathan Chancellor
Link: https://discourse.llvm.org/t/update-on-github-pull-requests/71540/172 Signed-off-by: Nathan Chancellor --- arch/arm64/Kconfig | 4 ++-- arch/riscv/Kconfig | 2 +- arch/riscv/include/asm/ftrace.h | 2 +- include/linux/compiler-clang.h | 2 +- 4 files changed, 5 inser

[PATCH 0/3] Update LLVM Phabricator and Bugzilla links

2024-01-09 Thread Nathan Chancellor
al (famous last words...). --- Nathan Chancellor (3): selftests/bpf: Update LLVM Phabricator links arch and include: Update LLVM Phabricator links treewide: Update LLVM Bugzilla links arch/arm64/Kconfig | 4 +-- arch/powerp

Re: [PATCH 2/7] kexec_file: print out debugging message if required

2023-11-23 Thread Nathan Chancellor
On Thu, Nov 23, 2023 at 09:49:20PM +0800, b...@redhat.com wrote: > On 11/17/23 at 10:01pm, Baoquan He wrote: > > On 11/17/23 at 09:37am, Liu, Yujie wrote: > > > Hi Baoquan, > > > > > > On Fri, 2023-11-17 at 17:14 +0800, Baoquan He wrote: > > > > Hi, > > > > > > > > On 11/16/23 at 05:04am, kernel

Re: [pci:controller/xilinx-xdma] BUILD REGRESSION 8d786149d78c7784144c7179e25134b6530b714b

2023-11-01 Thread Nathan Chancellor
On Wed, Nov 01, 2023 at 10:25:25AM +0100, Arnd Bergmann wrote: > On Tue, Oct 31, 2023, at 18:14, Bjorn Helgaas wrote: > > On Tue, Oct 31, 2023 at 09:59:29AM -0700, Nick Desaulniers wrote: > >> On Tue, Oct 31, 2023 at 7:56 AM Bjorn Helgaas wrote: > > >> > arch/powerpc/xmon/xmon.c: re

[PATCH] scsi: ibmvfc: Use 'unsigned int' for single-bit bitfields in 'struct ibmvfc_host'

2023-10-10 Thread Nathan Chancellor
asy enough to change the type of the fields to 'unsigned int', which keeps the same size in memory and resolves the warning. Fixes: 5144905884e2 ("scsi: ibmvfc: Use a bitfield for boolean flags") Signed-off-by: Nathan Chancellor --- drivers/scsi/ibmvscsi/ibmvfc.h | 18

Re: [PATCH v2] vfs: shave work on failed file open

2023-10-03 Thread Nathan Chancellor
Hi Christian, > >From d266eee9d9d917f07774e2c2bab0115d2119a311 Mon Sep 17 00:00:00 2001 > From: Christian Brauner > Date: Fri, 29 Sep 2023 08:45:59 +0200 > Subject: [PATCH] file: convert to SLAB_TYPESAFE_BY_RCU > > In recent discussions around some performance improvements in the file > handling

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-13 Thread Nathan Chancellor
On Wed, Sep 13, 2023 at 01:49:39PM -0700, Nick Desaulniers wrote: > On Wed, Sep 13, 2023 at 9:56 AM Nathan Chancellor wrote: > > > > Hi Greg, > > > > On Fri, Sep 08, 2023 at 10:30:54AM -0500, gjo...@linux.vnet.ibm.com wrote: > > > From: Greg Joyce > >

Re: [PATCH v7 3/3 RESEND] powerpc/pseries: PLPKS SED Opal keystore support

2023-09-13 Thread Nathan Chancellor
Hi Greg, On Fri, Sep 08, 2023 at 10:30:56AM -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Define operations for SED Opal to read/write keys > from POWER LPAR Platform KeyStore(PLPKS). This allows > non-volatile storage of SED Opal keys. > > Signed-off-by: Greg Joyce > Reviewed-b

Re: [PATCH v7 1/3 RESEND] block:sed-opal: SED Opal keystore

2023-09-13 Thread Nathan Chancellor
Hi Greg, On Fri, Sep 08, 2023 at 10:30:54AM -0500, gjo...@linux.vnet.ibm.com wrote: > From: Greg Joyce > > Add read and write functions that allow SED Opal keys to stored > in a permanent keystore. > > Signed-off-by: Greg Joyce > Reviewed-by: Jonathan Derrick > --- > block/Makefile

Re: [PATCH] Revert "Revert "powerpc/xmon: Relax frame size for clang""

2023-08-28 Thread Nathan Chancellor
and even a few randconfigs bots found. > > We'll have to revisit this again in the future, for now back this out. > > Reported-by: Nathan Chancellor > Closes: > https://github.com/ClangBuiltLinux/linux/issues/252#issuecomment-1690371256 > Reported-by: kernel test robo

Re: [PATCH] Revert "powerpc/xmon: Relax frame size for clang"

2023-08-17 Thread Nathan Chancellor
7;t know precisely when this was fixed in llvm, but it may be time > to revert this. > > Closes: https://github.com/ClangBuiltLinux/linux/issues/252 > Signed-off-by: Nick Desaulniers Reviewed-by: Nathan Chancellor > --- > arch/powerpc/xmon/Makefile | 6 -- > 1 file ch

Re: [PATCH v6 21/38] powerpc: Implement the new page table range API

2023-08-03 Thread Nathan Chancellor
Hi Matthew, On Wed, Aug 02, 2023 at 04:13:49PM +0100, Matthew Wilcox (Oracle) wrote: > Add set_ptes(), update_mmu_cache_range() and flush_dcache_folio(). > Change the PG_arch_1 (aka PG_dcache_dirty) flag from being per-page to > per-folio. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: M

Re: [PATCH v4 12/13] s390/kexec: refactor for kernel/Kconfig.kexec

2023-07-05 Thread Nathan Chancellor
Hi Eric, On Wed, Jul 05, 2023 at 10:20:03AM -0400, Eric DeVolder wrote: > The kexec and crash kernel options are provided in the common > kernel/Kconfig.kexec. Utilize the common options and provide > the ARCH_SUPPORTS_ and ARCH_SELECTS_ entries to recreate the > equivalent set of KEXEC and CRASH

Re: [PATCH v2 07/23] mips: update_mmu_cache() can replace __update_tlb()

2023-06-15 Thread Nathan Chancellor
On Wed, Jun 14, 2023 at 10:43:30PM -0700, Hugh Dickins wrote: > On Wed, 14 Jun 2023, Hugh Dickins wrote: > > On Wed, 14 Jun 2023, Nathan Chancellor wrote: > > > > > > I just bisected a crash while powering down a MIPS machine in QEMU to > > > this

Re: [PATCH v2 07/23] mips: update_mmu_cache() can replace __update_tlb()

2023-06-14 Thread Nathan Chancellor
Hi Hugh, On Thu, Jun 08, 2023 at 12:17:24PM -0700, Hugh Dickins wrote: > Don't make update_mmu_cache() a wrapper around __update_tlb(): call it > directly, and use the ptep (or pmdp) provided by the caller, instead of > re-calling pte_offset_map() - which would raise a question of whether a > pte_

Re: [PATCH 1/4] powerpc/64: Force ELFv2 when building with LLVM linker

2023-05-05 Thread Nathan Chancellor
e minimum binutils has increased such that ELFv2 is always supported, > so remove that check while we're here. > > Cc: Nathan Chancellor > Signed-off-by: Nicholas Piggin Thanks for this change! I ran it through my (admittedly limited set of) build tests with LD=ld.lld for big end

[PATCH] powerpc/boot: Disable power10 features after BOOTAFLAGS assignment

2023-04-27 Thread Nathan Chancellor
x boot wrapper code generation with CONFIG_POWER10_CPU") Link: https://github.com/ClangBuiltLinux/linux/issues/1839 Reviewed-by: Nicholas Piggin Signed-off-by: Nathan Chancellor --- I do not think that 648a1783fe25 is truly to blame for this but the Fixes tag will help the stable team ensu

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Nathan Chancellor
On Tue, Apr 18, 2023 at 07:25:00PM +0100, Mark Brown wrote: > On Tue, Apr 18, 2023 at 11:21:45AM -0700, Nathan Chancellor wrote: > > On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > > > > Done. > > > Thanks a lot, sorry for not saying it sooner! It lo

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-18 Thread Nathan Chancellor
On Fri, Apr 14, 2023 at 05:55:10PM +0100, Mark Brown wrote: > On Thu, Apr 13, 2023 at 11:47:25AM -0700, Nathan Chancellor wrote: > > On Wed, Apr 12, 2023 at 11:22:13AM +1000, Stephen Rothwell wrote: > > > select SND_HDA_COMPONENT if SND_HDA_CORE > > # !CC_IS_C

Re: linux-next: manual merge of the drm tree with the powerpc tree

2023-04-13 Thread Nathan Chancellor
Hi Mark, On Wed, Apr 12, 2023 at 11:22:13AM +1000, Stephen Rothwell wrote: > Hi all, > > Today's linux-next merge of the drm tree got a conflict in: > > drivers/gpu/drm/amd/display/Kconfig > > between commit: > > 78f0929884d4 ("powerpc/64: Always build with 128-bit long double") > > from

Re: [PATCH 2/2] start_kernel: omit prevent_tail_call_optimization for newer toolchains

2023-04-12 Thread Nathan Chancellor
alize the stack canary in the first place. > > Now that we have no_stack_protector function attribute (gcc-11+, > clang-7+) and use it on start_kernel, remove the call to > prevent_tail_call_optimization such that we may one day remove it > outright. > > Signed-off-by: Nick D

Re: [PATCH 1/2] start_kernel: add no_stack_protector fn attr

2023-04-12 Thread Nathan Chancellor
=94722 > Link: > https://lore.kernel.org/all/20200316130414.gc12...@hirez.programming.kicks-ass.net/ > Signed-off-by: Nick Desaulniers I applied this in front of Josh's series and defconfig no longer panics on boot :) Tested-by: Nathan Chancellor > --- > arch/powerpc/kernel/sm

Re: arch/powerpc/kvm/../kernel/head_booke.h:20:6: warning: "THREAD_SHIFT" is not defined, evaluates to 0

2023-04-07 Thread Nathan Chancellor
On Fri, Apr 07, 2023 at 04:08:43PM -0700, Nick Desaulniers wrote: > On Tue, Apr 4, 2023 at 6:29 PM kernel test robot wrote: > > > > Hi Masahiro, > > > > FYI, the error/warning still remains. > > > > tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git > > master > > head:

[PATCH] powerpc/32: Include thread_info.h in head_booke.h

2023-04-06 Thread Nathan Chancellor
ways defined. Reported-by: kernel test robot Link: https://lore.kernel.org/202304050954.yskldczh-...@intel.com/ Signed-off-by: Nathan Chancellor --- arch/powerpc/kernel/head_booke.h | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/powerpc/kernel/head_booke.h b/arch/powerpc/kernel/head_boo

Re: [PATCH 2/2] powerpc/64: Use -mtune=pwr10/9/8 for clang

2023-03-03 Thread Nathan Chancellor
On Fri, Mar 03, 2023 at 10:53:02AM +1100, Michael Ellerman wrote: > Nathan Chancellor writes: > > Hi Michael, > > > > Thanks for the workaround and sorry this has come to bite us :/ > > > > On Fri, Mar 03, 2023 at 12:16:56AM +1100, Michael Ellerman wrote: > &g

Re: [PATCH 2/2] powerpc/64: Use -mtune=pwr10/9/8 for clang

2023-03-02 Thread Nathan Chancellor
gt; the kernel must support the clang versions in the wild. > > So add support for the "pwr" spelling if clang is in use. > > Reported-by: Nathan Chancellor I think that should actually be Reported-by: Nick Desaulniers > BugLink: https://github.com/ClangBuiltLinux/lin

Re: [PATCH 1/2] powerpc/64: Move CPU -mtune options into Kconfig

2023-03-02 Thread Nathan Chancellor
; Another downside is that doing more complicated logic to calculate the > correct option gets messy in the Makefile. > > So move the determination of which -mtune option to use into Kconfig > logic. > > Signed-off-by: Michael Ellerman Reviewed-by: Nathan Chan

Re: [PATCH] powerpc/vmlinux.lds: Add .text.asan/tsan sections

2023-02-22 Thread Nathan Chancellor
adding the sections to our linker script, similar to the > generic change made in 848378812e40 ("vmlinux.lds.h: Handle clang's > module.{c,d}tor sections"). > > Signed-off-by: Michael Ellerman Indeed, I had not thought about architectures not using the TEXT_TEXT macro.

Re: [PATCH 0/3] Allow CONFIG_PPC64_BIG_ENDIAN_ELF_ABI_V2 with ld.lld 15+

2023-02-20 Thread Nathan Chancellor
On Mon, Feb 20, 2023 at 05:11:54PM +1100, Michael Ellerman wrote: > Nathan Chancellor writes: > > Currently, CONFIG_PPC64_BIG_ENDIAN_ELF_ABI_V2 is not selectable with > > ld.lld because of an explicit dependency on GNU ld, due to lack of > > testing with LLVM. > > &g

[PATCH 2/3] powerpc: Fix use of '-mabi=elfv2' with clang

2023-02-15 Thread Nathan Chancellor
'-mabi=elfv2' is not added to clang's invocations when CONFIG_PPC64_ELF_ABI_V2 is enabled, resulting in the generation of elfv1 code, as evidenced by the orphan section warnings/errors: ld.lld: error: vmlinux.a(arch/powerpc/kernel/prom_init.o):(.opd) is being placed in '.opd' ld.lld: error: v

[PATCH 3/3] powerpc: Allow CONFIG_PPC64_BIG_ENDIAN_ELF_ABI_V2 with ld.lld 15+

2023-02-15 Thread Nathan Chancellor
Commit 5017b4594672 ("powerpc/64: Option to build big-endian with ELFv2 ABI") restricted the ELFv2 ABI configuration such that it can only be selected when linking with ld.bfd, due to lack of testing with LLVM. ld.lld can link ELFv2 kernels without any issues; in fact, it is the only ABI that ld.l

[PATCH 1/3] powerpc/boot: Only use '-mabi=elfv2' with CONFIG_PPC64_BOOT_WRAPPER

2023-02-15 Thread Nathan Chancellor
silently accepts it but clang errors out. Only provide '-mabi=elfv2' when CONFIG_PPC64_BOOT_WRAPPER is enabled, which is the only way '-mabi=elfv2' will be useful. Tested-by: "Erhard F." Signed-off-by: Nathan Chancellor --- arch/powerpc/boot/Makefile | 6 ++

[PATCH 0/3] Allow CONFIG_PPC64_BIG_ENDIAN_ELF_ABI_V2 with ld.lld 15+

2023-02-15 Thread Nathan Chancellor
first two patches fix a couple of issues I noticed while build testing and the final patch actually allows the option to be selected. --- Nathan Chancellor (3): powerpc/boot: Only use '-mabi=elfv2' with CONFIG_PPC64_BOOT_WRAPPER powerpc: Fix use of '-mabi=el

[PATCH] macintosh: windfarm: Use unsigned type for 1-bit bitfields

2023-02-15 Thread Nathan Chancellor
o code checks the actual value of these fields, just whether or not they are zero (boolean context), but this can be easily fixed by switching to an unsigned type. Signed-off-by: Nathan Chancellor --- drivers/macintosh/windfarm_lm75_sensor.c | 4 ++-- drivers/macintosh/windfarm_smu_sensors.c | 4 ++

Re: [PATCH v2 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

2023-01-25 Thread Nathan Chancellor
On Thu, Jan 26, 2023 at 10:29:54AM +0900, Masahiro Yamada wrote: > On Wed, Jan 25, 2023 at 1:11 PM Michael Ellerman wrote: > > > > Nathan Chancellor writes: > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > > points out that KBUIL

[PATCH] powerpc/vdso: Filter clang's auto var init zero enabler when linking

2023-01-24 Thread Nathan Chancellor
ter out this flag, as has been done for other flags. Fixes: b174f4c26aa3 ("powerpc/vdso: Improve linker flags") Fixes: 7bbf02b875b5 ("kbuild: Stop using '-Qunused-arguments' with clang") Link: https://github.com/llvm/llvm-project/commit/ca6d5813d17598cd180995fb3bdfca

Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

2023-01-24 Thread Nathan Chancellor
On Mon, Jan 23, 2023 at 09:07:16AM -0600, Segher Boessenkool wrote: > Hi! > > On Wed, Jan 11, 2023 at 08:05:04PM -0700, Nathan Chancellor wrote: > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: >

Re: [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-23 Thread Nathan Chancellor
Hi Naresh, On Mon, Jan 23, 2023 at 07:28:10PM +0530, Naresh Kamboju wrote: > FYI, > [ please provide comments, feedback and improvements on build/ ltp smoke > tests ] > > LKFT test farm have fetched your patch series [1] > [PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS >

Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

2023-01-22 Thread Nathan Chancellor
On Mon, Jan 23, 2023 at 02:27:51AM +0900, Masahiro Yamada wrote: > On Fri, Jan 13, 2023 at 3:21 AM Nathan Chancellor wrote: > > > > Hi Sedat, > > > > On Thu, Jan 12, 2023 at 07:02:30PM +0100, Sedat Dilek wrote: > > > On Thu, Jan 12, 2023 at 4:0

Re: [PATCH] powerpc: add crtsavres.o to always-y instead of extra-y

2023-01-19 Thread Nathan Chancellor
kefile.modfinal:61: > arch/powerpc/platforms/cell/spufs/spufs.ko] Error 1 > make: *** [Makefile:1924: modules] Error 2 > > Signed-off-by: Masahiro Yamada Reviewed-by: Nathan Chancellor > --- > > arch/powerpc/lib/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [PATCH v2 07/14] powerpc/vdso: Improve linker flags

2023-01-12 Thread Nathan Chancellor
Hi Sedat, On Thu, Jan 12, 2023 at 07:02:30PM +0100, Sedat Dilek wrote: > On Thu, Jan 12, 2023 at 4:06 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: > > &g

[PATCH v2 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

2023-01-11 Thread Nathan Chancellor
points out that while the flag is one that it recognizes, it is not actually used by this compiler job. To eliminate the warning, remove -fno-stack-clash-protection from vgettimeofday-32.c's CFLAGS when using clang, as has been done for other flags previously. Signed-off-by: Nathan Chancello

[PATCH v2 05/14] powerpc: Remove linker flag from KBUILD_AFLAGS

2023-01-11 Thread Nathan Chancellor
"/dev/null" "/tmp/null-80267c.s" $ clang --target=powerpc64-linux-gnu -fno-integrated-as -m64 -### \ -x assembler-with-cpp -c -o /dev/null /dev/null &| grep gnu-as "/usr/bin/powerpc64-linux-gnu-as" "-a32" "-mppc" "-many" &

[PATCH v2 07/14] powerpc/vdso: Improve linker flags

2023-01-11 Thread Nathan Chancellor
b15 ("powerpc/vdso: link with -z noexecstack") but now that there is a common ldflags variable, it can be moved there. Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desaulniers --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...@csgroup.eu Cc: linuxppc-dev@lists.o

[PATCH v2 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-11 Thread Nathan Chancellor
), which means it does nothing when the linker is not invoked by the compiler. The kernel builds all .o files with '-c', which stops the compilation pipeline before linking, so '-s' can be safely dropped from ASFLAGS. Signed-off-by: Nathan Chancellor Reviewed-by: Nick Desau

[PATCH v2 00/14] Remove clang's -Qunused-arguments from KBUILD_CPPFLAGS

2023-01-11 Thread Nathan Chancellor
ked (Nick, Segher) - Patch 7: Move '-z noexecstack' into new ldflags-y variable (Nick) - Patch 8: Reword commit message to explain the problem in a clearer manner (Nick) - Link to v1: https://lore.kernel.org/r/20221228-drop-qunused-arguments-v1-0-658cbc8fc...@kernel.org --- Nathan

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-10 Thread Nathan Chancellor
On Tue, Jan 10, 2023 at 05:45:23AM -0600, Segher Boessenkool wrote: > On Mon, Jan 09, 2023 at 05:51:23PM -0700, Nathan Chancellor wrote: > > So for this patch, I have > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns: > &

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nathan Chancellor
: > > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor > > > wrote: > > > > > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > > > warns that ASFLAGS contains '-s', which is a linking phase

Re: [PATCH 08/14] powerpc/vdso: Remove an unsupported flag from vgettimeofday-32.o with clang

2023-01-09 Thread Nathan Chancellor
On Mon, Jan 09, 2023 at 02:12:55PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns: > > > > clang-16: error: argument unused duri

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nathan Chancellor
On Mon, Jan 09, 2023 at 04:23:37PM -0600, Segher Boessenkool wrote: > Hi! Happy new year all. > > On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > > > When clang

Re: [PATCH 07/14] powerpc/vdso: Improve linker flags

2023-01-09 Thread Nathan Chancellor
On Mon, Jan 09, 2023 at 02:08:41PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, there > > are several warnings in the PowerPC vDSO: > > > >

Re: [PATCH 06/14] powerpc/vdso: Remove unused '-s' flag from ASFLAGS

2023-01-09 Thread Nathan Chancellor
On Mon, Jan 09, 2023 at 01:58:32PM -0800, Nick Desaulniers wrote: > On Wed, Jan 4, 2023 at 11:55 AM Nathan Chancellor wrote: > > > > When clang's -Qunused-arguments is dropped from KBUILD_CPPFLAGS, it > > warns that ASFLAGS contains '-s', which is a linki

[PATCH 07/14] powerpc/vdso: Improve linker flags

2023-01-04 Thread Nathan Chancellor
e flags to ldflags-y. The second group of warnings are compiler or assembler flags that will be unused during linking. Filter them out from KBUILD_CFLAGS so that they are not used during linking. Signed-off-by: Nathan Chancellor --- Cc: m...@ellerman.id.au Cc: npig...@gmail.com Cc: christophe.le...

  1   2   3   >