RE: [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic

2011-05-18 Thread Moore, Eric
On Wednesday, May 18, 2011 3:30 PM, Benjamin Herrenschmidt wrote: > > You may also want to look at Milton's comments, it looks like the way > you do init_completion followed immediately by wait_completion is racy. > > You should init the completion before you do the IO that will eventually > trig

RE: [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic

2011-05-18 Thread Moore, Eric
On Wednesday, May 18, 2011 12:31 PM Milton Miller wrote: > Ingo I would propose the following commits added in 2.6.29 be reverted. > I think the current concensus is drivers must know if the writeq is > not atomic so they can provide their own locking or other workaround. > Exactly.

RE: [PATCH 1/3] mpt2sas: remove the use of writeq, since writeq is not atomic

2011-05-18 Thread Moore, Eric
On Wednesday, May 18, 2011 2:24 AM, Milton Miller wrote: > On Wed, 18 May 2011 around 17:00:10 +1000, Benjamin Herrenschmidt wrote: > > (Just adding Milton to the CC list, he suspects races in the > > driver instead). > > > > On Wed, 2011-05-18 at 08:23 +0400, James Bottomley wrote: > > > On Tue, 2