Re: [PATCH v3 2/4] PCI/AER: Factor out interrupt toggling into helpers

2023-04-20 Thread Mika Westerberg
On Thu, Apr 20, 2023 at 08:59:38PM +0800, Kai-Heng Feng wrote: > There are many places that enable and disable AER interrput, so move > them into helpers. > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg

Re: [PATCH v2 4/4] PCI/DPC: Disable DPC interrupt during suspend

2023-04-20 Thread Mika Westerberg
gt; > This is very similar to previous attempts to suspend AER and DPC [1], > but with a different reason. > > [1] > https://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.f...@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg

Re: [PATCH v2 3/4] PCI/AER: Disable AER interrupt on suspend

2023-04-20 Thread Mika Westerberg
ps://lore.kernel.org/linux-pci/20220408153159.106741-1-kai.heng.f...@canonical.com/ > Link: https://bugzilla.kernel.org/show_bug.cgi?id=216295 > > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg

Re: [PATCH v2 2/4] PCI/AER: Factor out interrput toggling into helpers

2023-04-20 Thread Mika Westerberg
Typo in $subject: interrput -> interrupt On Thu, Apr 20, 2023 at 09:58:28AM +0800, Kai-Heng Feng wrote: > There are many places that enable and disable AER interrput, so move > them into helpers. > > Signed-off-by: Kai-Heng Feng > --- > v2: > - New patch. > > drivers/pci/pcie/aer.c | 45 +++

Re: [PATCH v3 3/5] treewide: use get_random_u32() when possible

2022-10-07 Thread Mika Westerberg
On Thu, Oct 06, 2022 at 10:53:44AM -0600, Jason A. Donenfeld wrote: > drivers/thunderbolt/xdomain.c | 2 +- Acked-by: Mika Westerberg

Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
On Thu, Jan 27, 2022 at 08:29:22AM +0200, Mika Westerberg wrote: > > For example, should we convert commit a697f072f5da8 ("PCI: Disable PTM > > during suspend to save power") to PM hooks in PTM service? > > Yes, I think that's the right thing to do. I wonder how i

Re: [PATCH v2 2/2] PCI/DPC: Disable DPC service when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
On Thu, Jan 27, 2022 at 10:54:18AM +0800, Kai-Heng Feng wrote: > Since TLP and DLLP transmission is disabled for a Link in L2/L3 Ready, > L2 and L3 (i.e. device in D3hot and D3cold), and DPC depends on AER, so > also disable DPC here. > > Signed-off-by: Kai-Heng Feng Re

Re: [PATCH v2 1/2] PCI/AER: Disable AER service when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
t TLP and DLLP > transmission is disabled for a Link in L2/L3 Ready (D3hot), L2 (D3cold > with aux power) and L3 (D3cold). > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209149 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215453 > Fixes: 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in hint") > Signed-off-by: Kai-Heng Feng Reviewed-by: Mika Westerberg

Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
Hi, On Thu, Jan 27, 2022 at 10:21:35AM +0800, Kai-Heng Feng wrote: > On Wed, Jan 26, 2022 at 7:03 PM Mika Westerberg > wrote: > > > > Hi, > > > > On Wed, Jan 26, 2022 at 03:18:51PM +0800, Kai-Heng Feng wrote: > > > Commit 50310600ebda ("iommu/vt-d: E

Re: [PATCH 2/2] PCI/DPC: Disable DPC when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
ted the PM hooks in the first place > Signed-off-by: Kai-Heng Feng One minor comment below, but other than that looks good, Reviewed-by: Mika Westerberg > --- > drivers/pci/pcie/dpc.c | 61 +++--- > 1 file changed, 45 insertions(+), 16 deletions(

Re: [PATCH 1/2] PCI/AER: Disable AER when link is in L2/L3 ready, L2 and L3 state

2022-01-26 Thread Mika Westerberg
wer states. Reason here is that you can't really tell from the OS standpoint whether the link went into L1 or L2/3 before the ACPI power resource is turned off. > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=209149 > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=215453 > Fixes: 50310600ebda ("iommu/vt-d: Enable PCI ACS for platform opt in hint") > Signed-off-by: Kai-Heng Feng Thanks for fixing this! Reviewed-by: Mika Westerberg

Re: [PATCH v2 2/2] powerpc/pci: Unroll two pass loop when scanning bridges

2017-11-13 Thread Mika Westerberg
the loop in > pci_scan_child_bus() and pci_hp_add_bridge() with added comments. > > No functional changes intended. > > Cc: Mika Westerberg Reviewed-by: Mika Westerberg

Re: [PATCH] i2c: Remove unneeded xxx_set_drvdata(..., NULL) calls

2013-02-18 Thread Mika Westerberg
signware-platdrv.c | 2 -- For i2c-designware-pcidrv.c and i2c-designware-platdrv.c: Reviewed-by: Mika Westerberg ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev