Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

heport_lock for CONSOLE_CONSOLE_PORT?  Using the port_lock wouldprovide the HVC serialization "for free" but it would be cleaner if weput HVC related synchronization in hvc_console.c. On Thu, Dec 8, 2011 at 4:08 AM, Amit Shah wrote: > On (Tue) 06 Dec 2011 [09:05:38], Miche Baker-Harvey wrote: >

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

pace? Miche On Mon, Dec 5, 2011 at 2:54 AM, Amit Shah wrote: > On (Tue) 29 Nov 2011 [09:50:41], Miche Baker-Harvey wrote: >> Good grief!  Sorry for the spacing mess-up!  Here's a resend with >> reformatting. >> >> Amit, >> We aren't using either Q

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

Good grief! Sorry for the spacing mess-up! Here's a resend with reformatting. Amit, We aren't using either QEMU or kvmtool, but we are using KVM. All the issues we are seeing happen when we try to establish multiple virtioconsoles at boot time. The command line isn't relevant, but I can tell y

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

he PORT_READY messages. After each successful init_port_console(), the guest sendsVIRTIO_CONSOLE_PORT_OPEN back to the host. On Tue, Nov 29, 2011 at 6:21 AM, Amit Shah wrote: > Hi, > > On (Mon) 28 Nov 2011 [15:40:41], Miche Baker-Harvey wrote: >> Amit, >> >> You said t

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

t; On (Thu) 17 Nov 2011 [10:57:37], Miche Baker-Harvey wrote: >> Rusty, Michael, Stephen, et al, >> >> Thanks for your comments on these patches. >> >> For what I'm trying to do, all three patches are necessary, but maybe >> I'm going about it the wrong way

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

Thanks, Rusty. I'm not using QEMU though, just KVM. I create the device, wait for the message from the guest that the device is ready, and then add ports. Miche On Sun, Nov 20, 2011 at 9:01 PM, Rusty Russell wrote: > On Thu, 17 Nov 2011 10:57:37 -0800, Miche Baker-Harvey > wrot

Re: [PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

Rusty, Michael, Stephen, et al, Thanks for your comments on these patches. For what I'm trying to do, all three patches are necessary, but maybe I'm going about it the wrong way. Your input would be appreciated. I'm in no way claiming that these patches are "right", just that it's working for me,

[PATCH v3 3/3] Use separate struct console structure for each hvc_console.

CONSOLE_PORT. Signed-off-by: Miche Baker-Harvey --- drivers/tty/hvc/hvc_console.c | 20 drivers/tty/hvc/hvc_console.h |1 + 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 09a6159..24a84d6

[PATCH RFC v3 0/3] Support multiple VirtioConsoles.

lloc() to one thread. I would appreciate any comments or feedback, or accept if appropriate. Thanks, Miche Baker-Harvey --- Miche Baker-Harvey (3): virtio_console: Fix locking of vtermno. hvc_init(): Enforce one-time initialization. Use separate struct console structure for each

[PATCH v3 1/3] virtio_console: Fix locking of vtermno.

Some modifications of vtermno were not done under the spinlock. Moved assignment from vtermno and increment of vtermno together, putting both under the spinlock. Revert vtermno on failure. Signed-off-by: Miche Baker-Harvey --- drivers/char/virtio_console.c |9 ++--- 1 files changed, 6

[PATCH v3 2/3] hvc_init(): Enforce one-time initialization.

completed. This patch fixes multiple crash symptoms. Signed-off-by: Miche Baker-Harvey --- drivers/tty/hvc/hvc_console.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index b6b2d18..09a6159 100644

[PATCH v2 3/3] Use separate struct console structure for each hvc_console.

CONSOLE_PORT. Signed-off-by: Miche Baker-Harvey --- drivers/tty/hvc/hvc_console.c | 20 drivers/tty/hvc/hvc_console.h |1 + 2 files changed, 21 insertions(+), 0 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index 09a6159..24a84d6

[PATCH v2 2/3] hvc_init(): Enforce one-time initialization.

completed. This patch fixes multiple crash symptoms. Signed-off-by: Miche Baker-Harvey --- drivers/tty/hvc/hvc_console.c | 13 +++-- 1 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/tty/hvc/hvc_console.c b/drivers/tty/hvc/hvc_console.c index b6b2d18..09a6159 100644

[PATCH v2 1/3] virtio_console: Fix locking of vtermno.

Some modifications of vtermno were not done under the spinlock. Moved assignment from vtermno and increment of vtermno together, putting both under the spinlock. Revert vtermno on failure. Signed-off-by: Miche Baker-Harvey --- drivers/char/virtio_console.c |9 ++--- 1 files changed, 6

[PATCH RFC v2 0/3] Support multiple VirtioConsoles.

to be asking for guidance, but I didn't mark it as "RFC". This series reflects the input from Konrad Rzeszutek, Amit Shah, Stephen Boyd, and Rusty Russell. I think we do have to limit hvc_alloc() to one thread. I would appreciate any comments or feedback, or accept if appropriate.

[PATCH RFC 0/3] Support multiple VirtioConsoles.

, and Rusty Russell. I think we do have to limit hvc_alloc() to one thread. I would appreciate any comments or feedback, or accept if appropriate. Thanks, Miche Baker-Harvey --- Miche Baker-Harvey (3): virtio_console: Fix locking of vtermno. hvc_init(): Enforce one-time initializ

[PATCH] hvc_console: display printk messages on console.

up the index in the hvc_console, and set up the necessary vtermnos[] and cons_op[] entries so that printk functions work. Signed-off-by: Miche Baker-Harvey --- However, I'm not sure how this is supposed to be working, and not at all sure how this should tie in with command line selection o