Re: [PATCH net-next v3 2/3] net: ibmveth: Reset the adapter when unexpected states are detected

2025-04-17 Thread Michal Swiatkowski
t/ibm/ibmveth.c | 116 - > drivers/net/ethernet/ibm/ibmveth.h | 1 + > 2 files changed, 98 insertions(+), 19 deletions(-) > Thanks for addressing comments Reviewed-by: Michal Swiatkowski

Re: [PATCH net-next v3 1/3] net: ibmveth: Indented struct ibmveth_adapter correctly

2025-04-17 Thread Michal Swiatkowski
lure; > + u64 replenish_add_buff_success; > + u64 rx_invalid_buffer; > + u64 rx_no_buffer; > + u64 tx_map_failed; > + u64 tx_send_failed; > + u64 tx_large_packets; > + u64 rx_large_packets; > + /* Ethtool settings */ > u8 duplex; > u32 speed; > }; > -- > 2.49.0 Reviewed-by: Michal Swiatkowski

Re: [PATCH net-next] ibmveth: Use WARN_ON with error handling rather than BUG_ON

2025-04-10 Thread Michal Swiatkowski
On Thu, Apr 10, 2025 at 01:39:18PM -0500, Dave Marquardt wrote: > - Replaced BUG_ON calls with WARN_ON calls with error handling, > with calls to a new ibmveth_reset routine, which resets the device. > - Added KUnit tests for ibmveth_remove_buffer_from_pool and > ibmveth_rxq_get_buffer under ne