Re: [PATCH] soc: fsl: qe: Add check for platform_driver_register

2024-04-08 Thread Maxim Kochetkov
09.04.2024 06:08, Chen Ni пишет: Return platform_driver_register() in order to transfer the error if it fails. Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device") Signed-off-by: Chen Ni Reviewed-by: Maxim Kochetkov

[PATCH] soc: fsl: qe: fix static checker warning

2021-08-11 Thread Maxim Kochetkov
o make checkpatch happy. Fixes: be7ecbd240b2 ("soc: fsl: qe: convert QE interrupt controller to platform_device") Signed-off-by: Maxim Kochetkov Reported-by: Dan Carpenter --- drivers/soc/fsl/qe/qe_ic.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/soc

Re: [PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-06 Thread Maxim Kochetkov
03.08.2021 20:51, Saravana Kannan wrote: So lets convert this driver to simple platform_device with probe(). Also use platform_get_ and devm_ family function to get/allocate resources and drop unused .compatible = "qeic". Yes, please! Should I totally drop { .type = "qeic"}, or keep?

[PATCH v4] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-08-03 Thread Maxim Kochetkov
[1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mlxb9po8myyk6u2vhpvwtmsa5nkd-ywh5xh...@mail.gmail.com Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") Signed-off-by: Maxim Kochet

[PATCH v3] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-07-26 Thread Maxim Kochetkov
[1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mlxb9po8myyk6u2vhpvwtmsa5nkd-ywh5xh...@mail.gmail.com Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") Signed-off-by: Maxim Kochetko

[PATCH v2] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-07-19 Thread Maxim Kochetkov
[1] - https://lore.kernel.org/lkml/CAGETcx9PiX==mlxb9po8myyk6u2vhpvwtmsa5nkd-ywh5xh...@mail.gmail.com Fixes: e590474768f1 ("driver core: Set fw_devlink=on by default") Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") Signed-off-by: Maxim Kochetko

Re: [PATCH] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-07-19 Thread Maxim Kochetkov
15.07.2021 01:29, Li Yang wrote: From the original code, this should be type = "qeic". It is not defined in current binding but probably needed for backward compatibility. I took these strings from this part: np = of_find_compatible_node(NULL, NULL, "fsl,qe-ic"); if (!np) {

[PATCH] soc: fsl: qe: convert QE interrupt controller to platform_device

2021-07-05 Thread Maxim Kochetkov
devlink=on by default") Fixes: ea718c699055 ("Revert "Revert "driver core: Set fw_devlink=on by default""") Signed-off-by: Maxim Kochetkov --- drivers/soc/fsl/qe/qe_ic.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(

Re: [PATCH v2 devicetree 0/2] Add Seville Ethernet switch to T1040RDB

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: Seville is a DSA switch that is embedded inside the T1040 SoC, and supported by the mscc_seville DSA driver inside drivers/net/dsa/ocelot. This series adds this switch to the SoC's dtsi files and to the T1040RDB board

Re: [PATCH v2 devicetree 2/2] powerpc: dts: t1040rdb: add ports for Seville Ethernet switch

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: From: Vladimir Oltean Define the network interface names for the switch ports and hook them up to the 2 QSGMII PHYs that are onboard. A conscious decision was taken to go along with the numbers that are written on the

Re: [PATCH v2 devicetree 1/2] powerpc: dts: t1040: add bindings for Seville Ethernet switch

2020-09-29 Thread Maxim Kochetkov
Reviewed-by: Maxim Kochetkov 29.09.2020 14:32, Vladimir Oltean пишет: Add the description of the embedded L2 switch inside the SoC dtsi file for NXP T1040. Signed-off-by: Vladimir Oltean --- Changes in v2: Make switch node disabled by default. arch/powerpc/boot/dts/fsl/t1040si-post.dtsi