Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

2011-06-21 Thread Matt Mackall
On Tue, 2011-06-21 at 11:38 -0500, Kim Phillips wrote: > [adding linux-crypto] > > On Tue, 21 Jun 2011 10:56:02 -0500 > Matt Mackall wrote: > > > On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote: > > > +static struct hwrng ppc4xx_rng = { > > > + .na

Re: [PATCH] hwrng: ppc4xx - add support for ppc4xx TRNG

2011-06-21 Thread Matt Mackall
On Tue, 2011-06-21 at 08:19 -0400, Josh Boyer wrote: > Various PowerPC 4xx SoCs contain a TRNG embedded in the Security function. > This adds a device driver for that TRNG. > > Signed-off-by: Josh Boyer Looks good. Acked-by: Matt Mackall > --- > drivers/char/hw_random/K

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-18 Thread Matt Mackall
On Fri, 2008-01-18 at 18:23 +0100, Mariusz Kozlowski wrote: > Hello, > > > > Do we need `offset' at all? > > > > Looks like no. > > > > I wonder if there's a good argument for adding a pte_offset_val() which > > would let us do: > > > > pteval = pte_offset_val(pmd, addr); > > > > and shrink t

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 17:07 -0800, Andrew Morton wrote: > That worked out nicely. Cool, feel free to add: Signed-off-by: Matt Mackall <[EMAIL PROTECTED]> > Wasn't the old code potentially pte_unmap()ping the wrong address? If we > enter with addr==end? Yes, that was bust

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 16:29 -0800, Andrew Morton wrote: > Do we need `offset' at all? Looks like no. I wonder if there's a good argument for adding a pte_offset_val() which would let us do: pteval = pte_offset_val(pmd, addr); and shrink the map/unmap window and overhead here and possibly elsew

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 16:05 -0800, Andrew Morton wrote: > On Thu, 17 Jan 2008 17:39:54 -0600 > Matt Mackall <[EMAIL PROTECTED]> wrote: > > > > > On Thu, 2008-01-17 at 14:51 -0800, Andrew Morton wrote: > > > > proc_loop: /proc/3731/task/3731/pagemap > &

Re: 2.6.24-rc8-mm1: powerpc oopses

2008-01-17 Thread Matt Mackall
On Thu, 2008-01-17 at 14:51 -0800, Andrew Morton wrote: > > proc_loop: /proc/3731/task/3731/pagemap > > kernel: BUG: sleeping function called from invalid context at > > fs/proc/task_mmu.c:554 > > kernel: in_atomic():1, irqs_disabled():0 > > kernel: Call Trace: > > kernel: [cf1cddf0] [c000840c] s

Re: [PATCH/RFC] powerpc: Pass PID argument to _tlbie (WAS: Apparent kernel bug with GDB on ppc405)

2007-10-29 Thread Matt Mackall
Ok, just backported the 405 bits of this to my client's sad sad MV 2.6.10 kernel and it appears to work fine. Only tricky bit was context.id -> context. So: Tested-by: Matt Mackall <[EMAIL PROTECTED]> And her