tribute'
https://git.kernel.org/mkp/scsi/c/a8116aa2898b
[09/11] scsi: qedi: Constify 'struct bin_attribute'
https://git.kernel.org/mkp/scsi/c/f9d0a8450ee3
[10/11] scsi: qla2xxx: Constify 'struct bin_attribute'
https://git.kernel.org/mkp/scsi/c/06a9ceb95f8
Joel,
> Add the const qualifier to all the ctl_tables in the tree except the
> ones in ./net dir. The "net" sysctl code is special as it modifies the
> arrays before passing it on to the registration function.
Reviewed-by: Martin K. Petersen # SCSI
--
Martin K. Peterse
Thomas,
> The sysfs core now allows instances of 'struct bin_attribute' to be
> moved into read-only memory. Make use of that to protect them against
> accidental or malicious modifications.
Applied to 6.14/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Thomas,
> Using the macro saves some lines of code and prepares the attributes for
> the general constifications of struct bin_attributes.
>
> While at it also constify the callback parameters.
Looks OK to me.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen
.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Thomas,
> The is_bin_visible() callbacks should not modify the struct
> bin_attribute passed as argument. Enforce this by marking the argument
> as const.
>
> As there are not many callback implementers perform this change
> throughout the tree at once.
For scsi:
Acked-by:
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
n
> a position to access cxlflash hardware, so remove him from the maintainers
> list.
>
> [...]
Applied to 6.10/scsi-queue, thanks!
[1/2] MAINTAINERS: Make cxlflash obsolete
https://git.kernel.org/mkp/scsi/c/6d97e807c906
--
Martin K. Petersen Oracle Linux Engineering
andling & drop bogus warn
https://git.kernel.org/mkp/scsi/c/d4e655c49f47
--
Martin K. Petersen Oracle Linux Engineering
Alexander,
> commit 27f58c04a8f4 ("scsi: sg: Avoid sg device teardown race")
> introduced an incorrect WARN_ON_ONCE() and missed a sequence where
> sg_device_destroy() was used after scsi_device_put().
Applied to 6.9/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
t; "make W=1".
>
> Unfortunately, gcc produces a lot more warnings when the option
> is enabled, so it's not yet possible to turn it on both both
> compilers.
>
> [...]
Applied to 6.9/scsi-fixes, thanks!
[7/9] scsi: mylex: fix sysfs buffer lengths
https://git.kernel.org/mk
git.kernel.org/mkp/scsi/c/01105c23de42
[27/42] drivers/scsi/isci: Convert snprintf to sysfs_emit
https://git.kernel.org/mkp/scsi/c/5fbf37e53091
[34/42] drivers/scsi/pm8001: Convert snprintf to sysfs_emit
https://git.kernel.org/mkp/scsi/c/8179041f801d
--
Martin K. Petersen Oracle Linux Engineering
s\n",
> |hostdata->madapter_info.partition_name);
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: replace deprecated strncpy with strscpy
https://git.kernel.org/mkp/scsi/c/712b3f43ba0e
--
Martin K. Petersen Oracle Linux Engineering
erty names from
> which they are derived are also NUL-terminated.
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: ibmvfc: replace deprecated strncpy with strscpy
https://git.kernel.org/mkp/scsi/c/a9baa16b4fc1
--
Martin K. Petersen Oracle Linux Engineering
;
> The most recent CPU it checks for is Power4+ which was removed in commit
> 471d7ff8b51b ("powerpc/64s: Remove POWER4 support").
>
> [...]
Applied to 6.8/scsi-queue, thanks!
[1/1] scsi: ipr: Remove obsolete check for old CPUs
https://git.kernel.org/mkp/scsi/c/84e469
to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
to me too.
>
> Reviewed-by: Kees Cook
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Michael,
> The IPR driver has a routine to check whether it's running on certain
> CPU versions and if so whether the adapter is supported on that CPU.
Applied to 6.8/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Bjorn,
> So I kept these in the PCI tree:
>
> 420ac76610d7 ("scsi: lpfc: Use PCI_HEADER_TYPE_MFD instead of literal")
I merged this without seeing your note but I haven't pushed yet so I'll
just drop the commit.
--
Martin K. Petersen Oracle Linux Engineering
#x27;struct
ibmvfc_host'
https://git.kernel.org/mkp/scsi/c/78882c7657bb
--
Martin K. Petersen Oracle Linux Engineering
nstant-conversion]
> 650 | vhost->reinit = 1;
> | ^ ~
>
Applied to 6.7/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
6.6/scsi-queue, thanks!
[07/17] scsi: qlogicpti: mark qlogicpti_info() static
https://git.kernel.org/mkp/scsi/c/71cc486335c4
[11/17] scsi: gvp11: remove unused gvp11_setup() function
https://git.kernel.org/mkp/scsi/c/bfaa4a0ce1bb
--
Martin K. Petersen Oracle Linux Engineering
tches are based on linux-next-20230125.
>
> [...]
Applied to 6.3/scsi-queue, thanks!
[28/35] Documentation: target: correct spelling
https://git.kernel.org/mkp/scsi/c/c57ac5748be5
--
Martin K. Petersen Oracle Linux Engineering
to 6.1/scsi-fixes, thanks!
[1/1] ibmvfc: Avoid path failures during live migration
https://git.kernel.org/mkp/scsi/c/62fa3ce05d5d
--
Martin K. Petersen Oracle Linux Engineering
obsolete driver
https://git.kernel.org/mkp/scsi/c/b04e75a4a8a8
--
Martin K. Petersen Oracle Linux Engineering
eaks...
--
Martin K. Petersen Oracle Linux Engineering
https://git.kernel.org/mkp/scsi/c/aeaadcde1a60
--
Martin K. Petersen Oracle Linux Engineering
to 5.18/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
5e6b6f61e0
[13/16] scsi: mptsas: Use dma_alloc_coherent() in
mptsas_exp_repmanufacture_info()
https://git.kernel.org/mkp/scsi/c/7a960b3a5e37
[14/16] scsi: mptsas: Use dma_alloc_coherent()
https://git.kernel.org/mkp/scsi/c/76a334d756c5
[15/16] scsi: mptctl: Use dma_alloc_coherent()
https://gi
Christophe,
> This serie axes all the remaining usages of the deprecated
> "pci-dma-compat.h" API.
Applied patches 10-15 to 5.17/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ry.
>
> Fix by passing GFP_KERNEL explicitly to dma_alloc_coherent().
>
> [...]
Applied to 5.16/scsi-queue, thanks!
[1/1] ibmvscsi: use GFP_KERNEL with dma_alloc_coherent in initialize_event_pool
https://git.kernel.org/mkp/scsi/c/3319a8ba82b9
--
Martin K. Petersen Oracle Linux Engineering
Michael,
> It's marked "Changes Requested" here:
Not sure why.
Applied to 5.16/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Tue, 17 Aug 2021 21:43:37 +0800, John Garry wrote:
> Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag.
>
>
>
>
Applied to 5.15/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Stop using scsi_cmnd.tag
https://git.kernel.org/mkp/scsi/c/6a036ce0e25c
--
John,
> Use scsi_cmd_to_rq(scsi_cmnd)->tag in preference to scsi_cmnd.tag.
Applied to 5.15/scsi-staging and rebased for bisectability.
Just to be picky it looks like there's another scsi_cmmd tag lurking in
qla1280.c but it's sitting behind an #ifdef DEBUG_QLA1280.
--
Ma
ixes, thanks!
[1/1] ibmvfc: fix command state accounting and stale response detection
https://git.kernel.org/mkp/scsi/c/73bfdf707d01
--
Martin K. Petersen Oracle Linux Engineering
Christoph,
> this series switches the core block layer code and all users of the
> existing bvec kmap helpers to use kmap_local_page. Drivers that
> currently use open coded kmap_atomic calls will converted in a follow
> on series.
Looks OK to me.
Reviewed-by: Martin K. Petersen
he reset / reenable
> state until we've finished processing the reset or reenable.
Applied to 5.13/scsi-queue, thanks!
[1/1] ibmvfc: Fix invalid state machine BUG_ON
https://git.kernel.org/mkp/scsi/c/15cfef8623a4
--
Martin K. Petersen Oracle Linux Engineering
..]
Applied to 5.13/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
https://git.kernel.org/mkp/scsi/c/0d556a21a9da
--
Martin K. Petersen Oracle Linux Engineering
: ibmvscsi: Fix a bunch of kernel-doc related issues
https://git.kernel.org/mkp/scsi/c/841d7df0d416
[34/36] scsi: ibmvscsi: ibmvfc: Fix a bunch of misdocumentation
https://git.kernel.org/mkp/scsi/c/dd9c77297148
[35/36] scsi: ibmvscsi_tgt: ibmvscsi_tgt: Remove duplicate section
race in ibmvfc_wait_for_ops
https://git.kernel.org/mkp/scsi/c/8b1c9b202549
[2/2] ibmvfc: make ibmvfc_wait_for_ops MQ aware
https://git.kernel.org/mkp/scsi/c/62fc2661482b
--
Martin K. Petersen Oracle Linux Engineering
Lee,
> This set is part of a larger effort attempting to clean-up W=1 kernel
> builds, which are currently overwhelmingly riddled with niggly little
> warnings.
Applied to 5.13/scsi-staging, thanks! I fixed a few little things.
--
Martin K. Petersen Oracle Linux Engineering
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
kobj_to_dev()
https://git.kernel.org/mkp/scsi/c/18c2a59a4190
--
Martin K. Petersen Oracle Linux Engineering
of a hotplug remove.
>
> Fix this issue by freeing the buffer allocation in ibmvfc_free_mem().
Applied to 5.12/scsi-fixes, thanks!
[1/1] ibmvfc: free channel_setup_buf during device tear down
https://git.kernel.org/mkp/scsi/c/febb0cc847e7
--
Martin K. Petersen Oracle Linux Engineering
perform channel enquiry after LPM
https://git.kernel.org/mkp/scsi/c/f4c5e949056d
--
Martin K. Petersen Oracle Linux Engineering
On Mon, 18 Jan 2021 11:13:46 +, Colin King wrote:
> There is a spelling mistake in a ibmvfc_dbg debug message. Fix it.
Applied to 5.12/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Fix spelling mistake "succeded" -> "succeeded"
https://git.kernel.org/mkp/scsi/c/
ibmvfc: enable MQ and set reasonable defaults
https://git.kernel.org/mkp/scsi/c/9000cb998bcf
[21/21] ibmvfc: provide modules parameters for MQ settings
https://git.kernel.org/mkp/scsi/c/032d1900869f
--
Martin K. Petersen Oracle Linux Engineering
Colin,
> There is a spelling mistake in a ibmvfc_dbg debug message. Fix it.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
s to associated VIOS HW backed channels.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
vfc: complete commands outside the host/queue lock
https://git.kernel.org/mkp/scsi/c/1f4a4a19508d
[5/5] ibmvfc: relax locking around ibmvfc_queuecommand
https://git.kernel.org/mkp/scsi/c/654080d02edb
--
Martin K. Petersen Oracle Linux Engineering
; from the host lock reducing lock contention while also relaxing
> locking for submissions and completions to simply the list lock of the
> queue in question.
Applied to 5.12/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
e] val
> ibmvfc.c:2375:36: sparse: got struct ibmvfc_event *[assigned] evt
>
> [...]
Applied to 5.11/scsi-fixes, thanks!
[1/1] ibmvfc: fix missing cast of ibmvfc_event pointer to u64 handle
https://git.kernel.org/mkp/scsi/c/901d01c8e50c
--
Martin K. Petersen Oracle Linux Engineering
l patches.
thanks!
--
Martin K. Petersen Oracle Linux Engineering
kp/scsi/c/5a9d16f71c26
[5/6] scsi: ibmvfc: Add support for target_wwpn field in v2 MADs and vfcFrame
https://git.kernel.org/mkp/scsi/c/ebc7c74bd2dc
[6/6] scsi: ibmvfc: Advertise client support for targetWWPN using v2 commands
https://git.kernel.org/mkp/scsi/c/e4af87b7079e
--
Martin K. Petersen Oracle Linux Engineering
emove trailing semicolon
https://git.kernel.org/mkp/scsi/c/4e0716199ab6
[3/3] scsi: ibmvfc: Use correlation token to tag commands
https://git.kernel.org/mkp/scsi/c/2aa0102c6688
--
Martin K. Petersen Oracle Linux Engineering
and exposing
> the capability to the VIOS. This targetWWPN support is a prerequisuite
> for upcoming channelization/MQ support.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
e your best judgment to optimize for readability.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> I'm going to have to ask that this patch be unstaged.
Done!
--
Martin K. Petersen Oracle Linux Engineering
ising client
> support for targetWWPN with the VIOS. This latter capability flag will
> be required for future clients capable of requesting multiple hardware
> queues from the host adapter.
Applied to 5.11/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> After a loss of tranport due to an adatper migration or
> crash/disconnect from the host partner there is a tiny window where we
> can race adjusting the request_limit of the adapter.
Applied to 5.10/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
tps://git.kernel.org/mkp/scsi/c/2584e5aef87a
--
Martin K. Petersen Oracle Linux Engineering
all, since this
> should all be done in a single threaded loop from the discovery
> thread, but let's fix it up anyway to be safe.
Applied to 5.10/scsi-staging, thanks!
--
Martin K. Petersen Oracle Linux Engineering
rder to get the VIOS and client LPAR in sync.
>
> [...]
Applied to 5.10/scsi-queue, thanks!
[1/1] scsi: ibmvfc: Avoid link down on FS9100 canister reboot
https://git.kernel.org/mkp/scsi/c/4b29cb6197d9
--
Martin K. Petersen Oracle Linux Engineering
Brian,
> When a canister on a FS9100, or similar storage, running in NPIV mode,
> is rebooted, its WWPNs will fail over to another canister.
[...]
Applied to 5.10/scsi-staging, thanks! I fixed a bunch of checkpatch
warnings.
--
Martin K. Petersen Oracle Linux Engineering
Martin K. Petersen Oracle Linux Engineering
Jing,
> Fix to return error code PTR_ERR() from the error handling case instead
> of 0.
Applied to 5.10/scsi-staging. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
b: zstd: Avoid comma separated statements
(no commit info)
[27/29] ipv6: fib6: Avoid comma separated statements
(no commit info)
[28/29] sunrpc: Avoid comma separated statements
(no commit info)
[29/29] tools: Avoid comma separated statements
(no commit info)
--
Tyrel,
> Update ibmvfc.h structs to use the preferred __packed and __aligned()
> attribute macros defined in include/linux/compiler_attributes.h in place
> of __attribute__().
Applied 1+2 to my 5.10 staging tree. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> Fixup complier errors from neglected commit --amend
Bunch of formatting-related checkpatch warnings. Please fix.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
On Tue, 7 Jul 2020 11:03:54 -0700, Randy Dunlap wrote:
> Drop doubled words in various parts of Documentation/.
>
> [...]
Applied to 5.9/scsi-queue, thanks!
[17/20] scsi: advansys: docs: Eliminate duplicated word
https://git.kernel.org/mkp/scsi/c/3010dfb0b77c
--
Martin K.
lso very happy to bring them back if somebody
uses them or - even better - are willing to step up and maintain them.
I don't particularly like the notion of a driver being orphaned because
all that really means is that the driver transitions from being (at
least partially) somebody els
o ever touch any of that again.
I could understand an objection if we were to entertain removing
sbp2. But really, how many people are setting up FireWire targets?
--
Martin K. Petersen Oracle Linux Engineering
with an addition in
> scripts/spelling.txt so it shouldn't re-appear ;-)
>
> [...]
Applied to 5.9/scsi-queue, thanks!
[06/17] scsi: Fix trivial spelling
https://git.kernel.org/mkp/scsi/c/0a19a725c0ed
--
Martin K. Petersen Oracle Linux Engineering
result after Live Partition Migration
> (LPM) we erroneously report the hosts info as our own.
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: Don't send host info in adapter info MAD after LPM
https://git.kernel.org/mkp/scsi/c/4919b33b63c8
--
Martin K. Petersen Oracle Linux Engineering
; 'ibmvscsi_module_exit' was not declared. Should it be static?
Applied to 5.8/scsi-queue, thanks!
[1/1] scsi: ibmvscsi: Make some functions static
https://git.kernel.org/mkp/scsi/c/1f93ad177d24
--
Martin K. Petersen Oracle Linux Engineering
eading to a BUG assert.
Applied to 5.7/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
scsi/c/cff6a5746645
--
Martin K. Petersen Oracle Linux Engineering
Gustavo,
> Mark switch cases where we are expecting to fall through.
Applied to 5.4/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> While removing an ibmvfc client adapter a WARN_ON like the following
> WARN_ON is seen in the kernel log:
Applied to 5.3/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
ed to 5.3/scsi-queue, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Tyrel,
> Wire up the host_reset function in our driver_template to allow a user
> requested adpater reset via the host_reset sysfs attribute.
Series applied to 5.3/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
whether a command was
> successfully cancelled. The following real log message for example it
> is unclear if the transaction was actaully cancelled.
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
ls
> to prevent concurrent updates as is done similarly in the ibmvfc
> driver and ipr driver.
Applied to 5.1/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
NULL pointer
> dereference as seen here:
Applied to 5.1/scsi-fixes. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Vaibhav,
> Presently when an error is encountered during probe of the cxlflash
> adapter, a deadlock is seen with cpu thread stuck inside
> cxlflash_remove(). Below is the trace of the deadlock as logged by
> khungtaskd:
Applied to 5.0/scsi-fixes, thanks!
--
Martin K. Petersen
Uma,
> This patch series adds few improvements to the cxlflash driver and it
> also contains couple of bug fixes.
Applied to 4.18/scsi-queue, thank you!
--
Martin K. Petersen Oracle Linux Engineering
e cycle to ensure proper zeroday coverage for all these
commits.
I have started a 4.18/scsi-queue branch to hold this series for now.
The 4.18 branch will be rebased once 4.17rc1 is out in a few weeks. Your
changes won't show up in for-next until then either.
Thanks!
--
Martin K. Petersen Oracle Linux Engineering
Joe,
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
drivers/scsi and drivers/message/fusion parts look fine.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
sting
> core driver that communicates with the AFU.
This one has been sitting for a week without any reviews. Andrew, when
will you have time to take a look?
Being a pretty big chunk of code, I would like to merge it sooner rather
than later. Or we can postpone until 4.18, of course.
--
Mar
always being reported as zero by the
> driver.
Applied to 4.16/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
Uma,
> This patch series contains miscellaneous fixes. The first patch fixes
> a bug while the rest improve the code structure and prepare the code
> for future enhancements.
Added stable tag to first patch and applied series to
4.16/scsi-queue. Thank you!
--
Martin K. Petersen
Joe,
> Some functions definitions have either the initial open brace and/or
> the closing brace outside of column 1.
>
> Move those braces to column 1.
SCSI bits look OK.
Acked-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Kees,
> In preparation for unconditionally passing the struct timer_list
> pointer to all timer callbacks, switch to using the new timer_setup()
> and from_timer() to pass the timer pointer explicitly.
Reviewed-by: Martin K. Petersen
--
Martin K. Petersen Oracle Linux Engineering
Uma,
> This patch series contains miscellaneous fixes. All three patches resolve
> minor issues.
>
> This series is intended for 4.15 and is bisectable.
Applied to 4.15/scsi-queue. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
.14/scsi-queue. Thanks!
--
Martin K. Petersen Oracle Linux Engineering
onal testing before I submit, as it will impact much more than
> just this case.
I agree. In this case where a command is not supported, a check
condition would be a better way to signal the failure to the SCSI
midlayer.
--
Martin K. Petersen Oracle Linux Engineering
Brian,
> Since ipr RAID arrays do not support the MAINTENANCE_IN /
> MI_REPORT_SUPPORTED_OPERATION_CODES, set no_report_opcodes to prevent
> it from being sent.
Applied to 4.13/scsi-fixes. Thank you!
--
Martin K. Petersen Oracle Linux Engineering
Brian,
> Fixes the following lockdep warning that can occur when scsi-mq is
> enabled with ipr due to ipr calling scsi_unblock_requests from irq
> context. The fix is to move the call to scsi_unblock_requests to ipr's
> existing workqueue.
Applied to 4.13/scsi-fixes. Thank y
1 - 100 of 135 matches
Mail list logo
