Re: [PATCH RESEND v3 0/4] ASoC: fsl: fsl_qmc_audio: Reduce amount of interrupts

2025-09-19 Thread Mark Brown
On Thu, 18 Sep 2025 17:34:07 +0200, Christophe Leroy wrote: > This is a RESEND of v3 sent one month ago, see: > https://lore.kernel.org/all/cover.1754993232.git.christophe.le...@csgroup.eu/ > > This series reduces significantly the amount of interrupts on > fsl_qmc_audio device. > > Patches 1 and

Re: [PATCH RESEND v3 0/4] ASoC: fsl: fsl_qmc_audio: Reduce amount of interrupts

2025-09-18 Thread Mark Brown
On Thu, Sep 18, 2025 at 05:34:07PM +0200, Christophe Leroy wrote: > This is a RESEND of v3 sent one month ago, see: > https://lore.kernel.org/all/cover.1754993232.git.christophe.le...@csgroup.eu/ That's a link to v2 which had substantial review comments and build issues... I did actually go searc

Re: [PATCH v3 0/4] ASoC: fsl: fsl_qmc_audio: Reduce amount of interrupts

2025-09-18 Thread Mark Brown
On Thu, Sep 18, 2025 at 08:12:21AM +0200, Christophe Leroy wrote: > Hi Mark, Liam, > > Le 18/08/2025 à 10:19, Christophe Leroy a écrit : > > This series reduces significantly the amount of interrupts on > > fsl_qmc_audio device. > > I can't see this series in linux-next. > > I see in patchwork [

Re: [PATCH] ASoC: imx-hdmi: remove cpu_pdev related code

2025-08-25 Thread Mark Brown
On Wed, 20 Aug 2025 11:16:41 +0800, Shengjiu Wang wrote: > If a defer probe happens for the cpu device, the return value for > cpu_pdev "ret = -EINVAL" breaks defer probe. As the cpus->dai_name > can be replaced by cpus->of_node, to simplify the code, remove related > code for cpu_pdev. > > Appl

Re: [PATCH 0/3] ASoC: Use kcalloc() instead of kzalloc()

2025-08-20 Thread Mark Brown
On Wed, 20 Aug 2025 20:34:17 +0800, Qianfeng Rong wrote: > Replace devm_kzalloc() with devm_kcalloc() in sound/soc. As noted in the > kernel documentation [1], open-coded multiplication in allocator arguments > is discouraged because it can lead to integer overflow. > > Using devm_kcalloc() provi

Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config

2025-08-14 Thread Mark Brown
On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote: > While working on a driver using regmap with MMIO, I wondered if I need > to set 'fast_io' in the config. Turned out I don't need to, so I added > documentation for it with commit ffc72771ff6e ("regmap: Annotate that > MMIO implies fast IO").

Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config

2025-08-14 Thread Mark Brown
On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote: > While working on a driver using regmap with MMIO, I wondered if I need > to set 'fast_io' in the config. Turned out I don't need to, so I added > documentation for it with commit ffc72771ff6e ("regmap: Annotate that > MMIO implies fast IO").

Re: (subset) [PATCH 00/21] treewide: remove unneeded 'fast_io' parameter in regmap_config

2025-08-13 Thread Mark Brown
On Wed, 13 Aug 2025 18:14:46 +0200, Wolfram Sang wrote: > While working on a driver using regmap with MMIO, I wondered if I need > to set 'fast_io' in the config. Turned out I don't need to, so I added > documentation for it with commit ffc72771ff6e ("regmap: Annotate that > MMIO implies fast IO").

Re: [PATCH] ASoC: fsl_sai: replace regmap_write with regmap_update_bits

2025-08-12 Thread Mark Brown
On Thu, 07 Aug 2025 10:03:18 +0800, Shengjiu Wang wrote: > Use the regmap_write() for software reset in fsl_sai_config_disable would > cause the FSL_SAI_CSR_BCE bit to be cleared. Refer to > commit 197c53c8ecb34 ("ASoC: fsl_sai: Don't disable bitclock for i.MX8MP") > FSL_SAI_CSR_BCE should not be c

Re: [PATCH 0/2] ASoC: fsl_xcvr: get channel status data in two cases

2025-07-24 Thread Mark Brown
On Thu, 10 Jul 2025 11:04:03 +0800, Shengjiu Wang wrote: > There is two different cases for getting channel status data: > 1. With PHY exists, there is firmware running on M core, the firmware > should fill the channel status to RAM space, driver need to read them > from RAM. > 2. Without PHY, the

Re: [PATCH v2] ASoC: imx-card: Add WM8524 support

2025-07-24 Thread Mark Brown
On Wed, 23 Jul 2025 16:37:25 +0900, Chancel Liu wrote: > WM8524 is a stereo DAC. Add support for this codec in imx-card ASoC > machine driver. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: imx-card: Add WM8524 support co

Re: [PATCH] ASoC: imx-card: Add WM8524 support

2025-07-24 Thread Mark Brown
On Thu, 19 Jun 2025 15:24:13 +0900, Chancel Liu wrote: > WM8524 is a stereo DAC. Add support for this codec in imx-card ASoC > machine driver. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: imx-card: Add WM8524 support co

Re: [PATCH] ASoC: fsl-asoc-card: add sysclk_ratio for calculate sysclk frequency

2025-07-14 Thread Mark Brown
On Tue, 08 Jul 2025 16:53:17 +0800, Shengjiu Wang wrote: > The sysclk frequency can be calculated from sample rate multiply ratio. > When sysclk_freq is not configured, but sysclk_ratio is configured, then > calculate sysclk frequency according to sysclk_ratio. > > Apply this change for wm8524 cod

Re: [PATCH 0/2] ASoC: fsl_mqs: support MQS2 on i.MX94 platform

2025-07-03 Thread Mark Brown
On Fri, 20 Jun 2025 13:52:27 +0800, Shengjiu Wang wrote: > ASoC: fsl_mqs: support MQS2 on i.MX94 platform > > Shengjiu Wang (2): > ASoC: fsl_mqs: Distinguish different modules by system manager indices > ASoC: fsl_mqs: rename system manager indices for i.MX95 > > include/linux/firmware/imx/sm

Re: [PATCH] ASoC: fsl_asrc: use internal measured ratio for non-ideal ratio mode

2025-06-30 Thread Mark Brown
On Wed, 25 Jun 2025 10:05:04 +0800, Shengjiu Wang wrote: > When USRC=0, there is underrun issue for the non-ideal ratio mode; > according to the reference mannual, the internal measured ratio can be > used with USRC=1 and IDRC=0. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git

Re: [PATCH v4] ASoC: fsl_sai: Force a software reset when starting in consumer mode

2025-06-30 Thread Mark Brown
On Thu, 26 Jun 2025 09:08:25 -0400, Arun Raghavan wrote: > On an imx8mm platform with an external clock provider, when running the > receiver (arecord) and triggering an xrun with xrun_injection, we see a > channel swap/offset. This happens sometimes when running only the > receiver, but occurs rel

Re: [PATCH v2] ASoC: fsl_sai: Force a software reset when starting in consumer mode

2025-06-26 Thread Mark Brown
On Wed, Jun 25, 2025 at 07:56:16PM -0400, Arun Raghavan wrote: > From: Arun Raghavan > > In a setup with an external clock provider, when running the receiver > (arecord) and triggering an xrun with xrun_injection, we see a channel > swap/offset. This happens sometimes when running only the recei

Re: [PATCH 0/8] ASoC: codecs: More const and unused member cleanups

2025-06-09 Thread Mark Brown
On Wed, 28 May 2025 21:59:54 +0200, Krzysztof Kozlowski wrote: > Make static data const for code safety and drop some unused fields in > structs. > > This is based on for-v6.16 branch in ASoC tree for context in wcd938x > driver. > > Best regards, > Krzysztof > > [...] Applied to https://gi

Re: [PATCH v2 1/6] ASoC: ppc: Use helper function for_each_child_of_node_scoped()

2025-05-22 Thread Mark Brown
On Thu, May 22, 2025 at 01:02:54PM +0800, Ai Chao wrote: > The for_each_child_of_node_scoped() helper provides a scope-based > clean-up functionality to put the device_node automatically, and > as such, there is no need to call of_node_put() directly. > > Thus, use this helper to simplify the code

Re: [PATCH] ASoC: fsl_xcvr: update platform driver name

2025-05-16 Thread Mark Brown
On Fri, 16 May 2025 16:03:34 +0800, Shengjiu Wang wrote: > XCVR driver is not only used for i.MX8MP platform, so update driver name > to make it more generic. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_xcvr: update plat

Re: [PATCH 1/2] ASoC: fsl_rpmsg: Configure CPU DAI for card that sits on rpmsg-micfil-channel

2025-05-02 Thread Mark Brown
On Mon, 21 Apr 2025 19:57:00 +0900, Chancel Liu wrote: > Sound card that sits on rpmsg-micfil-channel has different settings on > CPU DAI. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/2] ASoC: fsl_rpmsg: Configure CPU DAI for card tha

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-29 Thread Mark Brown
On Mon, Apr 28, 2025 at 11:20:42AM +0200, Christophe Leroy wrote: > Le 10/04/2025 à 15:47, Mark Brown a écrit : > Would it be possible to get this patch into one of the v6.15 rc as it is a > bug fix ? It appears to be queued as a fix, could you be more specific please? Please delete

Re: [PATCH] ASoC: fsl_rpmsg: Remove useless return variable

2025-04-16 Thread Mark Brown
On Wed, 16 Apr 2025 12:14:31 +0800, Chen Ni wrote: > Remove unnecessary return variable and compress the return logic. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl_rpmsg: Remove useless return variable commit: ba05b

Re: [PATCH] ASoC: imx-card: Adjust over allocation of memory in imx_card_parse_of()

2025-04-14 Thread Mark Brown
On Sun, 06 Apr 2025 16:08:54 -0500, Chenyuan Yang wrote: > Incorrect types are used as sizeof() arguments in devm_kcalloc(). > It should be sizeof(dai_link_data) for link_data instead of > sizeof(snd_soc_dai_link). > > This is found by our static analysis tool. > > > [...] Applied to https:

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Reset audio data pointers on TRIGGER_START event

2025-04-10 Thread Mark Brown
On Thu, 10 Apr 2025 11:16:43 +0200, Herve Codina wrote: > On SNDRV_PCM_TRIGGER_START event, audio data pointers are not reset. > > This leads to wrong data buffer usage when multiple TRIGGER_START are > received and ends to incorrect buffer usage between the user-space and > the driver. Indeed, th

Re: [PATCH] ASoC: fsl_asrc_dma: get codec or cpu dai from backend

2025-04-09 Thread Mark Brown
On Wed, 19 Mar 2025 11:35:04 +0800, Shengjiu Wang wrote: > With audio graph card, original cpu dai is changed to codec device in > backend, so if cpu dai is dummy device in backend, get the codec dai > device, which is the real hardware device connected. > > The specific case is ASRC->SAI->AMIX->C

Re: [PATCH 0/4] ASoC: fsl_sai: add several improvements

2025-04-08 Thread Mark Brown
On Fri, 28 Mar 2025 16:57:40 +0800, Shengjiu Wang wrote: > Add several improvements for the sai interface. > 1.allow to set mclk rate with zero clk_id for master mode > 2.add xlate_tdm_slot_mask() callback to avoid channel constrain > 3.separate 'is_dsp_mode' for tx and rx > 4.separate set_tdm_slot

Re: [PATCH v1] ASoC: imx-card: Add NULL check in imx_card_probe()

2025-04-05 Thread Mark Brown
On Tue, 01 Apr 2025 22:25:10 +0800, Henry Martin wrote: > devm_kasprintf() returns NULL when memory allocation fails. Currently, > imx_card_probe() does not check for this case, which results in a NULL > pointer dereference. > > Add NULL check after devm_kasprintf() to prevent this issue. > > >

Re: (subset) [PATCH v2 00/57] irqdomain: Cleanups and Documentation

2025-03-25 Thread Mark Brown
On Wed, 19 Mar 2025 10:28:53 +0100, Jiri Slaby (SUSE) wrote: > tl;dr if patches are agreed upon, I ask subsys maintainers to take the > respective ones via their trees (as they are split per subsys), so that > the IRQ tree can take only the rest. That would minimize churn/conflicts > during merges.

Re: [PATCH v2 00/13] arch, mm: reduce code duplication in mem_init()

2025-03-13 Thread Mark Brown
> * fix alignment in allocation of zero pages on s390 > * add Acked-by This resolves the issues for 32 bit arm, at least the v7 boards: Tested-by: Mark Brown My v5 and v6 boards are having issues but I think that's unrelated infrastructure (in one case definitely so). signature.asc Description: PGP signature

Re: [PATCH 10/13] arch, mm: set high_memory in free_area_init()

2025-03-12 Thread Mark Brown
On Tue, Mar 11, 2025 at 10:41:28PM +0100, Geert Uytterhoeven wrote: > On Tue, 11 Mar 2025 at 22:33, Mark Brown wrote: > > [0.00] efi: UEFI not found. > > [0.00] cma: Reserved 64 MiB at 0x > > - I'd only been sampling the logs for the physical pl

Re: [PATCH 10/13] arch, mm: set high_memory in free_area_init()

2025-03-11 Thread Mark Brown
On Tue, Mar 11, 2025 at 11:06:56PM +0200, Mike Rapoport wrote: > On Tue, Mar 11, 2025 at 05:51:06PM +0000, Mark Brown wrote: > > This patch appears to be causing breakage on a number of 32 bit arm > > platforms, including qemu's virt-2.11,gic-version=3. Affected platforms >

Re: [PATCH 10/13] arch, mm: set high_memory in free_area_init()

2025-03-11 Thread Mark Brown
On Thu, Mar 06, 2025 at 08:51:20PM +0200, Mike Rapoport wrote: > From: "Mike Rapoport (Microsoft)" > > high_memory defines upper bound on the directly mapped memory. > This bound is defined by the beginning of ZONE_HIGHMEM when a system has > high memory and by the end of memory otherwise. > > A

Re: [PATCH 0/4] ASoC: fsl_audmix: support audio graph card for audmix

2025-03-04 Thread Mark Brown
On Wed, 26 Feb 2025 18:05:04 +0800, Shengjiu Wang wrote: > Change 'dais' property to be optional, that fsl_audmix device can be > linked with SAI device by audio graph card. > > Shengjiu Wang (4): > ASoC: dt-bindings: fsl,sai: Document audio graph port > ASoC: dt-bindings: fsl,audmix: Document

Re: [PATCH v3 0/2] ASoC: imx-card: support playback or capture only

2025-02-25 Thread Mark Brown
On Mon, 17 Feb 2025 10:17:13 +0800, Shengjiu Wang wrote: > Be similar to audio graph card, support playback or capture only for > imx-audio-card. > > imx-card can't directly refer to audio-graph-port.yaml, because it is > not based on 'ports'. Add playback-only and capture-only property > directly

Re: [PATCH 0/2] ASoC: imx-card: support playback or capture only

2025-02-25 Thread Mark Brown
On Tue, 11 Feb 2025 11:57:35 +0800, Shengjiu Wang wrote: > Be similar to audio graph card, support playback or capture only > for imx-audio-card. > > Shengjiu Wang (2): > ASoC: dt-bindings: imx-card: Add playback-only and capture-only > property > ASoC: imx-card: Add playback_only or captu

Re: [PATCH v3] ASoC: fsl: Rename stream name of SAI DAI driver

2025-02-25 Thread Mark Brown
On Mon, 17 Feb 2025 10:04:37 +0900, Chancel Liu wrote: > If stream names of DAI driver are duplicated there'll be warnings when > machine driver tries to add widgets on a route: > > [8.831335] fsl-asoc-card sound-wm8960: ASoC: sink widget CPU-Playback > overwritten > [8.839917] fsl-asoc-c

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Remove unnecessary bool conversions

2025-02-25 Thread Mark Brown
On Sun, 23 Feb 2025 21:27:41 +0100, Thorsten Blum wrote: > Remove unnecessary bool conversions and simplify the code. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next Thanks! [1/1] ASoC: fsl: fsl_qmc_audio: Remove unnecessary bool conversions

Re: [PATCH v2] ASoC: imx-audmix: remove cpu_mclk which is from cpu dai device

2025-02-13 Thread Mark Brown
On Thu, 13 Feb 2025 15:05:18 +0800, Shengjiu Wang wrote: > When defer probe happens, there may be below error: > > platform 5982.sai: Resources present before probing > > The cpu_mclk clock is from the cpu dai device, if it is not released, > then the cpu dai device probe will fail for the se

Re: [PATCH] ASoC: imx-audmix: release cpu_mclk clock at failure

2025-02-12 Thread Mark Brown
On Wed, Feb 12, 2025 at 05:38:16PM +0800, Shengjiu Wang wrote: > When defer probe happens, there may be below error: > > platform 5982.sai: Resources present before probing > > The cpu_mclk clock is from the cpu dai device, if it is > not released, then the cpu dai device probe will fail > fo

Re: [PATCH 2/2] ASoC: imx-card: Add playback_only or capture_only support

2025-02-12 Thread Mark Brown
On Wed, Feb 12, 2025 at 11:48:43AM +0800, Shengjiu Wang wrote: > On Tue, Feb 11, 2025 at 11:34 PM Frank Li wrote: > > On Tue, Feb 11, 2025 at 11:57:37AM +0800, Shengjiu Wang wrote: > > > With the DPCM case, the backend only support capture or > > > playback, then the linked frontend can only supp

Re: [PATCH] ASoC: fsl_micfil: Add decimation filter bypass mode support

2025-02-11 Thread Mark Brown
On Thu, 06 Feb 2025 11:03:06 +0800, Shengjiu Wang wrote: > When decimation filter bypass mode is enabled, PDM data can be > written into FIFO directly without any processing. > > The interface of this mode is DSD big endian format, when > user needs this format, then this mode is enabled. > > Thi

Re: [PATCH v2 00/12] YAML conversion of several Freescale/PowerPC DT bindings

2025-02-10 Thread Mark Brown
On Mon, Feb 10, 2025 at 03:57:42PM +, J. Neuschäfer wrote: > On Mon, Feb 10, 2025 at 12:59:35PM +0000, Mark Brown wrote: > > Please don't do this, it just makes it harder to merge things since it > > makes it look like there's cross tree merges needed whe

Re: [PATCH v2 00/12] YAML conversion of several Freescale/PowerPC DT bindings

2025-02-10 Thread Mark Brown
On Sat, Feb 08, 2025 at 02:20:47AM +, J. Neuschäfer wrote: > On Fri, Feb 07, 2025 at 09:38:05PM +0000, Mark Brown wrote: > > What's the story with dependencies here - why is all this stuff in one > > series? > The patches are independent of each other, except for the f

Re: [PATCH v2 00/12] YAML conversion of several Freescale/PowerPC DT bindings

2025-02-07 Thread Mark Brown
On Fri, Feb 07, 2025 at 10:30:17PM +0100, J. Neuschäfer via B4 Relay wrote: > This is a spin-off of the series titled > "powerpc: MPC83xx cleanup and LANCOM NWAPP2 board". > During the development of that series, it became clear that many > devicetree bindings for Freescale MPC8xxx platforms are

Re: [PATCH] ASoC: fsl_micfil: Enable default case in micfil_set_quality()

2025-02-03 Thread Mark Brown
On Thu, 16 Jan 2025 06:24:36 -0800, Nikita Zhandarovich wrote: > If 'micfil->quality' received from micfil_quality_set() somehow ends > up with an unpredictable value, switch() operator will fail to > initialize local variable qsel before regmap_update_bits() tries > to utilize it. > > While it is

Re: [PATCH 0/2] ASoC: fsl: two fixes for asrc memory to memory

2025-01-20 Thread Mark Brown
On Mon, 20 Jan 2025 16:19:36 +0800, Shengjiu Wang wrote: > 1. Fix the suspend failure for memory to peripheral function. > 2. Return error value for processing function. > > Shengjiu Wang (2): > ASoC: fsl_asrc_m2m: only handle pairs for m2m in the suspend > ASoC: fsl_asrc_m2m: return error val

Re: [PATCH 0/2] ASoC: fsl: Support micfil on i.MX943

2025-01-14 Thread Mark Brown
On Tue, 14 Jan 2025 18:27:18 +0800, Shengjiu Wang wrote: > On i.MX943, the FIFO data address is changed and the bit width > of CICOSR is changed. > Add a new compatible string and update driver for these changes. > > Shengjiu Wang (2): > ASoC: fsl_micfil: Add i.MX943 platform support > ASoC: d

Re: [PATCH 0/2] ASoC: fsl: Support MQS on i.MX943

2025-01-13 Thread Mark Brown
On Mon, 13 Jan 2025 17:03:19 +0800, Shengjiu Wang wrote: > There are two MQS instances on the i.MX943 platform. > The definition of bit positions in the control register are > different. In order to support these MQS modules, define > two compatible strings to distinguish them. > > Shengjiu Wang (

Re: [PATCH] ASoC: Use of_property_present() for non-boolean properties

2025-01-09 Thread Mark Brown
On Thu, 09 Jan 2025 12:23:00 -0600, Rob Herring (Arm) wrote: > The use of of_property_read_bool() for non-boolean properties is > deprecated in favor of of_property_present() when testing for property > presence. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.gi

Re: [PATCH] spi: fsl-spi: Remove display of virtual address

2025-01-09 Thread Mark Brown
On Thu, 09 Jan 2025 07:51:45 +0100, Christophe Leroy wrote: > The following appears in kernel log at boot: > > fsl_spi b01004c0.spi: at 0x(ptrval) (irq = 51), QE mode > > This is useless, so remove the display of that virtual address and > display the MMIO address instead, just like serial

Re: [PATCH] ASoC: fsl_asrc_m2m: force cast for snd_pcm_format_t type

2024-12-18 Thread Mark Brown
On Wed, 18 Dec 2024 10:43:58 +0800, Shengjiu Wang wrote: > Fix sparse warnings: > > fsl_asrc_m2m.c:360:45: sparse: warning: incorrect type in argument 1 > (different base types) > fsl_asrc_m2m.c:360:45: sparse:expected restricted snd_pcm_format_t > [usertype] pcm_forma > fsl_asrc_m2m.c:360:4

Re: [PATCH v7 0/6] ASoC: fsl: add memory to memory function for ASRC

2024-12-13 Thread Mark Brown
On Thu, 12 Dec 2024 15:45:03 +0800, Shengjiu Wang wrote: > This function is base on the accelerator implementation > for compress API: > 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") > > Audio signal processing also has the requirement for memory to > memory similar as Vi

Re: [PATCH v6 0/6] ASoC: fsl: add memory to memory function for ASRC

2024-12-13 Thread Mark Brown
On Wed, 11 Dec 2024 11:08:43 +0800, Shengjiu Wang wrote: > This function is base on the accelerator implementation > for compress API: > 04177158cf98 ("ALSA: compress_offload: introduce accel operation mode") > > Audio signal processing also has the requirement for memory to > memory similar as Vi

Re: [PATCH v7 4/6] ASoC: fsl_asrc_m2m: Add memory to memory function

2024-12-12 Thread Mark Brown
On Thu, Dec 12, 2024 at 03:45:07PM +0800, Shengjiu Wang wrote: > Implement the ASRC memory to memory function using > the compress framework, user can use this function with > compress ioctl interface. > > This feature can be shared by ASRC and EASRC drivers This breaks an x86 allmodconfig build

Re: [PATCH v2 0/2] ASoC: fsl: change IFACE_PCM to IFACE_MIXER

2024-12-11 Thread Mark Brown
On Tue, 26 Nov 2024 13:32:52 +0800, Shengjiu Wang wrote: > As the snd_soc_card_get_kcontrol() is updated to use > snd_ctl_find_id_mixer() in > commit 897cc72b0837 ("ASoC: soc-card: Use > snd_ctl_find_id_mixer() instead of open-coding") > which make the iface fix to be IFACE_MIXER. > > if driver ne

Re: [PATCH v6 4/6] ASoC: fsl_asrc_m2m: Add memory to memory function

2024-12-11 Thread Mark Brown
On Wed, Dec 11, 2024 at 11:08:47AM +0800, Shengjiu Wang wrote: > Implement the ASRC memory to memory function using > the compress framework, user can use this function with > compress ioctl interface. > > This feature can be shared by ASRC and EASRC drivers This breaks an imx_v6_v7_defconfig bui

Re: [PATCH 0/4] Add function to constrain rates

2024-12-10 Thread Mark Brown
On Tue, 26 Nov 2024 20:54:36 +0900, Chancel Liu wrote: > Platforms like i.MX93/91 only have one audio PLL. Some sample rates are > not supported. If the PLL source is used for 8kHz series rates, then > 11kHz series rates can't be supported. Add common function to constrain > rates according to diff

Re: [PATCH 0/2] ASoC: fsl_xcvr: Add suspend and resume support

2024-12-03 Thread Mark Brown
On Wed, 27 Nov 2024 11:00:33 +0800, Shengjiu Wang wrote: > Define regmap for PHY and PLL registers, the PHY and PLL > registers are accessed by AI interface in controller. > Then driver can use regcache to recover registers > after suspend and resume. > > Shengjiu Wang (2): > ASoC: fsl_xcvr: Us

Re: [PATCH v2] ASoC: fsl_mqs: Support accessing registers by scmi interface

2024-11-05 Thread Mark Brown
On Fri, 25 Oct 2024 14:29:35 +0800, Shengjiu Wang wrote: > On i.MX95, the MQS module in Always-on (AON) domain only can > be accessed by System Controller Management Interface (SCMI) > MISC Protocol. So define a specific regmap_config for the case. > > Applied to https://git.kernel.org/pub/s

Re: [PATCH AUTOSEL 6.11 05/32] ASoC: fsl_esai: change dev_warn to dev_dbg in irq handler

2024-10-28 Thread Mark Brown
On Mon, Oct 28, 2024 at 06:49:47AM -0400, Sasha Levin wrote: > From: Shengjiu Wang > > [ Upstream commit 54c805c1eb264c839fa3027d0073bb7f323b0722 ] > > Irq handler need to be executed as fast as possible, so > the log in irq handler is better to use dev_dbg which needs > to be enabled when debug

Re: [PATCH 0/2] ASoC: fsl_xcvr: enable some interrupts

2024-10-22 Thread Mark Brown
On Tue, 08 Oct 2024 14:27:51 +0800, Shengjiu Wang wrote: > Enable interrupt of cmdc status update and the interrupts for > wrong preamble received. > > Shengjiu Wang (2): > ASoC: fsl_xcvr: enable interrupt of cmdc status update > ASoC: fsl_xcvr: reset RX dpath after wrong preamble > > [...]

Re: [PATCH] ASoC: fsl_micfil: Add sample rate constraint

2024-10-22 Thread Mark Brown
On Mon, 14 Oct 2024 13:38:33 +0800, Shengjiu Wang wrote: > On some platforms, for example i.MX93, there is only one > audio PLL source, so some sample rate can't be supported. > If the PLL source is used for 8kHz series rates, then 11kHz > series rates can't be supported. > > So add constraints ac

Re: [PATCH] ASoC: fsl_micfil: Add a flag to distinguish with different volume control types

2024-10-18 Thread Mark Brown
On Thu, 17 Oct 2024 16:15:07 +0900, Chancel Liu wrote: > On i.MX8MM the register of volume control has positive and negative > values. It is different from other platforms like i.MX8MP and i.MX93 > which only have positive values. Add a volume_sx flag to use SX_TLV > volume control for this kind of

Re: (subset) [PATCH v3 00/16] timers: Cleanup delay/sleep related mess

2024-10-18 Thread Mark Brown
ps://lore.kernel.org/r/202410161059.a0f6ibwj-...@intel.com Oh, and for that: Reviewed-by: Mark Brown signature.asc Description: PGP signature

Re: (subset) [PATCH v3 00/16] timers: Cleanup delay/sleep related mess

2024-10-18 Thread Mark Brown
On Fri, Oct 18, 2024 at 10:06:33AM +0200, Anna-Maria Behnsen wrote: > Would it be ok for you, if the patch is routed through tip tree? kernel > test robot triggers a warning for htmldoc that there is a reference to > the no longer existing file 'timer-howto.rst': > https://lore.kernel.org/r/202

Re: (subset) [PATCH 00/15] timers: Cleanup delay/sleep related mess

2024-10-17 Thread Mark Brown
On Wed, 04 Sep 2024 15:04:50 +0200, Anna-Maria Behnsen wrote: > a question about which sleeping function should be used in acpi_os_sleep() > started a discussion and examination about the existing documentation and > implementation of functions which insert a sleep/delay. > > The result of the dis

Re: [PATCH v5 19/30] arm64: add POE signal support

2024-10-15 Thread Mark Brown
On Tue, Oct 15, 2024 at 01:25:29PM +0100, Joey Gouly wrote: > On Tue, Oct 15, 2024 at 12:41:16PM +0100, Will Deacon wrote: > > if (system_supports_poe() && err == 0 && user->poe_offset) { > > ... > > which gives the wrong impression that the POR is somehow optional, even > > if th

Re: [PATCH v5 19/30] arm64: add POE signal support

2024-10-15 Thread Mark Brown
On Tue, Oct 15, 2024 at 10:59:11AM +0100, Joey Gouly wrote: > On Mon, Oct 14, 2024 at 06:10:23PM +0100, Will Deacon wrote: > > Looking a little more at this, I think we have quite a weird behaviour > > on arm64 as it stands. It looks like we rely on the signal frame to hold > > the original POR_EL

Re: (subset) [PATCH v3 00/16] timers: Cleanup delay/sleep related mess

2024-10-14 Thread Mark Brown
On Mon, 14 Oct 2024 10:22:17 +0200, Anna-Maria Behnsen wrote: > a question about which sleeping function should be used in acpi_os_sleep() > started a discussion and examination about the existing documentation and > implementation of functions which insert a sleep/delay. > > The result of the dis

Re: [PATCH 0/2] ASoC: imx-card: add cs42888 codec support

2024-10-12 Thread Mark Brown
On Wed, 09 Oct 2024 15:46:42 +0800, Shengjiu Wang wrote: > add cs42888 codec support > > Chancel Liu (2): > ASoC: imx-card: Set mclk for codec > ASoC: imx-card: Add CS42888 support > > sound/soc/fsl/imx-card.c | 59 +++- > 1 file changed, 52 insertions(+),

Re: [PATCH] ASoC: fsl_esai: change dev_warn to dev_dbg in irq handler

2024-10-11 Thread Mark Brown
On Fri, 11 Oct 2024 12:53:53 +0800, Shengjiu Wang wrote: > Irq handler need to be executed as fast as possible, so > the log in irq handler is better to use dev_dbg which needs > to be enabled when debugging. > > Applied to https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git fo

Re: (subset) [PATCH treewide 00/11] ASoC: Clean up {hp,mic}-det-gpio handling

2024-10-05 Thread Mark Brown
On Fri, 27 Sep 2024 14:42:15 +0200, Geert Uytterhoeven wrote: > Hi all, > > The "gpio" suffix for GPIO consumers was deprecated a while ago, in > favor of the "gpios" suffix. However, there are still several users of > the "hp-det-gpio" and "mic-det-gpio" properties, in DT bindings, > drive

Re: [PATCH] ASoC: fsl: fsl_qmc_audio: Remove the logging when parsing channels

2024-10-04 Thread Mark Brown
On Thu, 03 Oct 2024 14:20:15 +0200, Herve Codina wrote: > On each channel parsing, a log message is issued. This log message is > not needed and become annoying when many channels are used (up to 64 > channel supported). > > Simply remove this unneeded log message. > > > [...] Applied to ht

Re: [PATCH 0/3] ASoC: fsl_micfil: fix and improvement

2024-10-01 Thread Mark Brown
On Fri, 27 Sep 2024 16:00:28 +0800, Shengjiu Wang wrote: > Fix the usage of regmap_write_bits(). > Move mclk clock enablement to late stage. > Enable the micfil error interrupt. > > Shengjiu Wang (3): > ASoC: fsl_micfil: fix regmap_write_bits usage > ASoC: fsl_micfil: Add mclk enable flag >

Re: [PATCH] ASoC: fsl_sai: Enable 'FIFO continue on error' FCONT bit

2024-10-01 Thread Mark Brown
On Mon, 30 Sep 2024 14:08:28 +0800, Shengjiu Wang wrote: > FCONT=1 means On FIFO error, the SAI will continue from the > same word that caused the FIFO error to set after the FIFO > warning flag has been cleared. > > Set FCONT bit in control register to avoid the channel swap > issue after SAI xru

Re: [PATCH] ASoC: fsl: Use maple tree register cache

2024-09-30 Thread Mark Brown
On Tue, 24 Sep 2024 15:58:42 +0200, Mark Brown wrote: > Several of the NXP drivers use regmaps with a rbtree register cache. Since > the maple tree cache is uisng a generally more modern data structure which > makes implementation choices more suitable for modern systems let's c

[PATCH] ASoC: fsl: Use maple tree register cache

2024-09-24 Thread Mark Brown
d-off-by: Mark Brown --- sound/soc/fsl/fsl_aud2htx.c | 2 +- sound/soc/fsl/fsl_easrc.c | 2 +- sound/soc/fsl/fsl_micfil.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sound/soc/fsl/fsl_aud2htx.c b/sound/soc/fsl/fsl_aud2htx.c index a6cbaa6364c7..910b4ce7671c 100644 --- a/

Re: [PATCH] ASoC: Switch back to struct platform_driver::remove()

2024-09-09 Thread Mark Brown
On Mon, 09 Sep 2024 17:12:30 +0200, Uwe Kleine-König wrote: > After commit 0edb555a65d1 ("platform: Make platform_driver::remove() > return void") .remove() is (again) the right callback to implement for > platform drivers. > > Convert all drivers below sound/soc to use .remove(), with the eventua

[PATCH v2 2/3] mm: Pass vm_flags to generic_get_unmapped_area()

2024-09-04 Thread Mark Brown
functional changes. Acked-by: Lorenzo Stoakes Reviewed-by: Liam R. Howlett Acked-by: Michael Ellerman Signed-off-by: Mark Brown --- arch/powerpc/mm/book3s64/slice.c | 4 ++-- include/linux/sched/mm.h | 4 ++-- mm/mmap.c| 10 ++ 3 files changed, 10

[PATCH v2 3/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-04 Thread Mark Brown
uses a single page guard, this is also sufficient for arm64 where we either do single word pops and pushes or unconstrained writes. Architectures which do not have this feature will define VM_SHADOW_STACK to VM_NONE and hence be unaffected. Suggested-by: Rick Edgecombe Acked-by: Lorenzo Stoa

[PATCH v2 0/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-04 Thread Mark Brown
ion for the generic code seems worth it. Changes in v2: - Add comment to stack_guard_placement() - Build fixes for xtensa and MIPS. - Link to v1: https://lore.kernel.org/r/20240902-mm-generic-shadow-stack-guard-v1-0-9acda38b3...@kernel.org --- Mark Brown (3): mm: Make arch_get_unmapped_a

[PATCH v2 1/3] mm: Make arch_get_unmapped_area() take vm_flags by default

2024-09-04 Thread Mark Brown
lags. No functional changes. Acked-by: Lorenzo Stoakes Reviewed-by: Liam R. Howlett Acked-by: Helge Deller # parisc Signed-off-by: Mark Brown --- arch/alpha/kernel/osf_sys.c | 2 +- arch/arc/mm/mmap.c| 3 ++- arch/arm/mm/mmap.c| 7 --- ar

Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-03 Thread Mark Brown
On Tue, Sep 03, 2024 at 03:41:49PM -0400, Liam R. Howlett wrote: > * Mark Brown [240902 15:09]: > > +static inline unsigned long stack_guard_placement(vm_flags_t vm_flags) > > +{ > > + if (vm_flags & VM_SHADOW_STACK) > > + return PAGE_SIZE; > Is P

Re: [PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-03 Thread Mark Brown
On Tue, Sep 03, 2024 at 06:49:46PM +0100, Lorenzo Stoakes wrote: > On Mon, Sep 02, 2024 at 08:08:15PM GMT, Mark Brown wrote: > > On x86 there is a custom arch_get_unmapped_area() which was updated by the > > above commit to cover this case by specifying a start_gap for alloc

[PATCH 3/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-02 Thread Mark Brown
rchitectures which do not have this feature will define VM_SHADOW_STACK to VM_NONE and hence be unaffected. Suggested-by: Rick Edgecombe Signed-off-by: Mark Brown --- mm/mmap.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/mm/mmap.c b/mm/mmap.c index b06ba847c96e..902c482b6084 1

[PATCH 2/3] mm: Pass vm_flags to generic_get_unmapped_area()

2024-09-02 Thread Mark Brown
. Signed-off-by: Mark Brown --- arch/powerpc/mm/book3s64/slice.c | 4 ++-- include/linux/sched/mm.h | 4 ++-- mm/mmap.c| 10 ++ 3 files changed, 10 insertions(+), 8 deletions(-) diff --git a/arch/powerpc/mm/book3s64/slice.c b/arch/powerpc/mm/book3s64/slice.c

[PATCH 1/3] mm: Make arch_get_unmapped_area() take vm_flags by default

2024-09-02 Thread Mark Brown
lags. No functional changes. Signed-off-by: Mark Brown --- arch/alpha/kernel/osf_sys.c | 2 +- arch/arc/mm/mmap.c| 3 ++- arch/arm/mm/mmap.c| 7 --- arch/csky/abiv1/mmap.c| 3 ++- arch/loongarch/mm/mmap.c | 5 +++--

[PATCH 0/3] mm: Care about shadow stack guard gap when getting an unmapped area

2024-09-02 Thread Mark Brown
ion for the generic code seems worth it. Signed-off-by: Mark Brown --- Mark Brown (3): mm: Make arch_get_unmapped_area() take vm_flags by default mm: Pass vm_flags to generic_get_unmapped_area() mm: Care about shadow stack guard gap when getting an unmapped area arch/alp

Re: [PATCH v5 16/30] arm64: handle PKEY/POE faults

2024-08-29 Thread Mark Brown
On Thu, Aug 22, 2024 at 04:10:59PM +0100, Joey Gouly wrote: > +static bool fault_from_pkey(unsigned long esr, struct vm_area_struct *vma, > + unsigned int mm_flags) > +{ > + unsigned long iss2 = ESR_ELx_ISS2(esr); > + > + if (!system_supports_poe()) > + retu

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-08-15 Thread Mark Brown
On Thu, Aug 15, 2024 at 04:09:26PM +0100, Dave Martin wrote: > I'm coming round to the view that trying to provide absolute guarantees > about the signal frame size is unsustainable. x86 didn't, and got away > with it for some time... Maybe we should just get rid of the relevant > comments in he

Re: [PATCH -next] ASoC: fsl: lpc3xxx: Make some symbols static

2024-08-02 Thread Mark Brown
On Fri, 02 Aug 2024 18:10:44 +0800, Yue Haibing wrote: > These symbols are not used outside of the files, make them static to fix > sparse warnings: > > sound/soc/fsl/lpc3xxx-i2s.c:261:30: warning: symbol 'lpc3xxx_i2s_dai_ops' was > not declared. Should it be static? > sound/soc/fsl/lpc3xxx-i2s.c

Re: [PATCH -next] ASoC: fsl: lpc3xxx-i2s: Remove set but not used variable 'savedbitclkrate'

2024-07-31 Thread Mark Brown
On Wed, 31 Jul 2024 10:29:49 +0800, Yue Haibing wrote: > The variable savedbitclkrate is assigned and never used, so can be removed. > > sound/soc/fsl/lpc3xxx-i2s.c:42:13: warning: variable ‘savedbitclkrate’ set > but not used [-Wunused-but-set-variable] > > Applied to https://git.kernel.o

Re: [PATCH 0/2] ASoC: fsl_micfil: Check the difference for i.MX8 and i.MX9

2024-07-31 Thread Mark Brown
On Thu, 25 Jul 2024 16:54:52 +0800, Shengjiu Wang wrote: > There are some register difference for i.MX8 and i.MX9 > REG_MICFIL_FIFO_CTRL definition is updated. > REG_MICFIL_FSYNC_CTRL, REG_MICFIL_VERID, REG_MICFIL_PARAM are added from > i.MX9 > > Shengjiu Wang (2): > ASoC: fsl_micfil: Expand the

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-07-29 Thread Mark Brown
On Mon, Jul 29, 2024 at 03:27:11PM +0100, Dave Martin wrote: > On Fri, Jul 26, 2024 at 06:39:27PM +0100, Mark Brown wrote: > > Yes, though that would mean if we had to generate any register in there > > we'd always have to generate at least as many entries as whatever number

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-07-26 Thread Mark Brown
On Fri, Jul 26, 2024 at 05:14:01PM +0100, Dave Martin wrote: > On Thu, Jul 25, 2024 at 07:11:41PM +0100, Mark Brown wrote: > > That'd have to be a variably sized structure with pairs of sysreg > > ID/value items in it I think which would be a bit of a pain to implement >

Re: [PATCH v4 18/29] arm64: add POE signal support

2024-07-25 Thread Mark Brown
On Thu, Jul 25, 2024 at 04:58:27PM +0100, Dave Martin wrote: > I'll post a draft patch separately, since I think the update could > benefit from separate discussion, but my back-of-the-envelope > calculation suggests that (before this patch) we are down to 0x90 > bytes of free space (i.e., over 96

Re: [PATCH] ASoC: fsl-asoc-card: Dynamically allocate memory for snd_soc_dai_link_components

2024-07-25 Thread Mark Brown
On Thu, 25 Jul 2024 11:22:53 +0800, Shengjiu Wang wrote: > The static snd_soc_dai_link_components cause conflict for multiple > instances of this generic driver. For example, when there is > wm8962 and SPDIF case enabled together, the contaminated > snd_soc_dai_link_components will cause another de

Re: [PATCH v4 06/29] arm64: context switch POR_EL0 register

2024-07-16 Thread Mark Brown
On Mon, Jul 15, 2024 at 01:57:10PM +0530, Anshuman Khandual wrote: > On 5/3/24 18:31, Joey Gouly wrote: > > +static inline bool system_supports_poe(void) > > +{ > > + return IS_ENABLED(CONFIG_ARM64_POE) && > CONFIG_ARM64_POE has not been defined/added until now ? That's a common pattern when a

Re: [PATCH v4 10/29] arm64: enable the Permission Overlay Extension for EL0

2024-07-15 Thread Mark Brown
On Fri, May 03, 2024 at 02:01:28PM +0100, Joey Gouly wrote: > This takes the last bit of HWCAP2, is this fine? What can we do about > more features in the future? HWCAP3 has already been allocated so we could just start using that. signature.asc Description: PGP signature

  1   2   3   4   5   6   7   8   9   10   >