Re: [PATCH] [v2] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Liam Girdwood
ia Lawall > Signed-off-by: Timur Tabi Acked-by: Liam Girdwood > --- > sound/soc/fsl/fsl_dma.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/sound/soc/fsl/fsl_dma.c b/sound/soc/fsl/fsl_dma.c > index 6680c0b..b300f4b 100644 > --- a/sound

Re: [PATCH] sound/soc/fsl/fsl_dma.c: add missing of_node_put

2011-08-22 Thread Liam Girdwood
sl,capture-dma", 0); > if (np == dma_channel_np) > return ssi_np; > + of_node_put(np); > } > > return NULL; > Acked-by: Liam Girdwood ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [alsa-devel] [PATCH] asoc/multi-component: fsl: add support for disabled SSI nodes

2010-08-05 Thread Liam Girdwood
On Thu, 2010-08-05 at 12:42 +0100, Mark Brown wrote: > On Wed, Aug 04, 2010 at 05:51:08PM -0500, Timur Tabi wrote: > > Add support for adding "status = disabled" to an SSI node to incidate that > > it > > is not wired on the board. This replaces the not-so-intuitive previous > > method > > of om

Re: [PATCH][v2] powerpc: rename immap_86xx.h to fsl_guts.h, and add 85xx support

2010-07-23 Thread Liam Girdwood
On Thu, 2010-07-22 at 13:43 -0500, Kumar Gala wrote: > On Jul 22, 2010, at 11:49 AM, Mark Brown wrote: > > > On Thu, Jul 22, 2010 at 11:33:30AM -0500, Timur Tabi wrote: > >> The immap_86xx.h header file only defines one data structure: the "global > >> utilities" register set found on Freescale Po

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-28 Thread Liam Girdwood
On Tue, 2010-04-27 at 14:27 -0600, Grant Likely wrote: > > Unfortunately, I'm in the same boat. :-( However, I'll be at UDS in > 2 weeks time, and I know audio is a big concern for the Ubuntu folks. > A bunch of the ARM vendors will be there too. I'll schedule a session > to talk about audio b

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Liam Girdwood
On Tue, 2010-04-27 at 10:28 -0500, Timur Tabi wrote: > Liam Girdwood wrote: > > > Iirc, the SSI and DMA controllers on your SoC mean that each DMA device > > can only do one direction (either Playback or Capture). So I'm thinking > > we create two DAI link entries

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Liam Girdwood
On Tue, 2010-04-27 at 09:52 -0500, Timur Tabi wrote: > Liam Girdwood wrote: > > > Now I don't know the mechanics of adding an ASoC sound card to the > > device tree, but the device tree should be able to define an ASoC sound > > card and also represent the relatio

Re: [alsa-devel] [PATCH 1/2] powerpc: add platform registration for ALSA SoC drivers

2010-04-27 Thread Liam Girdwood
On Tue, 2010-04-27 at 16:36 +1000, Benjamin Herrenschmidt wrote: > On Mon, 2010-04-26 at 15:49 -0500, Timur Tabi wrote: > > An upcoming change in the architecture of ALSA SoC (ASoC) will require the > > MPC8610 HPCD's ASoC fabric driver to register as a standard platform driver. > > Therefore, we n

Re: [alsa-devel] [PATCH 1/6] ASoC/mpc5200: Track DMA position by period number instead of bytes

2009-11-07 Thread Liam Girdwood
so makes the code simpler and > easier to understand. > > Signed-off-by: Grant Likely Very minor coding style thing below otherwise all get my Ack. Acked-by: Liam Girdwood > --- > > sound/soc/fsl/mpc5200_dma.c | 28 +--- > sound/soc/fsl/mpc5200

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-02 Thread Liam Girdwood
On Wed, 2008-07-02 at 09:52 -0400, Jon Smirl wrote: > > I've been using asoc-v2 so it may not be possible to make this arch > independent in asoc-v1. Maybe try porting this to asoc-v2 and see if > a bunch of the registration complexity disappears. Most of soc-of.c > should be unnecessary. > > Li

Re: [alsa-devel] [PATCH 1/3] ALSA SoC: Add OpenFirmware helper for matching bus and codec drivers

2008-07-02 Thread Liam Girdwood
On Wed, 2008-07-02 at 09:48 -0600, Grant Likely wrote: > On Wed, Jul 02, 2008 at 11:50:43AM +0200, Takashi Iwai wrote: > > > > This is a helper module and not necessarily manually selectable. > > Better to make the other driver selecting this. > > Yes, you're right. I hadn't put too much thought

Re: [alsa-devel] [PATCH 3/3] ALSA SoC: Add Texas Instruments TLV320AIC26 codec driver

2008-07-02 Thread Liam Girdwood
On Tue, 2008-07-01 at 17:53 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > ASoC Codec driver for the TLV320AIC26 device. This driver uses the ASoC > v1 API, so I don't expect it to get merged as-is, but I want to get it > out there for review. > --- > > sound/soc/codecs

Re: [alsa-devel] [PATCH 2/3] ALSA SoC: Add mpc5200-psc I2S driver

2008-07-02 Thread Liam Girdwood
On Tue, 2008-07-01 at 17:53 -0600, Grant Likely wrote: > From: Grant Likely <[EMAIL PROTECTED]> > > This is an I2S bus driver for the MPC5200 PSC device. It is probably > will not be merged as-is because it uses v1 of the ASoC API, but I want > to get it out there for comments. Looks good, just

Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

2008-01-10 Thread Liam Girdwood
On Thu, 2008-01-10 at 00:41 -0500, Jon Smirl wrote: > ASOC v2 is sitting on a Wolfson server out of tree. I have been using > it for several months without problem. The pace of it being merged > could probably be sped up. I think we are probably looking at submission in the next 8 - 10 weeks. Cur

Re: [PATCH v2] [ALSA] Add ASoC drivers for the Freescale MPC8610 SoC

2008-01-08 Thread Liam Girdwood
On Mon, 2008-01-07 at 12:56 -0600, Timur Tabi wrote: > Add the ASoC drivers for the Freescale MPC8610 SoC and the MPC8610 HPCD > reference board. > > Signed-off-by: Timur Tabi <[EMAIL PROTECTED]> Acked-by: Liam Girdwood

Re: [PATCH v2] [POWERPC] Update MPC8610 HPCD to support audio drivers

2008-01-08 Thread Liam Girdwood
On Tue, 2008-01-08 at 11:56 +1100, Stephen Rothwell wrote: > Hi Timur, > > On Mon, 7 Jan 2008 12:56:43 -0600 Timur Tabi <[EMAIL PROTECTED]> wrote: > > > > +++ b/arch/powerpc/platforms/86xx/mpc8610_hpcd.c > > @@ -34,9 +34,27 @@ > > > > #include > > > > +#include > > #include > > #include

Re: [PATCH 0/2] ASoC drivers for the Freescale MPC8610 SoC

2008-01-08 Thread Liam Girdwood
On Mon, 2008-01-07 at 12:56 -0600, Timur Tabi wrote: > These patches add ALSA SoC device drivers for the Freescale MPC8610 SoC > and the MPC8610-HPCD reference board. > > The first patch updates some files in arch/powerpc and booting-without-of.txt. > > The second patch adds the new audio driver

Re: [alsa-devel] [PATCH] ASoC drivers for the Freescale MPC8610 SoC

2008-01-07 Thread Liam Girdwood
On Mon, 2008-01-07 at 09:52 -0600, Timur Tabi wrote: > > So all I'm trying to do now is get my driver, with warts and all, into the > tree > so that I can focus with Liam et al to get a real ASoC V2 up and running. > I'll commit the MPC8610 into the ASoC (v1) dev tree soon (hopefully tonight).