Re: [PATCH v3] selftests: powerpc: Fix CPU affinity for child process

2020-06-09 Thread Kamalesh Babulal
r of CPUs as > reported by get_nprocs(). > > Fixes: 00b7ec5c9cf3 ("selftests/powerpc: Import Anton's context_switch2 > benchmark") > Reported-by: Shirisha Ganta > Signed-off-by: Sandipan Das > Signed-off-by: Harish LGTM, Reviewed-by: Kamalesh Babulal -- Kamalesh

Re: [PATCH v2] selftests: powerpc: Fix CPU affinity for child process

2020-06-09 Thread Kamalesh Babulal
On 6/9/20 9:10 AM, Harish wrote: > On systems with large number of cpus, test fails trying to set > affinity for child process by calling sched_setaffinity() with > smaller size for cpuset. This patch fixes it by making sure that > the size of allocated cpu set is dependent on the number of CPUs >

Re: [PATCH] selftests: powerpc: Fix online CPU selection

2020-06-08 Thread Kamalesh Babulal
located cpu set is dependent on the number > of CPUs as reported by get_nprocs(). > > Fixes: 3752e453f6ba ("selftests/powerpc: Add tests of PMU EBBs") > Reported-by: Shirisha Ganta > Signed-off-by: Sandipan Das LGTM, Reviewed-by: Kamalesh Babulal -- Kamalesh

Re: [PATCH v5 0/5] Track and expose idle PURR and SPURR ticks

2020-04-07 Thread Kamalesh Babulal
System Configuration type=Dedicated mode=Capped smt=8 lcpu=2 mem=4324928 kB cpus=0 ent=2.00 ---Actual--- -Normalized- %busy %idle Frequency %busy %idle -- -- - -- -- 99.99 0.00 3.35GHz[111%] 110.99 0.00 100.00 0.00 3.35GHz[111%] 111.00 0.00 100.00 0.00 3.35GHz[111%] 111.00 0.00 For the series: Reviewed-and-Tested-by: Kamalesh Babulal -- Kamalesh

Re: [PATCH v2 0/5] Track and expose idle PURR and SPURR ticks

2020-02-23 Thread Kamalesh Babulal
es changed, 191 insertions(+), 37 deletions(-) > create mode 100644 arch/powerpc/include/asm/idle.h > For the whole series: Tested-by: Kamalesh Babulal -- Kamalesh

Re: [PATCH 0/3] pseries: Track and expose idle PURR and SPURR ticks

2020-02-04 Thread Kamalesh Babulal
On 12/6/19 2:44 PM, Naveen N. Rao wrote: > Naveen N. Rao wrote: >> Hi Nathan, >> >> Nathan Lynch wrote: >>> Hi Kamalesh, >>> >>> Kamalesh Babulal writes: >>>> On 12/5/19 3:54 AM, Nathan Lynch wrote: >>>>> "Gautham R.

Re: [PATCH FIX] KVM: PPC: Book3S HV: Release lock on page-out failure path

2020-01-21 Thread Kamalesh Babulal
On 1/22/20 10:25 AM, Bharata B Rao wrote: > When migrate_vma_setup() fails in kvmppc_svm_page_out(), > release kvm->arch.uvmem_lock before returning. > > Fixes: ca9f4942670 ("KVM: PPC: Book3S HV: Support for running secure guests") > Signed-off-by: Bharata B Rao R

Re: [PATCH v2] selftests: vm: Fix 64-bit test builds for powerpc64le

2020-01-20 Thread Kamalesh Babulal
arch") > Signed-off-by: Sandipan Das I was about to suggest, the missing change in run_vmtests script in your V1. Reviewed-by: Kamalesh Babulal -- Kamalesh

Re: [PATCH 0/3] pseries: Track and expose idle PURR and SPURR ticks

2019-12-05 Thread Kamalesh Babulal
On 12/5/19 3:54 AM, Nathan Lynch wrote: > "Gautham R. Shenoy" writes: >> From: "Gautham R. Shenoy" >> >> On PSeries LPARs, the data centers planners desire a more accurate >> view of system utilization per resource such as CPU to plan the system >> capacity requirements better. Such accuracy can

Re: [PATCH 1/3] powerpc/pseries: Account for SPURR ticks on idle CPUs

2019-12-03 Thread Kamalesh Babulal
the idle PURR ticks in > the VPA variable "wait_state_cycles". This patch extends the support > to account for the idle SPURR ticks. Thanks for working on it. > > Signed-off-by: Gautham R. Shenoy Reviewed-by: Kamalesh Babulal

Re: [PATCH 2/3] powerpc/sysfs: Show idle_purr and idle_spurr for every CPU

2019-12-03 Thread Kamalesh Babulal
On 11/27/19 5:31 PM, Gautham R. Shenoy wrote: > From: "Gautham R. Shenoy" > > On Pseries LPARs, to calculate utilization, we need to know the > [S]PURR ticks when the CPUs were busy or idle. > > The total PURR and SPURR ticks are already exposed via the per-cpu > sysfs files /sys/devices/system/

Re: [PATCH] powerpc/modules: remove unused mod_arch_specific.toc field

2018-05-24 Thread Kamalesh Babulal
f the __powerpc64__ #ifdef. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal

Re: [PATCH v4.2] powerpc/modules: Don't try to restore r2 after a sibling call

2017-11-17 Thread Kamalesh Babulal
eue(): 14c: 00 00 00 48 b 14c 14c: R_PPC64_REL24 net_set_todo 150: 00 00 82 3c addis r4,r2,0 GCC didn't insert a nop after the branch to net_set_todo() because it's a sibling call, so it never returns. The nop isn't needed a

Re: [PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call

2017-11-14 Thread Kamalesh Babulal
On Tuesday 14 November 2017 09:23 PM, Josh Poimboeuf wrote: On Tue, Nov 14, 2017 at 03:59:21PM +0530, Naveen N. Rao wrote: Kamalesh Babulal wrote: From: Josh Poimboeuf When attempting to load a livepatch module, I got the following error: module_64: patch_module: Expect noop after

[PATCH v4 3/3] powerpc/modules: Improve restore_r2() error message

2017-11-14 Thread Kamalesh Babulal
, got 7c630034 at netdev_has_upper_dev+0x54/0xb0 [patch_foo] Signed-off-by: Josh Poimboeuf Signed-off-by: Kamalesh Babulal --- arch/powerpc/kernel/module_64.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c

[PATCH v4 2/3] powerpc/modules: Don't try to restore r2 after a sibling call

2017-11-14 Thread Kamalesh Babulal
Signed-off-by: Kamalesh Babulal --- arch/powerpc/kernel/module_64.c | 4 1 file changed, 4 insertions(+) diff --git a/arch/powerpc/kernel/module_64.c b/arch/powerpc/kernel/module_64.c index 39b01fd..9e5391f 100644 --- a/arch/powerpc/kernel/module_64.c +++ b/arch/powerpc/kernel/module_64.c @@

[PATCH v4 1/3] kernel/modules: Add REL24 relocation support of livepatch symbols

2017-11-14 Thread Kamalesh Babulal
d for global calls. This issue can be fixed by teaching apply_relocate_add() to handle both SHN_UNDEF/SHN_LIVEPATCH symbols via the same stub. This patch extends SHN_UNDEF code to handle livepatch symbols too. Signed-off-by: Kamalesh Babulal CC: Balbir Singh Cc: Naveen N. Rao Cc: Josh Poimboeu

[PATCH v4 0/3] ppc64le: Add REL24 relocation support of livepatch symbols

2017-11-14 Thread Kamalesh Babulal
. Josh Poimboeuf (2): powerpc/modules: Don't try to restore r2 after a sibling call powerpc/modules: Improve restore_r2() error message Kamalesh Babulal (1): kernel/modules: Add REL24 relocation support of livepatch symbols arch/powerpc/kernel/module_64.c | 11 --- 1 file chang

Re: [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-11-13 Thread Kamalesh Babulal
On Monday 13 November 2017 02:08 PM, Balbir Singh wrote: On Fri, Nov 10, 2017 at 2:28 PM, Josh Poimboeuf wrote: On Fri, Nov 10, 2017 at 01:06:25PM +1100, Balbir Singh wrote: On Fri, Nov 10, 2017 at 2:19 AM, Josh Poimboeuf wrote: FWIW, I think it won't matter anyway. I'm currently pursuing t

Re: [PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-11-01 Thread Kamalesh Babulal
On Tuesday 31 October 2017 07:49 PM, Naveen N . Rao wrote: Hi Kamalesh, Sorry for the late review. Overall, the patch looks good to me. So: Acked-by: Naveen N. Rao However, I have a few minor comments which can be addressed in a subsequent patch. Thanks for the review. [...] diff --git a/

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-23 Thread Kamalesh Babulal
On Saturday 21 October 2017 06:29 AM, Balbir Singh wrote: On Fri, 2017-10-20 at 14:07 +0200, Torsten Duwe wrote: On Wed, Oct 18, 2017 at 11:47:35AM +0530, Kamalesh Babulal wrote: Consider a trivial patch, supplied to kpatch tool for generating a livepatch module: --- a/fs/proc/meminfo.c

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-17 Thread Kamalesh Babulal
On Tuesday 17 October 2017 08:17 PM, Torsten Duwe wrote: > On Fri, Oct 06, 2017 at 11:27:42AM +0530, Kamalesh Babulal wrote: >> >> Consider the livepatch sequence[1]. Where function A calls B, B is the >> function which has been livepatched and the call to function B is >

[PATCH v3] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-16 Thread Kamalesh Babulal
atching-for-ppc64le/ Signed-off-by: Kamalesh Babulal Reviewed-by: Balbir Singh Cc: Naveen N. Rao Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Ananth N Mavinakayanahalli Cc: Aravinda Prasad Cc: Torsten Duwe Cc: linuxppc-dev@lists.ozlabs.org Cc: live-patch...@vger.kernel.org --- v3: - Defined F

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-11 Thread Kamalesh Babulal
On Friday 06 October 2017 11:13 AM, Kamalesh Babulal wrote: On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch

Re: [PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-10 Thread Kamalesh Babulal
On Wednesday 11 October 2017 09:42 AM, Michael Ellerman wrote: > Kamalesh Babulal writes: > >> Use WARN_ON(), while running out of stubs in stub_for_addr() >> and abort loading of the module instead of BUG_ON(). > > Thanks. This looks good in principle. Have you actu

[PATCH] powerpc/modules: Use WARN_ON() in stub_for_addr()

2017-10-10 Thread Kamalesh Babulal
Use WARN_ON(), while running out of stubs in stub_for_addr() and abort loading of the module instead of BUG_ON(). Signed-off-by: Kamalesh Babulal --- arch/powerpc/kernel/module_64.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/arch/powerpc/kernel/module_64.c b/arch

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-05 Thread Kamalesh Babulal
On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch stub. The newly setup klp_stub mimics the functionality of

Re: [PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-05 Thread Kamalesh Babulal
On Thursday 05 October 2017 06:13 PM, Torsten Duwe wrote: On Wed, Oct 04, 2017 at 11:25:16AM -0400, Kamalesh Babulal wrote: Both the failures with REL24 livepatch symbols relocation, can be resolved by constructing a new livepatch stub. The newly setup klp_stub mimics the functionality of

[PATCH v2] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-04 Thread Kamalesh Babulal
is used to store/restore TOC/LR values, other than the stub setup and branch. The additional instructions sequences to handle klp_stub increases the stub size and current ppc64_stub_insn[] is not sufficient to hold them. This patch also introduces new ppc64le_klp_stub_entry[], along with the helpe

Re: [PATCH] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-04 Thread Kamalesh Babulal
On Tuesday 03 October 2017 03:00 PM, Naveen N . Rao wrote: Hi Naveen, [snip] > > A few small nits focusing on just the trampoline... > >> diff --git a/arch/powerpc/kernel/trace/ftrace_64_mprofile.S >> b/arch/powerpc/kernel/trace/ftrace_64_mprofile.S >> index c98e90b..708a96d 100644 >> --- a/ar

[PATCH] kernel/module_64.c: Add REL24 relocation support of livepatch symbols

2017-10-02 Thread Kamalesh Babulal
equences to handle klp_stub increases the stub size and current ppc64_stub_insn[] is not sufficient to hold them. This patch also introduces new ppc64le_klp_stub_entry[], along with the helpers to find/allocate livepatch stub. Signed-off-by: Kamalesh Babulal Cc: Balbir Singh Cc: Naveen N

Re: [PATCH] powerpc/livepatch: Fix livepatch stack access

2017-09-21 Thread Kamalesh Babulal
On Thursday 21 September 2017 10:25 PM, Naveen N . Rao wrote: On 2017/09/21 09:00PM, Balbir Singh wrote: On Thu, Sep 21, 2017 at 8:02 PM, Michael Ellerman wrote: Kamalesh Babulal writes: While running stress test with livepatch module loaded, kernel bug was triggered. cpu 0x5: Vector: 400

Re: [PATCH] powerpc/livepatch: Fix livepatch stack access

2017-09-21 Thread Kamalesh Babulal
On Thursday 21 September 2017 04:30 PM, Balbir Singh wrote: On Thu, Sep 21, 2017 at 8:02 PM, Michael Ellerman wrote: Kamalesh Babulal writes: While running stress test with livepatch module loaded, kernel bug was triggered. cpu 0x5: Vector: 400 (Instruction Access) at [c000eb9d3b60

[PATCH] powerpc/livepatch: Fix livepatch stack access

2017-09-20 Thread Kamalesh Babulal
ead of shuffling task stack and livepatch stack into r1 register. Using r11 register also avoids disabling/enabling irq's while setting up the livepatch stack. Signed-off-by: Kamalesh Babulal Cc: Balbir Singh Cc: Naveen N. Rao Cc: linuxppc-dev@lists.ozlabs.org --- arch/powerpc/k

Re: [PATCH 3/5] powerpc/kprobes: Fix warnings from __this_cpu_read() on preempt kernels

2017-09-14 Thread Kamalesh Babulal
probe value skipping the check done by __this_cpu_read(). Fixes: c05b8c4474c030 ("powerpc/kprobes: Skip livepatch_handler() for jprobes") Reported-by: Kamalesh Babulal Signed-off-by: Naveen N. Rao Thanks, the call traces are not seen anymore with the patch. Tested-by: Kamalesh Babulal

Re: [PATCH 1/5] powerpc/kprobes: Some cosmetic updates to try_to_emulate()

2017-09-13 Thread Kamalesh Babulal
On Thursday 14 September 2017 02:50 AM, Naveen N. Rao wrote: 1. This is only used in kprobes.c, so make it static. 2. Remove the un-necessary (ret == 0) comparison in the else clause. Signed-off-by: Naveen N. Rao Reviewed-by: Kamalesh Babulal --- arch/powerpc/kernel/kprobes.c | 4 ++-- 1

[RESEND PATCH] powerpc/modules: Introduce new stub code for SHN_LIVEPATCH symbols

2017-06-26 Thread Kamalesh Babulal
the Link Register/TOC onto the stack of the livepatched function and restores them upon return from the called function. Signed-off-by: Kamalesh Babulal Cc: Michael Ellerman Cc: Balbir Singh Cc: Josh Poimboeuf Cc: Jessica Yu Cc: Ananth N Mavinakayanahalli Cc: Aravinda Prasad Cc: live-patch

Re: [PATCH] powerpc/modules: Introduce new stub code for SHN_LIVEPATCH symbols

2017-06-19 Thread Kamalesh Babulal
Hi Michael, Any thoughts/suggestions on the approach ? On Tuesday 13 June 2017 12:20 PM, Kamalesh Babulal wrote: R_PPC64_REL24 relocation type is used for a function call, where the function symbol address is resolved and stub code (a.k.a trampoline) is constructed to jump into the global

Re: [PATCH] recordmcount.pl: Add ppc64le to list of supported architectures

2017-06-13 Thread Kamalesh Babulal
On Wednesday 14 June 2017 10:23 AM, Michael Ellerman wrote: I don't get this, the arch should always be powerpc. Right. Something else is fubar for that to happen, we should fix whatever it is. Agree, ARCH over-ruling by reading the underlying architecture will not work, as the expectation is

Re: [PATCH] recordmcount.pl: Add ppc64le to list of supported architectures

2017-06-13 Thread Kamalesh Babulal
On Wednesday 14 June 2017 04:22 AM, Balbir Singh wrote: On Tue, Jun 13, 2017 at 4:49 PM, Kamalesh Babulal < kamal...@linux.vnet.ibm.com> wrote: Module make on ppc64le, fails with: make -C /root/kernel/linux M=/root/.kpatch/tmp/patch kpatch-data-read-mostly.ko make[1]: Entering dir

[PATCH] powerpc/modules: Introduce new stub code for SHN_LIVEPATCH symbols

2017-06-12 Thread Kamalesh Babulal
restores them upon return from the called function. Signed-off-by: Kamalesh Babulal Cc: Michael Ellerman Cc: Balbir Singh Cc: Josh Poimboeuf Cc: Jessica Yu Cc: live-patch...@vger.kernel.org --- arch/powerpc/kernel/module_64.c | 55 - 1 file changed, 44

[PATCH] recordmcount.pl: Add ppc64le to list of supported architectures

2017-06-12 Thread Kamalesh Babulal
./scripts/recordmcount.pl line 379. Fix it by adding 'ppc64le' to list of supported architectures in recordmcount.pl script. Signed-off-by: Kamalesh Babulal Cc: Michael Ellerman Cc: Balbir Singh --- scripts/recordmcount.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH v3 12/15] livepatch: store function sizes

2017-01-11 Thread Kamalesh Babulal
On Thursday 08 December 2016 11:38 PM, Josh Poimboeuf wrote: For the consistency model we'll need to know the sizes of the old and new functions to determine if they're on the stacks of any tasks. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 04/15] livepatch/x86: add TIF_PATCH_PENDING thread flag

2017-01-10 Thread Kamalesh Babulal
is placed in the _TIF_ALLWORK_MASK macro, which results in exit_to_usermode_loop() calling klp_update_patch_state() when it's set. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 09/15] livepatch: remove unnecessary object loaded check

2017-01-10 Thread Kamalesh Babulal
Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 10/15] livepatch: move patching functions into patch.c

2017-01-10 Thread Kamalesh Babulal
On Thursday 08 December 2016 11:38 PM, Josh Poimboeuf wrote: Move functions related to the actual patching of functions and objects into a new patch.c file. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 08/15] livepatch: separate enabled and patched states

2017-01-10 Thread Kamalesh Babulal
fully applied). - Patched means that an object's funcs are registered with ftrace and added to the klp_ops func stack. Also, since these states are binary, represent them with booleans instead of ints. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 02/15] x86/entry: define _TIF_ALLWORK_MASK flags explicitly

2017-01-10 Thread Kamalesh Babulal
explicitly. Signed-off-by: Josh Poimboeuf For the version with swapped _TIF_SINGLESTEP and _TIF_NEED_RESCHED flags. Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

Re: [PATCH v3 05/15] livepatch/powerpc: add TIF_PATCH_PENDING thread flag

2017-01-10 Thread Kamalesh Babulal
bit is included in the _TIF_USER_WORK_MASK macro so that do_notify_resume() and klp_update_patch_state() get called when the bit is set. Signed-off-by: Josh Poimboeuf Reviewed-by: Kamalesh Babulal -- cheers, Kamalesh.

[PATCH] powerpc/livepatch: Remove klp_write_module_reloc() stub

2016-12-15 Thread Kamalesh Babulal
commit 425595a7fc20 ("livepatch: reuse module loader code to write relocations") offloads livepatch module relocation write to arch specific module loader code. Remove unused klp_write_module_reloc() function stub. Signed-off-by: Kamalesh Babulal --- arch/powerpc/include/asm/livep

Re: [PATCH HACK 1/6] livepatch-test: Add more cases

2016-03-27 Thread Kamalesh Babulal
* Balbir Singh [2016-03-26 18:11:22]: > On Fri, Mar 25, 2016 at 3:37 AM, Kamalesh Babulal > wrote: > > * Michael Ellerman [2016-03-24 22:04:00]: > > > >> Not for merging. > >> > > > > Hi Michael, > > > > Loading the livepatch sample

Re: [PATCH HACK 1/6] livepatch-test: Add more cases

2016-03-24 Thread Kamalesh Babulal
* Michael Ellerman [2016-03-24 22:04:00]: > Not for merging. > Hi Michael, Loading the livepatch sample module, trigger following warning Mar 24 21:44:59 ubuntu kernel: [ 40.467580] sysfs: cannot create duplicate filename '/kernel/livepatch/livepatch_sample/vmlinux' Mar 24 21:44:59 ubuntu

Re: [PATCH/RFC] ppc64 livepatch: frameless klp_return_helper using odd TOC

2016-03-24 Thread Kamalesh Babulal
* Torsten Duwe [2016-03-24 11:27:57]: > On Thu, Mar 24, 2016 at 03:44:55PM +0530, Kamalesh Babulal wrote: > > * Torsten Duwe [2016-03-23 16:58:58]: > > > > > > > > Since nobody liked the extra stack frame nor its workarounds, here is > > > the

Re: [PATCH/RFC] ppc64 livepatch: frameless klp_return_helper using odd TOC

2016-03-24 Thread Kamalesh Babulal
* Torsten Duwe [2016-03-23 16:58:58]: > > Since nobody liked the extra stack frame nor its workarounds, here is > the next attempt. Assumptions: > > 1. Heuristics are bad. The better they are, the more subtly the >way they might fail. > > 2. The TOC pointer is usually dividable by 4, if no

Re: [PATCH][v4] livepatch/ppc: Enable livepatching on powerpc

2016-03-03 Thread Kamalesh Babulal
> > I tested the sample in the livepatch > > Signed-off-by: Torsten Duwe > Signed-off-by: Balbir Singh > Signed-off-by: Petr Mladek Reviewed-by: Kamalesh Babulal I tried it, with the sample livepatch module. Tested-by: Kamalesh Babulal Thanks, Kamalesh.

Re: [RFC][PATCH][v2] Enable livepatching for powerpc

2016-03-03 Thread Kamalesh Babulal
tchwork.ozlabs.org/patch/587464/ > > Signed-off-by: Torsten Duwe > Signed-off-by: Balbir Singh Tested-by: Kamalesh Babulal ___ Linuxppc-dev mailing list Linuxppc-dev@lists.ozlabs.org https://lists.ozlabs.org/listinfo/linuxppc-dev

Re: [PATCH v3 1/8] powerpc: Create a helper for getting the kernel toc value

2016-03-02 Thread Kamalesh Babulal
* Michael Ellerman [2016-03-03 15:26:53]: > Move the logic to work out the kernel toc pointer into a header. This is > a good cleanup, and also means we can use it elsewhere in future. > > Reviewed-by: Kamalesh Babulal > Reviewed-by: Torsten Duwe > Signed-off-by: Michael

Re: [PATCH v2 5/8] powerpc/ftrace: Use generic ftrace_modify_all_code()

2016-03-01 Thread Kamalesh Babulal
t; > With this we gain error checking and the much-needed function_trace_op > handling. > > Reviewed-by: Balbir Singh > Signed-off-by: Torsten Duwe > Signed-off-by: Michael Ellerman Reviewed-by: Kamalesh Babulal ___ Linuxppc-dev m

Re: [PATCH v2 2/8] powerpc/module: Only try to generate the ftrace_caller() stub once

2016-03-01 Thread Kamalesh Babulal
* Michael Ellerman [2016-02-29 20:26:23]: > Currently we generate the module stub for ftrace_caller() at the bottom > of apply_relocate_add(). However apply_relocate_add() is potentially > called more than once per module, which means we will try to generate > the ftrace_caller() stub multiple ti

Re: [PATCH v2 1/8] powerpc: Create a helper for getting the kernel toc value

2016-03-01 Thread Kamalesh Babulal
* Michael Ellerman [2016-02-29 20:26:22]: > Move the logic to work out the kernel toc pointer into a header. This is > a good cleanup, and also means we can use it elsewhere in future. > > Signed-off-by: Michael Ellerman Reviewed-by: Kama

Re: [RFC][PATCH] Enable livepatching for powerpc

2016-02-25 Thread Kamalesh Babulal
ested the sample in the livepatch > directory > > References > > 1. https://patchwork.ozlabs.org/patch/581521/ > 2. https://patchwork.ozlabs.org/patch/587464/ > > Signed-off-by: Torsten Duwe > Signed-off-by: Balbir Singh I was able to test livepatch-sample module with

Re: [PATCH 01/12] powerpc/module: Only try to generate the ftrace_caller() stub once

2016-02-25 Thread Kamalesh Babulal
> from module_finalize(). An additional benefit is we can clean the ifdefs > up a little. > > Finally we must propagate the const'ness of some of the pointers passed > to module_finalize(), but that is also an improvement. > > Signed-off-by: Michael Ellerman For all of

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-23 Thread Kamalesh Babulal
* Torsten Duwe [2016-02-23 18:00:17]: > On Wed, Feb 17, 2016 at 02:08:41PM +1100, Michael Ellerman wrote: > > > > That stub uses r2 to find the location of itself, but it only works if r2 > > holds > > the TOC for scsi_mod.ko. In this case r2 still contains ibmvscsi.ko's TOC. > > Here's my sol

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-16 Thread Kamalesh Babulal
* Torsten Duwe [2016-02-16 09:23:02]: > On Tue, Feb 16, 2016 at 11:17:02AM +0530, Kamalesh Babulal wrote: > > * Petr Mladek [2016-02-12 17:45:17]: > > > int test(int a) > > > { > > > + printk("%d\n", a); > > > return ++a; > >

Re: [PATCH v8 8/8] livepatch: Detect offset for the ftrace location during build

2016-02-15 Thread Kamalesh Babulal
* Petr Mladek [2016-02-12 17:45:17]: [...] > I guess that you used a broken gcc and cheated the check > to pass the compilation. Did you, please? > > The test used to detect the offset is using a minimalistic > function is is afftected by the gcc bug. > > The patch below might be used to cheat

Re: [PATCH v8 4/8] ppc64 ftrace_with_regs configuration variables

2016-02-11 Thread Kamalesh Babulal
* Balbir Singh [2016-02-11 18:48:17]: > On Wed, 2016-02-10 at 17:25 +0100, Torsten Duwe wrote: > > snip > > > diff --git a/arch/powerpc/gcc-mprofile-kernel-notrace.sh > > b/arch/powerpc/gcc-mprofile-kernel-notrace.sh > > new file mode 100755 > > index 000..68d6482 > > --- /dev/null > > +++

Re: [RESEND,v3] powerpc/pseries: Limit EPOW reset event warnings

2015-07-17 Thread Kamalesh Babulal
it means. > > But really it should be a counter, not a boolean. > > We could have multiple EPOW events come in and then later get the reset events > for them, couldn't we? > > > So what about: > > static unsigned epow_event_depth; > --->8---- From 0d2

[RESEND PATCH v3] powerpc/pseries: Limit EPOW reset event warnings

2015-07-14 Thread Kamalesh Babulal
multiple warning logs. Also, merged adjacent pr_err/pr_emerg into single one to reduce the number of lines printed per warning. Suggested-by: Vipin K Parashar [Vipin: edited the changelog] Cc: Anshuman Khandual Cc: Anton Blanchard Cc: Michael Ellerman Signed-off-by: Kamalesh Babulal --- v3

[PATCH v3] powerpc/pseries: Limit EPOW reset event warnings

2015-07-14 Thread Kamalesh Babulal
or cooling issue cleared May 25 04:22:36 alp kernel: Non critical power or cooling issue cleared Suggested-by: Vipin K Parashar Cc: Anshuman Khandual Cc: Anton Blanchard Cc: Michael Ellerman Signed-off-by: Kamalesh Babulal --- v3 Changes: - Limit warning printed by EPOW RESET event, by

Re: [PATCH v2] powerpc/pseries: Ratelimit EPOW event warnings

2015-07-14 Thread Kamalesh Babulal
* Vipin K Parashar [2015-06-25 00:48:20]: > > On 06/02/2015 10:48 AM, Kamalesh Babulal wrote: > >We print the respective warning after parsing EPOW interrupts, > >prompting user to take action depending upon the severity of the > >event. > > > >Some times sa

[PATCH v2] powerpc/pseries: Ratelimit EPOW event warnings

2015-06-01 Thread Kamalesh Babulal
04:22:26 alp kernel: Non critical power or cooling issue cleared May 25 04:22:36 alp kernel: Non critical power or cooling issue cleared Signed-off-by: Kamalesh Babulal Cc: Anshuman Khandual Cc: Anton Blanchard Cc: Michael Ellerman --- v2 Changes: - Merged multiple adjacent pr_err/pr_emerg into

Re: [RFC PATCH] powerpc/pseries: Ratelimit EPOW event warnings

2015-06-01 Thread Kamalesh Babulal
* Michael Ellerman [2015-06-01 21:26:51]: > On Thu, 2015-05-28 at 10:03 +0530, Kamalesh Babulal wrote: > > We print the respective warning after parsing EPOW interrupts, > > prompting user to take action depending upon the severity of the > > event. > > > > S

[RFC PATCH] powerpc/pseries: Ratelimit EPOW event warnings

2015-05-27 Thread Kamalesh Babulal
critical power or cooling issue cleared Signed-off-by: Kamalesh Babulal Cc: Anshuman Khandual Cc: Anton Blanchard Cc: Michael Ellerman --- arch/powerpc/platforms/pseries/ras.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/powerpc/platforms/pseries/ras.c b

Re: [PATCH] powerpc/spufs: Remove MAX_USER_PRIO define

2014-02-11 Thread Kamalesh Babulal
* Jeremy Kerr [2014-02-11 14:05:17]: > Current ppc64_defconfig fails with: > > arch/powerpc/platforms/cell/spufs/sched.c:86:0: error: "MAX_USER_PRIO" > redefined [-Werror] > cc1: all warnings being treated as errors > > 6b6350f1 introduced a generic MAX_USER_PRIO macro to sched/prio.h, which

Re: [PATCH V2 2/2] sched: Remove un-necessary iteration over sched domains to update nr_busy_cpus

2013-10-30 Thread Kamalesh Babulal
Hi Preeti, > nr_busy_cpus parameter is used by nohz_kick_needed() to find out the number > of busy cpus in a sched domain which has SD_SHARE_PKG_RESOURCES flag set. > Therefore instead of updating nr_busy_cpus at every level of sched domain, > since it is irrelevant, we can update this parameter o

Re: [PATCH 1/3] sched: Fix nohz_kick_needed to consider the nr_busy of the parent domain's group

2013-10-22 Thread Kamalesh Babulal
* Vaidyanathan Srinivasan [2013-10-21 17:14:42]: > for_each_domain(cpu, sd) { > - struct sched_group *sg = sd->groups; > - struct sched_group_power *sgp = sg->sgp; > - int nr_busy = atomic_read(&sgp->nr_busy_cpus); > - > - if (sd->flags & SD_S

linux-next: 20090925 - hvc driver build breaks with !HVC_CONSOLE

2009-09-25 Thread Kamalesh Babulal
Hi Stephen, next-20090925 randconfig build breaks on hvcs driver on powerpc, with HVC_CONSOLE=n. ERROR: ".hvc_put_chars" [drivers/char/hvcs.ko] undefined! ERROR: ".hvc_get_chars" [drivers/char/hvcs.ko] undefined! adding the dependency of HVC_CONSOLE helped Sig

[BUG] 2.6.29-rc1 - Badness at kernel/sched.c:4440 with CONFIG_DEBUG_PREEMPT

2009-01-12 Thread Kamalesh Babulal
(DEBUG_LOCKS_WARN_ON(val > preempt_count())) + if (DEBUG_LOCKS_WARN_ON(val > preempt_count() - (!!kernel_locked()))) return; /* * Is the spinlock portion underflowing? -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [BUG] 2.6.28-git-4 - powerpc - kernel expection 'c01 at .kernel_thread'

2009-01-12 Thread Kamalesh Babulal
* Rafael J. Wysocki [2009-01-12 09:07:19]: > On Monday 12 January 2009, Kamalesh Babulal wrote: > > * Rafael J. Wysocki [2009-01-11 01:08:19]: > > > > > On Friday 02 January 2009, Kamalesh Babulal wrote: > > > > Hi, > > > > > > &g

Re: [BUG] 2.6.28-git-4 - powerpc - kernel expection 'c01 at .kernel_thread'

2009-01-11 Thread Kamalesh Babulal
* Rafael J. Wysocki [2009-01-11 01:08:19]: > On Friday 02 January 2009, Kamalesh Babulal wrote: > > Hi, > > > > 2.6.28-git4 kernel drops to xmon with kernel expection. Similar kernel > > expection was seen next-20081230 and next-20081231 and was reported > >

Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-06 Thread Kamalesh Babulal
Series dependent drivers. iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. Removing the dependency of VIOPATH by selecting it, when the drivers dependent on iSeries code. Signed-off-by: Kamalesh Babulal --- arch/powerpc/platforms/iseries/Kconfig |5 +++-- dr

Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-06 Thread Kamalesh Babulal
ent drivers. > > > > iSeries depend drivers build fails, when CONFIG_VIOPATH is disabled. > > Removing the dependency of VIOPATH by selecting it, when the drivers > > dependent on iSeries code. > > > > > > Signed-off-by: Kamalesh Babulal > > --

Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-05 Thread Kamalesh Babulal
* Milton Miller [2009-01-05 07:33:32]: > On Jan 4, 2009, at 12:24 PM, Kamalesh Babulal wrote: > >> Hi Milton, >> >> Thanks for the review comments, I am resending the patch with the >> changes you have recommended. >> >> Signed-off-by: Kamalesh B

Re: [PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-04 Thread Kamalesh Babulal
* Milton Miller [2009-01-04 02:54:15]: > In-Reply-To: <20090103191359.ga9...@linux.vnet.ibm.com> > > Kamalesh Babulal wrote: >> config SCSI_IBMVSCSI >> tristate "IBM Virtual SCSI support" >> - depends on PPC_PSERIES || PPC_ISERIES >&g

[PATCH] 2.6.28-git4 - powerpc - drivers build fails with !CONFIG_VIOPATH

2009-01-03 Thread Kamalesh Babulal
[__modpost] Error 1 Adding CONFIG_VIOPATH to the depends list for both the drivers, fixes the build failure. I have tested the patch for build failure only. Signed-off-by: Kamalesh Babulal -- drivers/char/Kconfig |2 +- drivers/scsi/Kconfig |2 +- 2 files changed, 2 insertions(+), 2 d

[BUG] 2.6.28-git-4 - powerpc - kernel expection 'c01 at .kernel_thread'

2009-01-02 Thread Kamalesh Babulal
r9,4(r29) c00e2b9c 7f804840 cmplw cr7,r0,r9 c00e2ba0 40be0014 bne cr7,c00e2bb4# .kmem_cache_free+0x118/0x244 c00e2ba4 7f63db78 mr r3,r27 -- Thanks & Regards, Kamalesh Babulal, Lin

[BUG] next-20081231 -powerpc - panic at tasklet_kill_immediate()

2008-12-31 Thread Kamalesh Babulal
gt; 801f0004 7f8b0040 409c001c [1.269155] ---[ end trace 31fd0ba7d8756001 ]--- [1.269157] Fixing recursive fault but reboot is needed! -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ___ Linuxppc-dev mailing

[BUG] 2.6.28-git2 - powerpc - kernel expection with KGDB - "kgdbts:RUN sw breakpoint test"

2008-12-30 Thread Kamalesh Babulal
52] Call Trace: (1's of above 2 lines) -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

[PATCH] clean up of netif_rx_reschedule() changes in drivers

2008-12-29 Thread Kamalesh Babulal
ll > Date: Mon, 29 Dec 2008 10:56:00 +1100 > Subject: [PATCH] net: ibmveth NAPI interface cleanup fix > > Commit 908a7a16b852ffd618a9127be8d62432182d81b4 ("net: Remove unused > netdev arg from some NAPI interfaces") missed one spot. Hi Stephen, Thanks, the patch fixes the b

next-20081216 - powerpc link error 'dynreloc miscount'

2008-12-16 Thread Kamalesh Babulal
Hi, next-20081216 build breaks on powerpc ld: dynreloc miscount for kernel/built-in.o, section .opd ld: can not edit opd Bad value make: *** [vmlinux.o] Error 1 # ld --version GNU ld version 2.16.1 Debian GNU/Linux # gcc --version gcc (GCC) 4.0.2 20050808 (prerelease) (Ubuntu 4.0.1-4ubun

[BUILD-FAILURE] 2.6.28-rc2-mm1 - build breaks on powerpc with !GENERIC_BUG

2008-10-29 Thread Kamalesh Babulal
TO_LZO is not set # # Random Number Generation # CONFIG_CRYPTO_ANSI_CPRNG=m CONFIG_CRYPTO_HW=y # CONFIG_CRYPTO_DEV_HIFN_795X is not set # CONFIG_PPC_CLOCK is not set CONFIG_VIRTUALIZATION=y # CONFIG_VIRTIO_PCI is not set # CONFIG_VIRTIO_BALLOON is not set -- Thanks & Regards, Kamalesh Ba

Re: [BUILD_FAILURE] 2.6.27-git2 - allyesconfig on powerpc selectsCONFIG_INTEL_IOATDMA=y

2008-10-15 Thread Kamalesh Babulal
ne. > > cu > Adrian > Thanks, the patch fixes the build failure with CONFIG_MYRI10GE=y, once patch for CONFIG_IXGBE are send out by Jeff Kirsher/Jesse, I will retest them. -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ___ Linuxppc-dev mailing list Linuxppc-dev@ozlabs.org https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Kamalesh Babulal
Arjan van de Ven wrote: > Kamalesh Babulal wrote: >> Thanks for reference of the patch, After replacing the patch with the latest >> one above on the powerpc, the warning still remains >> >> Badness at kernel/notifier.c:86 > > sadly you have something going

Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-27 Thread Kamalesh Babulal
Arjan van de Ven wrote: > Kamalesh Babulal wrote: >> Hi Stephen, >> >> Badness warning is seen, while booting up the next-20080825/26 kernels on >> the powerpc boxes >> > > this is fixed in the patch I sent to Ingo earlie

[BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25

2008-08-26 Thread Kamalesh Babulal
truct notifier_block **nl, struct notifier_block *n) { + if (!kernel_text_address((unsigned long)n->notifier_call)) { + WARN(1, "Invalid notifier registered!"); + return 0; + } while ((*nl) != NULL) {

Re: [BUILD-FAILURE] 2.6.27-rc1-mm1 - allyesconfig build fails on powerpc

2008-08-01 Thread Kamalesh Babulal
Tony Breeds wrote: > On Thu, Jul 31, 2008 at 06:13:28PM +0530, Kamalesh Babulal wrote: >> Hi Andrew, >> >> make allyesconfig with 2.6.27-rc1-mm1 kernel on powerpc fails with build >> error > > > > Turning off GCOV "fixes" this. Not really the

Re: [BUG] 2.6.26-rc8-git2 - powerpc - circular locking dependency detected with net/ehea driver

2008-07-07 Thread Kamalesh Babulal
Jan-Bernd Themann wrote: > Hi Kamalesh, > > where you able to reproduce this problem with the patches applied > we posted on friday? > > Regards, > Jan-Bernd > > On Tuesday 01 July 2008 14:38, Kamalesh Babulal wrote: >> Hi, >> >> circular lock

[BUG] 2.6.26-rc8-git2 - kernel BUG at mm/page_alloc.c:585

2008-07-01 Thread Kamalesh Babulal
abfd90 256M ESID=1 VSID=217220abf LLP:110 38 f800 4000235bcc000500 1T ESID= f0 VSID= 235bcc LLP:100 -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL. ___ Linuxppc-dev mailing list Li

[BUG] 2.6.26-rc8-git2 - powerpc - circular locking dependency detected with net/ehea driver

2008-07-01 Thread Kamalesh Babulal
2552mutex_lock(&port->port_lock); 2553 2554if (netif_msg_ifup(port)) 2555ehea_info("enabling port %s", dev->name); 2556 -- Thanks & Regards, Kamalesh Babulal, Linux Technology Center, IBM, ISTL.

Re: [BUILD-FAILURE] linux-next: Tree for June 30 - powerpc - build failure at arch_add_memory()

2008-07-01 Thread Kamalesh Babulal
Tony Breeds wrote: > On Mon, Jun 30, 2008 at 11:55:02PM +0530, Kamalesh Babulal wrote: >> Hi Stephen, >> >> next-20080630 kernel build fails on powerpc, with randconfig >> >> CC arch/powerpc/mm/mem.o >> arch/powerpc/mm/mem.c: In function ‘arch_ad

  1   2   >